)]}'
{"vars/ubuntu-16.04.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7de05d77570968c591063136d8c672fc676cc773","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  # to have both queens and Pike removed."},{"line_number":98,"context_line":"  - repo: \"{{ uca_repo }}\""},{"line_number":99,"context_line":"    state: absent"},{"line_number":100,"context_line":"    filename: {{ uca_apt_source_list_filename | default(\u0027ubuntu_cloud_archive_canonical_com_ubuntu\u0027) }}"},{"line_number":101,"context_line":"  # Always use UCA filename"},{"line_number":102,"context_line":"  - repo: \"{{ uca_repo }}\""},{"line_number":103,"context_line":"    state: present"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df87a7cf_439f0450","line":100,"updated":"2017-12-02 12:44:39.000000000","message":"This will leave the file in place, but remove the config line. It\u0027s fine, although I\u0027d prefer to be rid of the file as a whole.\n\nThis will not be idempotent, unfortunately - if uca_repo and the file name is set to \u0027uca\u0027 then it will always remove the repo and add it back.\n\nThe elegance of https://github.com/openstack/openstack-ansible-galera_client/blob/master/tasks/galera_client_install_apt.yml#L58-L85 is that it\u0027s idempotent, and cleans up.","commit_id":"c71698debf5a33d3009f352bd63c4b67b4703f1b"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"000c616238a6501b2aa4c67d4e5b1e434a4c4743","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  # to have both queens and Pike removed."},{"line_number":98,"context_line":"  - repo: \"{{ uca_repo }}\""},{"line_number":99,"context_line":"    state: absent"},{"line_number":100,"context_line":"    filename: {{ uca_apt_source_list_filename | default(\u0027ubuntu_cloud_archive_canonical_com_ubuntu\u0027) }}"},{"line_number":101,"context_line":"  # Always use UCA filename"},{"line_number":102,"context_line":"  - repo: \"{{ uca_repo }}\""},{"line_number":103,"context_line":"    state: present"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df87a7cf_233e8029","line":100,"in_reply_to":"df87a7cf_439f0450","updated":"2017-12-02 13:00:34.000000000","message":"All of what you\u0027re saying is true.\n\nBut I considered the fact in which someone overrode uca_apt_source_list_filename with \"uca\" already:\n\nIf the repo is the same, there is no reason to have the override, and the deployer can remove it. In that case, if you remove the override, it will basically skip the removal of the default uca repo.\n\nIf you have a different repo, then the tasks still apply.\n\nSo the idempotency is broken if the deployer badly overrides. But I can\u0027t do anything for that.\n\nI am concerned about the empty file though, now that you mention it.\nWe should probably fix the module in ansible to ensure an empty file doesn\u0027t exist.","commit_id":"c71698debf5a33d3009f352bd63c4b67b4703f1b"}]}