)]}'
{"id":"openstack%2Fopenstack-ansible-openstack_hosts~534852","triplet_id":"openstack%2Fopenstack-ansible-openstack_hosts~master~Ic6ecbff84437d3285d4b81c7dbff71d2e2a193c3","project":"openstack/openstack-ansible-openstack_hosts","branch":"master","topic":"remove_fixed_period_sign","hashtags":[],"change_id":"Ic6ecbff84437d3285d4b81c7dbff71d2e2a193c3","subject":"Remove period sign before domain name","status":"NEW","created":"2018-01-17 17:43:20.000000000","updated":"2021-02-03 13:14:01.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7c4339eb790ee3383fad6c8c7828ff9ff599469a","_number":534852,"virtual_id_number":534852,"owner":{"_account_id":21740,"name":"Xin","email":"zxuuzx@gmail.com","username":"FrankZhang"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":-1,"date":"2018-01-17 18:00:52.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-01-17 17:54:37.000000000","updated_by":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"reviewer":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"state":"REVIEWER"},{"updated":"2018-01-17 18:00:52.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-02-03 13:14:01.000000000","updated_by":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"reviewer":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"state":"REMOVED"}],"messages":[{"id":"78ff2fa889bd485b2e1d9dccf6a4c540558ffee9","author":{"_account_id":21740,"name":"Xin","email":"zxuuzx@gmail.com","username":"FrankZhang"},"date":"2018-01-17 17:43:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b3fb3a83e9ed426bccce5c3866ffe32b857b2c85","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2018-01-17 17:54:37.000000000","message":"Patch Set 1: Code-Review-1\n\nWhile I see how this may be of value, changing this here for deployments that have been using this option now for nearly 5 releases would be bad form unless we\u0027re going to ensure we\u0027re not causing hard to the environment by handling the old value. If this is something that needs to be addressed in the leapfrom upgrade I suggest we do that there instead of making this change.","accounts_in_message":[],"_revision_number":1},{"id":"c002e2ce354fa8b41b49ff31d1788ebc936ddf26","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-17 18:00:52.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-sphinx-docs http://logs.openstack.org/52/534852/1/check/build-openstack-sphinx-docs/519f5c8/html/ : SUCCESS in 2m 41s\n- openstack-ansible-linters http://logs.openstack.org/52/534852/1/check/openstack-ansible-linters/f7832fd/ : SUCCESS in 5m 11s\n- openstack-ansible-functional-centos-7 http://logs.openstack.org/52/534852/1/check/openstack-ansible-functional-centos-7/07f36fe/ : FAILURE in 8m 48s\n- openstack-ansible-functional-opensuse-423 http://logs.openstack.org/52/534852/1/check/openstack-ansible-functional-opensuse-423/0e9769d/ : FAILURE in 6m 54s\n- openstack-ansible-functional-ubuntu-xenial http://logs.openstack.org/52/534852/1/check/openstack-ansible-functional-ubuntu-xenial/aa78674/ : FAILURE in 8m 48s","accounts_in_message":[],"_revision_number":1},{"id":"5135f8a3a5056cb4a438e0fa2989b9f8610126a3","tag":"autogenerated:gerrit:deleteVote","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2021-02-03 13:10:18.000000000","message":"Removed Code-Review-1 by Kevin Carter \u003ckevin@cloudnull.com\u003e\n","accounts_in_message":[],"_revision_number":1},{"id":"7c4339eb790ee3383fad6c8c7828ff9ff599469a","tag":"autogenerated:gerrit:deleteReviewer","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2021-02-03 13:14:01.000000000","message":"Removed reviewer Kevin Carter.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"be07d77f36ddc7d42e45f785b643bc759e7882ed","revisions":{"be07d77f36ddc7d42e45f785b643bc759e7882ed":{"kind":"REWORK","_number":1,"created":"2018-01-17 17:43:20.000000000","uploader":{"_account_id":21740,"name":"Xin","email":"zxuuzx@gmail.com","username":"FrankZhang"},"ref":"refs/changes/52/534852/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-openstack_hosts","ref":"refs/changes/52/534852/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-openstack_hosts refs/changes/52/534852/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-openstack_hosts refs/changes/52/534852/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-openstack_hosts refs/changes/52/534852/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-openstack_hosts refs/changes/52/534852/1"}}},"commit":{"parents":[{"commit":"05c7f09d181de1809fd596cc0d879c49e3f86bbf","subject":"SUSE: Refresh zypper repositories if necessary","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-openstack_hosts/commit/05c7f09d181de1809fd596cc0d879c49e3f86bbf"}]}],"author":{"name":"Frank-ZhangXin","email":"zxuuzx@gmail.com","date":"2018-01-17 17:30:30.000000000","tz":-360},"committer":{"name":"Frank-ZhangXin","email":"zxuuzx@gmail.com","date":"2018-01-17 17:42:37.000000000","tz":-360},"subject":"Remove period sign before domain name","message":"Remove period sign before domain name\n\nThe fixed period sign would potentially cause many hidden\nproblems, especially when \u0027domain_name\u0027 was set to empty string.\nAnd also, it is more important that we hope hostname won\u0027t be\nchanged during the leapfrog. Changed hostname would cause\nnova-compute rebuilding nova.compute_nodes table since\nnova.instance.node column refers to original hostname.\n\nChange-Id: Ic6ecbff84437d3285d4b81c7dbff71d2e2a193c3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-openstack_hosts/commit/be07d77f36ddc7d42e45f785b643bc759e7882ed"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-openstack_hosts/commit/be07d77f36ddc7d42e45f785b643bc759e7882ed"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}
