)]}'
{"id":"openstack%2Fopenstack-ansible-openstack_hosts~796850","triplet_id":"openstack%2Fopenstack-ansible-openstack_hosts~master~Ic68a0374b07f328e1bcb12d32acd24f03e628768","project":"openstack/openstack-ansible-openstack_hosts","branch":"master","topic":"install-tzdata","hashtags":[],"change_id":"Ic68a0374b07f328e1bcb12d32acd24f03e628768","subject":"Make sure tzdata is installed in containers","status":"ABANDONED","created":"2021-06-17 14:33:10.000000000","updated":"2021-06-18 14:00:22.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"94161babc790bec7bf38ef969c709559231989b6","_number":796850,"virtual_id_number":796850,"owner":{"_account_id":819,"name":"Adrien Cunin","email":"adrien@adriencunin.fr","username":"adri2000"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-06-17 16:09:25.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"all":[{"value":-2,"date":"2021-06-17 16:13:19.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-17 14:39:15.000000000","updated_by":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"reviewer":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"state":"CC"},{"updated":"2021-06-17 16:09:25.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-17 16:13:19.000000000","updated_by":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"reviewer":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"state":"REVIEWER"}],"messages":[{"id":"8c804d2222d9bd586f78b4a639878616bede58d5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":819,"name":"Adrien Cunin","email":"adrien@adriencunin.fr","username":"adri2000"},"date":"2021-06-17 14:33:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3a27caabe026ae5c477e9e9de10d635007dbb132","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2021-06-17 14:39:15.000000000","message":"Patch Set 1:\n\nI think containers should inherit systems timezone. And not sure I see usecases where they should have a different one?","accounts_in_message":[],"_revision_number":1},{"id":"a1f6632a43b61412017d39b64812f2702795c003","author":{"_account_id":819,"name":"Adrien Cunin","email":"adrien@adriencunin.fr","username":"adri2000"},"date":"2021-06-17 15:02:38.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e I think containers should inherit systems timezone. And not sure I see usecases where they should have a different one?\n\nAs far as I know and understand, containers \"inherit\" the host timezone when the container is created, as the /etc/localtime file is copied from the host to the container. However that file is only a symlink, pointing to timezone files that are provided by the tzdata package.\n\nIn other words, it doesn\u0027t make sense to copy the /etc/localtime file (as we currently do) if we don\u0027t also make sure that tzdata is installed.\n\nWithout tzdata installed, the container falls back to using UTC.\n\nThis is needed whether you\u0027re using or not using the same timezone between the host and the container. This is needed if you want to use any timezone (other than UTC) in the container.\nActually I use the same timezone between my hosts and containers - no strange use case here. :)","accounts_in_message":[],"_revision_number":1},{"id":"234d3a17c3ed8240bc62665bebc5c755a626c0c0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-17 16:09:25.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-ansible-deploy-hosts_metal-centos-8 https://zuul.opendev.org/t/openstack/build/04d23bf312c7466e9de41291ee37b36f : SUCCESS in 24m 24s\n- openstack-ansible-deploy-hosts_metal-centos-8-stream https://zuul.opendev.org/t/openstack/build/8ad100b8b8654d85afef760e012c2cb0 : SUCCESS in 23m 15s\n- openstack-ansible-deploy-hosts_metal-debian-buster https://zuul.opendev.org/t/openstack/build/f112962a848444ebb268b756e9ca900a : SUCCESS in 27m 22s\n- openstack-ansible-deploy-hosts_metal-debian-bullseye https://zuul.opendev.org/t/openstack/build/585bab6639044142bb487ed61c0853cf : SUCCESS in 21m 52s (non-voting)\n- openstack-ansible-deploy-hosts_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/6d9e2823ce594b4e91c35aa6caaf0c66 : POST_FAILURE in 22m 09s\n- openstack-ansible-deploy-hosts_distro_lxc-centos-8-stream https://zuul.opendev.org/t/openstack/build/66b5048fa59b415fbfc086e893dbc734 : SUCCESS in 36m 15s\n- openstack-ansible-deploy-hosts_distro_lxc-debian-buster https://zuul.opendev.org/t/openstack/build/40549f9d73664461bf4bad6ba61caae8 : SUCCESS in 29m 07s\n- openstack-ansible-deploy-hosts_distro_lxc-debian-bullseye https://zuul.opendev.org/t/openstack/build/1af39cee1d06445a8b37823288de9713 : SUCCESS in 34m 19s (non-voting)\n- openstack-ansible-deploy-hosts_distro_lxc-ubuntu-focal https://zuul.opendev.org/t/openstack/build/01f2dc3375cb48a6b5dfcb2a9c004143 : SUCCESS in 31m 27s\n- openstack-ansible-upgrade-infra_lxc-centos-8 https://zuul.opendev.org/t/openstack/build/ff455525c98b4b4fb45f9522be3b3b7b : SUCCESS in 1h 29m 07s (non-voting)\n- openstack-ansible-upgrade-infra_lxc-ubuntu-focal https://zuul.opendev.org/t/openstack/build/6e07dddb54604e27b8862aa3c7b07afc : SUCCESS in 1h 18m 33s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b33d7148e4aa4ee08c13a49c0925191d : SUCCESS in 6m 11s\n- openstack-ansible-linters-ubuntu-focal https://zuul.opendev.org/t/openstack/build/fb392c1257b54f968cc5002b1b8c6a2a : SUCCESS in 13m 59s","accounts_in_message":[],"_revision_number":1},{"id":"f24b3b513ce47293f12c1dfd6e3cc58492471d37","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2021-06-17 16:13:19.000000000","message":"Patch Set 1: Code-Review-2\n\nAh, yes, you\u0027re right here. I was just checking `/etc/timezone` instead for some reason.\n\nHowever, I have freshly deployed aio VM, and containers there already have tzdata. Doing some search, I found that these packages are already installed:\nhttps://opendev.org/openstack/openstack-ansible-lxc_hosts/src/branch/master/vars/ubuntu-20.04.yml#L49\n\nI checked and it\u0027s present for all distributions. And they\u0027re there for quite a while.\n\nSo I\u0027d say this patch is not needed at all, but probably we should look into backporting tzdata from lxc_hosts repo to some earlier branches.","accounts_in_message":[],"_revision_number":1},{"id":"37b461bf1a34fcb4b3d743cd11868d2de0ede0dc","author":{"_account_id":819,"name":"Adrien Cunin","email":"adrien@adriencunin.fr","username":"adri2000"},"date":"2021-06-18 08:11:07.000000000","message":"Patch Set 1:\n\nDespite doing quite a bit of grep\u0027ing for \"tzdata\", I somehow missed that. Sorry!\n\nSo indeed this patch is not needed.\n\nI\u0027m not sure it\u0027s worth backporting the change, as it\u0027s not going to fix existing containers, it will only make sure tzdata is installed in newly created containers. We can assume creating containers mostly happens during initial deployment, where people are probably using the latest release.\n(Moreover, it\u0027s obviously easy to workaround.)","accounts_in_message":[],"_revision_number":1},{"id":"61a5c02f58e53984f185acd01fe3b55ffd019b17","tag":"autogenerated:gerrit:abandon","author":{"_account_id":819,"name":"Adrien Cunin","email":"adrien@adriencunin.fr","username":"adri2000"},"date":"2021-06-18 08:11:50.000000000","message":"Abandoned\n\nnot needed, problem was already fixed elsewhere","accounts_in_message":[],"_revision_number":1},{"id":"94161babc790bec7bf38ef969c709559231989b6","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2021-06-18 14:00:22.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e I\u0027m not sure it\u0027s worth backporting the change, as it\u0027s not going to fix existing containers, it will only make sure tzdata is installed in newly created containers. \n\nwell yes, but ppl may start deploying ussuri right now (for example:))","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"31eb291b2a646d3af36eb23e98c766b16c09cb8d","revisions":{"31eb291b2a646d3af36eb23e98c766b16c09cb8d":{"kind":"REWORK","_number":1,"created":"2021-06-17 14:33:10.000000000","uploader":{"_account_id":819,"name":"Adrien Cunin","email":"adrien@adriencunin.fr","username":"adri2000"},"ref":"refs/changes/50/796850/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-openstack_hosts","ref":"refs/changes/50/796850/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-openstack_hosts refs/changes/50/796850/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-openstack_hosts refs/changes/50/796850/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-openstack_hosts refs/changes/50/796850/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-openstack_hosts refs/changes/50/796850/1"}}},"commit":{"parents":[{"commit":"fe04707b0b87c40596335f8506e6a87e429cbf9d","subject":"Merge \"Update distro mirrors to match release\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-openstack_hosts/commit/fe04707b0b87c40596335f8506e6a87e429cbf9d"}]}],"author":{"name":"Adrien Cunin","email":"adrien.cunin@springernature.com","date":"2021-06-17 14:32:17.000000000","tz":120},"committer":{"name":"Adrien Cunin","email":"adrien.cunin@springernature.com","date":"2021-06-17 14:32:17.000000000","tz":120},"subject":"Make sure tzdata is installed in containers","message":"Make sure tzdata is installed in containers\n\nThe tzdata package is needed so that the /etc/localtime symlink points\nto an existing file and so that the timezone is actually applied to the\nsystem.\n\nChange-Id: Ic68a0374b07f328e1bcb12d32acd24f03e628768\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-openstack_hosts/commit/31eb291b2a646d3af36eb23e98c766b16c09cb8d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-openstack_hosts/commit/31eb291b2a646d3af36eb23e98c766b16c09cb8d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}