)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"e1be9aa25e977b7ba13ab0941a8d24801db44eec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1cd5127b_3dddf87e","updated":"2025-10-09 19:10:20.000000000","message":"recheck - openstack-ansible-deploy-hosts_distro_lxc-rockylinux-10 failed when configuring dnf","commit_id":"cef8dd18f0231b8b2d07728c42680e2526c3ff5c"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"d80ec16c623abb215d811d4056471d4d16ec1d03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e997549f_fe1ea628","updated":"2025-11-03 10:06:09.000000000","message":"recheck - rocky distro are nv now","commit_id":"cef8dd18f0231b8b2d07728c42680e2526c3ff5c"}],"tasks/main.yml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"703c2edbe97f1308703503cfd29f971681ef3b56","unresolved":true,"context_lines":[{"line_number":162,"context_line":"      tags:"},{"line_number":163,"context_line":"        - pki"},{"line_number":164,"context_line":"  vars:"},{"line_number":165,"context_line":"    pki_default_backend: \"{{ openstack_pki_default_backend | default(\u0027standalone\u0027) }}\""},{"line_number":166,"context_line":"    pki_authorities: \"{{ openstack_pki_authorities }}\""},{"line_number":167,"context_line":"    pki_dir: \"{{ openstack_pki_dir }}\""},{"line_number":168,"context_line":"    pki_install_ca: \"{{ openstack_pki_install_ca | default([]) + openstack_host_ca_certificates }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3e87dcb6_f9913592","line":165,"range":{"start_line":165,"start_character":4,"end_line":165,"end_character":86},"updated":"2025-07-07 17:06:13.000000000","message":"why is this not just a role default that can be overridden in group_vars or user_variables as required?","commit_id":"a0398c42bd3db33a354dbe9a6841411c6c1ef067"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"3beb09f1cfd7da8178ac9b84636459201fe35fac","unresolved":false,"context_lines":[{"line_number":162,"context_line":"      tags:"},{"line_number":163,"context_line":"        - pki"},{"line_number":164,"context_line":"  vars:"},{"line_number":165,"context_line":"    pki_default_backend: \"{{ openstack_pki_default_backend | default(\u0027standalone\u0027) }}\""},{"line_number":166,"context_line":"    pki_authorities: \"{{ openstack_pki_authorities }}\""},{"line_number":167,"context_line":"    pki_dir: \"{{ openstack_pki_dir }}\""},{"line_number":168,"context_line":"    pki_install_ca: \"{{ openstack_pki_install_ca | default([]) + openstack_host_ca_certificates }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2ffc9812_6d118c1c","line":165,"range":{"start_line":165,"start_character":4,"end_line":165,"end_character":86},"in_reply_to":"3e87dcb6_f9913592","updated":"2025-07-17 17:13:15.000000000","message":"each certificate can have different backend.","commit_id":"a0398c42bd3db33a354dbe9a6841411c6c1ef067"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"b62daec637da9bae73ca185d5c3a1e581d87d067","unresolved":true,"context_lines":[{"line_number":162,"context_line":"      tags:"},{"line_number":163,"context_line":"        - pki"},{"line_number":164,"context_line":"  vars:"},{"line_number":165,"context_line":"    pki_authorities: \"{{ openstack_pki_authorities }}\""},{"line_number":166,"context_line":"    pki_dir: \"{{ openstack_pki_dir }}\""},{"line_number":167,"context_line":"    pki_install_ca: \"{{ openstack_pki_install_ca | default([]) + openstack_host_ca_certificates }}\""},{"line_number":168,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"021de250_51d176b5","line":165,"range":{"start_line":165,"start_character":25,"end_line":165,"end_character":50},"updated":"2025-08-04 08:26:09.000000000","message":"should we have some default in the role? As it\u0027s otherwise relying on group_vars containing it, which is not ideal...","commit_id":"c1d6b0c69396ff042bc76125675836be8ac8971c"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"30a273207cd3fc70a6ff1148f82a5ab9752bb562","unresolved":true,"context_lines":[{"line_number":162,"context_line":"      tags:"},{"line_number":163,"context_line":"        - pki"},{"line_number":164,"context_line":"  vars:"},{"line_number":165,"context_line":"    pki_authorities: \"{{ openstack_pki_authorities }}\""},{"line_number":166,"context_line":"    pki_dir: \"{{ openstack_pki_dir }}\""},{"line_number":167,"context_line":"    pki_install_ca: \"{{ openstack_pki_install_ca | default([]) + openstack_host_ca_certificates }}\""},{"line_number":168,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1c8d7052_e7b273da","line":165,"range":{"start_line":165,"start_character":25,"end_line":165,"end_character":50},"in_reply_to":"021de250_51d176b5","updated":"2025-09-30 20:03:18.000000000","message":"what would the default be? an empty list?","commit_id":"c1d6b0c69396ff042bc76125675836be8ac8971c"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"ffb163514eea9b5c035058b45b4a6b373cffe75c","unresolved":true,"context_lines":[{"line_number":162,"context_line":"      tags:"},{"line_number":163,"context_line":"        - pki"},{"line_number":164,"context_line":"  vars:"},{"line_number":165,"context_line":"    pki_authorities: \"{{ openstack_pki_authorities }}\""},{"line_number":166,"context_line":"    pki_dir: \"{{ openstack_pki_dir }}\""},{"line_number":167,"context_line":"    pki_install_ca: \"{{ openstack_pki_install_ca | default([]) + openstack_host_ca_certificates }}\""},{"line_number":168,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d8654d44_6be9c979","line":165,"range":{"start_line":165,"start_character":25,"end_line":165,"end_character":50},"in_reply_to":"1c8d7052_e7b273da","updated":"2025-10-02 10:14:04.000000000","message":"yup, exactly. With probably some comment above it with sample definition for docs","commit_id":"c1d6b0c69396ff042bc76125675836be8ac8971c"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"148eda3bbbd4ed7260ca291369a1849d3c9f0bb4","unresolved":true,"context_lines":[{"line_number":162,"context_line":"      tags:"},{"line_number":163,"context_line":"        - pki"},{"line_number":164,"context_line":"  vars:"},{"line_number":165,"context_line":"    pki_authorities: \"{{ openstack_pki_authorities }}\""},{"line_number":166,"context_line":"    pki_dir: \"{{ openstack_pki_dir }}\""},{"line_number":167,"context_line":"    pki_install_ca: \"{{ openstack_pki_install_ca | default([]) + openstack_host_ca_certificates }}\""},{"line_number":168,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"c2d8dcdd_2aa16052","line":165,"range":{"start_line":165,"start_character":25,"end_line":165,"end_character":50},"in_reply_to":"847274f4_3d0c2d45","updated":"2025-10-09 15:25:26.000000000","message":"`openstack_pki_install_ca` is allowed to be undefined in the existing code because it is followed by `default([])`.\n\nI think that the suggestion is to do the same for `openstack_pki_authorities`","commit_id":"c1d6b0c69396ff042bc76125675836be8ac8971c"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"269a6d18e13577b49c89d9ada162f187fcbf8378","unresolved":true,"context_lines":[{"line_number":162,"context_line":"      tags:"},{"line_number":163,"context_line":"        - pki"},{"line_number":164,"context_line":"  vars:"},{"line_number":165,"context_line":"    pki_authorities: \"{{ openstack_pki_authorities }}\""},{"line_number":166,"context_line":"    pki_dir: \"{{ openstack_pki_dir }}\""},{"line_number":167,"context_line":"    pki_install_ca: \"{{ openstack_pki_install_ca | default([]) + openstack_host_ca_certificates }}\""},{"line_number":168,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fe3f4086_8ecb108a","line":165,"range":{"start_line":165,"start_character":25,"end_line":165,"end_character":50},"in_reply_to":"c2d8dcdd_2aa16052","updated":"2025-10-09 19:09:25.000000000","message":"Ah, I missed the fact that you added  `default([])` filter in patchset #4.\nI thought it was there from day-1, that\u0027s why I was confused :D \nThanks","commit_id":"c1d6b0c69396ff042bc76125675836be8ac8971c"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"840b218880d61306b388128a917109c34f2a8354","unresolved":true,"context_lines":[{"line_number":162,"context_line":"      tags:"},{"line_number":163,"context_line":"        - pki"},{"line_number":164,"context_line":"  vars:"},{"line_number":165,"context_line":"    pki_authorities: \"{{ openstack_pki_authorities }}\""},{"line_number":166,"context_line":"    pki_dir: \"{{ openstack_pki_dir }}\""},{"line_number":167,"context_line":"    pki_install_ca: \"{{ openstack_pki_install_ca | default([]) + openstack_host_ca_certificates }}\""},{"line_number":168,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"847274f4_3d0c2d45","line":165,"range":{"start_line":165,"start_character":25,"end_line":165,"end_character":50},"in_reply_to":"d8654d44_6be9c979","updated":"2025-10-09 13:52:03.000000000","message":"maybe I\u0027m missing something, but what\u0027s the point of doing this?\n\nFor ex. in `openstack_pki_install_ca` which is defined 2 lines below we also rely on group_vars.\nWhat makes it ok for `openstack_pki_install_ca` but not for `openstack_pki_authorities`?\n\nThis variable is used mainly by `openstack.osa.certificate_authority` playbook so it\u0027s expected to define it in group_vars.\nIn this change, we only want to make openstack_hosts role aware of this variable so it can pass it to PKI role.","commit_id":"c1d6b0c69396ff042bc76125675836be8ac8971c"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"670e644f71521b3a27ea4b87c7699bc3d39a6077","unresolved":false,"context_lines":[{"line_number":162,"context_line":"      tags:"},{"line_number":163,"context_line":"        - pki"},{"line_number":164,"context_line":"  vars:"},{"line_number":165,"context_line":"    pki_authorities: \"{{ openstack_pki_authorities }}\""},{"line_number":166,"context_line":"    pki_dir: \"{{ openstack_pki_dir }}\""},{"line_number":167,"context_line":"    pki_install_ca: \"{{ openstack_pki_install_ca | default([]) + openstack_host_ca_certificates }}\""},{"line_number":168,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b8e01f72_e1530983","line":165,"range":{"start_line":165,"start_character":25,"end_line":165,"end_character":50},"in_reply_to":"fe3f4086_8ecb108a","updated":"2025-10-09 19:09:33.000000000","message":"Done","commit_id":"c1d6b0c69396ff042bc76125675836be8ac8971c"}]}