)]}'
{"ansible_tools/playbooks/ansible.cfg":[{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"d29674c12990121350418d8dcb5ea9aa207c54b1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[defaults]"},{"line_number":2,"context_line":"# Additional plugins"},{"line_number":3,"context_line":"lookup_plugins \u003d /etc/ansible/plugins/lookup"},{"line_number":4,"context_line":"filter_plugins \u003d /etc/ansible/plugins/filter"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"dada55a8_d98211c8","line":1,"updated":"2016-07-23 00:42:05.000000000","message":"We\u0027re actually trying to remove the use of ansible.cfg files in the long term. See https://review.openstack.org/#/c/345572/\n\nThis is probably okay for now, but just keep the future changes in mind.","commit_id":"3f6fd07172ceb3cbe87c73b228d09b6b0163a8de"}],"ansible_tools/playbooks/remove_compute_node.yml":[{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"d29674c12990121350418d8dcb5ea9aa207c54b1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  user: root"},{"line_number":19,"context_line":"  tasks:"},{"line_number":20,"context_line":"    - name: Fail if host_to_be_removed is not defined"},{"line_number":21,"context_line":"      fail: msg\u003d\"host_to_be_removed must be defined as ansible user variable\""},{"line_number":22,"context_line":"      when: host_to_be_removed is not defined"},{"line_number":23,"context_line":"    - name: Find ID of the nova-compute service we want to remove"},{"line_number":24,"context_line":"      shell: |"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"dada55a8_f969d526","line":21,"updated":"2016-07-23 00:42:05.000000000","message":"Please use the new YAML format here.\n\nfail:\n  msg: \"host_to_be_removed ...","commit_id":"3f6fd07172ceb3cbe87c73b228d09b6b0163a8de"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"0ab11b71ca6aef9f6aac6e6bb434b1e6f4da7f0c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- name: Remove a compute node from the OSA environment"},{"line_number":17,"context_line":"  hosts: utility[0]"},{"line_number":18,"context_line":"  user: root"},{"line_number":19,"context_line":"  tasks:"},{"line_number":20,"context_line":"    - name: Fail if host_to_be_removed is not defined"},{"line_number":21,"context_line":"      fail: "},{"line_number":22,"context_line":"        msg: \"host_to_be_removed must be defined as ansible user variable\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dada55a8_630c94ec","line":19,"updated":"2016-07-26 18:54:08.000000000","message":"maybe use pre_tasks to organize the preflight checks?\n(each of \"Fail if host_to_be_removed is not defined\" and \"Find ID of the nova-compute service we want to remove\" and \"Find ID of the neutron agent service we want to remove\")","commit_id":"be1213205190a42e6d548ea740f8fa649c0813b1"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"0ab11b71ca6aef9f6aac6e6bb434b1e6f4da7f0c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  user: root"},{"line_number":19,"context_line":"  tasks:"},{"line_number":20,"context_line":"    - name: Fail if host_to_be_removed is not defined"},{"line_number":21,"context_line":"      fail: "},{"line_number":22,"context_line":"        msg: \"host_to_be_removed must be defined as ansible user variable\""},{"line_number":23,"context_line":"      when: host_to_be_removed is not defined"},{"line_number":24,"context_line":"    - name: Find ID of the nova-compute service we want to remove"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dada55a8_a3732c7f","line":21,"range":{"start_line":21,"start_character":11,"end_line":21,"end_character":12},"updated":"2016-07-26 18:54:08.000000000","message":"nit whitespace","commit_id":"be1213205190a42e6d548ea740f8fa649c0813b1"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"0ab11b71ca6aef9f6aac6e6bb434b1e6f4da7f0c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        . {{ ansible_env.HOME }}/openrc"},{"line_number":27,"context_line":"        openstack compute service list | grep {{ host_to_be_removed }} | awk \u0027{print $2}\u0027"},{"line_number":28,"context_line":"      register: results"},{"line_number":29,"context_line":"      changed_when: results.rc \u003d\u003d 0"},{"line_number":30,"context_line":"      failed_when: results.rc \u003e 0"},{"line_number":31,"context_line":"    - name: Remove the nova-compute service from compute node"},{"line_number":32,"context_line":"      shell: |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dada55a8_c399007b","line":29,"updated":"2016-07-26 18:54:08.000000000","message":"and len(results.stdout_lines) \u003e 0 maybe to ensure that host was found?","commit_id":"be1213205190a42e6d548ea740f8fa649c0813b1"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"0ab11b71ca6aef9f6aac6e6bb434b1e6f4da7f0c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        . {{ ansible_env.HOME }}/openrc"},{"line_number":34,"context_line":"        openstack compute service delete {{ results.stdout }}"},{"line_number":35,"context_line":"      register: compute_delete_result"},{"line_number":36,"context_line":"      changed_when: compute_delete_result.rc \u003d\u003d 0"},{"line_number":37,"context_line":"      failed_when: compute_delete_result.rc \u003e 0"},{"line_number":38,"context_line":"    - name: Find ID of the neutron agent service we want to remove"},{"line_number":39,"context_line":"      shell: |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dada55a8_a3404ca6","line":36,"updated":"2016-07-26 18:54:08.000000000","message":"how much effort do you want to put into the changed_when? \n\nmaybe adjust the shell command to add \"\u0026\u0026 [...] openstack compute service list | grep [...]\" and ensure that the # of lines in stdout changed between runs?","commit_id":"be1213205190a42e6d548ea740f8fa649c0813b1"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"0ab11b71ca6aef9f6aac6e6bb434b1e6f4da7f0c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        openstack compute service delete {{ results.stdout }}"},{"line_number":35,"context_line":"      register: compute_delete_result"},{"line_number":36,"context_line":"      changed_when: compute_delete_result.rc \u003d\u003d 0"},{"line_number":37,"context_line":"      failed_when: compute_delete_result.rc \u003e 0"},{"line_number":38,"context_line":"    - name: Find ID of the neutron agent service we want to remove"},{"line_number":39,"context_line":"      shell: |"},{"line_number":40,"context_line":"        . {{ ansible_env.HOME }}/openrc"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dada55a8_2390dc42","line":37,"updated":"2016-07-26 18:54:08.000000000","message":"maybe adding a when, related to the comment above re: len(results.stdout_lines)","commit_id":"be1213205190a42e6d548ea740f8fa649c0813b1"}],"ansible_tools/playbooks/roles/remove_compute_node/README.md":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"536624e9f89e941762e650fe839c6a01c0ddd169","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Role Name"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"A brief description of the role goes here."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Requirements"},{"line_number":7,"context_line":"------------"}],"source_content_type":"text/x-gfm","patch_set":3,"id":"1aa78d24_483c22c8","line":4,"updated":"2016-07-06 14:43:30.000000000","message":"Would like to see some minimal doc here","commit_id":"3aacc1d2a9825fe2a95887f06ba62ccc79ca775f"}],"ansible_tools/playbooks/roles/remove_compute_node/defaults/main.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"536624e9f89e941762e650fe839c6a01c0ddd169","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# defaults file for remove_compute_node"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"name_of_neutron_agent: \"neutron-linuxbridge-agent\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1aa78d24_f4196a89","line":4,"updated":"2016-07-06 14:43:30.000000000","message":"Can this just use a var already defined for the neutron play?","commit_id":"3aacc1d2a9825fe2a95887f06ba62ccc79ca775f"}],"ansible_tools/playbooks/roles/remove_compute_node/tasks/remove_neutron_agent.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"536624e9f89e941762e650fe839c6a01c0ddd169","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"- name: Find id of the neutron agnet service"},{"line_number":4,"context_line":"  shell: |"},{"line_number":5,"context_line":"    . {{ ansible_env.HOME }}/openrc"},{"line_number":6,"context_line":"    neutron agent-list | grep {{ name_of_neutron_agent }} | grep {{ host_to_be_removed }} | awk \u0027{ print $2 }\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1aa78d24_147076db","line":3,"range":{"start_line":3,"start_character":31,"end_line":3,"end_character":36},"updated":"2016-07-06 14:43:30.000000000","message":"spelling","commit_id":"3aacc1d2a9825fe2a95887f06ba62ccc79ca775f"}],"ansible_tools/playbooks/roles/remove_compute_node/tasks/remove_nova_compute.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"536624e9f89e941762e650fe839c6a01c0ddd169","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  changed_when: results.rc !\u003d 0"},{"line_number":8,"context_line":"  failed_when: host_to_be_removed is not defined"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Remove the nove-compute service from compute node"},{"line_number":11,"context_line":"  shell: |"},{"line_number":12,"context_line":"    . {{ ansible_env.HOME }}/openrc"},{"line_number":13,"context_line":"    openstack compute service delete {{ results.stdout }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1aa78d24_c82772b4","line":10,"range":{"start_line":10,"start_character":19,"end_line":10,"end_character":23},"updated":"2016-07-06 14:43:30.000000000","message":"spelling","commit_id":"3aacc1d2a9825fe2a95887f06ba62ccc79ca775f"}]}
