)]}'
{"id":"openstack%2Fopenstack-ansible-ops~448231","triplet_id":"openstack%2Fopenstack-ansible-ops~master~I1836a3f354a951b6761442baf2c09d8d372c459f","project":"openstack/openstack-ansible-ops","branch":"master","topic":"cinder_volumn_container_check","hashtags":[],"change_id":"I1836a3f354a951b6761442baf2c09d8d372c459f","subject":"Correct conditional for cinder is_metal check","status":"MERGED","created":"2017-03-21 18:47:39.000000000","updated":"2017-03-21 19:02:31.000000000","submitted":"2017-03-21 19:02:31.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"515973af75b301594decc68e701d180ecb4ebf85","_number":448231,"virtual_id_number":448231,"owner":{"_account_id":16479,"name":"weezer su","email":"weezer.su@rackspace.com","username":"weezS"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":2,"date":"2017-03-21 19:02:31.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"all":[{"value":2,"date":"2017-03-21 18:59:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":2,"date":"2017-03-21 18:58:14.000000000","_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"all":[{"value":1,"date":"2017-03-21 18:59:21.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-03-21 18:58:14.000000000","updated_by":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"reviewer":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"state":"REVIEWER"},{"updated":"2017-03-21 18:59:21.000000000","updated_by":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"reviewer":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"state":"REVIEWER"},{"updated":"2017-03-21 19:02:31.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"1bc188d2ac6fa2d79ba66512b9c3312241cbd86f","author":{"_account_id":16479,"name":"weezer su","email":"weezer.su@rackspace.com","username":"weezS"},"date":"2017-03-21 18:47:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ba5982de77dd9318acb5edaff2fc277ab23b7677","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-21 18:49:20.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-ops-docs-ubuntu-xenial http://docs-draft.openstack.org/31/448231/1/check/gate-openstack-ansible-ops-docs-ubuntu-xenial/0d382d1//doc/build/html/ : SUCCESS in 1m 15s\n- gate-openstack-ansible-ops-linters-ubuntu-xenial http://logs.openstack.org/31/448231/1/check/gate-openstack-ansible-ops-linters-ubuntu-xenial/b0e81cb/ : SUCCESS in 1m 15s","accounts_in_message":[],"_revision_number":1},{"id":"33ad245aa45a9bde43b79c28839aa8a200f5f9cd","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2017-03-21 18:50:19.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0b90c376bc5b2958b057335d1072676dccc5eaf9","author":{"_account_id":16479,"name":"weezer su","email":"weezer.su@rackspace.com","username":"weezS"},"date":"2017-03-21 18:56:52.000000000","message":"Patch Set 2: Published edit on patch set 1","accounts_in_message":[],"_revision_number":2},{"id":"46721cd642e9551b0344217d5c2a89c699b6f7cf","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2017-03-21 18:57:50.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"4cb9c73a8b2ef4fa97ea0d1e217560c7704586e1","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2017-03-21 18:58:11.000000000","message":"Patch Set 3: Published edit on patch set 2","accounts_in_message":[],"_revision_number":3},{"id":"a4a382bbc6246ce7548b27b9e86fda86d2acae39","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2017-03-21 18:58:14.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"4e0fb27eb7c007bcb5da21e7999b89fba325a1e5","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2017-03-21 18:59:21.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"7e11390f9de65553c06b5a4cd884e07daf43c253","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-21 19:01:04.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-ops-docs-ubuntu-xenial http://docs-draft.openstack.org/31/448231/3/check/gate-openstack-ansible-ops-docs-ubuntu-xenial/1728579//doc/build/html/ : SUCCESS in 1m 22s\n- gate-openstack-ansible-ops-linters-ubuntu-xenial http://logs.openstack.org/31/448231/3/check/gate-openstack-ansible-ops-linters-ubuntu-xenial/3471477/ : SUCCESS in 58s","accounts_in_message":[],"_revision_number":3},{"id":"a32297f5444918c40dc42fcea6f3b2a14cf0e993","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-21 19:01:16.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"077381fe6a11a27bdb4ff8a935e2752d37b9273c","date":"2017-03-21 19:02:31.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3},{"id":"57d76b6accbf743576adae9ea382042fc0cee3b1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-21 19:02:31.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-openstack-ansible-ops-docs-ubuntu-xenial http://docs-draft.openstack.org/31/448231/3/gate/gate-openstack-ansible-ops-docs-ubuntu-xenial/ce1407b//doc/build/html/ : SUCCESS in 47s\n- gate-openstack-ansible-ops-linters-ubuntu-xenial http://logs.openstack.org/31/448231/3/gate/gate-openstack-ansible-ops-linters-ubuntu-xenial/530a2cd/ : SUCCESS in 45s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"db9edda9c7ee63ec3e84b6b073f4f4d671d4024f","revisions":{"b55604f894db68f6688d1aab0abf17dbfcd21986":{"kind":"REWORK","_number":1,"created":"2017-03-21 18:47:39.000000000","uploader":{"_account_id":16479,"name":"weezer su","email":"weezer.su@rackspace.com","username":"weezS"},"ref":"refs/changes/31/448231/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-ops","ref":"refs/changes/31/448231/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-ops refs/changes/31/448231/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-ops refs/changes/31/448231/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-ops refs/changes/31/448231/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-ops refs/changes/31/448231/1"}}},"commit":{"parents":[{"commit":"eacb01c0a063774f3312999f3c756d06769d823c","subject":"Merge \"Add rolling downtime simulation tools\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-ops/commit/eacb01c0a063774f3312999f3c756d06769d823c"}]}],"author":{"name":"Weezer Su","email":"weezer.su@gmail.com","date":"2017-03-21 18:46:20.000000000","tz":-300},"committer":{"name":"Weezer Su","email":"weezer.su@gmail.com","date":"2017-03-21 18:46:20.000000000","tz":-300},"subject":"The is_metal !\u003d true means cinder in container. change the is_metal \u003d\u003d true to is_metal !\u003d true","message":"The is_metal !\u003d true means cinder in container.\nchange the is_metal \u003d\u003d true to is_metal !\u003d true\n\nChange-Id: I1836a3f354a951b6761442baf2c09d8d372c459f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-ops/commit/b55604f894db68f6688d1aab0abf17dbfcd21986"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-ops/commit/b55604f894db68f6688d1aab0abf17dbfcd21986"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"eacb01c0a063774f3312999f3c756d06769d823c","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"42122ea1f3d5486076390d52e1675dd1d92fbfbe":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2017-03-21 18:56:52.000000000","uploader":{"_account_id":16479,"name":"weezer su","email":"weezer.su@rackspace.com","username":"weezS"},"ref":"refs/changes/31/448231/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-ops","ref":"refs/changes/31/448231/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-ops refs/changes/31/448231/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-ops refs/changes/31/448231/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-ops refs/changes/31/448231/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-ops refs/changes/31/448231/2"}}},"commit":{"parents":[{"commit":"eacb01c0a063774f3312999f3c756d06769d823c","subject":"Merge \"Add rolling downtime simulation tools\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-ops/commit/eacb01c0a063774f3312999f3c756d06769d823c"}]}],"author":{"name":"Weezer Su","email":"weezer.su@gmail.com","date":"2017-03-21 18:46:20.000000000","tz":-300},"committer":{"name":"weezer su","email":"weezer.su@rackspace.com","date":"2017-03-21 18:56:42.000000000","tz":0},"subject":"Correct conditional for cinder is_metal check change the is_metal \u003d\u003d true to is_metal !\u003d true","message":"Correct conditional for cinder is_metal check\nchange the is_metal \u003d\u003d true to is_metal !\u003d true\n\nChange-Id: I1836a3f354a951b6761442baf2c09d8d372c459f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-ops/commit/42122ea1f3d5486076390d52e1675dd1d92fbfbe"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-ops/commit/42122ea1f3d5486076390d52e1675dd1d92fbfbe"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"eacb01c0a063774f3312999f3c756d06769d823c","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"db9edda9c7ee63ec3e84b6b073f4f4d671d4024f":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2017-03-21 18:58:11.000000000","uploader":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"ref":"refs/changes/31/448231/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-ops","ref":"refs/changes/31/448231/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-ops refs/changes/31/448231/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-ops refs/changes/31/448231/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-ops refs/changes/31/448231/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-ops refs/changes/31/448231/3"}}},"commit":{"parents":[{"commit":"eacb01c0a063774f3312999f3c756d06769d823c","subject":"Merge \"Add rolling downtime simulation tools\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-ops/commit/eacb01c0a063774f3312999f3c756d06769d823c"}]}],"author":{"name":"Weezer Su","email":"weezer.su@gmail.com","date":"2017-03-21 18:46:20.000000000","tz":-300},"committer":{"name":"Jesse Pretorius (odyssey4me)","email":"jesse.pretorius@rackspace.co.uk","date":"2017-03-21 18:58:08.000000000","tz":0},"subject":"Correct conditional for cinder is_metal check","message":"Correct conditional for cinder is_metal check\n\nchange the is_metal \u003d\u003d true to is_metal !\u003d true\n\nChange-Id: I1836a3f354a951b6761442baf2c09d8d372c459f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-ops/commit/db9edda9c7ee63ec3e84b6b073f4f4d671d4024f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-ops/commit/db9edda9c7ee63ec3e84b6b073f4f4d671d4024f"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"eacb01c0a063774f3312999f3c756d06769d823c","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}