)]}'
{"leap-upgrades/lib/functions.sh":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"188d9a4d71fd6c9dd883afc7e9882b386ec97ec9","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    fi"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    # Verify the Ubuntu Trusty Backports repo enabled on all hosts"},{"line_number":266,"context_line":"    pushed ${MAIN_PATH}/playbooks"},{"line_number":267,"context_line":"      if ! ansible \"hosts:is_metal\" -m shell -a \"grep -rn ^ /etc/apt/sources.list /etc/apt/sources.list.d/ | grep -qw \"backports\"\"; then"},{"line_number":268,"context_line":"        failure \"The trusty backports repo has not been enabled on this host.\""},{"line_number":269,"context_line":"        exit 99"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3f1d235d_23de183f","line":266,"range":{"start_line":266,"start_character":4,"end_line":266,"end_character":10},"updated":"2017-07-03 11:34:07.000000000","message":"Do you mean pushd ?","commit_id":"017e103259640f7a5840779135e8215bdf4755e9"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"52440964e685597afc1836774ec033b75f52485e","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    fi"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    # Verify the Ubuntu Trusty Backports repo enabled on all hosts"},{"line_number":266,"context_line":"    pushed ${MAIN_PATH}/playbooks"},{"line_number":267,"context_line":"      if ! ansible \"hosts:is_metal\" -m shell -a \"grep -rn ^ /etc/apt/sources.list /etc/apt/sources.list.d/ | grep -qw \"backports\"\"; then"},{"line_number":268,"context_line":"        failure \"The trusty backports repo has not been enabled on this host.\""},{"line_number":269,"context_line":"        exit 99"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3f1d235d_e6602e04","line":266,"range":{"start_line":266,"start_character":4,"end_line":266,"end_character":10},"in_reply_to":"3f1d235d_23de183f","updated":"2017-07-03 11:57:41.000000000","message":"Ahah we think alike. I was fixing it.","commit_id":"017e103259640f7a5840779135e8215bdf4755e9"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"188d9a4d71fd6c9dd883afc7e9882b386ec97ec9","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    # Verify the Ubuntu Trusty Backports repo enabled on all hosts"},{"line_number":266,"context_line":"    pushed ${MAIN_PATH}/playbooks"},{"line_number":267,"context_line":"      if ! ansible \"hosts:is_metal\" -m shell -a \"grep -rn ^ /etc/apt/sources.list /etc/apt/sources.list.d/ | grep -qw \"backports\"\"; then"},{"line_number":268,"context_line":"        failure \"The trusty backports repo has not been enabled on this host.\""},{"line_number":269,"context_line":"        exit 99"},{"line_number":270,"context_line":"      fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3f1d235d_63d41021","line":267,"range":{"start_line":267,"start_character":118,"end_line":267,"end_character":129},"updated":"2017-07-03 11:34:07.000000000","message":"\u0027backports\u0027 otherwise you\u0027re putting this outside of quotes. You can also optionally just be rid of the quotes.","commit_id":"017e103259640f7a5840779135e8215bdf4755e9"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"52440964e685597afc1836774ec033b75f52485e","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    # Verify the Ubuntu Trusty Backports repo enabled on all hosts"},{"line_number":266,"context_line":"    pushed ${MAIN_PATH}/playbooks"},{"line_number":267,"context_line":"      if ! ansible \"hosts:is_metal\" -m shell -a \"grep -rn ^ /etc/apt/sources.list /etc/apt/sources.list.d/ | grep -qw \"backports\"\"; then"},{"line_number":268,"context_line":"        failure \"The trusty backports repo has not been enabled on this host.\""},{"line_number":269,"context_line":"        exit 99"},{"line_number":270,"context_line":"      fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3f1d235d_c65bf251","line":267,"range":{"start_line":267,"start_character":118,"end_line":267,"end_character":129},"in_reply_to":"3f1d235d_63d41021","updated":"2017-07-03 11:57:41.000000000","message":"Same here :)","commit_id":"017e103259640f7a5840779135e8215bdf4755e9"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"393753a1e01a3116b16a5685e07eb8bc88c277fd","unresolved":false,"context_lines":[{"line_number":265,"context_line":"    # Verify the Ubuntu Trusty Backports repo enabled on all hosts"},{"line_number":266,"context_line":"    pushd ${MAIN_PATH}/playbooks"},{"line_number":267,"context_line":"        if ! ansible hosts -m shell -a \"grep -rn ^ /etc/apt/sources.list /etc/apt/sources.list.d/ | grep -qw backports\"; then"},{"line_number":268,"context_line":"            failure \"The trusty backports repo has not been enabled on this host.\""},{"line_number":269,"context_line":"            exit 99"},{"line_number":270,"context_line":"        fi"},{"line_number":271,"context_line":"    popd"}],"source_content_type":"text/x-sh","patch_set":7,"id":"3f1d235d_09821d50","line":268,"range":{"start_line":268,"start_character":71,"end_line":268,"end_character":80},"updated":"2017-07-03 12:05:00.000000000","message":"Seeing as all hosts are being checked - this should probably be \u0027all hosts\u0027.\n\nI have to ask though, why is this necessary? The lxc_hosts role add it if it\u0027s missing automatically, and the behaviour can be disabled if you have a consolidated repo.\n\nThe swift deployment, which is the only other one that needed this in the past, gets the liberasurecode-dev package from UCA so the backports repo is not necessary.\n\nIn other words, what exactly is it that\u0027s being pulled from backports and why is it necessary?","commit_id":"b8cd603ad64d5b7f65c1db6ca8de0460d26de7c3"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"ba674c4468bdddad1842ddf1af1c866422358e96","unresolved":false,"context_lines":[{"line_number":265,"context_line":"    # Verify the Ubuntu Trusty Backports repo enabled on all hosts"},{"line_number":266,"context_line":"    pushd ${MAIN_PATH}/playbooks"},{"line_number":267,"context_line":"        if ! ansible hosts -m shell -a \"grep -rn ^ /etc/apt/sources.list /etc/apt/sources.list.d/ | grep -qw backports\"; then"},{"line_number":268,"context_line":"            failure \"The trusty backports repo has not been enabled on this host.\""},{"line_number":269,"context_line":"            exit 99"},{"line_number":270,"context_line":"        fi"},{"line_number":271,"context_line":"    popd"}],"source_content_type":"text/x-sh","patch_set":7,"id":"3f1d235d_09d57db9","line":268,"range":{"start_line":268,"start_character":71,"end_line":268,"end_character":80},"in_reply_to":"3f1d235d_09821d50","updated":"2017-07-03 12:27:54.000000000","message":"The first time you\u0027re running this code, you could still be either at Juno or Kilo. That\u0027s what I assume you have as runtime when running this code for the first time.\n\nA recent lxc_host role hasn\u0027t run yet, nor is UCA deployed for J/K.\n\nThis code runs on the deploy node, and these lines should only matter for venv building.\n\nChecking for liberasurecode-dev is good in the building, this way you ensure you can build the venv properly.\n\nHowever, I agree with you, this is not necessary in its current form:\n1) No need to do this on all nodes\n2) no need to do this if the venvs are already built.\n3) No need if running something above kilo.","commit_id":"b8cd603ad64d5b7f65c1db6ca8de0460d26de7c3"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"78a2c14931223f5e36d1dca25c7cbe3e59f3397d","unresolved":false,"context_lines":[{"line_number":265,"context_line":"    # Verify the Ubuntu Trusty Backports repo enabled on all hosts"},{"line_number":266,"context_line":"    pushd ${MAIN_PATH}/playbooks"},{"line_number":267,"context_line":"        if ! ansible hosts -m shell -a \"grep -rn ^ /etc/apt/sources.list /etc/apt/sources.list.d/ | grep -qw backports\"; then"},{"line_number":268,"context_line":"            failure \"The trusty backports repo has not been enabled on this host.\""},{"line_number":269,"context_line":"            exit 99"},{"line_number":270,"context_line":"        fi"},{"line_number":271,"context_line":"    popd"}],"source_content_type":"text/x-sh","patch_set":7,"id":"3f1d235d_b4c01c7d","line":268,"range":{"start_line":268,"start_character":71,"end_line":268,"end_character":80},"in_reply_to":"3f1d235d_09d57db9","updated":"2017-07-03 12:42:01.000000000","message":"If it\u0027s only for venv building, then surely it only needs to run on the node doing the venv build (deploy node)? Or will it also need to be installed wherever the venv will be used?\n\nAlso, once the venv build is done, will the additional repo be removed?","commit_id":"b8cd603ad64d5b7f65c1db6ca8de0460d26de7c3"}]}
