)]}'
{"id":"openstack%2Fopenstack-ansible-ops~511147","triplet_id":"openstack%2Fopenstack-ansible-ops~master~I2c780eb46dd57e680fc8681824de2fe913824fd9","project":"openstack/openstack-ansible-ops","branch":"master","hashtags":[],"change_id":"I2c780eb46dd57e680fc8681824de2fe913824fd9","subject":"Add option to set FROM code and fix logic bug","status":"MERGED","created":"2017-10-11 06:22:39.000000000","updated":"2017-10-11 16:56:46.000000000","submitted":"2017-10-11 16:56:46.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"511147-1507741006936-eef2cb8e","meta_rev_id":"515e0e0e89401531847ea90a8e22f0682545f25b","_number":511147,"virtual_id_number":511147,"owner":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-10-11 16:56:45.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":2,"date":"2017-10-11 15:31:19.000000000","_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},{"value":2,"date":"2017-10-11 14:35:19.000000000","_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":1,"date":"2017-10-11 15:31:19.000000000","_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-10-11 08:14:21.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2017-10-11 14:35:19.000000000","updated_by":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"reviewer":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"state":"REVIEWER"},{"updated":"2017-10-11 15:31:19.000000000","updated_by":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"reviewer":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"state":"REVIEWER"},{"updated":"2017-10-11 16:56:45.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"851a17179937531bd30e82c8f185642af97b03e2","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2017-10-11 06:22:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7380067b71c726410af19992976a4c739e403f2d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-11 06:38:10.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-ops-docs-ubuntu-xenial http://docs-draft.openstack.org/47/511147/1/check/gate-openstack-ansible-ops-docs-ubuntu-xenial/93af598//doc/build/html/ : SUCCESS in 1m 56s\n- gate-openstack-ansible-ops-linters-ubuntu-xenial http://logs.openstack.org/47/511147/1/check/gate-openstack-ansible-ops-linters-ubuntu-xenial/a2bdb6e/ : SUCCESS in 1m 05s","accounts_in_message":[],"_revision_number":1},{"id":"09d72179599a7afd6b2d4a55c886d7adcda431fb","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2017-10-11 07:42:18.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nShould be ok but I think we should remove that line below.","accounts_in_message":[],"_revision_number":1},{"id":"90372f3741f2eb612a630fdc02c2756053a732f1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-10-11 08:14:21.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed.\n\n- build-openstack-sphinx-docs http://logs.openstack.org/47/511147/1/check/build-openstack-sphinx-docs/6d4169c/html/ : SUCCESS in 2m 14s\n- openstack-tox-linters http://logs.openstack.org/47/511147/1/check/openstack-tox-linters/e680f21/ : FAILURE in 1m 40s","accounts_in_message":[],"_revision_number":1},{"id":"50acd145a6355c15f313efc56ca90b97b437b4d2","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2017-10-11 14:16:19.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"d5639b943795a3e725d8442de78c8ed01d9c2aaa","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2017-10-11 14:16:39.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6bff88fed1840d95ca9dc2d3e78a2f6ff4290066","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2017-10-11 14:35:19.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"d6ba289b38099b07149536f0bafec281aa29dac4","author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"date":"2017-10-11 15:31:19.000000000","message":"Patch Set 2: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"34f63ac2499e219a516b65c6e19180624f41842b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-11 16:54:05.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-ops-docs-ubuntu-xenial http://docs-draft.openstack.org/47/511147/2/check/gate-openstack-ansible-ops-docs-ubuntu-xenial/1b84867//doc/build/html/ : SUCCESS in 1m 32s\n- gate-openstack-ansible-ops-linters-ubuntu-xenial http://logs.openstack.org/47/511147/2/check/gate-openstack-ansible-ops-linters-ubuntu-xenial/0587d31/ : SUCCESS in 1m 06s","accounts_in_message":[],"_revision_number":2},{"id":"c0139937d72d457c82f8c17fa9c20145fdf4f543","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-11 16:54:16.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"7f255427301ba2431f959b8cc2cf545fc7ac7711","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-11 16:56:45.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-openstack-ansible-ops-docs-ubuntu-xenial http://docs-draft.openstack.org/47/511147/2/gate/gate-openstack-ansible-ops-docs-ubuntu-xenial/499c5ad//doc/build/html/ : SUCCESS in 1m 03s\n- gate-openstack-ansible-ops-linters-ubuntu-xenial http://logs.openstack.org/47/511147/2/gate/gate-openstack-ansible-ops-linters-ubuntu-xenial/a74f9e6/ : SUCCESS in 1m 58s","accounts_in_message":[],"_revision_number":2},{"id":"515e0e0e89401531847ea90a8e22f0682545f25b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-11 16:56:46.000000000","message":"Change has been successfully merged by Jenkins","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e7ea3b56c6d52462b77178a71c1c84fa5e3d2c9b","revisions":{"3daa5a1d6adecc2dee9dae197c3a0051fd67eed6":{"kind":"REWORK","_number":1,"created":"2017-10-11 06:22:39.000000000","uploader":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"ref":"refs/changes/47/511147/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-ops","ref":"refs/changes/47/511147/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-ops refs/changes/47/511147/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-ops refs/changes/47/511147/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-ops refs/changes/47/511147/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-ops refs/changes/47/511147/1"}}},"commit":{"parents":[{"commit":"cc9294bb0d4191bf6a78ef15b02bcaed86cdd709","subject":"use linux-image-generic by default","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-ops/commit/cc9294bb0d4191bf6a78ef15b02bcaed86cdd709"}]}],"author":{"name":"Kevin Carter","email":"kevin.carter@rackspace.com","date":"2017-10-11 06:19:44.000000000","tz":-300},"committer":{"name":"Kevin Carter","email":"kevin.carter@rackspace.com","date":"2017-10-11 06:19:44.000000000","tz":-300},"subject":"Add option to set FROM code and fix logic bug","message":"Add option to set FROM code and fix logic bug\n\nThe leap tooling was attempting to run `set_upgrade_vars` at point where\nspecific upgrade variables were already needed. Within this change that\nfunction call is moved up a few lines so that it has the chance to set\nthe required values. Additionally the option to pre-define the variable\nCODE_UPGRADE_FROM has been added giving the deployer the option to set\nthis variable before a leap upgrade is run.\n\nChange-Id: I2c780eb46dd57e680fc8681824de2fe913824fd9\nSigned-off-by: Kevin Carter \u003ckevin.carter@rackspace.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-ops/commit/3daa5a1d6adecc2dee9dae197c3a0051fd67eed6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-ops/commit/3daa5a1d6adecc2dee9dae197c3a0051fd67eed6"}]},"branch":"refs/heads/master"},"e7ea3b56c6d52462b77178a71c1c84fa5e3d2c9b":{"kind":"REWORK","_number":2,"created":"2017-10-11 14:16:19.000000000","uploader":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"ref":"refs/changes/47/511147/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-ops","ref":"refs/changes/47/511147/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-ops refs/changes/47/511147/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-ops refs/changes/47/511147/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-ops refs/changes/47/511147/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-ops refs/changes/47/511147/2"}}},"commit":{"parents":[{"commit":"cc9294bb0d4191bf6a78ef15b02bcaed86cdd709","subject":"use linux-image-generic by default","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-ops/commit/cc9294bb0d4191bf6a78ef15b02bcaed86cdd709"}]}],"author":{"name":"Kevin Carter","email":"kevin.carter@rackspace.com","date":"2017-10-11 06:19:44.000000000","tz":-300},"committer":{"name":"Kevin Carter (cloudnull)","email":"kevin@cloudnull.com","date":"2017-10-11 14:15:56.000000000","tz":0},"subject":"Add option to set FROM code and fix logic bug","message":"Add option to set FROM code and fix logic bug\n\nThe leap tooling was attempting to run `set_upgrade_vars` at point where\nspecific upgrade variables were already needed. Within this change that\nfunction call is moved up a few lines so that it has the chance to set\nthe required values. Additionally the option to pre-define the variable\nCODE_UPGRADE_FROM has been added giving the deployer the option to set\nthis variable before a leap upgrade is run.\n\nChange-Id: I2c780eb46dd57e680fc8681824de2fe913824fd9\nSigned-off-by: Kevin Carter \u003ckevin.carter@rackspace.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-ops/commit/e7ea3b56c6d52462b77178a71c1c84fa5e3d2c9b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-ops/commit/e7ea3b56c6d52462b77178a71c1c84fa5e3d2c9b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}