)]}'
{"leap-upgrades/lib/vars.sh":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"8926385176d2cbd1c0127ea39552b224b9c1e8de","unresolved":false,"context_lines":[{"line_number":50,"context_line":"export ANSIBLE_LOG_PATH\u003d\"/opt/leap42/ansible-${LEAP_TIMESTAMP}.log\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"## Containers List to Destroy in destroy-old-containers.yml"},{"line_number":53,"context_line":"export CONTAINERS_TO_DESTROY\u003d\"${CONTAINERS_TO_DESTROY:-all_containers:!galera_all:!neutron_agent:!ceph_all:!rsyslog_all}\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f4b6375_8316c348","line":53,"range":{"start_line":53,"start_character":55,"end_line":53,"end_character":119},"updated":"2017-11-02 18:26:28.000000000","message":"This needs to be in single quotes else bash will attempt to interpret the \"!\".","commit_id":"81f17696d241e729eb089ffdf6b01bd2a933eecd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"e1fb0cab5bc4c871e9f4f55d499105842bcd06b9","unresolved":false,"context_lines":[{"line_number":50,"context_line":"export ANSIBLE_LOG_PATH\u003d\"/opt/leap42/ansible-${LEAP_TIMESTAMP}.log\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"## Containers List to Destroy in destroy-old-containers.yml"},{"line_number":53,"context_line":"export CONTAINERS_TO_DESTROY\u003d\u0027${CONTAINERS_TO_DESTROY:-all_containers:!galera_all:!neutron_agent:!ceph_all:!rsyslog_all}\u0027"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f4b6375_e6d0e521","line":53,"range":{"start_line":53,"start_character":29,"end_line":53,"end_character":121},"updated":"2017-11-02 19:10:01.000000000","message":"this will have to be something like double and single quotes otherwise the override will never work.\n\nsomething like: \n\n    export CONTAINERS_TO_DESTROY\u003d\"${CONTAINERS_TO_DESTROY:-\u0027all_containers:!galera_all:!neutron_agent:!ceph_all:!rsyslog_all\u0027}\"","commit_id":"a70b84b34f8813b770e3057a436f42e3a6f01afd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"d1688c11dfd85df224cf6dd9e4a3bfbcd9652d6a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"export ANSIBLE_LOG_PATH\u003d\"/opt/leap42/ansible-${LEAP_TIMESTAMP}.log\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"## Containers List to Destroy in destroy-old-containers.yml"},{"line_number":53,"context_line":"export CONTAINERS_TO_DESTROY\u003d\u0027${CONTAINERS_TO_DESTROY:-all_containers:!galera_all:!neutron_agent:!ceph_all:!rsyslog_all}\u0027"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1f485f77_cd4b4685","line":53,"range":{"start_line":53,"start_character":29,"end_line":53,"end_character":121},"in_reply_to":"3f4b6375_e6d0e521","updated":"2017-11-10 16:48:45.000000000","message":"To force string quoting maybe it\u0027d be best to alternate the quotes:\n\n  export CONTAINERS_TO_DESTROY\u003d\u0027\"\u0027\"${CONTAINERS_TO_DESTROY:-all_containers:!galera_all:!neutron_agent:!ceph_all:!rsyslog_all}\"\u0027\"\u0027\n\nwhich will always result in a quoted string regardless of an override being present or not.","commit_id":"a70b84b34f8813b770e3057a436f42e3a6f01afd"}],"leap-upgrades/re-deploy.sh":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"3bce16791be265591fe5e4a6aeac675e92cd668a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"RUN_TASKS+\u003d(\"${UPGRADE_UTILS}/db-stop.yml\")"},{"line_number":62,"context_line":"RUN_TASKS+\u003d(\"${UPGRADE_UTILS}/ansible_fact_cleanup.yml\")"},{"line_number":63,"context_line":"# Physical host cleanup"},{"line_number":64,"context_line":"RUN_TASKS+\u003d(\"${UPGRADE_UTILS}/destroy-old-containers.yml -e \u0027destroy_hosts\u003d\u0027${CONTAINERS_TO_DESTROY}\u0027\u0027\")"},{"line_number":65,"context_line":"# Permissions for qemu save, because physical host cleanup"},{"line_number":66,"context_line":"RUN_TASKS+\u003d(\"${UPGRADE_UTILS}/nova-libvirt-fix.yml\")"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f4b6375_e6fa2573","line":64,"range":{"start_line":64,"start_character":56,"end_line":64,"end_character":102},"updated":"2017-11-02 19:16:09.000000000","message":"I don\u0027t believe we need the single quotes from.","commit_id":"a70b84b34f8813b770e3057a436f42e3a6f01afd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"d428b45a5cd41ab85e860d873dac6a378e5c2fb4","unresolved":false,"context_lines":[{"line_number":61,"context_line":"RUN_TASKS+\u003d(\"${UPGRADE_UTILS}/db-stop.yml\")"},{"line_number":62,"context_line":"RUN_TASKS+\u003d(\"${UPGRADE_UTILS}/ansible_fact_cleanup.yml\")"},{"line_number":63,"context_line":"# Physical host cleanup"},{"line_number":64,"context_line":"RUN_TASKS+\u003d(\"${UPGRADE_UTILS}/destroy-old-containers.yml -e \u0027destroy_hosts\u003d\u0027${CONTAINERS_TO_DESTROY}\u0027\u0027\")"},{"line_number":65,"context_line":"# Permissions for qemu save, because physical host cleanup"},{"line_number":66,"context_line":"RUN_TASKS+\u003d(\"${UPGRADE_UTILS}/nova-libvirt-fix.yml\")"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1f485f77_6d4a1281","line":64,"range":{"start_line":64,"start_character":56,"end_line":64,"end_character":102},"in_reply_to":"3f4b6375_e6fa2573","updated":"2017-11-10 16:58:56.000000000","message":"If the previous variable is using alternating quotes the extra quotes would no longer be needed. \n\nWe can change this line to be like so:\n\n  RUN_TASKS+\u003d(\"${UPGRADE_UTILS}/destroy-old-containers.yml -e \u0027destroy_hosts\u003d${CONTAINERS_TO_DESTROY}\u0027\")\n\nWhich will have a resultant of:\n\n  /special-path/destroy-old-containers.yml -e \u0027destroy_hosts\u003d\"all_containers:!galera_all:!neutron_agent:!ceph_all:!rsyslog_all\"\u0027","commit_id":"a70b84b34f8813b770e3057a436f42e3a6f01afd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"7162efb7d0f456ab0f680f7bfe2b4c46835c7b1d","unresolved":false,"context_lines":[{"line_number":61,"context_line":"RUN_TASKS+\u003d(\"${UPGRADE_UTILS}/db-stop.yml\")"},{"line_number":62,"context_line":"RUN_TASKS+\u003d(\"${UPGRADE_UTILS}/ansible_fact_cleanup.yml\")"},{"line_number":63,"context_line":"# Physical host cleanup"},{"line_number":64,"context_line":"RUN_TASKS+\u003d(\"${UPGRADE_UTILS}/destroy-old-containers.yml -e \u0027destroy_hosts\u003d\u0027${CONTAINERS_TO_DESTROY}\u0027\u0027\")"},{"line_number":65,"context_line":"# Permissions for qemu save, because physical host cleanup"},{"line_number":66,"context_line":"RUN_TASKS+\u003d(\"${UPGRADE_UTILS}/nova-libvirt-fix.yml\")"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"1f485f77_ff6e6894","line":64,"range":{"start_line":64,"start_character":60,"end_line":64,"end_character":102},"updated":"2017-11-14 10:45:03.000000000","message":"IDK about the double use of single quotes here however it does some to render right.","commit_id":"4538a7e08306da73d446aa07ba76d10c73341969"}]}