)]}'
{"id":"openstack%2Fopenstack-ansible-ops~595743","triplet_id":"openstack%2Fopenstack-ansible-ops~master~Ia9001522ce054ee9f8a6dd38270da3e3fd039813","project":"openstack/openstack-ansible-ops","branch":"master","topic":"file-backed-vms","hashtags":[],"change_id":"Ia9001522ce054ee9f8a6dd38270da3e3fd039813","subject":"MNAIO: Move to using SCSI controller for TRIM support","status":"MERGED","created":"2018-08-23 12:24:42.000000000","updated":"2018-08-25 16:14:14.000000000","submitted":"2018-08-25 16:14:14.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"595743-1535213654753-aa6e6c01","meta_rev_id":"a38db378a7258b1184f25278d928d241607de110","_number":595743,"virtual_id_number":595743,"owner":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":2,"date":"2018-08-25 16:14:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":2,"date":"2018-08-23 13:44:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"value":2,"date":"2018-08-24 14:43:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"value":1,"date":"2018-08-24 14:43:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-08-23 13:44:05.000000000","updated_by":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"reviewer":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"state":"REVIEWER"},{"updated":"2018-08-24 14:43:49.000000000","updated_by":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"reviewer":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"state":"REVIEWER"},{"updated":"2018-08-25 16:14:14.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a957601044e2622ed016057dabf9cd7395260183","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2018-08-23 12:24:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"697dabdff2ebe05049d18938d997da7bcb28877e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-08-23 12:42:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/43/595743/1/check/build-openstack-sphinx-docs/15d64cf/html/ : SUCCESS in 3m 43s\n- openstack-ansible-linters http://logs.openstack.org/43/595743/1/check/openstack-ansible-linters/20b4a64/ : SUCCESS in 6m 09s\n- openstack-ansible-functional-centos-7 http://logs.openstack.org/43/595743/1/check/openstack-ansible-functional-centos-7/b72a1fc/ : SUCCESS in 5m 50s\n- openstack-ansible-functional-opensuse-423 http://logs.openstack.org/43/595743/1/check/openstack-ansible-functional-opensuse-423/eeeac3c/ : SUCCESS in 3m 37s\n- openstack-ansible-functional-ubuntu-bionic http://logs.openstack.org/43/595743/1/check/openstack-ansible-functional-ubuntu-bionic/d8a5b15/ : SUCCESS in 4m 52s\n- openstack-ansible-functional-ubuntu-xenial http://logs.openstack.org/43/595743/1/check/openstack-ansible-functional-ubuntu-xenial/8db4a96/ : SUCCESS in 4m 54s","accounts_in_message":[],"_revision_number":1},{"id":"7171aa7db734f35e0aa2d7f0bed2f375cc8d988b","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2018-08-23 12:47:03.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"ca3b6f328c570300a6bb997facbf4503b3493698","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2018-08-23 12:53:44.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"91197498d9158e014ff9b2f27157382503e18c0b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-08-23 13:05:51.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/43/595743/2/check/build-openstack-sphinx-docs/c0dedfd/html/ : SUCCESS in 3m 33s\n- openstack-ansible-linters http://logs.openstack.org/43/595743/2/check/openstack-ansible-linters/265c8e4/ : SUCCESS in 6m 18s\n- openstack-ansible-functional-centos-7 http://logs.openstack.org/43/595743/2/check/openstack-ansible-functional-centos-7/92c7507/ : SUCCESS in 6m 46s\n- openstack-ansible-functional-opensuse-423 http://logs.openstack.org/43/595743/2/check/openstack-ansible-functional-opensuse-423/282a07b/ : SUCCESS in 7m 03s\n- openstack-ansible-functional-ubuntu-bionic http://logs.openstack.org/43/595743/2/check/openstack-ansible-functional-ubuntu-bionic/0764df8/ : SUCCESS in 3m 44s\n- openstack-ansible-functional-ubuntu-xenial http://logs.openstack.org/43/595743/2/check/openstack-ansible-functional-ubuntu-xenial/417fb6e/ : SUCCESS in 4m 56s","accounts_in_message":[],"_revision_number":2},{"id":"bc08c41c994f3070a7d4cad581ae08a61d0538d8","author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"date":"2018-08-23 13:44:05.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"cfcd01e85eba87058f8f5f5f75cc236ecf17ad21","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2018-08-24 14:43:49.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"857ecf2f966b2bebda8ab880b22cb95a019b598a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-08-25 16:02:08.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"4be04e6eaa5dc5c7aa1dc67d5b684623927e3bb7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-08-25 16:14:14.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/43/595743/2/gate/build-openstack-sphinx-docs/e22884d/html/ : SUCCESS in 3m 02s\n- openstack-ansible-linters http://logs.openstack.org/43/595743/2/gate/openstack-ansible-linters/a4e2643/ : SUCCESS in 5m 15s\n- openstack-ansible-functional-centos-7 http://logs.openstack.org/43/595743/2/gate/openstack-ansible-functional-centos-7/1fd4da4/ : SUCCESS in 4m 55s\n- openstack-ansible-functional-opensuse-423 http://logs.openstack.org/43/595743/2/gate/openstack-ansible-functional-opensuse-423/ff15c71/ : SUCCESS in 6m 27s\n- openstack-ansible-functional-ubuntu-bionic http://logs.openstack.org/43/595743/2/gate/openstack-ansible-functional-ubuntu-bionic/ca2a089/ : SUCCESS in 4m 43s\n- openstack-ansible-functional-ubuntu-xenial http://logs.openstack.org/43/595743/2/gate/openstack-ansible-functional-ubuntu-xenial/808a8b5/ : SUCCESS in 2m 55s","accounts_in_message":[],"_revision_number":2},{"id":"d30fc7f1c42048df34ffdc623b9703cb2d834ce8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-08-25 16:14:14.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f3575be76a679b16158fea2ba672f36f508e88ff","revisions":{"6d7e7826e07286f28c034b55af836cbc08307c84":{"kind":"REWORK","_number":1,"created":"2018-08-23 12:24:42.000000000","uploader":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"ref":"refs/changes/43/595743/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-ops","ref":"refs/changes/43/595743/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-ops refs/changes/43/595743/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-ops refs/changes/43/595743/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-ops refs/changes/43/595743/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-ops refs/changes/43/595743/1"}}},"commit":{"parents":[{"commit":"c556bea0d70222412ac9792e3dfc12ceeb225ab6","subject":"MNAIO: Clean up existing data when switching backing store","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-ops/commit/c556bea0d70222412ac9792e3dfc12ceeb225ab6"}]}],"author":{"name":"Jesse Pretorius","email":"jesse.pretorius@rackspace.co.uk","date":"2018-08-23 12:20:25.000000000","tz":60},"committer":{"name":"Jesse Pretorius","email":"jesse.pretorius@rackspace.co.uk","date":"2018-08-23 12:20:25.000000000","tz":60},"subject":"MNAIO: Move to using SCSI controller for TRIM support","message":"MNAIO: Move to using SCSI controller for TRIM support\n\nWhen using file-backed storage, or SSD storage, any erasing\ndone in the VM does not actually clear up the space. By using\nthe virtio-scsi controller the VM is able to use TRIM to clear\nany blocks which are deleted.\n\nThis also allows us to use fstrim to reduce the size of the\nqemu files before we save them for later re-use.\n\nChange-Id: Ia9001522ce054ee9f8a6dd38270da3e3fd039813\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-ops/commit/6d7e7826e07286f28c034b55af836cbc08307c84"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-ops/commit/6d7e7826e07286f28c034b55af836cbc08307c84"}]},"branch":"refs/heads/master"},"f3575be76a679b16158fea2ba672f36f508e88ff":{"kind":"REWORK","_number":2,"created":"2018-08-23 12:53:44.000000000","uploader":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"ref":"refs/changes/43/595743/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-ops","ref":"refs/changes/43/595743/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-ops refs/changes/43/595743/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-ops refs/changes/43/595743/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-ops refs/changes/43/595743/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-ops refs/changes/43/595743/2"}}},"commit":{"parents":[{"commit":"c556bea0d70222412ac9792e3dfc12ceeb225ab6","subject":"MNAIO: Clean up existing data when switching backing store","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-ops/commit/c556bea0d70222412ac9792e3dfc12ceeb225ab6"}]}],"author":{"name":"Jesse Pretorius","email":"jesse.pretorius@rackspace.co.uk","date":"2018-08-23 12:20:25.000000000","tz":60},"committer":{"name":"Jesse Pretorius","email":"jesse.pretorius@rackspace.co.uk","date":"2018-08-23 12:53:20.000000000","tz":60},"subject":"MNAIO: Move to using SCSI controller for TRIM support","message":"MNAIO: Move to using SCSI controller for TRIM support\n\nWhen using file-backed storage, or SSD storage, any erasing\ndone in the VM does not actually clear up the space. By using\nthe virtio-scsi controller the VM is able to use TRIM to clear\nany blocks which are deleted.\n\nThis also allows us to use fstrim to reduce the size of the\nqemu files before we save them for later re-use.\n\nChange-Id: Ia9001522ce054ee9f8a6dd38270da3e3fd039813\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-ops/commit/f3575be76a679b16158fea2ba672f36f508e88ff"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-ops/commit/f3575be76a679b16158fea2ba672f36f508e88ff"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}