)]}'
{"elk_metrics_7x/roles/elastic_kibana/templates/kibana.yml.j2":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"a44be7e47835a558802df3456a7af9715408132c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"# The URLs of the Elasticsearch instances to use for all your queries."},{"line_number":28,"context_line":"elasticsearch.hosts:"},{"line_number":29,"context_line":"{% for endpoint in kibana_elastic_endpoints %}"},{"line_number":30,"context_line":"  - http://{{ endpoint }}:{{ elastic_port }}"},{"line_number":31,"context_line":"{% endfor %}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# When this setting\u0027s value is true Kibana uses the hostname specified in the server.host"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_55f4d2cf","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":44},"updated":"2020-02-14 03:37:43.000000000","message":"tbh I don\u0027t like such combining for several reasons:\n- why proto is always http?\n- for different urls only the same port can be used. So this makes unable to use proper endpoint/port combination\n\nSo probably it\u0027s worth making kibana_elastic_endpoints a dict, with keys host, port (with default to elastic_port), proto (default to http).\nMaybe you can find even better solution :p","commit_id":"13c70ec6213f5d3b0536445cd7d40df74ea2dd3e"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"9602e07571c68163fe42c8720b9c75c72debc0b4","unresolved":false,"context_lines":[{"line_number":27,"context_line":"# The URLs of the Elasticsearch instances to use for all your queries."},{"line_number":28,"context_line":"elasticsearch.hosts:"},{"line_number":29,"context_line":"{% for endpoint in kibana_elastic_endpoints %}"},{"line_number":30,"context_line":"  - http://{{ endpoint }}:{{ elastic_port }}"},{"line_number":31,"context_line":"{% endfor %}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# When this setting\u0027s value is true Kibana uses the hostname specified in the server.host"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_870f7289","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":44},"in_reply_to":"3fa7e38b_55f4d2cf","updated":"2020-02-15 13:36:52.000000000","message":"duncan i think you should look at how endpoints are handled more generally in OSA - perhaps this all needs refactoring a bit.","commit_id":"13c70ec6213f5d3b0536445cd7d40df74ea2dd3e"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"6ba4c5688e8d6b3bac5ecf4384317eca5454fd15","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# The URLs of the Elasticsearch instances to use for all your queries."},{"line_number":28,"context_line":"elasticsearch.hosts:"},{"line_number":29,"context_line":"{% for endpoint in kibana_elastic_endpoints %}"},{"line_number":30,"context_line":"  - {{ endpoint }}"},{"line_number":31,"context_line":"{% endfor %}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# When this setting\u0027s value is true Kibana uses the hostname specified in the server.host"},{"line_number":34,"context_line":"# setting. When the value of this setting is false, Kibana uses the hostname of the host"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_bf3f0022","line":31,"range":{"start_line":29,"start_character":0,"end_line":31,"end_character":12},"updated":"2020-02-17 21:15:46.000000000","message":"given that this is now simply a list is to_json useful here?","commit_id":"8e9cf3252b29d9bcd7cb93cbe4f7e3ebea1c52fc"}]}
