)]}'
{"elk_metrics_7x/installElastic.yml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"832af642e5d665d5bfff723fd35c0656bbd8e612","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# limitations under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Install Elastic Search"},{"line_number":15,"context_line":"  hosts: \"{{ elastic_hosts + groups[\u0027kibana\u0027] }}\""},{"line_number":16,"context_line":"  become: true"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  vars_files:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_a0efd51a","line":15,"range":{"start_line":15,"start_character":10,"end_line":15,"end_character":48},"updated":"2020-02-20 22:59:47.000000000","message":"this should probably be elastic_hosts:kibana see https://docs.ansible.com/ansible/latest/user_guide/intro_patterns.html#common-patterns","commit_id":"6ad05b74e606275de93ac298705242f5de15f150"},{"author":{"_account_id":31004,"name":"Duncan Martin Walker","email":"Duncan.Walker02@bbc.co.uk","username":"duncan-martin-walker"},"change_message_id":"27530669e7862ca37dfc164a78d63eea8db862ce","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# limitations under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Install Elastic Search"},{"line_number":15,"context_line":"  hosts: \"{{ elastic_hosts + groups[\u0027kibana\u0027] }}\""},{"line_number":16,"context_line":"  become: true"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  vars_files:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_72cdf6b7","line":15,"range":{"start_line":15,"start_character":10,"end_line":15,"end_character":48},"in_reply_to":"3fa7e38b_a0efd51a","updated":"2020-02-21 17:08:55.000000000","message":"Unfortunately, because elastic_hosts isn\u0027t a group but a variable, just a list of hosts, this syntax doesn\u0027t work (it doesn\u0027t get expanded). The closest syntax I can find that generates the correct host list is hosts: \"{{ elastic_hosts | join(\u0027:\u0027) }}:kibana\", which may still be preferable.","commit_id":"6ad05b74e606275de93ac298705242f5de15f150"}],"elk_metrics_7x/vars/variables.yml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"832af642e5d665d5bfff723fd35c0656bbd8e612","unresolved":false,"context_lines":[{"line_number":22,"context_line":"kibana_port: 5601"},{"line_number":23,"context_line":"kibana_nginx_port: 81"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Elastic-logstash group definitions"},{"line_number":26,"context_line":"elastic_hosts: \"{{ groups[\u0027elastic\u0027] | default(groups[\u0027elastic-logstash\u0027]) }}\""},{"line_number":27,"context_line":"logstash_hosts: \"{{ groups[\u0027logstash\u0027] | default(groups[\u0027elastic-logstash\u0027]) }}\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# This is the URL external services can use to communicate with the"},{"line_number":30,"context_line":"# elasticsearch cluster."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_1de7fcd9","line":27,"range":{"start_line":25,"start_character":0,"end_line":27,"end_character":80},"updated":"2020-02-20 22:59:47.000000000","message":"is this the only place the elastic and logstash groups are defined? Is it possible to move these vars to the relevant defaults file and drop the references to groups[\u0027elastic\u0027] and groups[\u0027logstash\u0027] ?","commit_id":"7114e097efba1ebbb8f9bba2cb060793e26a660d"},{"author":{"_account_id":31004,"name":"Duncan Martin Walker","email":"Duncan.Walker02@bbc.co.uk","username":"duncan-martin-walker"},"change_message_id":"27530669e7862ca37dfc164a78d63eea8db862ce","unresolved":false,"context_lines":[{"line_number":22,"context_line":"kibana_port: 5601"},{"line_number":23,"context_line":"kibana_nginx_port: 81"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Elastic-logstash group definitions"},{"line_number":26,"context_line":"elastic_hosts: \"{{ groups[\u0027elastic\u0027] | default(groups[\u0027elastic-logstash\u0027]) }}\""},{"line_number":27,"context_line":"logstash_hosts: \"{{ groups[\u0027logstash\u0027] | default(groups[\u0027elastic-logstash\u0027]) }}\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# This is the URL external services can use to communicate with the"},{"line_number":30,"context_line":"# elasticsearch cluster."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_f287a614","line":27,"range":{"start_line":25,"start_character":0,"end_line":27,"end_character":80},"in_reply_to":"3fa7e38b_1de7fcd9","updated":"2020-02-21 17:08:55.000000000","message":"It is for elastic_hosts, but the presence of groups[\u0027logstash\u0027] is used for a test in data_node_variables r.e. overriding the installation of logstash to ingest nodes or not. \nThe trouble is that elastic_hosts and logstash_hosts are used at the top level in e.g. the installElastic and installLogstash playbooks, rather than just within roles with default files. To my understanding this means that any defaults file would have to be included in the same ways as variables.yml using include_vars:","commit_id":"7114e097efba1ebbb8f9bba2cb060793e26a660d"}]}