)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"558af7d2bf7646100ce879295b05f60e5d057de8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aeeb9aa3_2425d528","updated":"2022-05-31 10:40:17.000000000","message":"The apt_package_pinning role needs to available for this to work","commit_id":"df7ff53798722511f4cee026588fcf797b19e437"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"d3a5a1632f5a718b47e8bb5c5fb087b640435e81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"155817f7_d9a9f13d","updated":"2022-10-28 12:20:39.000000000","message":"Seems we don\u0027t run correct a-r-r or a-c-r here:\nhttps://zuul.opendev.org/t/openstack/build/faf22914206d467290dbe6a5b0a6d3c2/log/job-output.txt#689-705","commit_id":"28b1b478e874cd200faa89d0f99f84d9e0287e34"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2f2ae6560baca71e5b87c839b177c0499880ecac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"90263cde_1387bbf4","updated":"2022-11-11 08:48:08.000000000","message":"Well, I think we can land as is and iterate later if needed. No reason to block this patch and all on top of it.","commit_id":"29080ab4f6cfbcb9e55cfdcab3f6e569c88e814a"}],"elk_metrics_7x/vars/variables.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"4b46e77e27d89b8b6a530f113e2d232e7afe1cdc","unresolved":true,"context_lines":[{"line_number":435,"context_line":"# elastic_apt_pin_version: \"{{ beat_version }}\""},{"line_number":436,"context_line":"# elastic_apt_pin_packages: []"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"_elastic_apt_pin_packages:"},{"line_number":439,"context_line":"  - version: \"{{ elastic_apt_pin_version_journalbeat | default(elastic_apt_pin_version | default(beat_version)) }}\""},{"line_number":440,"context_line":"    package: \"journalbeat\""},{"line_number":441,"context_line":"  - version: \"{{ elastic_apt_pin_version | default(beat_version) }}\""},{"line_number":442,"context_line":"    package: \"packetbeat\""},{"line_number":443,"context_line":"  - version: \"{{ elastic_apt_pin_version | default(beat_version) }}\""},{"line_number":444,"context_line":"    package: \"apm-server\""},{"line_number":445,"context_line":"  - version: \"{{ elastic_apt_pin_version | default(beat_version) }}\""},{"line_number":446,"context_line":"    package: \"metricbeat\""},{"line_number":447,"context_line":"  - version: \"{{ elastic_apt_pin_version | default(beat_version) }}\""},{"line_number":448,"context_line":"    package: \"auditbeat\""},{"line_number":449,"context_line":"  - version: \"{{ elastic_apt_pin_version | default(beat_version) }}\""},{"line_number":450,"context_line":"    package: \"filebeat\""},{"line_number":451,"context_line":"  - version: \"1:{{ elastic_apt_pin_version | default(beat_version) }}-1\""},{"line_number":452,"context_line":"    package: \"logstash\""},{"line_number":453,"context_line":"  - version: \"{{ elastic_apt_pin_version | default(beat_version) }}\""},{"line_number":454,"context_line":"    package: \"elasticsearch\""},{"line_number":455,"context_line":"  - version: \"{{ elastic_apt_pin_version | default(beat_version) }}\""},{"line_number":456,"context_line":"    package: \"kibana\""},{"line_number":457,"context_line":"  - version: \"{{ elastic_apt_pin_version | default(beat_version) }}\""},{"line_number":458,"context_line":"    package: \"heartbeat-elastic\""},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"apt_package_pinning_file_name: \"{{ elastic_apt_pin_file_name | default(\u0027elasticsearch.pref\u0027) }}\""},{"line_number":461,"context_line":"apt_pinned_packages: \"{{ elastic_apt_pin_packages | default(_elastic_apt_pin_packages) }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f11a404e_3461a4e2","line":458,"range":{"start_line":438,"start_character":0,"end_line":458,"end_character":32},"updated":"2022-10-31 17:47:28.000000000","message":"given all these packages come from same source and have same version - doesn\u0027t it make sense to pin by the repo or release rather then repeat all packages independently? or maybe intention was to make all variables different and it\u0027s just copy-paste error?","commit_id":"29080ab4f6cfbcb9e55cfdcab3f6e569c88e814a"},{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"8d24128364b1daef7ddc93aa4cebd049d4164c19","unresolved":true,"context_lines":[{"line_number":435,"context_line":"# elastic_apt_pin_version: \"{{ beat_version }}\""},{"line_number":436,"context_line":"# elastic_apt_pin_packages: []"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"_elastic_apt_pin_packages:"},{"line_number":439,"context_line":"  - version: \"{{ elastic_apt_pin_version_journalbeat | default(elastic_apt_pin_version | default(beat_version)) }}\""},{"line_number":440,"context_line":"    package: \"journalbeat\""},{"line_number":441,"context_line":"  - version: \"{{ elastic_apt_pin_version | default(beat_version) }}\""},{"line_number":442,"context_line":"    package: \"packetbeat\""},{"line_number":443,"context_line":"  - version: \"{{ elastic_apt_pin_version | default(beat_version) }}\""},{"line_number":444,"context_line":"    package: \"apm-server\""},{"line_number":445,"context_line":"  - version: \"{{ elastic_apt_pin_version | default(beat_version) }}\""},{"line_number":446,"context_line":"    package: \"metricbeat\""},{"line_number":447,"context_line":"  - version: \"{{ elastic_apt_pin_version | default(beat_version) }}\""},{"line_number":448,"context_line":"    package: \"auditbeat\""},{"line_number":449,"context_line":"  - version: \"{{ elastic_apt_pin_version | default(beat_version) }}\""},{"line_number":450,"context_line":"    package: \"filebeat\""},{"line_number":451,"context_line":"  - version: \"1:{{ elastic_apt_pin_version | default(beat_version) }}-1\""},{"line_number":452,"context_line":"    package: \"logstash\""},{"line_number":453,"context_line":"  - version: \"{{ elastic_apt_pin_version | default(beat_version) }}\""},{"line_number":454,"context_line":"    package: \"elasticsearch\""},{"line_number":455,"context_line":"  - version: \"{{ elastic_apt_pin_version | default(beat_version) }}\""},{"line_number":456,"context_line":"    package: \"kibana\""},{"line_number":457,"context_line":"  - version: \"{{ elastic_apt_pin_version | default(beat_version) }}\""},{"line_number":458,"context_line":"    package: \"heartbeat-elastic\""},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"apt_package_pinning_file_name: \"{{ elastic_apt_pin_file_name | default(\u0027elasticsearch.pref\u0027) }}\""},{"line_number":461,"context_line":"apt_pinned_packages: \"{{ elastic_apt_pin_packages | default(_elastic_apt_pin_packages) }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"723079f5_c9736c48","line":458,"range":{"start_line":438,"start_character":0,"end_line":458,"end_character":32},"in_reply_to":"d3e6e48a_28d411a4","updated":"2022-11-02 11:43:39.000000000","message":"Speaking to Jon I see it might have been possible to use similar syntax to https://github.com/openstack/openstack-ansible-openstack_hosts/blob/master/defaults/main.yml#L193 to tidy this up. Unfortunately as far as I can see these packages don\u0027t indicate a source package in their metadata (other than elasticsearch itself), perhaps indicating they\u0027re all independent. If it helps it might be possible to define the package names on a single line?","commit_id":"29080ab4f6cfbcb9e55cfdcab3f6e569c88e814a"},{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"095f9ba162d6b970c6adcb836e267152f467194a","unresolved":true,"context_lines":[{"line_number":435,"context_line":"# elastic_apt_pin_version: \"{{ beat_version }}\""},{"line_number":436,"context_line":"# elastic_apt_pin_packages: []"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"_elastic_apt_pin_packages:"},{"line_number":439,"context_line":"  - version: \"{{ elastic_apt_pin_version_journalbeat | default(elastic_apt_pin_version | default(beat_version)) }}\""},{"line_number":440,"context_line":"    package: \"journalbeat\""},{"line_number":441,"context_line":"  - version: \"{{ elastic_apt_pin_version | default(beat_version) }}\""},{"line_number":442,"context_line":"    package: \"packetbeat\""},{"line_number":443,"context_line":"  - version: \"{{ elastic_apt_pin_version | default(beat_version) }}\""},{"line_number":444,"context_line":"    package: \"apm-server\""},{"line_number":445,"context_line":"  - version: \"{{ elastic_apt_pin_version | default(beat_version) }}\""},{"line_number":446,"context_line":"    package: \"metricbeat\""},{"line_number":447,"context_line":"  - version: \"{{ elastic_apt_pin_version | default(beat_version) }}\""},{"line_number":448,"context_line":"    package: \"auditbeat\""},{"line_number":449,"context_line":"  - version: \"{{ elastic_apt_pin_version | default(beat_version) }}\""},{"line_number":450,"context_line":"    package: \"filebeat\""},{"line_number":451,"context_line":"  - version: \"1:{{ elastic_apt_pin_version | default(beat_version) }}-1\""},{"line_number":452,"context_line":"    package: \"logstash\""},{"line_number":453,"context_line":"  - version: \"{{ elastic_apt_pin_version | default(beat_version) }}\""},{"line_number":454,"context_line":"    package: \"elasticsearch\""},{"line_number":455,"context_line":"  - version: \"{{ elastic_apt_pin_version | default(beat_version) }}\""},{"line_number":456,"context_line":"    package: \"kibana\""},{"line_number":457,"context_line":"  - version: \"{{ elastic_apt_pin_version | default(beat_version) }}\""},{"line_number":458,"context_line":"    package: \"heartbeat-elastic\""},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"apt_package_pinning_file_name: \"{{ elastic_apt_pin_file_name | default(\u0027elasticsearch.pref\u0027) }}\""},{"line_number":461,"context_line":"apt_pinned_packages: \"{{ elastic_apt_pin_packages | default(_elastic_apt_pin_packages) }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d3e6e48a_28d411a4","line":458,"range":{"start_line":438,"start_character":0,"end_line":458,"end_character":32},"in_reply_to":"f11a404e_3461a4e2","updated":"2022-11-01 15:21:34.000000000","message":"In order to pin by package version, which is the intention here, I don\u0027t think there\u0027s an alternative. Apt pinning requires an exact list of package names or a wildcard given this repository holds many options. I could make the structure more flexible so there\u0027s a variable for each of them (like the Journalbeat case), but without an explicit reason to do that I thought allowing the whole structure to be overridden might be sufficient.","commit_id":"29080ab4f6cfbcb9e55cfdcab3f6e569c88e814a"}]}