)]}'
{"id":"openstack%2Fopenstack-ansible-os_aodh~671116","triplet_id":"openstack%2Fopenstack-ansible-os_aodh~master~I2492ed205a94541160e72a9cb3631e0b255d5b53","project":"openstack/openstack-ansible-os_aodh","branch":"master","topic":"static_imports","hashtags":[],"change_id":"I2492ed205a94541160e72a9cb3631e0b255d5b53","subject":"Convert dynamic includes to static imports","status":"MERGED","created":"2019-07-16 17:22:21.000000000","updated":"2019-07-16 23:41:42.000000000","submitted":"2019-07-16 23:41:42.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"671116-1563320502452-6d7173bf","meta_rev_id":"7d89e3fedd35293c9fda42d4c09096706e5a0a02","_number":671116,"virtual_id_number":671116,"owner":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-07-16 23:41:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-07-16 19:18:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":2,"date":"2019-07-16 20:35:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":1,"date":"2019-07-16 20:35:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-16 19:18:03.000000000","updated_by":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"reviewer":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"state":"REVIEWER"},{"updated":"2019-07-16 20:35:24.000000000","updated_by":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"reviewer":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"state":"REVIEWER"},{"updated":"2019-07-16 23:41:42.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"03c111ba8306541aba747e5357b50ad21baa5287","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2019-07-16 17:22:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"91c329fe6b5fcc2746c5108a438111a5a7c08c28","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-16 18:17:50.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-ansible-linters http://logs.openstack.org/16/671116/1/check/openstack-ansible-linters/270cfff/ : FAILURE in 4m 39s\n- openstack-ansible-deploy-aio_metal-debian-stable http://logs.openstack.org/16/671116/1/check/openstack-ansible-deploy-aio_metal-debian-stable/bd3e293/ : FAILURE in 18m 58s\n- openstack-ansible-deploy-aio_metal-centos-7 http://logs.openstack.org/16/671116/1/check/openstack-ansible-deploy-aio_metal-centos-7/71dcb43/ : FAILURE in 25m 28s\n- openstack-ansible-deploy-aio_metal-opensuse-15 http://logs.openstack.org/16/671116/1/check/openstack-ansible-deploy-aio_metal-opensuse-15/0ec3d97/ : FAILURE in 30m 41s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic http://logs.openstack.org/16/671116/1/check/openstack-ansible-deploy-aio_metal-ubuntu-bionic/8427673/ : FAILURE in 17m 36s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 http://logs.openstack.org/16/671116/1/check/openstack-ansible-deploy-aio_distro_metal-centos-7/4725847/ : FAILURE in 22m 39s\n- openstack-ansible-deploy-aio_distro_metal-opensuse-15 http://logs.openstack.org/16/671116/1/check/openstack-ansible-deploy-aio_distro_metal-opensuse-15/07fa57f/ : FAILURE in 20m 38s (non-voting)\n- openstack-ansible-deploy-aio_telemetry_metal-centos-7 http://logs.openstack.org/16/671116/1/check/openstack-ansible-deploy-aio_telemetry_metal-centos-7/779087e/ : FAILURE in 30m 51s\n- openstack-ansible-deploy-aio_telemetry_metal-debian-stable http://logs.openstack.org/16/671116/1/check/openstack-ansible-deploy-aio_telemetry_metal-debian-stable/a0f8c9f/ : FAILURE in 19m 33s\n- openstack-ansible-deploy-aio_telemetry_metal-ubuntu-bionic http://logs.openstack.org/16/671116/1/check/openstack-ansible-deploy-aio_telemetry_metal-ubuntu-bionic/71c5193/ : FAILURE in 21m 47s\n- openstack-tox-docs http://logs.openstack.org/16/671116/1/check/openstack-tox-docs/2a36e3a/html/ : SUCCESS in 3m 28s","accounts_in_message":[],"_revision_number":1},{"id":"637ff9accd72284732f6f10d94ee2338803d30e2","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2019-07-16 18:37:08.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4bcba1c3554f0120e51d7d47e4518ad4908153c6","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2019-07-16 19:18:03.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"0de06fc0beb197be63f6d878c147b3715b34e6d3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-16 20:34:21.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-ansible-linters http://logs.openstack.org/16/671116/2/check/openstack-ansible-linters/51ada1c/ : SUCCESS in 5m 47s\n- openstack-ansible-deploy-aio_metal-debian-stable http://logs.openstack.org/16/671116/2/check/openstack-ansible-deploy-aio_metal-debian-stable/4e7a349/ : SUCCESS in 1h 09m 26s\n- openstack-ansible-deploy-aio_metal-centos-7 http://logs.openstack.org/16/671116/2/check/openstack-ansible-deploy-aio_metal-centos-7/dbefdbe/ : SUCCESS in 1h 40m 51s\n- openstack-ansible-deploy-aio_metal-opensuse-15 http://logs.openstack.org/16/671116/2/check/openstack-ansible-deploy-aio_metal-opensuse-15/cabd164/ : SUCCESS in 1h 41m 15s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic http://logs.openstack.org/16/671116/2/check/openstack-ansible-deploy-aio_metal-ubuntu-bionic/c99a7b2/ : SUCCESS in 1h 19m 54s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 http://logs.openstack.org/16/671116/2/check/openstack-ansible-deploy-aio_distro_metal-centos-7/c41275a/ : SUCCESS in 1h 25m 16s\n- openstack-ansible-deploy-aio_distro_metal-opensuse-15 http://logs.openstack.org/16/671116/2/check/openstack-ansible-deploy-aio_distro_metal-opensuse-15/afc7535/ : FAILURE in 48m 12s (non-voting)\n- openstack-ansible-deploy-aio_telemetry_metal-centos-7 http://logs.openstack.org/16/671116/2/check/openstack-ansible-deploy-aio_telemetry_metal-centos-7/58e9aa7/ : SUCCESS in 1h 50m 22s\n- openstack-ansible-deploy-aio_telemetry_metal-debian-stable http://logs.openstack.org/16/671116/2/check/openstack-ansible-deploy-aio_telemetry_metal-debian-stable/da22263/ : SUCCESS in 1h 22m 41s\n- openstack-ansible-deploy-aio_telemetry_metal-ubuntu-bionic http://logs.openstack.org/16/671116/2/check/openstack-ansible-deploy-aio_telemetry_metal-ubuntu-bionic/c1e71cc/ : SUCCESS in 1h 41m 43s\n- openstack-tox-docs http://logs.openstack.org/16/671116/2/check/openstack-tox-docs/915a4a1/html/ : SUCCESS in 3m 07s","accounts_in_message":[],"_revision_number":2},{"id":"e3f7bb3c118fd8e29b139f20b20519ac8ce029a1","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2019-07-16 20:35:24.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"dda9b2540dfc23beec2f7f2f49845aa26d65ec5c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-16 20:35:36.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"dc91fc320f20fa90b21d15a0f808bffbea4fbda4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-16 23:41:42.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"d28fa9ac44f97c59ce21591204ebd956e9d14316","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-16 23:41:42.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-ansible-linters http://logs.openstack.org/16/671116/2/gate/openstack-ansible-linters/d4aceb9/ : SUCCESS in 5m 35s\n- openstack-ansible-deploy-aio_metal-debian-stable http://logs.openstack.org/16/671116/2/gate/openstack-ansible-deploy-aio_metal-debian-stable/1608cee/ : SUCCESS in 1h 34m 35s\n- openstack-ansible-deploy-aio_metal-centos-7 http://logs.openstack.org/16/671116/2/gate/openstack-ansible-deploy-aio_metal-centos-7/14d4177/ : SUCCESS in 1h 38m 25s\n- openstack-ansible-deploy-aio_metal-opensuse-15 http://logs.openstack.org/16/671116/2/gate/openstack-ansible-deploy-aio_metal-opensuse-15/87a6c89/ : SUCCESS in 2h 43m 03s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic http://logs.openstack.org/16/671116/2/gate/openstack-ansible-deploy-aio_metal-ubuntu-bionic/4d00910/ : SUCCESS in 1h 03m 18s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 http://logs.openstack.org/16/671116/2/gate/openstack-ansible-deploy-aio_distro_metal-centos-7/9a2fc77/ : SUCCESS in 1h 30m 23s\n- openstack-ansible-deploy-aio_telemetry_metal-centos-7 http://logs.openstack.org/16/671116/2/gate/openstack-ansible-deploy-aio_telemetry_metal-centos-7/fe10721/ : SUCCESS in 1h 39m 17s\n- openstack-ansible-deploy-aio_telemetry_metal-debian-stable http://logs.openstack.org/16/671116/2/gate/openstack-ansible-deploy-aio_telemetry_metal-debian-stable/44963d3/ : SUCCESS in 1h 20m 48s\n- openstack-ansible-deploy-aio_telemetry_metal-ubuntu-bionic http://logs.openstack.org/16/671116/2/gate/openstack-ansible-deploy-aio_telemetry_metal-ubuntu-bionic/f9b48fe/ : SUCCESS in 1h 30m 45s\n- openstack-tox-docs http://logs.openstack.org/16/671116/2/gate/openstack-tox-docs/e21463e/html/ : SUCCESS in 2m 50s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"480d74bb71232ec2f174ab1515d5095707b97c3f","revisions":{"2d83292798c7372bd3c5ce7d6e3bd2aa61046b32":{"kind":"REWORK","_number":1,"created":"2019-07-16 17:22:21.000000000","uploader":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"ref":"refs/changes/16/671116/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-os_aodh","ref":"refs/changes/16/671116/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_aodh refs/changes/16/671116/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_aodh refs/changes/16/671116/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_aodh refs/changes/16/671116/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-os_aodh refs/changes/16/671116/1"}}},"commit":{"parents":[{"commit":"0075b90198c4ae1953eb62a6c410db1f0687e0e7","subject":"Updated from OpenStack Ansible Tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_aodh/commit/0075b90198c4ae1953eb62a6c410db1f0687e0e7"}]}],"author":{"name":"Dmitriy Rabotyagov","email":"drabotyagov@vexxhost.com","date":"2019-07-16 17:21:57.000000000","tz":180},"committer":{"name":"Dmitriy Rabotyagov","email":"drabotyagov@vexxhost.com","date":"2019-07-16 17:22:18.000000000","tz":180},"subject":"Convert dynamic includes to static imports","message":"Convert dynamic includes to static imports\n\nWhen task/role files are included using include_tasks, tags are not\npassed to the included tasks. As a result, tags like neutron-config\ndo not have the intended effect. This patch changes include_tasks\nto import_tasks for all cases where dynamic vars or loops are not used\nso that tags are properly handled.\n\nReference -\nhttps://docs.ansible.com/ansible/latest/user_guide/playbooks_reuse.html\nhttps://bugs.launchpad.net/openstack-ansible/+bug/1815043\n\nChange-Id: I2492ed205a94541160e72a9cb3631e0b255d5b53\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_aodh/commit/2d83292798c7372bd3c5ce7d6e3bd2aa61046b32"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_aodh/commit/2d83292798c7372bd3c5ce7d6e3bd2aa61046b32"}]},"branch":"refs/heads/master"},"480d74bb71232ec2f174ab1515d5095707b97c3f":{"kind":"REWORK","_number":2,"created":"2019-07-16 18:37:08.000000000","uploader":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"ref":"refs/changes/16/671116/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-os_aodh","ref":"refs/changes/16/671116/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_aodh refs/changes/16/671116/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_aodh refs/changes/16/671116/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_aodh refs/changes/16/671116/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-os_aodh refs/changes/16/671116/2"}}},"commit":{"parents":[{"commit":"0075b90198c4ae1953eb62a6c410db1f0687e0e7","subject":"Updated from OpenStack Ansible Tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_aodh/commit/0075b90198c4ae1953eb62a6c410db1f0687e0e7"}]}],"author":{"name":"Dmitriy Rabotyagov","email":"drabotyagov@vexxhost.com","date":"2019-07-16 17:21:57.000000000","tz":180},"committer":{"name":"Dmitriy Rabotyagov","email":"drabotyagov@vexxhost.com","date":"2019-07-16 18:36:56.000000000","tz":180},"subject":"Convert dynamic includes to static imports","message":"Convert dynamic includes to static imports\n\nWhen task/role files are included using include_tasks, tags are not\npassed to the included tasks. As a result, tags like neutron-config\ndo not have the intended effect. This patch changes include_tasks\nto import_tasks for all cases where dynamic vars or loops are not used\nso that tags are properly handled.\n\nReference -\nhttps://docs.ansible.com/ansible/latest/user_guide/playbooks_reuse.html\nhttps://bugs.launchpad.net/openstack-ansible/+bug/1815043\n\nChange-Id: I2492ed205a94541160e72a9cb3631e0b255d5b53\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_aodh/commit/480d74bb71232ec2f174ab1515d5095707b97c3f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_aodh/commit/480d74bb71232ec2f174ab1515d5095707b97c3f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}