)]}'
{"tests/test-prepare-host.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"181d2eeb1934679701a7e501ce89ad16d41bc566","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Perform baisc LXC host setup"},{"line_number":17,"context_line":"  hosts: localhost"},{"line_number":18,"context_line":"  connection: local"},{"line_number":19,"context_line":"  become: yes"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fa0719c6_ed4a9882","line":16,"range":{"start_line":16,"start_character":16,"end_line":16,"end_character":21},"updated":"2016-03-22 14:03:07.000000000","message":"nit: basic","commit_id":"406cdb56af21bc19b8c9f8296b1434f0993f4385"},{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"d2ecbc1d9e2e7b50fcfa59f062a9cf4d0d6c488e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Perform baisc LXC host setup"},{"line_number":17,"context_line":"  hosts: localhost"},{"line_number":18,"context_line":"  connection: local"},{"line_number":19,"context_line":"  become: yes"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fa0719c6_1ba88ada","line":16,"range":{"start_line":16,"start_character":16,"end_line":16,"end_character":21},"in_reply_to":"fa0719c6_ed4a9882","updated":"2016-03-23 21:13:51.000000000","message":"Done","commit_id":"406cdb56af21bc19b8c9f8296b1434f0993f4385"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"181d2eeb1934679701a7e501ce89ad16d41bc566","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Perform baisc LXC host setup"},{"line_number":17,"context_line":"  hosts: localhost"},{"line_number":18,"context_line":"  connection: local"},{"line_number":19,"context_line":"  become: yes"},{"line_number":20,"context_line":"  pre_tasks:"},{"line_number":21,"context_line":"    # Make sure OS does not have a stale package cache."},{"line_number":22,"context_line":"    - name: Update apt cache"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fa0719c6_8d54bc21","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":13},"updated":"2016-03-22 14:03:07.000000000","message":"The inventory specifies this, so it shouldn\u0027t be required.","commit_id":"406cdb56af21bc19b8c9f8296b1434f0993f4385"},{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"d2ecbc1d9e2e7b50fcfa59f062a9cf4d0d6c488e","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Perform baisc LXC host setup"},{"line_number":17,"context_line":"  hosts: localhost"},{"line_number":18,"context_line":"  connection: local"},{"line_number":19,"context_line":"  become: yes"},{"line_number":20,"context_line":"  pre_tasks:"},{"line_number":21,"context_line":"    # Make sure OS does not have a stale package cache."},{"line_number":22,"context_line":"    - name: Update apt cache"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fa0719c6_7bb1c646","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":13},"in_reply_to":"fa0719c6_8d54bc21","updated":"2016-03-23 21:13:51.000000000","message":"Done","commit_id":"406cdb56af21bc19b8c9f8296b1434f0993f4385"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"a985219a8199af873d0d2f547e68a1fc580bfc1d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"          name: \"trusty.tgz\""},{"line_number":61,"context_line":"          sha256sum: \"56c6a6e132ea7d10be2f3e8104f47136ccf408b30e362133f0dc4a0a9adb4d0c\""},{"line_number":62,"context_line":"          chroot_path: trusty/rootfs-amd64"},{"line_number":63,"context_line":"      # The $HOME directory is mocked to work with tox"},{"line_number":64,"context_line":"      #  by defining the \u0027ansible_env\u0027 hash. This should"},{"line_number":65,"context_line":"      #  NEVER be done outside of testing."},{"line_number":66,"context_line":"      ansible_env:  ## NEVER DO THIS OUTSIDE OF TESTING"},{"line_number":67,"context_line":"        HOME: \"/tmp\""},{"line_number":68,"context_line":"  post_tasks:"},{"line_number":69,"context_line":"    # Inventory is being pre-loaded using a post tasks instead of through a dynamic"},{"line_number":70,"context_line":"    #  inventory system. While this is not a usual method for deployment it\u0027s being"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fa0719c6_b3de360f","line":67,"range":{"start_line":63,"start_character":0,"end_line":67,"end_character":20},"updated":"2016-03-22 16:48:13.000000000","message":"I think this needs to come out - we\u0027re passing the HOME env in the tox configuration.","commit_id":"406cdb56af21bc19b8c9f8296b1434f0993f4385"}],"tests/test-prepare-vg.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c14feca9ee1b1a69dc4cabf63747a882c19bae0a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Prepare cinder-volumes volume group"},{"line_number":17,"context_line":"  hosts: 127.0.0.1"},{"line_number":18,"context_line":"  connection: local"},{"line_number":19,"context_line":"  become: true"},{"line_number":20,"context_line":"  tasks:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"fa0719c6_5a36dce7","line":17,"range":{"start_line":17,"start_character":9,"end_line":17,"end_character":18},"updated":"2016-03-22 13:32:31.000000000","message":"nit:\n\n127.0.0.1 and localhost are seen as different hosts. In our current paradigm we use 127.0.0.1 for non-root stuff and localhost for root stuff. This is because connection\u003dlocal and become\u003dtrue are set in the inventory for that target.\n\nie this should actually target localhost and shouldn\u0027t need the connection and become vars.","commit_id":"f1f95ce87945aac320c62cab2178cfe6c889d80c"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"181d2eeb1934679701a7e501ce89ad16d41bc566","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Prepare cinder-volumes volume group"},{"line_number":17,"context_line":"  hosts: 127.0.0.1"},{"line_number":18,"context_line":"  connection: local"},{"line_number":19,"context_line":"  become: true"},{"line_number":20,"context_line":"  tasks:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fa0719c6_503d1bba","line":17,"range":{"start_line":17,"start_character":9,"end_line":17,"end_character":18},"updated":"2016-03-22 14:03:07.000000000","message":"Shouldn\u0027t this be \u0027localhost\u0027?","commit_id":"406cdb56af21bc19b8c9f8296b1434f0993f4385"},{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"d2ecbc1d9e2e7b50fcfa59f062a9cf4d0d6c488e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Prepare cinder-volumes volume group"},{"line_number":17,"context_line":"  hosts: 127.0.0.1"},{"line_number":18,"context_line":"  connection: local"},{"line_number":19,"context_line":"  become: true"},{"line_number":20,"context_line":"  tasks:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fa0719c6_bb8ebe76","line":17,"range":{"start_line":17,"start_character":9,"end_line":17,"end_character":18},"in_reply_to":"fa0719c6_503d1bba","updated":"2016-03-23 21:13:51.000000000","message":"Done","commit_id":"406cdb56af21bc19b8c9f8296b1434f0993f4385"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"181d2eeb1934679701a7e501ce89ad16d41bc566","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Prepare cinder-volumes volume group"},{"line_number":17,"context_line":"  hosts: 127.0.0.1"},{"line_number":18,"context_line":"  connection: local"},{"line_number":19,"context_line":"  become: true"},{"line_number":20,"context_line":"  tasks:"},{"line_number":21,"context_line":"    - name: Install lvm2 package"},{"line_number":22,"context_line":"      apt:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fa0719c6_5064fbe3","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":14},"updated":"2016-03-22 14:03:07.000000000","message":"If the above is \u0027localhost\u0027 then these shouldn\u0027t be required as they\u0027re set in the inventory.","commit_id":"406cdb56af21bc19b8c9f8296b1434f0993f4385"},{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"d2ecbc1d9e2e7b50fcfa59f062a9cf4d0d6c488e","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Prepare cinder-volumes volume group"},{"line_number":17,"context_line":"  hosts: 127.0.0.1"},{"line_number":18,"context_line":"  connection: local"},{"line_number":19,"context_line":"  become: true"},{"line_number":20,"context_line":"  tasks:"},{"line_number":21,"context_line":"    - name: Install lvm2 package"},{"line_number":22,"context_line":"      apt:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fa0719c6_9b8bfa67","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":14},"in_reply_to":"fa0719c6_5064fbe3","updated":"2016-03-23 21:13:51.000000000","message":"Done","commit_id":"406cdb56af21bc19b8c9f8296b1434f0993f4385"}],"tox.ini":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"cbf21de0bcd6e95cf2faf806ad35629c14b1c0c3","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    # This forces Ansible to use the venv interpreter for localhost, which means we don\u0027t"},{"line_number":119,"context_line":"    # run into issues where things are being installed into the venv but then Ansible"},{"line_number":120,"context_line":"    # complains that it doesn\u0027t exist in /usr/local/lib."},{"line_number":121,"context_line":"    sed -i \u0027s@ENVPYTHON@{envpython}@g\u0027 tests/inventory"},{"line_number":122,"context_line":"    git clone https://git.openstack.org/openstack/openstack-ansible-plugins \\"},{"line_number":123,"context_line":"              {homedir}/.ansible/plugins"},{"line_number":124,"context_line":"    ansible-galaxy install \\"}],"source_content_type":"text/x-properties","patch_set":11,"id":"fa0719c6_485a8450","line":121,"range":{"start_line":121,"start_character":4,"end_line":121,"end_character":54},"updated":"2016-03-22 17:18:03.000000000","message":"While this works in the gate, it appears from Matt\u0027s testing that it doesn\u0027t work locally. If anyone else can give this a go to figure it out it\u0027d be awesome. :)","commit_id":"406cdb56af21bc19b8c9f8296b1434f0993f4385"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"c71aebb8fccd376d0ba281bcef7c0bc0891145fd","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    # This forces Ansible to use the venv interpreter for localhost, which means we don\u0027t"},{"line_number":119,"context_line":"    # run into issues where things are being installed into the venv but then Ansible"},{"line_number":120,"context_line":"    # complains that it doesn\u0027t exist in /usr/local/lib."},{"line_number":121,"context_line":"    sed -i \u0027s@ENVPYTHON@{envpython}@g\u0027 tests/inventory"},{"line_number":122,"context_line":"    git clone https://git.openstack.org/openstack/openstack-ansible-plugins \\"},{"line_number":123,"context_line":"              {homedir}/.ansible/plugins"},{"line_number":124,"context_line":"    ansible-galaxy install \\"}],"source_content_type":"text/x-properties","patch_set":15,"id":"fa0719c6_3cfbd2c2","line":121,"updated":"2016-03-23 18:09:07.000000000","message":"Could this be passed as an extra var to ansible-playbook instead? It would avoid modifying source files during local testing.","commit_id":"a8022eefe9a7709ba4c8ceda7a14c692c2d4ed83"},{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"33b1037ea21af2bd01018f1c5e410d0e90a4fe8a","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    # This forces Ansible to use the venv interpreter for localhost, which means we don\u0027t"},{"line_number":119,"context_line":"    # run into issues where things are being installed into the venv but then Ansible"},{"line_number":120,"context_line":"    # complains that it doesn\u0027t exist in /usr/local/lib."},{"line_number":121,"context_line":"    sed -i \u0027s@ENVPYTHON@{envpython}@g\u0027 tests/inventory"},{"line_number":122,"context_line":"    git clone https://git.openstack.org/openstack/openstack-ansible-plugins \\"},{"line_number":123,"context_line":"              {homedir}/.ansible/plugins"},{"line_number":124,"context_line":"    ansible-galaxy install \\"}],"source_content_type":"text/x-properties","patch_set":15,"id":"fa0719c6_9b501ad6","line":121,"in_reply_to":"fa0719c6_3cfbd2c2","updated":"2016-03-23 21:15:53.000000000","message":"Hi Jimmy, we only set this when host\u003d\u003dlocalhost, so that makes it difficult to pass in from tox as an extra var.","commit_id":"a8022eefe9a7709ba4c8ceda7a14c692c2d4ed83"}]}
