)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"48d5d3d68fe1768dd33307071b7c3628fd9c33cf","unresolved":false,"context_lines":[{"line_number":10,"context_line":"systemd time between SIGTERM and SIGKILL to be adjusted by the deployer."},{"line_number":11,"context_line":"Also lower the default from 5 minutes to 2."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also lower the restart time from 150 seconds to 1 to recover more"},{"line_number":14,"context_line":"quickly."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The `cinder_sigkill_timout` variable will also be provided for upstart"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a1ced50_e5b4cd83","line":13,"range":{"start_line":13,"start_character":48,"end_line":13,"end_character":49},"updated":"2017-03-24 09:06:00.000000000","message":"5","commit_id":"6ec01900922421aaf40aab890f1f3c0025589497"}],"defaults/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2b718eb8961c0e9710a369d1f5d08ce8ba82346b","unresolved":false,"context_lines":[{"line_number":297,"context_line":"cinder_api_paste_ini_overrides: {}"},{"line_number":298,"context_line":"cinder_cinder_conf_overrides: {}"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"# Timeout (in seconds) for cinder to wait between SIGTERM and SIGKILL"},{"line_number":301,"context_line":"# Applies to TimeoutSec in systemd, affecting start and stop times."},{"line_number":302,"context_line":"# \u0027sigkill_timeout\u0027 is a global option should one desired."},{"line_number":303,"context_line":"cinder_sigkill_timeout: \"{{ sigkill_timeout | default(120) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a1ced50_fa871f5e","line":300,"updated":"2017-03-23 10:45:25.000000000","message":"The new variables introduced, and the change in default values should be announced in a release note. The change in default values should be an \u0027upgrade\u0027 release note as that\u0027s where people look for changes in behaviour that may affect them coming from earlier releases.","commit_id":"a2c49d60d360461fe765b808864db4f1652b3221"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a746fc1404acdabe7f906543248bf7c13b3bf2e6","unresolved":false,"context_lines":[{"line_number":300,"context_line":"# Timeout (in seconds) for cinder to wait between SIGTERM and SIGKILL"},{"line_number":301,"context_line":"# Applies to TimeoutSec in systemd, affecting start and stop times."},{"line_number":302,"context_line":"# \u0027sigkill_timeout\u0027 is a global option should one desired."},{"line_number":303,"context_line":"cinder_sigkill_timeout: \"{{ sigkill_timeout | default(120) }}\""},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"# Number of seconds to wait before restarting the service"},{"line_number":306,"context_line":"cinder_restart_wait: 5"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ffe62b97_108da97a","line":303,"updated":"2017-03-26 12:51:40.000000000","message":"go ahead and set 120 directly here.\n\nWe can wire this with sigkill_timeout outside the role","commit_id":"8006fae15de8c56a8efa53c7309aa68ddb99ceac"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"0e64f3f58d0fa85141d4be08bf50f26f293b583d","unresolved":false,"context_lines":[{"line_number":300,"context_line":"# Timeout (in seconds) for cinder to wait between SIGTERM and SIGKILL"},{"line_number":301,"context_line":"# Applies to TimeoutSec in systemd, affecting start and stop times."},{"line_number":302,"context_line":"# \u0027sigkill_timeout\u0027 is a global option should one desired."},{"line_number":303,"context_line":"cinder_sigkill_timeout: \"{{ sigkill_timeout | default(120) }}\""},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"# Number of seconds to wait before restarting the service"},{"line_number":306,"context_line":"cinder_restart_wait: 5"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ffe62b97_27a28eaf","line":303,"in_reply_to":"ffe62b97_108da97a","updated":"2017-03-27 15:09:57.000000000","message":"Done. Still waiting on the cinder fix upstream to merge.","commit_id":"8006fae15de8c56a8efa53c7309aa68ddb99ceac"}],"templates/cinder-systemd-init.j2":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2b718eb8961c0e9710a369d1f5d08ce8ba82346b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# Give a reasonable amount of time for the server to start up/shut down"},{"line_number":20,"context_line":"TimeoutSec\u003d{{ cinder_sigkill_timeout }}"},{"line_number":21,"context_line":"Restart\u003don-failure"},{"line_number":22,"context_line":"RestartSec\u003d1"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"[Install]"},{"line_number":25,"context_line":"WantedBy\u003dmulti-user.target"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1a1ced50_faa0fff5","line":22,"range":{"start_line":22,"start_character":11,"end_line":22,"end_character":12},"updated":"2017-03-23 10:45:25.000000000","message":"I think 1 second is too short, but that\u0027s subjective. I\u0027m concerned that during initial setup that this will cause massive CPU contention because we\u0027re not yet co-ordinating the startups or restarts properly. I would suggest a 5 second default and that this should be a variable too.","commit_id":"a2c49d60d360461fe765b808864db4f1652b3221"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"c3c40b8978cb3acb26a957fb5fe3dd4ec0442af3","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# Give a reasonable amount of time for the server to start up/shut down"},{"line_number":20,"context_line":"TimeoutSec\u003d{{ cinder_sigkill_timeout }}"},{"line_number":21,"context_line":"Restart\u003don-failure"},{"line_number":22,"context_line":"RestartSec\u003d1"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"[Install]"},{"line_number":25,"context_line":"WantedBy\u003dmulti-user.target"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1a1ced50_8fc41860","line":22,"range":{"start_line":22,"start_character":11,"end_line":22,"end_character":12},"in_reply_to":"1a1ced50_faa0fff5","updated":"2017-03-23 18:16:41.000000000","message":"I agree on the variable - finding the right time will probably be a matter of trial and error, though. I\u0027ll bump to 5 for now.","commit_id":"a2c49d60d360461fe765b808864db4f1652b3221"}]}