)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fa8feb39e902f6a62af1d6262c9c308d553874be","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Horizon cannot retrive volume \u0026 snapshot informatiom with filter."},{"line_number":12,"context_line":"It will return bad request(400)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: https://review.openstack.org/615869"},{"line_number":15,"context_line":"Closes-Bug: #1802070"},{"line_number":16,"context_line":"Change-Id: I735931ed041d4fa37e7c182acc19979beba7f4de"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bfdaf3ff_3de2ca30","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":47},"updated":"2019-01-17 05:54:39.000000000","message":"Looks like the dependent patch is merged and this is no longer required.\nAs the author seems inactive on this, removing this in next PS.","commit_id":"782afe29ff5edfd65fc5b761ec0ad47b9c85ccae"}],"tasks/cinder_post_install.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"abe9cc3604ca81f101c9de222393306721161df7","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      dest: \"/etc/cinder/policy.json-{{ cinder_venv_tag }}\""},{"line_number":40,"context_line":"      config_overrides: \"{{ cinder_policy_overrides }}\""},{"line_number":41,"context_line":"      config_type: \"json\""},{"line_number":42,"context_line":"    - src: \"resource_filters.json.j2\""},{"line_number":43,"context_line":"      dest: \"/etc/cinder/resource_filters.json\""},{"line_number":44,"context_line":"      config_overrides: \"{{ cinder_resource_filters_overrides }}\""},{"line_number":45,"context_line":"      config_type: \"json\""},{"line_number":46,"context_line":"  notify:"},{"line_number":47,"context_line":"    - Manage LB"},{"line_number":48,"context_line":"    - Restart cinder services"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_9ba7610b","line":45,"range":{"start_line":42,"start_character":0,"end_line":45,"end_character":25},"updated":"2018-11-20 17:11:34.000000000","message":"I\u0027d probably added conditional as well, like it has been done for masakari https://github.com/openstack/openstack-ansible-os_masakari/blob/master/tasks/masakari_post_install.yml#L25 (probably others won\u0027t share this idea)","commit_id":"782afe29ff5edfd65fc5b761ec0ad47b9c85ccae"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cd5a9bf1d58beaf7d99882a9c4d90ae919fdd058","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      dest: \"/etc/cinder/policy.json-{{ cinder_venv_tag }}\""},{"line_number":40,"context_line":"      config_overrides: \"{{ cinder_policy_overrides }}\""},{"line_number":41,"context_line":"      config_type: \"json\""},{"line_number":42,"context_line":"    - src: \"resource_filters.json.j2\""},{"line_number":43,"context_line":"      dest: \"/etc/cinder/resource_filters.json\""},{"line_number":44,"context_line":"      config_overrides: \"{{ cinder_resource_filters_overrides }}\""},{"line_number":45,"context_line":"      config_type: \"json\""},{"line_number":46,"context_line":"  notify:"},{"line_number":47,"context_line":"    - Manage LB"},{"line_number":48,"context_line":"    - Restart cinder services"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bfdaf3ff_bd731ab1","line":45,"range":{"start_line":42,"start_character":0,"end_line":45,"end_character":25},"in_reply_to":"3f79a3b5_9ba7610b","updated":"2019-01-17 05:49:35.000000000","message":"I think the conditions defined are for optional files.\nI checked out nova_post_install[1] and it also doesn\u0027t contain any conditionals.\nIMO this file should always be created and not require conditions.\n\n[1] https://github.com/openstack/openstack-ansible-os_nova/blob/master/tasks/nova_post_install.yml#L37","commit_id":"782afe29ff5edfd65fc5b761ec0ad47b9c85ccae"}],"templates/cinder.conf.j2":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"abe9cc3604ca81f101c9de222393306721161df7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"api_paste_config \u003d /etc/cinder/api-paste.ini"},{"line_number":15,"context_line":"auth_strategy \u003d {{ cinder_auth_strategy }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"resource_query_filters_file \u003d /etc/cinder/resource_filters.json"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"## Cinder API\u0027s enabled"},{"line_number":20,"context_line":"{% if cinder_services[\u0027cinder-volume\u0027][\u0027group\u0027] in group_names %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3f79a3b5_5b15493d","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":63},"updated":"2018-11-20 17:11:34.000000000","message":"I\u0027m not sure, that it\u0027s required for every deployment. Probably, this should be deployed conditionally","commit_id":"782afe29ff5edfd65fc5b761ec0ad47b9c85ccae"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cd5a9bf1d58beaf7d99882a9c4d90ae919fdd058","unresolved":false,"context_lines":[{"line_number":14,"context_line":"api_paste_config \u003d /etc/cinder/api-paste.ini"},{"line_number":15,"context_line":"auth_strategy \u003d {{ cinder_auth_strategy }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"resource_query_filters_file \u003d /etc/cinder/resource_filters.json"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"## Cinder API\u0027s enabled"},{"line_number":20,"context_line":"{% if cinder_services[\u0027cinder-volume\u0027][\u0027group\u0027] in group_names %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bfdaf3ff_8bccd361","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":63},"in_reply_to":"3f79a3b5_5b15493d","updated":"2019-01-17 05:49:35.000000000","message":"This is a required file for every deployment.\nIt states the valid filters which a user can pass[1].\nFor every command, the valid filters are initialized by this file [2] and are checked against the passed filters[3].\n\n[1] https://github.com/openstack/cinder/blob/master/cinder/api/common.py#L39-L42\n[2] https://github.com/openstack/cinder/blob/master/cinder/api/common.py#L356-L357\n[3] https://github.com/openstack/cinder/blob/master/cinder/api/common.py#L415-L423","commit_id":"782afe29ff5edfd65fc5b761ec0ad47b9c85ccae"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d1249dca006b2f68d7b8811d9bd86f64cd439ddf","unresolved":false,"context_lines":[{"line_number":14,"context_line":"api_paste_config \u003d /etc/cinder/api-paste.ini"},{"line_number":15,"context_line":"auth_strategy \u003d {{ cinder_auth_strategy }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"resource_query_filters_file \u003d /etc/cinder/resource_filters.json"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"## Cinder API\u0027s enabled"},{"line_number":20,"context_line":"{% if cinder_services[\u0027cinder-volume\u0027][\u0027group\u0027] in group_names %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"bfdaf3ff_11e7ad42","line":17,"updated":"2019-01-17 09:56:48.000000000","message":"This is the default, so there\u0027s no need to add the .conf entry: http://git.openstack.org/cgit/openstack/cinder/tree/cinder/api/common.py#n39","commit_id":"eb49b8e5cc346cc2c938d6f49d06edac998e367e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ed2dccde37a66d766980085174d5e9680afe17c4","unresolved":false,"context_lines":[{"line_number":14,"context_line":"api_paste_config \u003d /etc/cinder/api-paste.ini"},{"line_number":15,"context_line":"auth_strategy \u003d {{ cinder_auth_strategy }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"resource_query_filters_file \u003d /etc/cinder/resource_filters.json"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"## Cinder API\u0027s enabled"},{"line_number":20,"context_line":"{% if cinder_services[\u0027cinder-volume\u0027][\u0027group\u0027] in group_names %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"bfdaf3ff_4ffd89af","line":17,"in_reply_to":"bfdaf3ff_11e7ad42","updated":"2019-01-17 16:49:54.000000000","message":"Missed this detail. Thanks for pointing that out.","commit_id":"eb49b8e5cc346cc2c938d6f49d06edac998e367e"}]}