)]}'
{"tasks/main.yml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"e561a11ddf3fc9451d9a1ac5ed69221e6ab9e8ea","unresolved":false,"context_lines":[{"line_number":172,"context_line":"  tags:"},{"line_number":173,"context_line":"    - ceph"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"# NOTE(jrosser) Tools required by cinder-volumes may have dependancies on librados and librbd"},{"line_number":176,"context_line":"# so are installed after the ceph_client role is run to ensure that the ceph repos setup"},{"line_number":177,"context_line":"# is in place."},{"line_number":178,"context_line":"- name: Install cinder volumes distro tool packages"},{"line_number":179,"context_line":"  package:"},{"line_number":180,"context_line":"    name: \"{{ cinder_volume_distro_packages_tools }}\""},{"line_number":181,"context_line":"    state: \"{{ cinder_package_state }}\""},{"line_number":182,"context_line":"    update_cache: \"{{ (ansible_pkg_mgr in [\u0027apt\u0027, \u0027zypper\u0027]) | ternary(\u0027yes\u0027, omit) }}\""},{"line_number":183,"context_line":"    cache_valid_time: \"{{ (ansible_pkg_mgr \u003d\u003d \u0027apt\u0027) | ternary(cache_timeout, omit) }}\""},{"line_number":184,"context_line":"  register: install_packages"},{"line_number":185,"context_line":"  until: install_packages  is success"},{"line_number":186,"context_line":"  retries: 5"},{"line_number":187,"context_line":"  delay: 2"},{"line_number":188,"context_line":"  when:"},{"line_number":189,"context_line":"   - \"cinder_services[\u0027cinder-volume\u0027][\u0027group\u0027] in group_names\""},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"- name: Flush handlers"},{"line_number":192,"context_line":"  meta: flush_handlers"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_c7c03c7f","side":"PARENT","line":189,"range":{"start_line":175,"start_character":0,"end_line":189,"end_character":63},"updated":"2019-09-04 07:45:02.000000000","message":"doesnt removing these tasks and the _tools var now install the packages which have dependancies on ceph libraries before the ceph_client role is run? I think that will break if there is a mismatch between the enabled ceph.com packages and the distro packages.","commit_id":"c4efbadb0ff1007bf49d22341d6a789b10eec32b"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"6b940f009c87ffbb3abbe1088ee8054874fab919","unresolved":false,"context_lines":[{"line_number":172,"context_line":"  tags:"},{"line_number":173,"context_line":"    - ceph"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"# NOTE(jrosser) Tools required by cinder-volumes may have dependancies on librados and librbd"},{"line_number":176,"context_line":"# so are installed after the ceph_client role is run to ensure that the ceph repos setup"},{"line_number":177,"context_line":"# is in place."},{"line_number":178,"context_line":"- name: Install cinder volumes distro tool packages"},{"line_number":179,"context_line":"  package:"},{"line_number":180,"context_line":"    name: \"{{ cinder_volume_distro_packages_tools }}\""},{"line_number":181,"context_line":"    state: \"{{ cinder_package_state }}\""},{"line_number":182,"context_line":"    update_cache: \"{{ (ansible_pkg_mgr in [\u0027apt\u0027, \u0027zypper\u0027]) | ternary(\u0027yes\u0027, omit) }}\""},{"line_number":183,"context_line":"    cache_valid_time: \"{{ (ansible_pkg_mgr \u003d\u003d \u0027apt\u0027) | ternary(cache_timeout, omit) }}\""},{"line_number":184,"context_line":"  register: install_packages"},{"line_number":185,"context_line":"  until: install_packages  is success"},{"line_number":186,"context_line":"  retries: 5"},{"line_number":187,"context_line":"  delay: 2"},{"line_number":188,"context_line":"  when:"},{"line_number":189,"context_line":"   - \"cinder_services[\u0027cinder-volume\u0027][\u0027group\u0027] in group_names\""},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"- name: Flush handlers"},{"line_number":192,"context_line":"  meta: flush_handlers"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_12b534ed","side":"PARENT","line":189,"range":{"start_line":175,"start_character":0,"end_line":189,"end_character":63},"in_reply_to":"7faddb67_c7c03c7f","updated":"2019-09-04 08:56:15.000000000","message":"Yeah, I didn\u0027t realize at once that qemu-utils require qemu-block-extra which depend on librbd... So that I decided that nothing requires ceph packages and it\u0027s safe to remove now","commit_id":"c4efbadb0ff1007bf49d22341d6a789b10eec32b"}]}