)]}'
{"id":"openstack%2Fopenstack-ansible-os_designate~294034","triplet_id":"openstack%2Fopenstack-ansible-os_designate~master~I9f47a143b3e79b35754584ae35fcbd9436479717","project":"openstack/openstack-ansible-os_designate","branch":"master","topic":"pip_install_options","hashtags":[],"change_id":"I9f47a143b3e79b35754584ae35fcbd9436479717","subject":"Fix how constraints are added to pip_install_options","status":"MERGED","created":"2016-03-17 13:54:21.000000000","updated":"2016-03-17 20:58:02.000000000","submitted":"2016-03-17 20:58:02.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"22c7e8a136b5f8a90effb7fe4cff2e8a680708af","_number":294034,"virtual_id_number":294034,"owner":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":2,"date":"2016-03-17 20:58:02.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"all":[{"value":2,"date":"2016-03-17 14:19:15.000000000","_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-03-17 20:43:02.000000000","_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-03-17 20:43:02.000000000","_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-03-17 14:19:15.000000000","updated_by":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"reviewer":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"state":"REVIEWER"},{"updated":"2016-03-17 20:43:02.000000000","updated_by":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"reviewer":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"state":"REVIEWER"},{"updated":"2016-03-17 20:58:02.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"0090f66f75364b51e7d6f7c0c55ef2372d970563","author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"date":"2016-03-17 13:54:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c94ca87fdcb5d22bd952eeacb93746e9741cb28e","author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"date":"2016-03-17 13:56:34.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"a1b7a89fbf1600fef346b89b102df5ffd8a50637","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-17 14:17:33.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-os_designate-docs http://docs-draft.openstack.org/34/294034/2/check/gate-openstack-ansible-os_designate-docs/8f61a48//doc/build/html/ : SUCCESS in 23s\n- gate-openstack-ansible-os_designate-linters http://logs.openstack.org/34/294034/2/check/gate-openstack-ansible-os_designate-linters/87124a9/ : SUCCESS in 43s\n- gate-openstack-ansible-os_designate-ansible-func-ubuntu-trusty http://logs.openstack.org/34/294034/2/check/gate-openstack-ansible-os_designate-ansible-func-ubuntu-trusty/94b6db3/ : SUCCESS in 17m 52s\n- gate-openstack-ansible-os_designate-dsvm-ansible-functional-centos7-nv http://logs.openstack.org/34/294034/2/check/gate-openstack-ansible-os_designate-dsvm-ansible-functional-centos7-nv/b11683c/ : FAILURE in 1m 15s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"e677e51225eee394114465827daf0c0c8bada0da","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2016-03-17 14:19:15.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"865b06a67c4a66bd203f41d6db87bc70dcbeda92","author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"date":"2016-03-17 20:43:02.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"61a09ab7944ba7756611ec0c824e1c5d5ec136a6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-17 20:43:07.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"db179c8b22653fa7701a408f5be09daddb72f1ee","date":"2016-03-17 20:58:02.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"77a50b88b92edc07a9efa632d89f5bfc5b20c7ff","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-17 20:58:02.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-openstack-ansible-os_designate-docs http://docs-draft.openstack.org/34/294034/2/gate/gate-openstack-ansible-os_designate-docs/b57d629//doc/build/html/ : SUCCESS in 13s\n- gate-openstack-ansible-os_designate-linters http://logs.openstack.org/34/294034/2/gate/gate-openstack-ansible-os_designate-linters/a290df7/ : SUCCESS in 44s\n- gate-openstack-ansible-os_designate-ansible-func-ubuntu-trusty http://logs.openstack.org/34/294034/2/gate/gate-openstack-ansible-os_designate-ansible-func-ubuntu-trusty/492d4b4/ : SUCCESS in 14m 18s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"dd560d7f83d9e7c11ccab34fe5c05032e882a665","revisions":{"e7fbaecedab2d9524c561878af6bc0cfe7a08fc9":{"kind":"REWORK","_number":1,"created":"2016-03-17 13:54:21.000000000","uploader":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"ref":"refs/changes/34/294034/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-os_designate","ref":"refs/changes/34/294034/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_designate refs/changes/34/294034/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_designate refs/changes/34/294034/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_designate refs/changes/34/294034/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-os_designate refs/changes/34/294034/1"}}},"commit":{"parents":[{"commit":"f926a74c61929fb10a93971eadfa26058d93299b","subject":"Role cleanup","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_designate/commit/f926a74c61929fb10a93971eadfa26058d93299b"}]}],"author":{"name":"Matt Thompson","email":"mattt@defunct.ca","date":"2016-03-17 13:54:07.000000000","tz":0},"committer":{"name":"Matt Thompson","email":"mattt@defunct.ca","date":"2016-03-17 13:54:07.000000000","tz":0},"subject":"Fix how constraints are added to pip_install_options","message":"Fix how constraints are added to pip_install_options\n\nThis commit changes the pip_install_options fact name in\nkeystone_install.yml to pip_install_options_fact.  This allows us to\nmaintain the existing pip_install_options variable without overwriting\nit with options when in developer mode, which ultimately means we can\nhave multiple services running in a container use a combination of\n*_developer_mode: true and *_developer_mode: false.  At the moment,\nif a service writes pip_install_options fact with the constraints\noptions, those options will persist to other services running in the\ncontainer even if *_developer_mode: false.\n\nChange-Id: I9f47a143b3e79b35754584ae35fcbd9436479717\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_designate/commit/e7fbaecedab2d9524c561878af6bc0cfe7a08fc9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_designate/commit/e7fbaecedab2d9524c561878af6bc0cfe7a08fc9"}]},"branch":"refs/heads/master"},"dd560d7f83d9e7c11ccab34fe5c05032e882a665":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-03-17 13:56:34.000000000","uploader":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"ref":"refs/changes/34/294034/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-os_designate","ref":"refs/changes/34/294034/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_designate refs/changes/34/294034/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_designate refs/changes/34/294034/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_designate refs/changes/34/294034/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-os_designate refs/changes/34/294034/2"}}},"commit":{"parents":[{"commit":"f926a74c61929fb10a93971eadfa26058d93299b","subject":"Role cleanup","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_designate/commit/f926a74c61929fb10a93971eadfa26058d93299b"}]}],"author":{"name":"Matt Thompson","email":"mattt@defunct.ca","date":"2016-03-17 13:54:07.000000000","tz":0},"committer":{"name":"Matt Thompson","email":"mattt@defunct.ca","date":"2016-03-17 13:56:20.000000000","tz":0},"subject":"Fix how constraints are added to pip_install_options","message":"Fix how constraints are added to pip_install_options\n\nThis commit changes the pip_install_options fact name in\ndesignate_install.yml to pip_install_options_fact.  This allows us to\nmaintain the existing pip_install_options variable without overwriting\nit with options when in developer mode, which ultimately means we can\nhave multiple services running in a container use a combination of\n*_developer_mode: true and *_developer_mode: false.  At the moment,\nif a service writes pip_install_options fact with the constraints\noptions, those options will persist to other services running in the\ncontainer even if *_developer_mode: false.\n\nChange-Id: I9f47a143b3e79b35754584ae35fcbd9436479717\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_designate/commit/dd560d7f83d9e7c11ccab34fe5c05032e882a665"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_designate/commit/dd560d7f83d9e7c11ccab34fe5c05032e882a665"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}