)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"94760407910fa5bdd7e5021017046cd2c6c7a9df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"69148951_d36d3d2a","updated":"2026-10-11 20:11:28.000000000","message":"LGTM overall, it\u0027s pretty similar to: https://opendev.org/openstack/openstack-ansible-os_cinder/commit/f16036e1f1d8898a528e6ad17a4f7c079cb26beb\n\n\nbut to get it working, we\u0027d need to merge https://review.opendev.org/c/openstack/freezer-api/+/1009443 first and bump freezer-api version in OSA here:\nhttps://opendev.org/openstack/openstack-ansible/src/branch/master/inventory/group_vars/freezer_all/source_git.yml#L19\n\nSo I\u0027d suggest to do the following:\n\n1. create a patch in openstack-ansible repo that bumps freezer-api version. It should have: `Depends-On: https://review.opendev.org/c/openstack/freezer-api/+/1009443`\n2. In this patch, add `Depends-On` pointing to the patch from 1.\n\n\n\nCI is failing, but I doubt it\u0027s related to this patch.\nTempest is failing with:\n\n```\nCaptured traceback:\n~~~~~~~~~~~~~~~~~~~\n    Traceback (most recent call last):\n\n      File \"/openstack/venvs/tempest-33.1.0.dev88/lib/python3.12/site-packages/freezer_tempest_plugin/tests/freezer/scenario/test_backups.py\", line 559, in setUp\n    self._start_scheduler(\n\n      File \"/openstack/venvs/tempest-33.1.0.dev88/lib/python3.12/site-packages/freezer_tempest_plugin/tests/freezer/scenario/test_backups.py\", line 223, in _start_scheduler\n    proc \u003d subprocess.Popen(cmd, stdout\u003dlog_file, stderr\u003dlog_file)\n           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n\n      File \"/usr/lib/python3.12/subprocess.py\", line 1026, in __init__\n    self._execute_child(args, executable, preexec_fn, close_fds,\n\n      File \"/usr/lib/python3.12/subprocess.py\", line 1955, in _execute_child\n    raise child_exception_type(errno_num, err_msg, err_filename)\n\n    FileNotFoundError: [Errno 2] No such file or directory: \u0027freezer-scheduler\u0027\n```\n\nI guess it\u0027s because freezer-scheduler is not installed in tempest venv.","commit_id":"ae743502aad81cd2d02f874bc33a1d0de9823f8d"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"a339c59614c32076f978fb47fe09b0454b90cadc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5ac80fc4_ad2c2eef","in_reply_to":"69148951_d36d3d2a","updated":"2026-10-12 07:24:10.000000000","message":"1. We can set depends-on for https://review.opendev.org/c/openstack/freezer-api/+/1009443 and it should work.\n2. We have this special case here for tempest: https://opendev.org/openstack/openstack-ansible-os_tempest/src/branch/master/tasks/tempest_run.yml#L25-L27","commit_id":"ae743502aad81cd2d02f874bc33a1d0de9823f8d"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"6600fde17159a464183947f576d514ac23aa00fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b83c8ec4_ff2486d9","updated":"2026-10-20 15:33:19.000000000","message":"lgtm but I think this can merge only after 2026.2 will branch, as the code is not yet in freezer-api, so it won\u0027t be in until 2027.1","commit_id":"cfbbacc6d8fcccf3ed8e0d9a2b065080c145e4b6"},{"author":{"_account_id":39044,"name":"Alicja Filipek","display_name":"alaf01","email":"alicja.filipek@cleura.com","username":"alaf01"},"change_message_id":"62be7f8c4d59fe27b9270f19e06b9a44a79eb45f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"dabdbafc_4269e109","updated":"2026-10-19 08:16:09.000000000","message":"recheck","commit_id":"cfbbacc6d8fcccf3ed8e0d9a2b065080c145e4b6"},{"author":{"_account_id":39044,"name":"Alicja Filipek","display_name":"alaf01","email":"alicja.filipek@cleura.com","username":"alaf01"},"change_message_id":"77725e274b17db40dd75692782763cb67d49b45b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"11be2dc5_5f410b28","in_reply_to":"b83c8ec4_ff2486d9","updated":"2026-10-27 12:24:24.000000000","message":"yes, definetly, we need to wait for the command itself.","commit_id":"cfbbacc6d8fcccf3ed8e0d9a2b065080c145e4b6"}],"tasks/main.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"a339c59614c32076f978fb47fe09b0454b90cadc","unresolved":true,"context_lines":[{"line_number":191,"context_line":"          UMASK_DIR: \"0750\""},{"line_number":192,"context_line":"        program_sandboxing:"},{"line_number":193,"context_line":"          RuntimeDirectory: \"freezer-purge-deleted\""},{"line_number":194,"context_line":"        enabled: \"{{ freezer_purge_deleted }}\""},{"line_number":195,"context_line":"        timer:"},{"line_number":196,"context_line":"          state: \"{{ freezer_purge_deleted | ternary(\u0027started\u0027, \u0027stopped\u0027) }}\""},{"line_number":197,"context_line":"          enabled: \"{{ freezer_purge_deleted }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5667fc8e_5b7c8d46","line":194,"updated":"2026-10-12 07:24:10.000000000","message":"let\u0027s add\n`state: \"{{ freezer_purge_deleted | ternary(\u0027present\u0027, \u0027absent\u0027) }}\"` ?\n\nI am actually not sure if that would propogate to the timer itself... Smth to check.","commit_id":"ae743502aad81cd2d02f874bc33a1d0de9823f8d"}]}
