)]}'
{"other-requirements.txt":[{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"cab318bf94c6e9991610f36d9979b45c50a965f0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# will fall back to installing its default packages which"},{"line_number":11,"context_line":"# will potentially be detrimental to the tests executed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# OpenStack-CI\u0027s Jenkins needs curl"},{"line_number":14,"context_line":"# TODO(odyssey4me) remove this once https://review.openstack.org/288634 has merged"},{"line_number":15,"context_line":"# and the disk images are rebuilt and redeployed."},{"line_number":16,"context_line":"curl"},{"line_number":17,"context_line":"wget"},{"line_number":18,"context_line":""}],"source_content_type":"text/plain","patch_set":10,"id":"dada55a8_36518ad9","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":49},"updated":"2016-07-25 15:11:12.000000000","message":"The mentioned patch set has merged, perhaps remove this comment?","commit_id":"6c5d62755587c7e1a7aed36d1f3345007abf0f9a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ef75617aa406e2f5a9925ebfc5c35ea9377fdf2d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# will fall back to installing its default packages which"},{"line_number":11,"context_line":"# will potentially be detrimental to the tests executed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# OpenStack-CI\u0027s Jenkins needs curl"},{"line_number":14,"context_line":"# TODO(odyssey4me) remove this once https://review.openstack.org/288634 has merged"},{"line_number":15,"context_line":"# and the disk images are rebuilt and redeployed."},{"line_number":16,"context_line":"curl"},{"line_number":17,"context_line":"wget"},{"line_number":18,"context_line":""}],"source_content_type":"text/plain","patch_set":10,"id":"dada55a8_e7fe1a6a","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":49},"in_reply_to":"dada55a8_36518ad9","updated":"2016-07-25 16:00:19.000000000","message":"In another patch set, sure.","commit_id":"6c5d62755587c7e1a7aed36d1f3345007abf0f9a"}],"releasenotes/notes/glance-packages-rename-abd348b0725e4b7b.yaml":[{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"cab318bf94c6e9991610f36d9979b45c50a965f0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The ``glance_apt_packages`` variable has been renamed to"},{"line_number":4,"context_line":"    ``glance_packages`` so that it applies to multiple operating systems."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"dada55a8_36eeaab4","line":4,"range":{"start_line":1,"start_character":0,"end_line":4,"end_character":73},"updated":"2016-07-25 15:11:12.000000000","message":"We originally separated the package name variables because there are cases where packages will not have the same name in rpm/apt distros.  Also, packages is not specific; it could refer to pip packges.\n\nI prefer the separation of the names; this also allows the somewhat unlikely ability to define separate package name lists via user variables for a mixed deployment.","commit_id":"6c5d62755587c7e1a7aed36d1f3345007abf0f9a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d62e7c8d4f1167bbc221fa5818afc62aefd27eb6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The ``glance_apt_packages`` variable has been renamed to"},{"line_number":4,"context_line":"    ``glance_packages`` so that it applies to multiple operating systems."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"dada55a8_07508e5d","line":4,"range":{"start_line":1,"start_character":0,"end_line":4,"end_character":73},"in_reply_to":"dada55a8_36eeaab4","updated":"2016-07-25 16:02:51.000000000","message":"Actually the normalisation of the name is to ensure that the var is not empty and thus causing task failures and having to add defaults into the install tasks all over the place.\n\nPerhaps the name isn\u0027t best, but that\u0027s not for this patch because it would need to be a pattern applied across all repositories where this agreed pattern has already been implemented.","commit_id":"6c5d62755587c7e1a7aed36d1f3345007abf0f9a"}],"tasks/glance_install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"0c50a2ec67b84a274efebfe228acea3a7276e2bd","unresolved":false,"context_lines":[{"line_number":20,"context_line":"- include: glance_install_yum.yml"},{"line_number":21,"context_line":"  when:"},{"line_number":22,"context_line":"    - ansible_pkg_mgr \u003d\u003d \u0027yum\u0027"},{"line_number":23,"context_line":"  tags:"},{"line_number":24,"context_line":"    - glance-install"},{"line_number":25,"context_line":"    - glance-yum-packages"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: Create developer mode constraint file"},{"line_number":28,"context_line":"  copy:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"fad55976_763f6ed6","line":25,"range":{"start_line":23,"start_character":0,"end_line":25,"end_character":25},"updated":"2016-07-16 18:45:47.000000000","message":"Remove the tags.","commit_id":"8490cbcc8216793d073344fdf467c29124336a1c"}],"tests/test-prepare-host.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"0c50a2ec67b84a274efebfe228acea3a7276e2bd","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        manage_dir: no"},{"line_number":29,"context_line":"    - set_fact:"},{"line_number":30,"context_line":"        lxc_container_ssh_key: \"{{ hostvars[\u0027localhost\u0027][\u0027lxc_container_ssh_key\u0027] }}\""},{"line_number":31,"context_line":"    - name: Check if this is an OpenStack-CI nodepool instance"},{"line_number":32,"context_line":"      stat:"},{"line_number":33,"context_line":"        path: /etc/nodepool/provider"},{"line_number":34,"context_line":"      register: nodepool"},{"line_number":35,"context_line":"    - name: Set the files to copy into the container cache for OpenStack-CI instances (rhel)"},{"line_number":36,"context_line":"      set_fact:"},{"line_number":37,"context_line":"        lxc_container_cache_files:"},{"line_number":38,"context_line":"          - { src: \u0027/etc/pip.conf\u0027, dest: \u0027/etc/pip.conf\u0027 }"},{"line_number":39,"context_line":"      when:"},{"line_number":40,"context_line":"        - nodepool.stat.exists | bool"},{"line_number":41,"context_line":"        - ansible_pkg_mgr \u003d\u003d \u0027yum\u0027"},{"line_number":42,"context_line":"    - name: Set the files to copy into the container cache for OpenStack-CI instances (deb)"},{"line_number":43,"context_line":"      set_fact:"},{"line_number":44,"context_line":"        lxc_container_cache_files:"},{"line_number":45,"context_line":"          - { src: \u0027/etc/pip.conf\u0027, dest: \u0027/etc/pip.conf\u0027 }"},{"line_number":46,"context_line":"          - { src: \u0027/etc/apt/apt.conf.d/99unauthenticated\u0027, dest: \u0027/etc/apt/apt.conf.d/99unauthenticated\u0027 }"},{"line_number":47,"context_line":"      when:"},{"line_number":48,"context_line":"        - nodepool.stat.exists | bool"},{"line_number":49,"context_line":"        - ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"},{"line_number":50,"context_line":"    - name: Determine the existing Ubuntu repo configuration"},{"line_number":51,"context_line":"      shell: \u0027awk \"/^deb .*ubuntu\\/? {{ ansible_distribution_release }} main/ {print \\$2; exit}\" /etc/apt/sources.list\u0027"},{"line_number":52,"context_line":"      register: ubuntu_repo"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"fad55976_d678dac6","line":49,"range":{"start_line":31,"start_character":0,"end_line":49,"end_character":34},"updated":"2016-07-16 18:45:47.000000000","message":"This needs to be replaced by:\n\n    - name: Check if this is an OpenStack-CI nodepool instance\n      stat:\n        path: /etc/nodepool/provider\n      register: nodepool\n    - name: Set the files to copy into the container cache for OpenStack-CI instances\n      set_fact:\n        lxc_container_cache_files:\n          - { src: \u0027/etc/pip.conf\u0027, dest: \u0027/etc/pip.conf\u0027 }\n      when: nodepool.stat.exists | bool","commit_id":"8490cbcc8216793d073344fdf467c29124336a1c"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"0c50a2ec67b84a274efebfe228acea3a7276e2bd","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      when:"},{"line_number":48,"context_line":"        - nodepool.stat.exists | bool"},{"line_number":49,"context_line":"        - ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"},{"line_number":50,"context_line":"    - name: Determine the existing Ubuntu repo configuration"},{"line_number":51,"context_line":"      shell: \u0027awk \"/^deb .*ubuntu\\/? {{ ansible_distribution_release }} main/ {print \\$2; exit}\" /etc/apt/sources.list\u0027"},{"line_number":52,"context_line":"      register: ubuntu_repo"},{"line_number":53,"context_line":"      changed_when: false"},{"line_number":54,"context_line":"      when: ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"},{"line_number":55,"context_line":"    - name: Set apt repo facts based on discovered information"},{"line_number":56,"context_line":"      set_fact:"},{"line_number":57,"context_line":"        lxc_container_template_main_apt_repo: \"{{ ubuntu_repo.stdout }}\""},{"line_number":58,"context_line":"        lxc_container_template_security_apt_rep: \"{{ ubuntu_repo.stdout }}\""},{"line_number":59,"context_line":"      when: ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"},{"line_number":60,"context_line":"    - name: install the epel repo rpm from a remote repo"},{"line_number":61,"context_line":"      yum:"},{"line_number":62,"context_line":"        name: \"https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"fad55976_966e62ff","line":59,"range":{"start_line":50,"start_character":0,"end_line":59,"end_character":36},"updated":"2016-07-16 18:45:47.000000000","message":"This is no longer necessary.","commit_id":"8490cbcc8216793d073344fdf467c29124336a1c"}],"vars/redhat-7.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"0c50a2ec67b84a274efebfe228acea3a7276e2bd","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# limitations under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"glance_packages:"},{"line_number":16,"context_line":"  - cronie"},{"line_number":17,"context_line":"  - cronie-anacron"},{"line_number":18,"context_line":"  - rpcbind"},{"line_number":19,"context_line":"  - rsync"},{"line_number":20,"context_line":"  - git"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"fad55976_564b4a87","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":18},"updated":"2016-07-16 18:45:47.000000000","message":"Odd packages in the list. Why do these need inclusion?","commit_id":"8490cbcc8216793d073344fdf467c29124336a1c"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"81074ad40c3b373c04023571d72698d8ec13f439","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"glance_packages:"},{"line_number":16,"context_line":"  - cronie"},{"line_number":17,"context_line":"  - cronie-anacron"},{"line_number":18,"context_line":"  - rpcbind"},{"line_number":19,"context_line":"  - rsync"},{"line_number":20,"context_line":"  - git"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"dada55a8_198949cb","line":17,"in_reply_to":"fad55976_564b4a87","updated":"2016-07-23 00:48:23.000000000","message":"Glance needs cron daemons installed and running. CentOS 7 should have these normally, but I assume the gate image doesn\u0027t have them.","commit_id":"8490cbcc8216793d073344fdf467c29124336a1c"}],"vars/ubuntu-14.04.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"0c50a2ec67b84a274efebfe228acea3a7276e2bd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"cache_timeout: 600"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Common apt packages"},{"line_number":19,"context_line":"glance_packages:"},{"line_number":20,"context_line":"  - rpcbind"},{"line_number":21,"context_line":"  - rsync"},{"line_number":22,"context_line":"  - git"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"fad55976_9645c271","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":15},"updated":"2016-07-16 18:45:47.000000000","message":"The rename of this var needs to be mentioned as an upgrade note in the release notes.","commit_id":"8490cbcc8216793d073344fdf467c29124336a1c"}]}