)]}'
{"tasks/glance_db_setup.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"82effbd1d6ea252825e37cdf589c7f60db4d67fd","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Check Glance DB version"},{"line_number":17,"context_line":"  command: \"{{ glance_bin }}/glance-manage db version\""},{"line_number":18,"context_line":"  register: db_version"},{"line_number":19,"context_line":"  changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"5f201791_94a40fbb","line":16,"updated":"2017-06-22 20:53:06.000000000","message":"I\u0027m fairly certain that this should run as the glance user, ie:\n\n  become: yes\n  become_user: \"{{ glance_system_user_name }}\"","commit_id":"caa44d482198caf21560114c0b491d091587465d"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"db378097c282855a4e5914925be887de3f6ffdda","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Check Glance DB version"},{"line_number":17,"context_line":"  command: \"{{ glance_bin }}/glance-manage db version\""},{"line_number":18,"context_line":"  register: db_version"},{"line_number":19,"context_line":"  changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"5f201791_d2ede08b","line":16,"in_reply_to":"5f201791_94a40fbb","updated":"2017-06-23 14:38:18.000000000","message":"It should, yes, I was getting permissions errors on logs in the gate when those lines are kept; something may be wrong elsewhere that\u0027s causing it.","commit_id":"caa44d482198caf21560114c0b491d091587465d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"82effbd1d6ea252825e37cdf589c7f60db4d67fd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- name: Check Glance DB version"},{"line_number":17,"context_line":"  command: \"{{ glance_bin }}/glance-manage db version\""},{"line_number":18,"context_line":"  register: db_version"},{"line_number":19,"context_line":"  changed_when: false"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# We only set to minor here if the version_compare filter passes, and we make"},{"line_number":22,"context_line":"# sure that can\u0027t be accessed unless there\u0027s actually a \u0027.\u0027 in the version."}],"source_content_type":"text/x-yaml","patch_set":22,"id":"5f201791_14cc7f5f","line":19,"updated":"2017-06-22 20:53:06.000000000","message":"This can also run_once, so you may as well do run_once on the include and remove them from all the tasks.","commit_id":"caa44d482198caf21560114c0b491d091587465d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"82effbd1d6ea252825e37cdf589c7f60db4d67fd","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# Passing in \u0027major\u0027 or \u0027testing\u0027 to version_compare causes a Jinja error."},{"line_number":24,"context_line":"- name: Determine whether a major or minor release was installed"},{"line_number":25,"context_line":"  set_fact:"},{"line_number":26,"context_line":"    upgrade_type: |"},{"line_number":27,"context_line":"        {%- set existing \u003d glance_venv_tag %}"},{"line_number":28,"context_line":"        {%- set upgrade_type \u003d \u0027major\u0027 %}"},{"line_number":29,"context_line":"        {%- if \u0027.\u0027 in existing %}"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"5f201791_d4728749","line":26,"updated":"2017-06-22 20:53:06.000000000","message":"Make this |- to strip the newline, then you won\u0027t need ot use .strip() below.","commit_id":"caa44d482198caf21560114c0b491d091587465d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"82effbd1d6ea252825e37cdf589c7f60db4d67fd","unresolved":false,"context_lines":[{"line_number":24,"context_line":"- name: Determine whether a major or minor release was installed"},{"line_number":25,"context_line":"  set_fact:"},{"line_number":26,"context_line":"    upgrade_type: |"},{"line_number":27,"context_line":"        {%- set existing \u003d glance_venv_tag %}"},{"line_number":28,"context_line":"        {%- set upgrade_type \u003d \u0027major\u0027 %}"},{"line_number":29,"context_line":"        {%- if \u0027.\u0027 in existing %}"},{"line_number":30,"context_line":"        {%-  if existing | version_compare(glance_venv_tag, \u0027!\u003d\u0027, strict\u003dTrue) %}"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"5f201791_94bbefc2","line":27,"updated":"2017-06-22 20:53:06.000000000","message":"No need for {%- you can just do {%","commit_id":"caa44d482198caf21560114c0b491d091587465d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"82effbd1d6ea252825e37cdf589c7f60db4d67fd","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        {%-  if existing | version_compare(glance_venv_tag, \u0027!\u003d\u0027, strict\u003dTrue) %}"},{"line_number":31,"context_line":"        {%-    set upgrade_type \u003d \u0027minor\u0027 %}"},{"line_number":32,"context_line":"        {%-  endif %}"},{"line_number":33,"context_line":"        {%- endif %}"},{"line_number":34,"context_line":"        {{ upgrade_type }}"},{"line_number":35,"context_line":"  run_once: true"},{"line_number":36,"context_line":"  delegate_to: localhost"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"5f201791_5411d7ab","line":33,"updated":"2017-06-22 20:53:06.000000000","message":"I\u0027m not sure I understand the logic here, it seems like it will set it as a minor upgrade even if it is the same version. Also, if it\u0027s not the same version, but is a minor upgrade, it will think it\u0027s a major upgrade.","commit_id":"caa44d482198caf21560114c0b491d091587465d"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"db378097c282855a4e5914925be887de3f6ffdda","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        {%-  if existing | version_compare(glance_venv_tag, \u0027!\u003d\u0027, strict\u003dTrue) %}"},{"line_number":31,"context_line":"        {%-    set upgrade_type \u003d \u0027minor\u0027 %}"},{"line_number":32,"context_line":"        {%-  endif %}"},{"line_number":33,"context_line":"        {%- endif %}"},{"line_number":34,"context_line":"        {{ upgrade_type }}"},{"line_number":35,"context_line":"  run_once: true"},{"line_number":36,"context_line":"  delegate_to: localhost"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"5f201791_f2d1fcce","line":33,"in_reply_to":"5f201791_5411d7ab","updated":"2017-06-23 14:38:18.000000000","message":"The check for a \u0027.\u0027 is there because in master and the gate, the version number is invalid for sending to version_compare - it\u0027ll be \u0027master\u0027 or \u0027testing\u0027. Thus, we don\u0027t do a version_compare that\u0027s unnecessary and will abort the run. It will fail there even with strict\u003dFalse.\n\nYou\u0027re right that this could flag a major version as minor, though. I\u0027ll have another look...","commit_id":"caa44d482198caf21560114c0b491d091587465d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"82effbd1d6ea252825e37cdf589c7f60db4d67fd","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  run_once: true"},{"line_number":36,"context_line":"  delegate_to: localhost"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- name: Perform a Glance DB sync"},{"line_number":39,"context_line":"  command: \"{{ glance_bin }}/glance-manage db sync\""},{"line_number":40,"context_line":"  changed_when: false"},{"line_number":41,"context_line":"  when: upgrade_type.strip() \u003d\u003d \u0027major\u0027 or db_version.stdout.startswith(\u0027Database is either not under migration control\u0027)"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"5f201791_54ae7798","line":38,"updated":"2017-06-22 20:53:06.000000000","message":"Same as above.","commit_id":"caa44d482198caf21560114c0b491d091587465d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"82effbd1d6ea252825e37cdf589c7f60db4d67fd","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  when: upgrade_type.strip() \u003d\u003d \u0027major\u0027 or db_version.stdout.startswith(\u0027Database is either not under migration control\u0027)"},{"line_number":42,"context_line":"  run_once: true"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- name: Load glance metadata definitions"},{"line_number":45,"context_line":"  command: \"{{ glance_bin }}/glance-manage db load_metadefs\""},{"line_number":46,"context_line":"  changed_when: false"},{"line_number":47,"context_line":"  when: upgrade_type.strip() \u003d\u003d \u0027major\u0027 or db_version.stdout.startswith(\u0027Database is either not under migration control\u0027)"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"5f201791_34953b41","line":44,"updated":"2017-06-22 20:53:06.000000000","message":"Same as above.","commit_id":"caa44d482198caf21560114c0b491d091587465d"}],"tasks/glance_install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"36614fcafc5f6b0e1dbb886a88de874aa8a848d6","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        {%-  endif %}"},{"line_number":129,"context_line":"        {%- endif %}"},{"line_number":130,"context_line":"        {{ upgrade_type }}"},{"line_number":131,"context_line":"  when: inventory_hostname \u003d\u003d groups[\u0027glance_all\u0027][0]"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"- name: Record the venv tag deployed"},{"line_number":134,"context_line":"  ini_file:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"5f201791_8870a374","line":131,"range":{"start_line":131,"start_character":0,"end_line":131,"end_character":53},"updated":"2017-06-21 13:06:13.000000000","message":"In order to use it properly in the follow on patch, you\u0027ll need to delegate this to localhost and should set this to run_once rather than restrict based on the hostname.\n\nAlso, this patch alone makes no sense. It\u0027d be better to squash the two as they are clearly needed to work together.\n\nMy other suggestion is to have this task run in the same task file as the db sync because that\u0027s where it\u0027s used. If someone does an install and config process separately (using tags), this task will be skipped.","commit_id":"ee4cac9998113da2f2b77fa5e56a393ea23b3bf5"}]}