)]}'
{"tasks/glance_pre_install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"96f8dd9a875e78fe88489220bab7e284bd39d53c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    - { path: \"{{ glance_system_user_home }}/cache/registry\" }"},{"line_number":55,"context_line":"    - { path: \"{{ glance_system_user_home }}/scrubber\" }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- name: Stat the images directory"},{"line_number":58,"context_line":"  stat:"},{"line_number":59,"context_line":"    path: \"{{ glance_system_user_home }}/images/\""},{"line_number":60,"context_line":"  register: images_stat"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"- name: Create glance images dir"},{"line_number":63,"context_line":"  file:"},{"line_number":64,"context_line":"    path: \"{{ glance_system_user_home }}/images/\""},{"line_number":65,"context_line":"    state: directory"},{"line_number":66,"context_line":"    owner: \"{{ glance_system_user_name }}\""},{"line_number":67,"context_line":"    group: \"{{ glance_system_group_name }}\""},{"line_number":68,"context_line":"    mode: \"0755\""},{"line_number":69,"context_line":"  when:"},{"line_number":70,"context_line":"    - not images_stat.stat.exists | default(false) | bool"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"- name: Test for log directory or link"},{"line_number":73,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"df87a7cf_e21afb6c","line":70,"range":{"start_line":57,"start_character":0,"end_line":70,"end_character":57},"updated":"2017-12-12 02:51:07.000000000","message":"Why stat it, then create if it doesn\u0027t exist? This task should be idempotent and will adjust the owner/group if that\u0027s not right.","commit_id":"775ebc846085baca2d264adb3a31296542e545ea"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"a72c008e40edd9d40942958bb4f2976fe69657ab","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    - { path: \"{{ glance_system_user_home }}/cache/registry\" }"},{"line_number":55,"context_line":"    - { path: \"{{ glance_system_user_home }}/scrubber\" }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- name: Stat the images directory"},{"line_number":58,"context_line":"  stat:"},{"line_number":59,"context_line":"    path: \"{{ glance_system_user_home }}/images/\""},{"line_number":60,"context_line":"  register: images_stat"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"- name: Create glance images dir"},{"line_number":63,"context_line":"  file:"},{"line_number":64,"context_line":"    path: \"{{ glance_system_user_home }}/images/\""},{"line_number":65,"context_line":"    state: directory"},{"line_number":66,"context_line":"    owner: \"{{ glance_system_user_name }}\""},{"line_number":67,"context_line":"    group: \"{{ glance_system_group_name }}\""},{"line_number":68,"context_line":"    mode: \"0755\""},{"line_number":69,"context_line":"  when:"},{"line_number":70,"context_line":"    - not images_stat.stat.exists | default(false) | bool"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"- name: Test for log directory or link"},{"line_number":73,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"df87a7cf_9d9d92bd","line":70,"range":{"start_line":57,"start_character":0,"end_line":70,"end_character":57},"in_reply_to":"df87a7cf_22d22329","updated":"2017-12-12 04:02:44.000000000","message":"Fair enough.\n\nWe could perhaps use glance_system_user_uid /  glance_system_group_gid here if they\u0027re set, but otherwise omit.","commit_id":"775ebc846085baca2d264adb3a31296542e545ea"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"2e122bf2eafa9e6ae5901c007397f04fcc0fa60a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    - { path: \"{{ glance_system_user_home }}/cache/registry\" }"},{"line_number":55,"context_line":"    - { path: \"{{ glance_system_user_home }}/scrubber\" }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- name: Stat the images directory"},{"line_number":58,"context_line":"  stat:"},{"line_number":59,"context_line":"    path: \"{{ glance_system_user_home }}/images/\""},{"line_number":60,"context_line":"  register: images_stat"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"- name: Create glance images dir"},{"line_number":63,"context_line":"  file:"},{"line_number":64,"context_line":"    path: \"{{ glance_system_user_home }}/images/\""},{"line_number":65,"context_line":"    state: directory"},{"line_number":66,"context_line":"    owner: \"{{ glance_system_user_name }}\""},{"line_number":67,"context_line":"    group: \"{{ glance_system_group_name }}\""},{"line_number":68,"context_line":"    mode: \"0755\""},{"line_number":69,"context_line":"  when:"},{"line_number":70,"context_line":"    - not images_stat.stat.exists | default(false) | bool"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"- name: Test for log directory or link"},{"line_number":73,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"df87a7cf_22d22329","line":70,"range":{"start_line":57,"start_character":0,"end_line":70,"end_character":57},"in_reply_to":"df87a7cf_e21afb6c","updated":"2017-12-12 03:58:02.000000000","message":"Because we have not enforced deployers to set the UID/GID from the beginning when using shared storage (they\u0027ve not even had the option until this commit) we can not guarantee the UID/GID will be the same as glance within the NFS environment. If \"/var/lib/glance/images\" has a different UID/GID when the mount is active ansible will not have the ability to reset the UID/GID resulting on a failed run.\n\nA typical setup within NFS that would cause this scenario would be when using \"all_squash\" with \"anonuid\" and \"anongid\". I captured this scenario in the new NFS test.","commit_id":"775ebc846085baca2d264adb3a31296542e545ea"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"96f8dd9a875e78fe88489220bab7e284bd39d53c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    name: openstack-ansible-nfs_glance"},{"line_number":32,"context_line":"    parent: openstack-ansible-functional"},{"line_number":33,"context_line":"    nodeset: ubuntu-xenial"},{"line_number":34,"context_line":"    voting: false"},{"line_number":35,"context_line":"    vars:"},{"line_number":36,"context_line":"      tox_env: nfs"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"df87a7cf_e233dbf4","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":17},"updated":"2017-12-12 02:51:07.000000000","message":"I suggest that we actually remove this. This should be a voting test.","commit_id":"775ebc846085baca2d264adb3a31296542e545ea"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"2e122bf2eafa9e6ae5901c007397f04fcc0fa60a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    name: openstack-ansible-nfs_glance"},{"line_number":32,"context_line":"    parent: openstack-ansible-functional"},{"line_number":33,"context_line":"    nodeset: ubuntu-xenial"},{"line_number":34,"context_line":"    voting: false"},{"line_number":35,"context_line":"    vars:"},{"line_number":36,"context_line":"      tox_env: nfs"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"df87a7cf_42cde782","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":17},"in_reply_to":"df87a7cf_e233dbf4","updated":"2017-12-12 03:58:02.000000000","message":"Done","commit_id":"775ebc846085baca2d264adb3a31296542e545ea"}],"zuul.d/project.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"96f8dd9a875e78fe88489220bab7e284bd39d53c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        - openstack-ansible-functional-ubuntu-xenial"},{"line_number":37,"context_line":"        - openstack-ansible-upgrade-ubuntu-xenial"},{"line_number":38,"context_line":"        - openstack-ansible-v1_api_enabled"},{"line_number":39,"context_line":"        - openstack-ansible-v2_registry_enabled"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"df87a7cf_022fdf87","line":39,"updated":"2017-12-12 02:51:07.000000000","message":"I suggest adding the new test to the gate queue.","commit_id":"775ebc846085baca2d264adb3a31296542e545ea"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"2e122bf2eafa9e6ae5901c007397f04fcc0fa60a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        - openstack-ansible-functional-ubuntu-xenial"},{"line_number":37,"context_line":"        - openstack-ansible-upgrade-ubuntu-xenial"},{"line_number":38,"context_line":"        - openstack-ansible-v1_api_enabled"},{"line_number":39,"context_line":"        - openstack-ansible-v2_registry_enabled"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"df87a7cf_02c35f58","line":39,"in_reply_to":"df87a7cf_022fdf87","updated":"2017-12-12 03:58:02.000000000","message":"Done","commit_id":"775ebc846085baca2d264adb3a31296542e545ea"}]}