)]}'
{"tasks/glance_install.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"fe9021024896a051f14cd8fd9c54d92b6aaf6e43","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    venv_install_destination_path: \"{{ glance_bin | dirname }}\""},{"line_number":138,"context_line":"    venv_install_distro_package_list: \"{{ glance_distro_packages }}\""},{"line_number":139,"context_line":"    venv_pip_install_args: \"{{ glance_pip_install_args }}\""},{"line_number":140,"context_line":"    venv_pip_packages: \"{{ glance_pip_packages | union(glance_user_pip_packages) +"},{"line_number":141,"context_line":"    (glance_oslomsg_amqp1_enabled | bool) | ternary(glance_optional_oslomsg_amqp1_pip_packages, []) }}\""},{"line_number":142,"context_line":"    venv_facts_when_changed:"},{"line_number":143,"context_line":"      - section: \"glance\""},{"line_number":144,"context_line":"        option: \"need_service_restart\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5fc1f717_705d38e8","line":141,"range":{"start_line":140,"start_character":24,"end_line":141,"end_character":102},"updated":"2019-03-19 19:50:52.000000000","message":"for the the venv pip packages entry I would probably do something like so: \n\n{{ glance_pip_packages | \n     union(glance_user_pip_packages) | \n       union(((glance_oslomsg_amqp1_enabled | bool) | ternary(glance_optional_oslomsg_amqp1_pip_packages, []))) }}\n\n\nThis would ensure there are no duplicate packages in the list.","commit_id":"a2098482dbe8669e72cfd4b51b2561a714508508"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"36316466c96fe84903a0fb13ae153d0dfe4fa630","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    venv_install_destination_path: \"{{ glance_bin | dirname }}\""},{"line_number":138,"context_line":"    venv_install_distro_package_list: \"{{ glance_distro_packages }}\""},{"line_number":139,"context_line":"    venv_pip_install_args: \"{{ glance_pip_install_args }}\""},{"line_number":140,"context_line":"    venv_pip_packages: \"{{ glance_pip_packages | union(glance_user_pip_packages) +"},{"line_number":141,"context_line":"    (glance_oslomsg_amqp1_enabled | bool) | ternary(glance_optional_oslomsg_amqp1_pip_packages, []) }}\""},{"line_number":142,"context_line":"    venv_facts_when_changed:"},{"line_number":143,"context_line":"      - section: \"glance\""},{"line_number":144,"context_line":"        option: \"need_service_restart\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5fc1f717_10b0748b","line":141,"range":{"start_line":140,"start_character":24,"end_line":141,"end_character":102},"in_reply_to":"5fc1f717_705d38e8","updated":"2019-03-19 20:14:25.000000000","message":"Good call - will do that in the next iteration.","commit_id":"a2098482dbe8669e72cfd4b51b2561a714508508"}],"tasks/main.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"42671c3996ca20d0e0498dc0acbff4572b5cbc67","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    - common-mq"},{"line_number":68,"context_line":"    - glance-config"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"- include_tasks: glance_db_setup.yml"},{"line_number":71,"context_line":"  when:"},{"line_number":72,"context_line":"    - \"glance_services[\u0027glance-api\u0027][\u0027group\u0027] in group_names\""},{"line_number":73,"context_line":"    - \"inventory_hostname \u003d\u003d ((groups[glance_services[\u0027glance-api\u0027][\u0027group\u0027]]| intersect(ansible_play_hosts)) | list)[0]\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5fc1f717_eba1f296","line":70,"range":{"start_line":70,"start_character":2,"end_line":70,"end_character":15},"updated":"2019-03-22 13:23:44.000000000","message":"shouldn\u0027t it be converted to import_tasks?","commit_id":"522bba6f30e9b20e32bde1a120053034181d1657"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"42671c3996ca20d0e0498dc0acbff4572b5cbc67","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  tags:"},{"line_number":75,"context_line":"    - glance-config"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"- include_tasks: glance_service_setup.yml"},{"line_number":78,"context_line":"  when:"},{"line_number":79,"context_line":"    - \"glance_services[\u0027glance-api\u0027][\u0027group\u0027] in group_names\""},{"line_number":80,"context_line":"    - \"inventory_hostname \u003d\u003d ((groups[glance_services[\u0027glance-api\u0027][\u0027group\u0027]]| intersect(ansible_play_hosts)) | list)[0]\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5fc1f717_6bb742da","line":77,"range":{"start_line":77,"start_character":2,"end_line":77,"end_character":15},"updated":"2019-03-22 13:23:44.000000000","message":"ditto","commit_id":"522bba6f30e9b20e32bde1a120053034181d1657"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"42671c3996ca20d0e0498dc0acbff4572b5cbc67","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    - glance-config"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"- name: Include ceph_client role"},{"line_number":85,"context_line":"  include_role:"},{"line_number":86,"context_line":"    name: ceph_client"},{"line_number":87,"context_line":"  vars:"},{"line_number":88,"context_line":"    openstack_service_system_user: \"{{ glance_system_user_name }}\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5fc1f717_2bb13ae2","line":85,"range":{"start_line":85,"start_character":2,"end_line":85,"end_character":14},"updated":"2019-03-22 13:23:44.000000000","message":"Maybe we can use import_role here as there\u0027s ceph tag?","commit_id":"522bba6f30e9b20e32bde1a120053034181d1657"}]}
