)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"1591352c5e7fff7f24f3be7ab49620dd6a010241","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There are a number of missing dependencies when using cinder store"},{"line_number":10,"context_line":"with glance:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":" - olso.rootwrapper is was not included in glance_pip_packages"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":" - files/rootwrap.d/glance_cinder_store.filters"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fb8cfa7_a673df4d","line":12,"range":{"start_line":12,"start_character":3,"end_line":12,"end_character":19},"updated":"2019-06-26 19:29:18.000000000","message":"we should probably keep this as the actual package name","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"38a91b2f40c0c6f20e630e62dbbb877d21ad1571","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There are a number of missing dependencies when using cinder store"},{"line_number":10,"context_line":"with glance:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":" - olso.rootwrapper is was not included in glance_pip_packages"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":" - files/rootwrap.d/glance_cinder_store.filters"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fb8cfa7_343f1026","line":12,"range":{"start_line":12,"start_character":3,"end_line":12,"end_character":19},"in_reply_to":"9fb8cfa7_25984473","updated":"2019-06-27 06:32:49.000000000","message":"The proper name is oslo.rootwrap","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"},{"author":{"_account_id":30204,"name":"Craig McIntyre","email":"craig.mcintyre@k3btg.com","username":"ceemac"},"change_message_id":"d71e2df6160a48468eaf41bf99369f573e3697e4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There are a number of missing dependencies when using cinder store"},{"line_number":10,"context_line":"with glance:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":" - olso.rootwrapper is was not included in glance_pip_packages"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":" - files/rootwrap.d/glance_cinder_store.filters"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fb8cfa7_347710d7","line":12,"range":{"start_line":12,"start_character":3,"end_line":12,"end_character":19},"in_reply_to":"9fb8cfa7_343f1026","updated":"2019-06-27 06:52:43.000000000","message":"So it is. No idea how I missed that. Will correct.","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"},{"author":{"_account_id":30204,"name":"Craig McIntyre","email":"craig.mcintyre@k3btg.com","username":"ceemac"},"change_message_id":"f75acc6eec07d59aa769364bd0c486718450a845","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There are a number of missing dependencies when using cinder store"},{"line_number":10,"context_line":"with glance:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":" - olso.rootwrapper is was not included in glance_pip_packages"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":" - files/rootwrap.d/glance_cinder_store.filters"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fb8cfa7_a8d15725","line":12,"range":{"start_line":12,"start_character":3,"end_line":12,"end_character":19},"in_reply_to":"9fb8cfa7_a673df4d","updated":"2019-06-27 16:45:46.000000000","message":"Done","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"},{"author":{"_account_id":30204,"name":"Craig McIntyre","email":"craig.mcintyre@k3btg.com","username":"ceemac"},"change_message_id":"aaacfcc925725847fc4ff9d105fe32c99339ba2d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There are a number of missing dependencies when using cinder store"},{"line_number":10,"context_line":"with glance:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":" - olso.rootwrapper is was not included in glance_pip_packages"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":" - files/rootwrap.d/glance_cinder_store.filters"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fb8cfa7_25984473","line":12,"range":{"start_line":12,"start_character":3,"end_line":12,"end_character":19},"in_reply_to":"9fb8cfa7_a673df4d","updated":"2019-06-26 22:03:21.000000000","message":"To clarify, do you mean the package name is incorrect, or not to mention glance_pip_packages?","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"}],"defaults/main.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"83fc4ebc20348644c55256de18b5d1c211e20f63","unresolved":false,"context_lines":[{"line_number":240,"context_line":"  - glance"},{"line_number":241,"context_line":"  - keystonemiddleware"},{"line_number":242,"context_line":"  - os-brick"},{"line_number":243,"context_line":"  - oslo.rootwrap                          ## (CeeMac) added as pre-req for glance cinder store bug#1833725"},{"line_number":244,"context_line":"  - osprofiler"},{"line_number":245,"context_line":"  - PyMySQL"},{"line_number":246,"context_line":"  - python-cinderclient"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_df656db6","line":243,"range":{"start_line":243,"start_character":43,"end_line":243,"end_character":107},"updated":"2019-06-27 07:22:43.000000000","message":"This should not be here.\nInstead it should be documented in the commit message, so it appears in a git blame. (I mean more than \"Partial bug\", we have to explain why the addition of oslo.rootwrap will fix things).\n\nMy guess is that we need rootwrap in glance to connect with cinder backed storage, which could require elevated access, like for iscsi/fc.\n\nGlance supports rootwrap for a while, we just didn\u0027t have the case. You\u0027re giving us one here :)","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"},{"author":{"_account_id":30204,"name":"Craig McIntyre","email":"craig.mcintyre@k3btg.com","username":"ceemac"},"change_message_id":"f75acc6eec07d59aa769364bd0c486718450a845","unresolved":false,"context_lines":[{"line_number":240,"context_line":"  - glance"},{"line_number":241,"context_line":"  - keystonemiddleware"},{"line_number":242,"context_line":"  - os-brick"},{"line_number":243,"context_line":"  - oslo.rootwrap                          ## (CeeMac) added as pre-req for glance cinder store bug#1833725"},{"line_number":244,"context_line":"  - osprofiler"},{"line_number":245,"context_line":"  - PyMySQL"},{"line_number":246,"context_line":"  - python-cinderclient"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_e8a8af8c","line":243,"range":{"start_line":243,"start_character":43,"end_line":243,"end_character":107},"in_reply_to":"9fb8cfa7_df656db6","updated":"2019-06-27 16:45:46.000000000","message":"comment removed, commit message fleshed out, would like to discuss more about your other comments","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"}],"files/rootwrap.d/glance_cinder_store.filters":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"1591352c5e7fff7f24f3be7ab49620dd6a010241","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# glance-rootwrap command filters for glance cinder store"},{"line_number":2,"context_line":"# This file should be owned by (and only-writable by) the root user"},{"line_number":3,"context_line":" "},{"line_number":4,"context_line":"[Filters]"},{"line_number":5,"context_line":"# cinder store driver"},{"line_number":6,"context_line":"disk_chown: RegExpFilter, chown, root, chown, \\d+, /dev/(?!.*/\\.\\.).*"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9fb8cfa7_668ac71b","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":1},"updated":"2019-06-26 19:29:18.000000000","message":"whitespace","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"},{"author":{"_account_id":30204,"name":"Craig McIntyre","email":"craig.mcintyre@k3btg.com","username":"ceemac"},"change_message_id":"f75acc6eec07d59aa769364bd0c486718450a845","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# glance-rootwrap command filters for glance cinder store"},{"line_number":2,"context_line":"# This file should be owned by (and only-writable by) the root user"},{"line_number":3,"context_line":" "},{"line_number":4,"context_line":"[Filters]"},{"line_number":5,"context_line":"# cinder store driver"},{"line_number":6,"context_line":"disk_chown: RegExpFilter, chown, root, chown, \\d+, /dev/(?!.*/\\.\\.).*"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9fb8cfa7_a896374b","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":1},"in_reply_to":"9fb8cfa7_668ac71b","updated":"2019-06-27 16:45:46.000000000","message":"Done","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"1591352c5e7fff7f24f3be7ab49620dd6a010241","unresolved":false,"context_lines":[{"line_number":4,"context_line":"[Filters]"},{"line_number":5,"context_line":"# cinder store driver"},{"line_number":6,"context_line":"disk_chown: RegExpFilter, chown, root, chown, \\d+, /dev/(?!.*/\\.\\.).*"},{"line_number":7,"context_line":" "},{"line_number":8,"context_line":"# os-brick"},{"line_number":9,"context_line":"mount: CommandFilter, mount, root"},{"line_number":10,"context_line":"blockdev: RegExpFilter, blockdev, root, blockdev, (--getsize64|--flushbufs), /dev/.*"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9fb8cfa7_868fbb28","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":1},"updated":"2019-06-26 19:29:18.000000000","message":"whitespace","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"},{"author":{"_account_id":30204,"name":"Craig McIntyre","email":"craig.mcintyre@k3btg.com","username":"ceemac"},"change_message_id":"f75acc6eec07d59aa769364bd0c486718450a845","unresolved":false,"context_lines":[{"line_number":4,"context_line":"[Filters]"},{"line_number":5,"context_line":"# cinder store driver"},{"line_number":6,"context_line":"disk_chown: RegExpFilter, chown, root, chown, \\d+, /dev/(?!.*/\\.\\.).*"},{"line_number":7,"context_line":" "},{"line_number":8,"context_line":"# os-brick"},{"line_number":9,"context_line":"mount: CommandFilter, mount, root"},{"line_number":10,"context_line":"blockdev: RegExpFilter, blockdev, root, blockdev, (--getsize64|--flushbufs), /dev/.*"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9fb8cfa7_689cbf69","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":1},"in_reply_to":"9fb8cfa7_868fbb28","updated":"2019-06-27 16:45:46.000000000","message":"Done","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"}],"tasks/glance_post_install.yml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"1591352c5e7fff7f24f3be7ab49620dd6a010241","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# NOTE(CeeMac): This task is required to copy rootwrap filters that we need        "},{"line_number":17,"context_line":"# and glance does not provide by default."},{"line_number":18,"context_line":"- name: Create aux glance dir"},{"line_number":19,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_46ac639e","line":16,"range":{"start_line":16,"start_character":75,"end_line":16,"end_character":83},"updated":"2019-06-26 19:29:18.000000000","message":"whitespace","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"},{"author":{"_account_id":30204,"name":"Craig McIntyre","email":"craig.mcintyre@k3btg.com","username":"ceemac"},"change_message_id":"f75acc6eec07d59aa769364bd0c486718450a845","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# NOTE(CeeMac): This task is required to copy rootwrap filters that we need        "},{"line_number":17,"context_line":"# and glance does not provide by default."},{"line_number":18,"context_line":"- name: Create aux glance dir"},{"line_number":19,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_8897b345","line":16,"range":{"start_line":16,"start_character":75,"end_line":16,"end_character":83},"in_reply_to":"9fb8cfa7_46ac639e","updated":"2019-06-27 16:45:46.000000000","message":"Done","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"1591352c5e7fff7f24f3be7ab49620dd6a010241","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    - path: \"/etc/glance/rootwrap.d\""},{"line_number":27,"context_line":"      owner: \"root\""},{"line_number":28,"context_line":"      group: \"root\""},{"line_number":29,"context_line":" "},{"line_number":30,"context_line":"- name: Copy glance rootwrap filter config"},{"line_number":31,"context_line":"  copy:"},{"line_number":32,"context_line":"    src: \"{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_e6947746","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":1},"updated":"2019-06-26 19:29:18.000000000","message":"whitespace","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"},{"author":{"_account_id":30204,"name":"Craig McIntyre","email":"craig.mcintyre@k3btg.com","username":"ceemac"},"change_message_id":"f75acc6eec07d59aa769364bd0c486718450a845","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    - path: \"/etc/glance/rootwrap.d\""},{"line_number":27,"context_line":"      owner: \"root\""},{"line_number":28,"context_line":"      group: \"root\""},{"line_number":29,"context_line":" "},{"line_number":30,"context_line":"- name: Copy glance rootwrap filter config"},{"line_number":31,"context_line":"  copy:"},{"line_number":32,"context_line":"    src: \"{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_288c8734","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":1},"in_reply_to":"9fb8cfa7_e6947746","updated":"2019-06-27 16:45:46.000000000","message":"Done","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"83fc4ebc20348644c55256de18b5d1c211e20f63","unresolved":false,"context_lines":[{"line_number":30,"context_line":"- name: Copy glance rootwrap filter config"},{"line_number":31,"context_line":"  copy:"},{"line_number":32,"context_line":"    src: \"{{ item }}\""},{"line_number":33,"context_line":"    dest: \"/etc/glance/rootwrap.d/\""},{"line_number":34,"context_line":"    owner: \"root\""},{"line_number":35,"context_line":"    group: \"root\""},{"line_number":36,"context_line":"  with_fileglob:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_7fd9e153","line":33,"range":{"start_line":33,"start_character":23,"end_line":33,"end_character":33},"updated":"2019-06-27 07:22:43.000000000","message":"Shouldn\u0027t we have a rootwrap.conf, allowing to load rootwrap.d filters files?\n\nAlternatively, if it\u0027s only one file, can\u0027t we just template the file we carry into rootwrap.conf?\n\nAlso: Can we/should we make this whole thing conditional?","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"},{"author":{"_account_id":30204,"name":"Craig McIntyre","email":"craig.mcintyre@k3btg.com","username":"ceemac"},"change_message_id":"f75acc6eec07d59aa769364bd0c486718450a845","unresolved":false,"context_lines":[{"line_number":30,"context_line":"- name: Copy glance rootwrap filter config"},{"line_number":31,"context_line":"  copy:"},{"line_number":32,"context_line":"    src: \"{{ item }}\""},{"line_number":33,"context_line":"    dest: \"/etc/glance/rootwrap.d/\""},{"line_number":34,"context_line":"    owner: \"root\""},{"line_number":35,"context_line":"    group: \"root\""},{"line_number":36,"context_line":"  with_fileglob:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_a87f1713","line":33,"range":{"start_line":33,"start_character":23,"end_line":33,"end_character":33},"in_reply_to":"9fb8cfa7_7fd9e153","updated":"2019-06-27 16:45:46.000000000","message":"I will need to look some more into how this is done in other roles if you want me to do it that way?","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"1591352c5e7fff7f24f3be7ab49620dd6a010241","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  with_fileglob:"},{"line_number":37,"context_line":"    - rootwrap.d/*"},{"line_number":38,"context_line":"  notify:"},{"line_number":39,"context_line":"    - Manage LB"},{"line_number":40,"context_line":"    - Restart glance services"},{"line_number":41,"context_line":"  tags:"},{"line_number":42,"context_line":"    - glance-config"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_c697f344","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":15},"updated":"2019-06-26 19:29:18.000000000","message":"why is this necessary?","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"},{"author":{"_account_id":30204,"name":"Craig McIntyre","email":"craig.mcintyre@k3btg.com","username":"ceemac"},"change_message_id":"aaacfcc925725847fc4ff9d105fe32c99339ba2d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  with_fileglob:"},{"line_number":37,"context_line":"    - rootwrap.d/*"},{"line_number":38,"context_line":"  notify:"},{"line_number":39,"context_line":"    - Manage LB"},{"line_number":40,"context_line":"    - Restart glance services"},{"line_number":41,"context_line":"  tags:"},{"line_number":42,"context_line":"    - glance-config"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_e5946c39","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":15},"in_reply_to":"9fb8cfa7_c697f344","updated":"2019-06-26 22:03:21.000000000","message":"I had been referencing a task from the nova role when composing thus, I had anticipated this would set the server in haproxy to MAINT prior to restarting the services, however upon review I note there is no listener for this in the handler so I will remove","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"},{"author":{"_account_id":30204,"name":"Craig McIntyre","email":"craig.mcintyre@k3btg.com","username":"ceemac"},"change_message_id":"f75acc6eec07d59aa769364bd0c486718450a845","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  with_fileglob:"},{"line_number":37,"context_line":"    - rootwrap.d/*"},{"line_number":38,"context_line":"  notify:"},{"line_number":39,"context_line":"    - Manage LB"},{"line_number":40,"context_line":"    - Restart glance services"},{"line_number":41,"context_line":"  tags:"},{"line_number":42,"context_line":"    - glance-config"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_089ae360","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":15},"in_reply_to":"9fb8cfa7_c697f344","updated":"2019-06-27 16:45:46.000000000","message":"I\u0027ve removed the notify section fully as the handlers are called by the next task. However, I note that the \u0027Deploy Glance configuration files\u0027 task also notifies \u0027Manage LB\u0027 which doesn\u0027t appear to exist in the handler? Or is this a global handler?","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"1591352c5e7fff7f24f3be7ab49620dd6a010241","unresolved":false,"context_lines":[{"line_number":188,"context_line":"      hour: \"*/5\""},{"line_number":189,"context_line":"  when: glance_flavor is search(\"cache\")"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"- name: Drop sudoers file        "},{"line_number":192,"context_line":"  template:"},{"line_number":193,"context_line":"    src: \"sudoers.j2\""},{"line_number":194,"context_line":"    dest: \"/etc/sudoers.d/{{ glance_system_user_name }}_sudoers\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_0692eb57","line":191,"range":{"start_line":191,"start_character":25,"end_line":191,"end_character":33},"updated":"2019-06-26 19:29:18.000000000","message":"whitespace","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"},{"author":{"_account_id":30204,"name":"Craig McIntyre","email":"craig.mcintyre@k3btg.com","username":"ceemac"},"change_message_id":"f75acc6eec07d59aa769364bd0c486718450a845","unresolved":false,"context_lines":[{"line_number":188,"context_line":"      hour: \"*/5\""},{"line_number":189,"context_line":"  when: glance_flavor is search(\"cache\")"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"- name: Drop sudoers file        "},{"line_number":192,"context_line":"  template:"},{"line_number":193,"context_line":"    src: \"sudoers.j2\""},{"line_number":194,"context_line":"    dest: \"/etc/sudoers.d/{{ glance_system_user_name }}_sudoers\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_a8a4f7a6","line":191,"range":{"start_line":191,"start_character":25,"end_line":191,"end_character":33},"in_reply_to":"9fb8cfa7_0692eb57","updated":"2019-06-27 16:45:46.000000000","message":"Done","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a4af36de88eec7c7854a42b0c6a3877af585c88e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    owner: \"{{ item.owner|default(glance_system_user_name) }}\""},{"line_number":23,"context_line":"    group: \"{{ item.group|default(glance_system_group_name) }}\""},{"line_number":24,"context_line":"    mode: \"{{ item.mode | default(omit) }}\""},{"line_number":25,"context_line":"  with_items:"},{"line_number":26,"context_line":"    - path: \"/etc/glance/rootwrap.d\""},{"line_number":27,"context_line":"      owner: \"root\""},{"line_number":28,"context_line":"      group: \"root\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_57a8e5d9","line":25,"range":{"start_line":25,"start_character":2,"end_line":25,"end_character":12},"updated":"2019-07-10 07:53:12.000000000","message":"nit: replace with_items with \"loop\"","commit_id":"bdce898942387f292804ee2626345f77071ae077"},{"author":{"_account_id":30204,"name":"Craig McIntyre","email":"craig.mcintyre@k3btg.com","username":"ceemac"},"change_message_id":"60791d4e12a2edbcf7816a2e4ce71175a7b24bd6","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    owner: \"{{ item.owner|default(glance_system_user_name) }}\""},{"line_number":23,"context_line":"    group: \"{{ item.group|default(glance_system_group_name) }}\""},{"line_number":24,"context_line":"    mode: \"{{ item.mode | default(omit) }}\""},{"line_number":25,"context_line":"  with_items:"},{"line_number":26,"context_line":"    - path: \"/etc/glance/rootwrap.d\""},{"line_number":27,"context_line":"      owner: \"root\""},{"line_number":28,"context_line":"      group: \"root\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_a5c8d8a7","line":25,"range":{"start_line":25,"start_character":2,"end_line":25,"end_character":12},"in_reply_to":"7faddb67_57a8e5d9","updated":"2019-07-30 14:05:07.000000000","message":"I\u0027m unsure of the correct syntax to use with path after loop, also would I need to flatten as per the migration of with_* to loop guide?","commit_id":"bdce898942387f292804ee2626345f77071ae077"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a4af36de88eec7c7854a42b0c6a3877af585c88e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"- name: Copy glance rootwrap filter config"},{"line_number":31,"context_line":"  copy:"},{"line_number":32,"context_line":"    src: \"{{ item }}\""},{"line_number":33,"context_line":"    dest: \"/etc/glance/rootwrap.d/\""},{"line_number":34,"context_line":"    owner: \"root\""},{"line_number":35,"context_line":"    group: \"root\""},{"line_number":36,"context_line":"  with_fileglob:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_17aa6dd1","line":33,"range":{"start_line":33,"start_character":23,"end_line":33,"end_character":34},"updated":"2019-07-10 07:53:12.000000000","message":"Not sure if that folder is correctly read by default, can anyone confirm? I thought we needed a rootwrap.conf including those. If that\u0027s the case, it means this directive is useless for now.","commit_id":"bdce898942387f292804ee2626345f77071ae077"},{"author":{"_account_id":30204,"name":"Craig McIntyre","email":"craig.mcintyre@k3btg.com","username":"ceemac"},"change_message_id":"60791d4e12a2edbcf7816a2e4ce71175a7b24bd6","unresolved":false,"context_lines":[{"line_number":30,"context_line":"- name: Copy glance rootwrap filter config"},{"line_number":31,"context_line":"  copy:"},{"line_number":32,"context_line":"    src: \"{{ item }}\""},{"line_number":33,"context_line":"    dest: \"/etc/glance/rootwrap.d/\""},{"line_number":34,"context_line":"    owner: \"root\""},{"line_number":35,"context_line":"    group: \"root\""},{"line_number":36,"context_line":"  with_fileglob:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_e5849060","line":33,"range":{"start_line":33,"start_character":23,"end_line":33,"end_character":34},"in_reply_to":"7faddb67_17aa6dd1","updated":"2019-07-30 14:05:07.000000000","message":"templates/rootwrap.conf.j2 has \u0027filters_path\u003d/etc/glance/rootwrap.d\u0027 under [DEFAULT], so it should process fine?","commit_id":"bdce898942387f292804ee2626345f77071ae077"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a4af36de88eec7c7854a42b0c6a3877af585c88e","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    dest: \"/etc/sudoers.d/{{ glance_system_user_name }}_sudoers\""},{"line_number":192,"context_line":"    mode: \"0440\""},{"line_number":193,"context_line":"    owner: \"root\""},{"line_number":194,"context_line":"    group: \"root\""},{"line_number":195,"context_line":"  tags:"},{"line_number":196,"context_line":"    - sudoers"},{"line_number":197,"context_line":"    - glance-sudoers"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_37a52905","line":194,"range":{"start_line":194,"start_character":4,"end_line":194,"end_character":17},"updated":"2019-07-10 07:53:12.000000000","message":"it would be super nice if we had a validate after group: , to see if things are well loaded.","commit_id":"bdce898942387f292804ee2626345f77071ae077"},{"author":{"_account_id":30204,"name":"Craig McIntyre","email":"craig.mcintyre@k3btg.com","username":"ceemac"},"change_message_id":"60791d4e12a2edbcf7816a2e4ce71175a7b24bd6","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    dest: \"/etc/sudoers.d/{{ glance_system_user_name }}_sudoers\""},{"line_number":192,"context_line":"    mode: \"0440\""},{"line_number":193,"context_line":"    owner: \"root\""},{"line_number":194,"context_line":"    group: \"root\""},{"line_number":195,"context_line":"  tags:"},{"line_number":196,"context_line":"    - sudoers"},{"line_number":197,"context_line":"    - glance-sudoers"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_05c20c5a","line":194,"range":{"start_line":194,"start_character":4,"end_line":194,"end_character":17},"in_reply_to":"7faddb67_37a52905","updated":"2019-07-30 14:05:07.000000000","message":"What would you recommend I use as the validation?  Is there an example in another role where this is used for sudoers I can reference?","commit_id":"bdce898942387f292804ee2626345f77071ae077"}],"templates/sudoers.j2":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"1591352c5e7fff7f24f3be7ab49620dd6a010241","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# {{ ansible_managed }}"},{"line_number":2,"context_line":" "},{"line_number":3,"context_line":"Defaults:{{ glance_system_user_name }} !requiretty"},{"line_number":4,"context_line":"Defaults:{{ glance_system_user_name }} secure_path\u003d\"{{ glance_bin }}:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin\""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9fb8cfa7_c6c29353","line":1,"updated":"2019-06-26 19:29:18.000000000","message":"e","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"},{"author":{"_account_id":30204,"name":"Craig McIntyre","email":"craig.mcintyre@k3btg.com","username":"ceemac"},"change_message_id":"f75acc6eec07d59aa769364bd0c486718450a845","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# {{ ansible_managed }}"},{"line_number":2,"context_line":" "},{"line_number":3,"context_line":"Defaults:{{ glance_system_user_name }} !requiretty"},{"line_number":4,"context_line":"Defaults:{{ glance_system_user_name }} secure_path\u003d\"{{ glance_bin }}:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin\""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9fb8cfa7_e8af4f7a","line":1,"in_reply_to":"9fb8cfa7_66b887c7","updated":"2019-06-27 16:45:46.000000000","message":"couldn\u0027t find any whitespace in this line?","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"3195911a477f860ed0b1a4f489a4bfdba39f8638","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# {{ ansible_managed }}"},{"line_number":2,"context_line":" "},{"line_number":3,"context_line":"Defaults:{{ glance_system_user_name }} !requiretty"},{"line_number":4,"context_line":"Defaults:{{ glance_system_user_name }} secure_path\u003d\"{{ glance_bin }}:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin\""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9fb8cfa7_66b887c7","line":1,"in_reply_to":"9fb8cfa7_c6c29353","updated":"2019-06-26 19:29:53.000000000","message":"oops - \"whitespace\"","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"1591352c5e7fff7f24f3be7ab49620dd6a010241","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# {{ ansible_managed }}"},{"line_number":2,"context_line":" "},{"line_number":3,"context_line":"Defaults:{{ glance_system_user_name }} !requiretty"},{"line_number":4,"context_line":"Defaults:{{ glance_system_user_name }} secure_path\u003d\"{{ glance_bin }}:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin\""},{"line_number":5,"context_line":" "}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9fb8cfa7_a6c51f5e","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":1},"updated":"2019-06-26 19:29:18.000000000","message":"whitespace","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"},{"author":{"_account_id":30204,"name":"Craig McIntyre","email":"craig.mcintyre@k3btg.com","username":"ceemac"},"change_message_id":"f75acc6eec07d59aa769364bd0c486718450a845","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# {{ ansible_managed }}"},{"line_number":2,"context_line":" "},{"line_number":3,"context_line":"Defaults:{{ glance_system_user_name }} !requiretty"},{"line_number":4,"context_line":"Defaults:{{ glance_system_user_name }} secure_path\u003d\"{{ glance_bin }}:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin\""},{"line_number":5,"context_line":" "}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9fb8cfa7_08b3c3ea","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":1},"in_reply_to":"9fb8cfa7_a6c51f5e","updated":"2019-06-27 16:45:46.000000000","message":"Done","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"},{"author":{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},"change_message_id":"f0a7423fbdafcc1b61d82c3a06f97759d5e70f92","unresolved":false,"context_lines":[{"line_number":2,"context_line":" "},{"line_number":3,"context_line":"Defaults:{{ glance_system_user_name }} !requiretty"},{"line_number":4,"context_line":"Defaults:{{ glance_system_user_name }} secure_path\u003d\"{{ glance_bin }}:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin\""},{"line_number":5,"context_line":" "},{"line_number":6,"context_line":"glance ALL \u003d (root) NOPASSWD: {{ glance_bin }}/{{ glance_service_name }}-rootwrap"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9fb8cfa7_41a68d11","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":1},"updated":"2019-06-26 20:06:17.000000000","message":"as well as here too :)","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"},{"author":{"_account_id":30204,"name":"Craig McIntyre","email":"craig.mcintyre@k3btg.com","username":"ceemac"},"change_message_id":"f75acc6eec07d59aa769364bd0c486718450a845","unresolved":false,"context_lines":[{"line_number":2,"context_line":" "},{"line_number":3,"context_line":"Defaults:{{ glance_system_user_name }} !requiretty"},{"line_number":4,"context_line":"Defaults:{{ glance_system_user_name }} secure_path\u003d\"{{ glance_bin }}:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin\""},{"line_number":5,"context_line":" "},{"line_number":6,"context_line":"glance ALL \u003d (root) NOPASSWD: {{ glance_bin }}/{{ glance_service_name }}-rootwrap"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9fb8cfa7_a8cdd766","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":1},"in_reply_to":"9fb8cfa7_41a68d11","updated":"2019-06-27 16:45:46.000000000","message":"Done","commit_id":"38283bf0063637af567f1a7a95a55103476b51e7"}]}