)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"3a4266187acc1830aac427e147757ac4363ae299","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"911075c7_b2c2af28","updated":"2021-12-10 12:30:39.000000000","message":"This looks really good, but some small things I\u0027d love to cover.","commit_id":"0a88154f7557f478e79b514d1dd80375a9fc54fb"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"915422a279f6feb0d544b6f13a1467abb70f211f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2dfce0aa_7e4fccab","updated":"2021-12-23 12:42:12.000000000","message":"recheck","commit_id":"7c79f6d4cdbc9914759ab380558de88e7c0e621b"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"11f2f738103ad856a2d756a0bc8ea69454b67e3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6a4d57d9_50a9167c","updated":"2021-12-20 08:12:39.000000000","message":"recheck","commit_id":"7c79f6d4cdbc9914759ab380558de88e7c0e621b"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"0c31318109b4816793989cc0a96801d1ae8fcef6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b62c302e_c909c6af","updated":"2021-12-23 13:27:22.000000000","message":"recheck","commit_id":"7c79f6d4cdbc9914759ab380558de88e7c0e621b"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"554c7358ed0e47a82d59f8a8fb55486ebab044bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"52a6007f_36cf095c","updated":"2022-01-11 21:08:45.000000000","message":"LGTM","commit_id":"5264c8ca406d8b158d0e46b0ed48dba967d289e2"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"801f0d54a675c121080a22f58ca5afde8967eb3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"919e997a_b7a22fa0","updated":"2022-01-11 21:11:10.000000000","message":"Oh, well. Should we also cover usecase when `glance_use_uwsgi: False` and native service is being used?\n\nAs eventually glance known to work unreliable with interoperable import feature when uwsgi is used.","commit_id":"5264c8ca406d8b158d0e46b0ed48dba967d289e2"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"d48066e771cea1e069909200539e360eef73a22a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"34dd95d5_72a90858","updated":"2022-02-16 09:33:01.000000000","message":"Addressed most comments, but not had chance to look at the use case when glance_use_uwsgi: False","commit_id":"4941de16afd7826f52c6eed1716906206cae9501"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"e87e47a350e59324e8885adf57907242aeab2bf2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"97084a21_3860fe79","updated":"2022-02-21 14:13:30.000000000","message":"Perhaps this should be container_address / management_address ?","commit_id":"6d97ef49bae926680c13b08fbd6514031f340b78"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"6f67e78cdc3dc460112e34e43e6da8ec0a9fbc0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"f0505ac4_5c1609d9","updated":"2022-11-17 17:41:47.000000000","message":"recheck - keystone 503s during tempest run","commit_id":"131dfba63d9cc1da820b2a111e10b0ea933c9ff1"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"a78c7177a99c9041853460d8d8f5e587fc5ec806","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"8f20824a_62e1b788","updated":"2022-11-17 10:39:09.000000000","message":"recheck - tempest failed, gerrit was super slow yesterday, maybe that was the reason","commit_id":"131dfba63d9cc1da820b2a111e10b0ea933c9ff1"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"b1c6ff37172e3dca9220c7120c47a4673f2499b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"9217ea96_9d1d5a9e","updated":"2023-02-20 21:37:28.000000000","message":"recheck","commit_id":"71b3ed0e4d40b29dd36e4da7a18337b83201c1e4"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"2fe0d2c953896a2762e064f8da04c0909f58cf2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"c885f94b_4bb8458f","updated":"2023-04-15 11:40:44.000000000","message":"recheck - openstack-ansible-deploy-aio_distro_metal-rockylinux-9 - Incompatible openstacksdk library found: Version MUST be \u003e\u003d1.0 and \u003c\u003dNone, but 0.101.0 is smaller than minimum version 1.0.","commit_id":"998cb99ec3aa1238030f7fb4ba453566cd359f30"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"eaa45665b431bbb8a6b909d9890385b2972b5c4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"d44038b5_84a93cbc","updated":"2023-04-15 17:17:28.000000000","message":"recheck - tempest failed for openstack-ansible-deploy-aio_ceph-ubuntu-focal","commit_id":"998cb99ec3aa1238030f7fb4ba453566cd359f30"}],"defaults/main.yml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"b7b05297532757ff36be38464cf4dbcac1f2c3fd","unresolved":true,"context_lines":[{"line_number":283,"context_line":"    uwsgi_tls: \"{{ glance_https | ternary(glance_uwsgi_tls, {}) }}\""},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"# Define if HTTPS should be used for API"},{"line_number":286,"context_line":"glance_https: False"},{"line_number":287,"context_line":"# Glance uWSGI settings"},{"line_number":288,"context_line":"glance_wsgi_processes_max: 16"},{"line_number":289,"context_line":"glance_wsgi_processes: \"{{ [[(ansible_facts[\u0027processor_vcpus\u0027]//ansible_facts[\u0027processor_threads_per_core\u0027])|default(1), 1] | max * 2, glance_wsgi_processes_max] | min }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"67f0f250_515b3bad","line":286,"range":{"start_line":286,"start_character":14,"end_line":286,"end_character":19},"updated":"2021-12-08 12:06:06.000000000","message":"I would make this be something like \"{{ openstack_backend_service_https | default(False) }}\"\n\nThen we can have a deployment wide toggle which turns backend https on everywhere, or it can be done on per service basis with \u003cservice\u003e_https","commit_id":"26b2c03131cdecded9bef6ec24b0175dba767d85"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"d48066e771cea1e069909200539e360eef73a22a","unresolved":false,"context_lines":[{"line_number":283,"context_line":"    uwsgi_tls: \"{{ glance_https | ternary(glance_uwsgi_tls, {}) }}\""},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"# Define if HTTPS should be used for API"},{"line_number":286,"context_line":"glance_https: False"},{"line_number":287,"context_line":"# Glance uWSGI settings"},{"line_number":288,"context_line":"glance_wsgi_processes_max: 16"},{"line_number":289,"context_line":"glance_wsgi_processes: \"{{ [[(ansible_facts[\u0027processor_vcpus\u0027]//ansible_facts[\u0027processor_threads_per_core\u0027])|default(1), 1] | max * 2, glance_wsgi_processes_max] | min }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c9af9508_b4deefd6","line":286,"range":{"start_line":286,"start_character":14,"end_line":286,"end_character":19},"in_reply_to":"67f0f250_515b3bad","updated":"2022-02-16 09:33:01.000000000","message":"Done","commit_id":"26b2c03131cdecded9bef6ec24b0175dba767d85"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"bb3e0712ca959d16409c47ebafff8d71c918c755","unresolved":true,"context_lines":[{"line_number":143,"context_line":"glance_service_region: \"{{ service_region | default(\u0027RegionOne\u0027) }}\""},{"line_number":144,"context_line":"glance_service_name: glance"},{"line_number":145,"context_line":"glance_service_port: 9292"},{"line_number":146,"context_line":"glance_service_proto: http"},{"line_number":147,"context_line":"glance_service_publicuri_proto: \"{{ openstack_service_publicuri_proto | default(glance_service_proto) }}\""},{"line_number":148,"context_line":"glance_service_adminuri_proto: \"{{ openstack_service_adminuri_proto | default(glance_service_proto) }}\""},{"line_number":149,"context_line":"glance_service_internaluri_proto: \"{{ openstack_service_internaluri_proto | default(glance_service_proto) }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a7d8906b_1ba737e3","line":146,"range":{"start_line":146,"start_character":0,"end_line":146,"end_character":20},"updated":"2021-12-10 12:30:06.000000000","message":"this is confusing now... we should at least cover this with a good comment for documenting reasons","commit_id":"0a88154f7557f478e79b514d1dd80375a9fc54fb"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"e5a118ffe19216c5324c8ebb6728ba3966812ce0","unresolved":false,"context_lines":[{"line_number":143,"context_line":"glance_service_region: \"{{ service_region | default(\u0027RegionOne\u0027) }}\""},{"line_number":144,"context_line":"glance_service_name: glance"},{"line_number":145,"context_line":"glance_service_port: 9292"},{"line_number":146,"context_line":"glance_service_proto: http"},{"line_number":147,"context_line":"glance_service_publicuri_proto: \"{{ openstack_service_publicuri_proto | default(glance_service_proto) }}\""},{"line_number":148,"context_line":"glance_service_adminuri_proto: \"{{ openstack_service_adminuri_proto | default(glance_service_proto) }}\""},{"line_number":149,"context_line":"glance_service_internaluri_proto: \"{{ openstack_service_internaluri_proto | default(glance_service_proto) }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"81b72ffb_a38741f8","line":146,"range":{"start_line":146,"start_character":0,"end_line":146,"end_character":20},"in_reply_to":"84bd605c_dd324430","updated":"2021-12-15 09:40:36.000000000","message":"Done","commit_id":"0a88154f7557f478e79b514d1dd80375a9fc54fb"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"f46b3272eac39ae62958649383daf08bc684375c","unresolved":true,"context_lines":[{"line_number":143,"context_line":"glance_service_region: \"{{ service_region | default(\u0027RegionOne\u0027) }}\""},{"line_number":144,"context_line":"glance_service_name: glance"},{"line_number":145,"context_line":"glance_service_port: 9292"},{"line_number":146,"context_line":"glance_service_proto: http"},{"line_number":147,"context_line":"glance_service_publicuri_proto: \"{{ openstack_service_publicuri_proto | default(glance_service_proto) }}\""},{"line_number":148,"context_line":"glance_service_adminuri_proto: \"{{ openstack_service_adminuri_proto | default(glance_service_proto) }}\""},{"line_number":149,"context_line":"glance_service_internaluri_proto: \"{{ openstack_service_internaluri_proto | default(glance_service_proto) }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"84bd605c_dd324430","line":146,"range":{"start_line":146,"start_character":0,"end_line":146,"end_character":20},"in_reply_to":"a7d8906b_1ba737e3","updated":"2021-12-10 17:00:40.000000000","message":"ah yes, this is indeed confusing now we have glance_https and openstack_backend_service_https. Needs a specific comment for what this is for","commit_id":"0a88154f7557f478e79b514d1dd80375a9fc54fb"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"bb3e0712ca959d16409c47ebafff8d71c918c755","unresolved":true,"context_lines":[{"line_number":283,"context_line":"    uwsgi_tls: \"{{ glance_https | ternary(glance_uwsgi_tls, {}) }}\""},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"# Define if HTTPS should be used for API"},{"line_number":286,"context_line":"glance_https: \"{{ openstack_backend_service_https | default(False) }}\""},{"line_number":287,"context_line":"# Glance uWSGI settings"},{"line_number":288,"context_line":"glance_wsgi_processes_max: 16"},{"line_number":289,"context_line":"glance_wsgi_processes: \"{{ [[(ansible_facts[\u0027processor_vcpus\u0027]//ansible_facts[\u0027processor_threads_per_core\u0027])|default(1), 1] | max * 2, glance_wsgi_processes_max] | min }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"97033778_a109711d","line":286,"range":{"start_line":286,"start_character":0,"end_line":286,"end_character":12},"updated":"2021-12-10 12:30:06.000000000","message":"I\u0027d probably called it `glance_backend_proto` or at least `glance_backend_https` as indeed it\u0027s neat to have it boolean.","commit_id":"0a88154f7557f478e79b514d1dd80375a9fc54fb"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"f46b3272eac39ae62958649383daf08bc684375c","unresolved":true,"context_lines":[{"line_number":283,"context_line":"    uwsgi_tls: \"{{ glance_https | ternary(glance_uwsgi_tls, {}) }}\""},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"# Define if HTTPS should be used for API"},{"line_number":286,"context_line":"glance_https: \"{{ openstack_backend_service_https | default(False) }}\""},{"line_number":287,"context_line":"# Glance uWSGI settings"},{"line_number":288,"context_line":"glance_wsgi_processes_max: 16"},{"line_number":289,"context_line":"glance_wsgi_processes: \"{{ [[(ansible_facts[\u0027processor_vcpus\u0027]//ansible_facts[\u0027processor_threads_per_core\u0027])|default(1), 1] | max * 2, glance_wsgi_processes_max] | min }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"da39699b_f029db16","line":286,"range":{"start_line":286,"start_character":0,"end_line":286,"end_character":12},"in_reply_to":"97033778_a109711d","updated":"2021-12-10 17:00:40.000000000","message":"The comment is slightly ambiguous as we\u0027re talking about the backend API - not the user facing external API and we could make that clearer. I agree on glance_backend_\u003cblah\u003e.","commit_id":"0a88154f7557f478e79b514d1dd80375a9fc54fb"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"e5a118ffe19216c5324c8ebb6728ba3966812ce0","unresolved":false,"context_lines":[{"line_number":283,"context_line":"    uwsgi_tls: \"{{ glance_https | ternary(glance_uwsgi_tls, {}) }}\""},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"# Define if HTTPS should be used for API"},{"line_number":286,"context_line":"glance_https: \"{{ openstack_backend_service_https | default(False) }}\""},{"line_number":287,"context_line":"# Glance uWSGI settings"},{"line_number":288,"context_line":"glance_wsgi_processes_max: 16"},{"line_number":289,"context_line":"glance_wsgi_processes: \"{{ [[(ansible_facts[\u0027processor_vcpus\u0027]//ansible_facts[\u0027processor_threads_per_core\u0027])|default(1), 1] | max * 2, glance_wsgi_processes_max] | min }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c4ca66f1_21eceede","line":286,"range":{"start_line":286,"start_character":0,"end_line":286,"end_character":12},"in_reply_to":"da39699b_f029db16","updated":"2021-12-15 09:40:36.000000000","message":"Done","commit_id":"0a88154f7557f478e79b514d1dd80375a9fc54fb"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"0166d209a5c42dfa1a012046eec40b66589f77f8","unresolved":true,"context_lines":[{"line_number":143,"context_line":"glance_service_region: \"{{ service_region | default(\u0027RegionOne\u0027) }}\""},{"line_number":144,"context_line":"glance_service_name: glance"},{"line_number":145,"context_line":"glance_service_port: 9292"},{"line_number":146,"context_line":"# Protocol used by glance clients to connect to glance server via load balancer VIP"},{"line_number":147,"context_line":"glance_service_proto: http"},{"line_number":148,"context_line":"glance_service_publicuri_proto: \"{{ openstack_service_publicuri_proto | default(glance_service_proto) }}\""},{"line_number":149,"context_line":"glance_service_adminuri_proto: \"{{ openstack_service_adminuri_proto | default(glance_service_proto) }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"10fe5c7f_7c419f2d","line":146,"range":{"start_line":146,"start_character":0,"end_line":146,"end_character":83},"updated":"2021-12-15 09:57:18.000000000","message":"Still confusing...\n\nMaybe it\u0027s \"Protocol to be used by default for defining glance service in catalog and configured on load balancer frontend\"?","commit_id":"81ae72712132f6c686410251b0393a85686d9a5c"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"9eae74a64a2fbc378ea6bf40a2e11520c59db1cd","unresolved":false,"context_lines":[{"line_number":143,"context_line":"glance_service_region: \"{{ service_region | default(\u0027RegionOne\u0027) }}\""},{"line_number":144,"context_line":"glance_service_name: glance"},{"line_number":145,"context_line":"glance_service_port: 9292"},{"line_number":146,"context_line":"# Protocol used by glance clients to connect to glance server via load balancer VIP"},{"line_number":147,"context_line":"glance_service_proto: http"},{"line_number":148,"context_line":"glance_service_publicuri_proto: \"{{ openstack_service_publicuri_proto | default(glance_service_proto) }}\""},{"line_number":149,"context_line":"glance_service_adminuri_proto: \"{{ openstack_service_adminuri_proto | default(glance_service_proto) }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1316321f_6603a66e","line":146,"range":{"start_line":146,"start_character":0,"end_line":146,"end_character":83},"in_reply_to":"10fe5c7f_7c419f2d","updated":"2021-12-15 14:16:50.000000000","message":"Done","commit_id":"81ae72712132f6c686410251b0393a85686d9a5c"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"04073bd77f2ba273bc03e6923f7a2ad5b10a3c38","unresolved":true,"context_lines":[{"line_number":283,"context_line":"    uwsgi_port: \"{{ glance_api_service_port }}\""},{"line_number":284,"context_line":"    uwsgi_tls: \"{{ glance_backend_https | ternary(glance_uwsgi_tls, {}) }}\""},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"# Define if glance server should use HTTPS for backend behind load balancer"},{"line_number":287,"context_line":"glance_backend_https: \"{{ openstack_backend_service_https | default(False) }}\""},{"line_number":288,"context_line":"# Glance uWSGI settings"},{"line_number":289,"context_line":"glance_wsgi_processes_max: 16"},{"line_number":290,"context_line":"glance_wsgi_processes: \"{{ [[(ansible_facts[\u0027processor_vcpus\u0027]//ansible_facts[\u0027processor_threads_per_core\u0027])|default(1), 1] | max * 2, glance_wsgi_processes_max] | min }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"6ab59a19_97b63fcf","line":287,"range":{"start_line":286,"start_character":0,"end_line":287,"end_character":78},"updated":"2021-12-15 09:58:39.000000000","message":"I\u0027d say that it would be good to place there somewhere nearby `glance_service_proto` so that while reading doc these 2 variables appeared nearby","commit_id":"81ae72712132f6c686410251b0393a85686d9a5c"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"9eae74a64a2fbc378ea6bf40a2e11520c59db1cd","unresolved":false,"context_lines":[{"line_number":283,"context_line":"    uwsgi_port: \"{{ glance_api_service_port }}\""},{"line_number":284,"context_line":"    uwsgi_tls: \"{{ glance_backend_https | ternary(glance_uwsgi_tls, {}) }}\""},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"# Define if glance server should use HTTPS for backend behind load balancer"},{"line_number":287,"context_line":"glance_backend_https: \"{{ openstack_backend_service_https | default(False) }}\""},{"line_number":288,"context_line":"# Glance uWSGI settings"},{"line_number":289,"context_line":"glance_wsgi_processes_max: 16"},{"line_number":290,"context_line":"glance_wsgi_processes: \"{{ [[(ansible_facts[\u0027processor_vcpus\u0027]//ansible_facts[\u0027processor_threads_per_core\u0027])|default(1), 1] | max * 2, glance_wsgi_processes_max] | min }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"b9d22207_bd8e207d","line":287,"range":{"start_line":286,"start_character":0,"end_line":287,"end_character":78},"in_reply_to":"6ab59a19_97b63fcf","updated":"2021-12-15 14:16:50.000000000","message":"Done","commit_id":"81ae72712132f6c686410251b0393a85686d9a5c"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"801f0d54a675c121080a22f58ca5afde8967eb3b","unresolved":true,"context_lines":[{"line_number":334,"context_line":"# Glance destination files for SSL certificates"},{"line_number":335,"context_line":"glance_ssl_cert: /etc/glance/glance.pem"},{"line_number":336,"context_line":"glance_ssl_key: /etc/glance/glance.key"},{"line_number":337,"context_line":"# glance_ssl_ca_cert: /etc/glance/glance-ca.pem"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"# Installation details for SSL certificates"},{"line_number":340,"context_line":"glance_pki_install_certificates:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"557ac17a_5d6ec97e","line":337,"range":{"start_line":337,"start_character":0,"end_line":337,"end_character":47},"updated":"2022-01-11 21:11:10.000000000","message":"this is not used anywhere?","commit_id":"5264c8ca406d8b158d0e46b0ed48dba967d289e2"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"d48066e771cea1e069909200539e360eef73a22a","unresolved":false,"context_lines":[{"line_number":334,"context_line":"# Glance destination files for SSL certificates"},{"line_number":335,"context_line":"glance_ssl_cert: /etc/glance/glance.pem"},{"line_number":336,"context_line":"glance_ssl_key: /etc/glance/glance.key"},{"line_number":337,"context_line":"# glance_ssl_ca_cert: /etc/glance/glance-ca.pem"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"# Installation details for SSL certificates"},{"line_number":340,"context_line":"glance_pki_install_certificates:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"8941b2c5_a08b7472","line":337,"range":{"start_line":337,"start_character":0,"end_line":337,"end_character":47},"in_reply_to":"557ac17a_5d6ec97e","updated":"2022-02-16 09:33:01.000000000","message":"Done","commit_id":"5264c8ca406d8b158d0e46b0ed48dba967d289e2"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"67a43733cbe60437be1b91d897e9f4903b47c358","unresolved":true,"context_lines":[{"line_number":316,"context_line":"# Delegated host for operating the certificate authority"},{"line_number":317,"context_line":"glance_pki_setup_host: \"{{ openstack_pki_setup_host | default(\u0027localhost\u0027) }}\""},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"# The local address used for the glance node"},{"line_number":320,"context_line":"glance_node_address: \"{{ ansible_host }}\""},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"# Glance server certificate"},{"line_number":323,"context_line":"glance_pki_keys_path: \"{{ glance_pki_dir ~ \u0027/certs/private/\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"a0fc349c_2ae303fe","line":320,"range":{"start_line":319,"start_character":0,"end_line":320,"end_character":41},"updated":"2022-02-17 07:27:26.000000000","message":"does this need to be it\u0027s own variable? I only see it used once elsewhere?","commit_id":"43877a84ce6fb28f214f2bf4d5747dea65efd960"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"6a8ae6cc6c2b58bf4c27eb3981ea377d4db93e24","unresolved":false,"context_lines":[{"line_number":316,"context_line":"# Delegated host for operating the certificate authority"},{"line_number":317,"context_line":"glance_pki_setup_host: \"{{ openstack_pki_setup_host | default(\u0027localhost\u0027) }}\""},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"# The local address used for the glance node"},{"line_number":320,"context_line":"glance_node_address: \"{{ ansible_host }}\""},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"# Glance server certificate"},{"line_number":323,"context_line":"glance_pki_keys_path: \"{{ glance_pki_dir ~ \u0027/certs/private/\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"a8073197_132d568b","line":320,"range":{"start_line":319,"start_character":0,"end_line":320,"end_character":41},"in_reply_to":"63519c37_e55a7263","updated":"2022-02-22 14:58:18.000000000","message":"Done","commit_id":"43877a84ce6fb28f214f2bf4d5747dea65efd960"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"e87e47a350e59324e8885adf57907242aeab2bf2","unresolved":true,"context_lines":[{"line_number":316,"context_line":"# Delegated host for operating the certificate authority"},{"line_number":317,"context_line":"glance_pki_setup_host: \"{{ openstack_pki_setup_host | default(\u0027localhost\u0027) }}\""},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"# The local address used for the glance node"},{"line_number":320,"context_line":"glance_node_address: \"{{ ansible_host }}\""},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"# Glance server certificate"},{"line_number":323,"context_line":"glance_pki_keys_path: \"{{ glance_pki_dir ~ \u0027/certs/private/\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"63519c37_e55a7263","line":320,"range":{"start_line":319,"start_character":0,"end_line":320,"end_character":41},"in_reply_to":"9164e880_fe4964d4","updated":"2022-02-21 14:13:30.000000000","message":"Is this always the address for br-mgmt? Or is it the address that ansible uses to connect. These could be different particularly in a metal deploy with a separate OOB network.","commit_id":"43877a84ce6fb28f214f2bf4d5747dea65efd960"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"33a1ff199d0e43804c864f2c0ab0f2151df2f3e4","unresolved":true,"context_lines":[{"line_number":316,"context_line":"# Delegated host for operating the certificate authority"},{"line_number":317,"context_line":"glance_pki_setup_host: \"{{ openstack_pki_setup_host | default(\u0027localhost\u0027) }}\""},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"# The local address used for the glance node"},{"line_number":320,"context_line":"glance_node_address: \"{{ ansible_host }}\""},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"# Glance server certificate"},{"line_number":323,"context_line":"glance_pki_keys_path: \"{{ glance_pki_dir ~ \u0027/certs/private/\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9164e880_fe4964d4","line":320,"range":{"start_line":319,"start_character":0,"end_line":320,"end_character":41},"in_reply_to":"a0fc349c_2ae303fe","updated":"2022-02-18 14:38:54.000000000","message":"Just added in case you need to override form some reason in you PKI cert","commit_id":"43877a84ce6fb28f214f2bf4d5747dea65efd960"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"67a43733cbe60437be1b91d897e9f4903b47c358","unresolved":true,"context_lines":[{"line_number":340,"context_line":"glance_pki_install_certificates:"},{"line_number":341,"context_line":"  - src: \"{{ glance_user_ssl_cert | default(glance_pki_certs_path ~ \u0027glance_\u0027 ~ ansible_facts[\u0027hostname\u0027] ~ \u0027-chain.crt\u0027) }}\""},{"line_number":342,"context_line":"    dest: \"{{ glance_ssl_cert }}\""},{"line_number":343,"context_line":"    owner: \"glance\""},{"line_number":344,"context_line":"    group: \"glance\""},{"line_number":345,"context_line":"    mode: \"0644\""},{"line_number":346,"context_line":"  - src: \"{{ glance_user_ssl_key | default(glance_pki_keys_path ~ \u0027glance_\u0027 ~ ansible_facts[\u0027hostname\u0027] ~ \u0027.key.pem\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"cb0c1c8a_c6bc56cf","line":343,"range":{"start_line":343,"start_character":12,"end_line":343,"end_character":18},"updated":"2022-02-17 07:27:26.000000000","message":"\"{{ glance_system_user_name }}\"","commit_id":"43877a84ce6fb28f214f2bf4d5747dea65efd960"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"33a1ff199d0e43804c864f2c0ab0f2151df2f3e4","unresolved":false,"context_lines":[{"line_number":340,"context_line":"glance_pki_install_certificates:"},{"line_number":341,"context_line":"  - src: \"{{ glance_user_ssl_cert | default(glance_pki_certs_path ~ \u0027glance_\u0027 ~ ansible_facts[\u0027hostname\u0027] ~ \u0027-chain.crt\u0027) }}\""},{"line_number":342,"context_line":"    dest: \"{{ glance_ssl_cert }}\""},{"line_number":343,"context_line":"    owner: \"glance\""},{"line_number":344,"context_line":"    group: \"glance\""},{"line_number":345,"context_line":"    mode: \"0644\""},{"line_number":346,"context_line":"  - src: \"{{ glance_user_ssl_key | default(glance_pki_keys_path ~ \u0027glance_\u0027 ~ ansible_facts[\u0027hostname\u0027] ~ \u0027.key.pem\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"d0687b4f_153e3e8b","line":343,"range":{"start_line":343,"start_character":12,"end_line":343,"end_character":18},"in_reply_to":"cb0c1c8a_c6bc56cf","updated":"2022-02-18 14:38:54.000000000","message":"Done","commit_id":"43877a84ce6fb28f214f2bf4d5747dea65efd960"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"67a43733cbe60437be1b91d897e9f4903b47c358","unresolved":true,"context_lines":[{"line_number":341,"context_line":"  - src: \"{{ glance_user_ssl_cert | default(glance_pki_certs_path ~ \u0027glance_\u0027 ~ ansible_facts[\u0027hostname\u0027] ~ \u0027-chain.crt\u0027) }}\""},{"line_number":342,"context_line":"    dest: \"{{ glance_ssl_cert }}\""},{"line_number":343,"context_line":"    owner: \"glance\""},{"line_number":344,"context_line":"    group: \"glance\""},{"line_number":345,"context_line":"    mode: \"0644\""},{"line_number":346,"context_line":"  - src: \"{{ glance_user_ssl_key | default(glance_pki_keys_path ~ \u0027glance_\u0027 ~ ansible_facts[\u0027hostname\u0027] ~ \u0027.key.pem\u0027) }}\""},{"line_number":347,"context_line":"    dest: \"{{ glance_ssl_key }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7bda3218_598e7c9f","line":344,"range":{"start_line":344,"start_character":12,"end_line":344,"end_character":18},"updated":"2022-02-17 07:27:26.000000000","message":"\"{{ glance_system_group_name }}\"","commit_id":"43877a84ce6fb28f214f2bf4d5747dea65efd960"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"33a1ff199d0e43804c864f2c0ab0f2151df2f3e4","unresolved":false,"context_lines":[{"line_number":341,"context_line":"  - src: \"{{ glance_user_ssl_cert | default(glance_pki_certs_path ~ \u0027glance_\u0027 ~ ansible_facts[\u0027hostname\u0027] ~ \u0027-chain.crt\u0027) }}\""},{"line_number":342,"context_line":"    dest: \"{{ glance_ssl_cert }}\""},{"line_number":343,"context_line":"    owner: \"glance\""},{"line_number":344,"context_line":"    group: \"glance\""},{"line_number":345,"context_line":"    mode: \"0644\""},{"line_number":346,"context_line":"  - src: \"{{ glance_user_ssl_key | default(glance_pki_keys_path ~ \u0027glance_\u0027 ~ ansible_facts[\u0027hostname\u0027] ~ \u0027.key.pem\u0027) }}\""},{"line_number":347,"context_line":"    dest: \"{{ glance_ssl_key }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"043ee28e_d330eb7e","line":344,"range":{"start_line":344,"start_character":12,"end_line":344,"end_character":18},"in_reply_to":"7bda3218_598e7c9f","updated":"2022-02-18 14:38:54.000000000","message":"Done","commit_id":"43877a84ce6fb28f214f2bf4d5747dea65efd960"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"67a43733cbe60437be1b91d897e9f4903b47c358","unresolved":true,"context_lines":[{"line_number":345,"context_line":"    mode: \"0644\""},{"line_number":346,"context_line":"  - src: \"{{ glance_user_ssl_key | default(glance_pki_keys_path ~ \u0027glance_\u0027 ~ ansible_facts[\u0027hostname\u0027] ~ \u0027.key.pem\u0027) }}\""},{"line_number":347,"context_line":"    dest: \"{{ glance_ssl_key }}\""},{"line_number":348,"context_line":"    owner: \"glance\""},{"line_number":349,"context_line":"    group: \"glance\""},{"line_number":350,"context_line":"    mode: \"0600\""},{"line_number":351,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"2bd3434b_09d07157","line":348,"range":{"start_line":348,"start_character":12,"end_line":348,"end_character":18},"updated":"2022-02-17 07:27:26.000000000","message":"\"{{ glance_system_user_name }}\"","commit_id":"43877a84ce6fb28f214f2bf4d5747dea65efd960"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"33a1ff199d0e43804c864f2c0ab0f2151df2f3e4","unresolved":false,"context_lines":[{"line_number":345,"context_line":"    mode: \"0644\""},{"line_number":346,"context_line":"  - src: \"{{ glance_user_ssl_key | default(glance_pki_keys_path ~ \u0027glance_\u0027 ~ ansible_facts[\u0027hostname\u0027] ~ \u0027.key.pem\u0027) }}\""},{"line_number":347,"context_line":"    dest: \"{{ glance_ssl_key }}\""},{"line_number":348,"context_line":"    owner: \"glance\""},{"line_number":349,"context_line":"    group: \"glance\""},{"line_number":350,"context_line":"    mode: \"0600\""},{"line_number":351,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"c65de3eb_6c948ed5","line":348,"range":{"start_line":348,"start_character":12,"end_line":348,"end_character":18},"in_reply_to":"2bd3434b_09d07157","updated":"2022-02-18 14:38:54.000000000","message":"Done","commit_id":"43877a84ce6fb28f214f2bf4d5747dea65efd960"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"67a43733cbe60437be1b91d897e9f4903b47c358","unresolved":true,"context_lines":[{"line_number":346,"context_line":"  - src: \"{{ glance_user_ssl_key | default(glance_pki_keys_path ~ \u0027glance_\u0027 ~ ansible_facts[\u0027hostname\u0027] ~ \u0027.key.pem\u0027) }}\""},{"line_number":347,"context_line":"    dest: \"{{ glance_ssl_key }}\""},{"line_number":348,"context_line":"    owner: \"glance\""},{"line_number":349,"context_line":"    group: \"glance\""},{"line_number":350,"context_line":"    mode: \"0600\""},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"# Define user-provided SSL certificates in:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"815aaf30_8f29eda9","line":349,"range":{"start_line":349,"start_character":12,"end_line":349,"end_character":18},"updated":"2022-02-17 07:27:26.000000000","message":"\"{{ glance_system_group_name }}\"","commit_id":"43877a84ce6fb28f214f2bf4d5747dea65efd960"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"33a1ff199d0e43804c864f2c0ab0f2151df2f3e4","unresolved":false,"context_lines":[{"line_number":346,"context_line":"  - src: \"{{ glance_user_ssl_key | default(glance_pki_keys_path ~ \u0027glance_\u0027 ~ ansible_facts[\u0027hostname\u0027] ~ \u0027.key.pem\u0027) }}\""},{"line_number":347,"context_line":"    dest: \"{{ glance_ssl_key }}\""},{"line_number":348,"context_line":"    owner: \"glance\""},{"line_number":349,"context_line":"    group: \"glance\""},{"line_number":350,"context_line":"    mode: \"0600\""},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"# Define user-provided SSL certificates in:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"5f32d3bd_0950a770","line":349,"range":{"start_line":349,"start_character":12,"end_line":349,"end_character":18},"in_reply_to":"815aaf30_8f29eda9","updated":"2022-02-18 14:38:54.000000000","message":"Done","commit_id":"43877a84ce6fb28f214f2bf4d5747dea65efd960"}],"releasenotes/notes/add-glance-tls-2aaf35f49df9b7eb.yaml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"bb3e0712ca959d16409c47ebafff8d71c918c755","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Enable support for TLS to API. TLS is enable by setting ``glance_https`` to"},{"line_number":5,"context_line":"    ``True``. By default glance will use a self-signed certificate generated"},{"line_number":6,"context_line":"    during the deployment process using the pki role. User provided certificates"},{"line_number":7,"context_line":"    can be used by setting the ``glance_user_ssl_cert`` and"},{"line_number":8,"context_line":"    ``glance_user_ssl_key`` variables."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3eb106fc_52277090","line":8,"range":{"start_line":1,"start_character":0,"end_line":8,"end_character":38},"updated":"2021-12-10 12:30:06.000000000","message":"I think it makes sense to land general release note rather then for each specific service. I guess we aim to cover most of them during release cycle?","commit_id":"0a88154f7557f478e79b514d1dd80375a9fc54fb"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"62225fea3a166792062fc1f5cc41d6250fe1a4a4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Enable support for TLS to API. TLS is enable by setting ``glance_https`` to"},{"line_number":5,"context_line":"    ``True``. By default glance will use a self-signed certificate generated"},{"line_number":6,"context_line":"    during the deployment process using the pki role. User provided certificates"},{"line_number":7,"context_line":"    can be used by setting the ``glance_user_ssl_cert`` and"},{"line_number":8,"context_line":"    ``glance_user_ssl_key`` variables."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"2bd98279_3155afa7","line":8,"range":{"start_line":1,"start_character":0,"end_line":8,"end_character":38},"in_reply_to":"3eb106fc_52277090","updated":"2022-11-16 20:35:00.000000000","message":"Done","commit_id":"0a88154f7557f478e79b514d1dd80375a9fc54fb"}],"releasenotes/notes/add-tls-db94efcc6655d331.yaml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"9b2095308bebd128d1e9aa2cc368233f274afe91","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Enable support for TLS to API. TLS is enable by setting ``glance_https`` to"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a4cbc66_834e9e9f","line":1,"updated":"2021-12-09 07:54:01.000000000","message":"add-glance-tls-\u003chash\u003e is probably a better name for when all of the release notes get aggregated into the openstack-ansible repo for publication","commit_id":"321a9f1d2b098d379de2d339460f2fc3ba2faa70"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"d1e8c61543942558ff043064f9d72cb5d5bf4c81","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Enable support for TLS to API. TLS is enable by setting ``glance_https`` to"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"19d39f2f_e1016af3","line":1,"in_reply_to":"1a4cbc66_834e9e9f","updated":"2021-12-09 07:59:31.000000000","message":"Done","commit_id":"321a9f1d2b098d379de2d339460f2fc3ba2faa70"}],"tasks/main.yml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"6d1bebf325832dd817ec84dadd6f4cc1b59ede94","unresolved":true,"context_lines":[{"line_number":86,"context_line":"  vars:"},{"line_number":87,"context_line":"    pki_setup_host: \"{{ glance_pki_setup_host }}\""},{"line_number":88,"context_line":"    pki_dir: \"{{ glance_pki_dir }}\""},{"line_number":89,"context_line":"    pki_authorities: \"{{ glance_pki_authorities }}\""},{"line_number":90,"context_line":"    pki_create_certificates: \"{{ glance_user_ssl_cert is not defined and glance_user_ssl_key is not defined }}\""},{"line_number":91,"context_line":"    pki_regen_cert: \"{{ glance_pki_regen_cert }}\""},{"line_number":92,"context_line":"    pki_certificates: \"{{ glance_pki_certificates }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3ae2adfd_56e288ad","line":89,"range":{"start_line":89,"start_character":4,"end_line":89,"end_character":19},"updated":"2021-12-09 08:01:04.000000000","message":"I think that this is only needed when creating a CA, in this case it\u0027s server certs only so it feels like this can be omitted.","commit_id":"321a9f1d2b098d379de2d339460f2fc3ba2faa70"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"6d1bebf325832dd817ec84dadd6f4cc1b59ede94","unresolved":true,"context_lines":[{"line_number":86,"context_line":"  vars:"},{"line_number":87,"context_line":"    pki_setup_host: \"{{ glance_pki_setup_host }}\""},{"line_number":88,"context_line":"    pki_dir: \"{{ glance_pki_dir }}\""},{"line_number":89,"context_line":"    pki_authorities: \"{{ glance_pki_authorities }}\""},{"line_number":90,"context_line":"    pki_create_certificates: \"{{ glance_user_ssl_cert is not defined and glance_user_ssl_key is not defined }}\""},{"line_number":91,"context_line":"    pki_regen_cert: \"{{ glance_pki_regen_cert }}\""},{"line_number":92,"context_line":"    pki_certificates: \"{{ glance_pki_certificates }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ea747e71_4a346515","line":89,"range":{"start_line":89,"start_character":25,"end_line":89,"end_character":47},"updated":"2021-12-09 08:01:04.000000000","message":"this isn\u0027t defined","commit_id":"321a9f1d2b098d379de2d339460f2fc3ba2faa70"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"7850f4609b4336db20bd587cdbbfb37f3df49904","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  vars:"},{"line_number":87,"context_line":"    pki_setup_host: \"{{ glance_pki_setup_host }}\""},{"line_number":88,"context_line":"    pki_dir: \"{{ glance_pki_dir }}\""},{"line_number":89,"context_line":"    pki_authorities: \"{{ glance_pki_authorities }}\""},{"line_number":90,"context_line":"    pki_create_certificates: \"{{ glance_user_ssl_cert is not defined and glance_user_ssl_key is not defined }}\""},{"line_number":91,"context_line":"    pki_regen_cert: \"{{ glance_pki_regen_cert }}\""},{"line_number":92,"context_line":"    pki_certificates: \"{{ glance_pki_certificates }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6c0e6584_2f84a538","line":89,"range":{"start_line":89,"start_character":4,"end_line":89,"end_character":19},"in_reply_to":"3ae2adfd_56e288ad","updated":"2021-12-09 08:06:25.000000000","message":"Done","commit_id":"321a9f1d2b098d379de2d339460f2fc3ba2faa70"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"7850f4609b4336db20bd587cdbbfb37f3df49904","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  vars:"},{"line_number":87,"context_line":"    pki_setup_host: \"{{ glance_pki_setup_host }}\""},{"line_number":88,"context_line":"    pki_dir: \"{{ glance_pki_dir }}\""},{"line_number":89,"context_line":"    pki_authorities: \"{{ glance_pki_authorities }}\""},{"line_number":90,"context_line":"    pki_create_certificates: \"{{ glance_user_ssl_cert is not defined and glance_user_ssl_key is not defined }}\""},{"line_number":91,"context_line":"    pki_regen_cert: \"{{ glance_pki_regen_cert }}\""},{"line_number":92,"context_line":"    pki_certificates: \"{{ glance_pki_certificates }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"527b2c4a_419e5a1e","line":89,"range":{"start_line":89,"start_character":25,"end_line":89,"end_character":47},"in_reply_to":"ea747e71_4a346515","updated":"2021-12-09 08:06:25.000000000","message":"Done","commit_id":"321a9f1d2b098d379de2d339460f2fc3ba2faa70"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"bb3e0712ca959d16409c47ebafff8d71c918c755","unresolved":true,"context_lines":[{"line_number":80,"context_line":"    - glance-install"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"- name: Create and install SSL certificates"},{"line_number":83,"context_line":"  include_role:"},{"line_number":84,"context_line":"    name: pki"},{"line_number":85,"context_line":"    tasks_from: main_certs.yml"},{"line_number":86,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"85b8c08f_6348ebe4","line":83,"range":{"start_line":83,"start_character":2,"end_line":83,"end_character":14},"updated":"2021-12-10 12:30:06.000000000","message":"While we don\u0027t have tags specificed in pki role, I think I\u0027d cover this use case if we decide to add them one day.\nSo probably used tags always here and might be applied smth like pki and glance-config, dunno.\n\nBut imo we should think about tags here while it\u0027s not too late.","commit_id":"0a88154f7557f478e79b514d1dd80375a9fc54fb"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"d48066e771cea1e069909200539e360eef73a22a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    - glance-install"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"- name: Create and install SSL certificates"},{"line_number":83,"context_line":"  include_role:"},{"line_number":84,"context_line":"    name: pki"},{"line_number":85,"context_line":"    tasks_from: main_certs.yml"},{"line_number":86,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1fff91f8_059543dc","line":83,"range":{"start_line":83,"start_character":2,"end_line":83,"end_character":14},"in_reply_to":"85b8c08f_6348ebe4","updated":"2022-02-16 09:33:01.000000000","message":"Done","commit_id":"0a88154f7557f478e79b514d1dd80375a9fc54fb"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"67a43733cbe60437be1b91d897e9f4903b47c358","unresolved":true,"context_lines":[{"line_number":104,"context_line":"    pki_install_certificates: \"{{ glance_pki_install_certificates }}\""},{"line_number":105,"context_line":"  when:"},{"line_number":106,"context_line":"    - glance_backend_https"},{"line_number":107,"context_line":"    - glance-config"},{"line_number":108,"context_line":"    - pki"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"- import_tasks: glance_post_install.yml"},{"line_number":111,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"774f95f6_a5e85aea","line":108,"range":{"start_line":107,"start_character":6,"end_line":108,"end_character":9},"updated":"2022-02-17 07:27:26.000000000","message":"are these two actually tags?","commit_id":"43877a84ce6fb28f214f2bf4d5747dea65efd960"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"67a43733cbe60437be1b91d897e9f4903b47c358","unresolved":true,"context_lines":[{"line_number":105,"context_line":"  when:"},{"line_number":106,"context_line":"    - glance_backend_https"},{"line_number":107,"context_line":"    - glance-config"},{"line_number":108,"context_line":"    - pki"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"- import_tasks: glance_post_install.yml"},{"line_number":111,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"620e3e35_9d8555b3","line":108,"range":{"start_line":108,"start_character":6,"end_line":108,"end_character":9},"updated":"2022-02-17 07:27:26.000000000","message":"what is this?","commit_id":"43877a84ce6fb28f214f2bf4d5747dea65efd960"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"33a1ff199d0e43804c864f2c0ab0f2151df2f3e4","unresolved":false,"context_lines":[{"line_number":105,"context_line":"  when:"},{"line_number":106,"context_line":"    - glance_backend_https"},{"line_number":107,"context_line":"    - glance-config"},{"line_number":108,"context_line":"    - pki"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"- import_tasks: glance_post_install.yml"},{"line_number":111,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ffcf85c6_8e9fc6b5","line":108,"range":{"start_line":108,"start_character":6,"end_line":108,"end_character":9},"in_reply_to":"620e3e35_9d8555b3","updated":"2022-02-18 14:38:54.000000000","message":"Done","commit_id":"43877a84ce6fb28f214f2bf4d5747dea65efd960"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"33a1ff199d0e43804c864f2c0ab0f2151df2f3e4","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    pki_install_certificates: \"{{ glance_pki_install_certificates }}\""},{"line_number":105,"context_line":"  when:"},{"line_number":106,"context_line":"    - glance_backend_https"},{"line_number":107,"context_line":"    - glance-config"},{"line_number":108,"context_line":"    - pki"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"- import_tasks: glance_post_install.yml"},{"line_number":111,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"a9947d5b_c36deccd","line":108,"range":{"start_line":107,"start_character":6,"end_line":108,"end_character":9},"in_reply_to":"774f95f6_a5e85aea","updated":"2022-02-18 14:38:54.000000000","message":"Yeah were meant to be tags, have changed","commit_id":"43877a84ce6fb28f214f2bf4d5747dea65efd960"}]}