)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"054a375a4bcdc412708e86142231f63ad779eb65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bd19b728_d40fd7ac","updated":"2023-04-21 07:07:37.000000000","message":"recheck - tempest failed for openstack-ansible-deploy-aio_nfs-ubuntu-focal","commit_id":"fafd49959e0f2c77dc29b9b35f1ff5a1360b0c0e"}],"defaults/main.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"bfc84a2d0a3e31e92791b153e9d7ceef982abde5","unresolved":true,"context_lines":[{"line_number":81,"context_line":"glance_additional_stores:"},{"line_number":82,"context_line":"  - http"},{"line_number":83,"context_line":"  - cinder"},{"line_number":84,"context_line":"_glance_available_stores: \"{{ [ glance_default_store ] + glance_additional_stores }}\""},{"line_number":85,"context_line":"glance_flavor: \"{% if glance_default_store \u003d\u003d \u0027rbd\u0027 %}keystone{% else %}keystone+cachemanagement{% endif %}\""},{"line_number":86,"context_line":"glance_show_image_direct_url: \"{{ glance_default_store \u003d\u003d \u0027rbd\u0027 }}\""},{"line_number":87,"context_line":"glance_show_multiple_locations: \"{{ glance_default_store \u003d\u003d \u0027rbd\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f2257b3_b8faf84d","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":24},"updated":"2023-04-20 14:22:43.000000000","message":"naming of variables in defaults should not start with underscore.\n\nUnderscore symbolize that the variable is local and should not be used or touched outside of the role. I know that PEP rules should not be applicable in ansible, but it\u0027s less mind-blowing to follow them then not: https://peps.python.org/pep-0008/#method-names-and-instance-variables","commit_id":"b3c643034c539de33fc666eb7dd7cb3a1a5e0949"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"550ef9e7a421bac9ef3bfd3d4ee9be2edd5a083e","unresolved":false,"context_lines":[{"line_number":81,"context_line":"glance_additional_stores:"},{"line_number":82,"context_line":"  - http"},{"line_number":83,"context_line":"  - cinder"},{"line_number":84,"context_line":"_glance_available_stores: \"{{ [ glance_default_store ] + glance_additional_stores }}\""},{"line_number":85,"context_line":"glance_flavor: \"{% if glance_default_store \u003d\u003d \u0027rbd\u0027 %}keystone{% else %}keystone+cachemanagement{% endif %}\""},{"line_number":86,"context_line":"glance_show_image_direct_url: \"{{ glance_default_store \u003d\u003d \u0027rbd\u0027 }}\""},{"line_number":87,"context_line":"glance_show_multiple_locations: \"{{ glance_default_store \u003d\u003d \u0027rbd\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"febb4f57_a1d0d650","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":24},"in_reply_to":"3f2257b3_b8faf84d","updated":"2023-04-20 19:12:52.000000000","message":"i remember that some time ago you said that variables that are not supposed to be overridden manually by the user should have `_` prefix, so that\u0027s why I didn\u0027t remove it.\n\nIt\u0027s fixed now. I assume we don\u0027t need a release note about variable name change because users are not supposed to define this variable anyway?","commit_id":"b3c643034c539de33fc666eb7dd7cb3a1a5e0949"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"a4aabde42882e137c8c7974dff5d0dd4fa94260c","unresolved":true,"context_lines":[{"line_number":81,"context_line":"glance_additional_stores:"},{"line_number":82,"context_line":"  - http"},{"line_number":83,"context_line":"  - cinder"},{"line_number":84,"context_line":"_glance_available_stores: \"{{ [ glance_default_store ] + glance_additional_stores }}\""},{"line_number":85,"context_line":"glance_flavor: \"{% if glance_default_store \u003d\u003d \u0027rbd\u0027 %}keystone{% else %}keystone+cachemanagement{% endif %}\""},{"line_number":86,"context_line":"glance_show_image_direct_url: \"{{ glance_default_store \u003d\u003d \u0027rbd\u0027 }}\""},{"line_number":87,"context_line":"glance_show_multiple_locations: \"{{ glance_default_store \u003d\u003d \u0027rbd\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"eb7473e7_2f003164","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":24},"in_reply_to":"febb4f57_a1d0d650","updated":"2023-04-24 14:26:37.000000000","message":"Well, they were not supposed to. But we do generate docs out of defaults/main content. So whatever is in defaults we assume can be overriden.\n\nNo, reno is not needed as indeed var wasn\u0027t intended to be used before.","commit_id":"b3c643034c539de33fc666eb7dd7cb3a1a5e0949"}]}