)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"6c9fc1fcf89a949da96c18adfff13bd514565337","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"eef8ea6a_5cf45ed4","updated":"2024-02-22 16:08:59.000000000","message":"Thanks a lot for proposing that. It is really a good feature we\u0027d need to land. I have couple of \"nits\" though.","commit_id":"3fbbfc81b7774717d424c9dcfcc58b90ef129086"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"a6955e506053446f3047c85214b3252518532273","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a8b2a82b_67ab313e","updated":"2024-02-28 08:08:46.000000000","message":"Actually, 1 more thing... Would be great if you could add a release not briefly describing a new feature.\nWe manage release notes through `reno` tool: https://docs.openstack.org/reno/latest/user/usage.html","commit_id":"ff5420acef132865410def44bc2698a7c40d29ca"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"68f3b3c550cca7e2ba6c9062cbbf9b1d5d84d910","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3af0bc0f_e73f5b5f","updated":"2024-02-28 08:07:30.000000000","message":"lgtm","commit_id":"ff5420acef132865410def44bc2698a7c40d29ca"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"98a80fd122d7da6741ca61729ca89b7f87fc7faa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ff6222bd_fdfa7678","updated":"2024-02-28 09:31:39.000000000","message":"awesome, thanks!","commit_id":"e8de2a5f0b2faeb0774e60d5c5c8ff15b1139c02"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"82e3fbaa4c79458446c762ebdb1c5b07db3ff0cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bd0c562a_5eb075a6","updated":"2024-03-06 09:34:35.000000000","message":"recheck upgrade job","commit_id":"e8de2a5f0b2faeb0774e60d5c5c8ff15b1139c02"}],"defaults/main.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"6c9fc1fcf89a949da96c18adfff13bd514565337","unresolved":true,"context_lines":[{"line_number":395,"context_line":""},{"line_number":396,"context_line":"# Glance property protection"},{"line_number":397,"context_line":"# Name of property protections file, for example \"glance_property_protection_file: property-protection.conf\""},{"line_number":398,"context_line":"glance_property_protection_file: \"\""},{"line_number":399,"context_line":"glance_property_protection_rule_format: roles"},{"line_number":400,"context_line":"# Expected dict structure example:"},{"line_number":401,"context_line":"# glance_property_protection_file_overrides:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a37a0f01_d367611d","line":398,"range":{"start_line":398,"start_character":33,"end_line":398,"end_character":35},"updated":"2024-02-22 16:08:59.000000000","message":"let\u0027s add a default path for the file location. Don\u0027t see any need to define that per deployment.","commit_id":"3fbbfc81b7774717d424c9dcfcc58b90ef129086"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"af669180cf56314b6a1f5b927ceb68a2c6a14b50","unresolved":true,"context_lines":[{"line_number":400,"context_line":"# Expected dict structure example:"},{"line_number":401,"context_line":"# glance_property_protection_file_overrides:"},{"line_number":402,"context_line":"#   protected_property1:"},{"line_number":403,"context_line":"#     create: admin,member,reader,_member_"},{"line_number":404,"context_line":"#     read: admin,member,reader,_member_"},{"line_number":405,"context_line":"#     update: admin"},{"line_number":406,"context_line":"#     delete: admin"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bb377275_30e44651","line":403,"range":{"start_line":403,"start_character":34,"end_line":403,"end_character":42},"updated":"2024-02-24 09:18:54.000000000","message":"should we be introducing new places that use _ member _ when this is deprecated?","commit_id":"3fbbfc81b7774717d424c9dcfcc58b90ef129086"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"34a8316b08115de2d9d488b1651e7182d7a68607","unresolved":true,"context_lines":[{"line_number":400,"context_line":"# Expected dict structure example:"},{"line_number":401,"context_line":"# glance_property_protection_file_overrides:"},{"line_number":402,"context_line":"#   protected_property1:"},{"line_number":403,"context_line":"#     create: admin,member,reader,_member_"},{"line_number":404,"context_line":"#     read: admin,member,reader,_member_"},{"line_number":405,"context_line":"#     update: admin"},{"line_number":406,"context_line":"#     delete: admin"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c7375d5a_5596ebe4","line":403,"range":{"start_line":403,"start_character":34,"end_line":403,"end_character":42},"in_reply_to":"bb377275_30e44651","updated":"2024-02-27 12:15:55.000000000","message":"nah, we should drop `_member_` here.","commit_id":"3fbbfc81b7774717d424c9dcfcc58b90ef129086"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"78b6bb6a6125bdf6b67128efc17f8f596c7bd68b","unresolved":true,"context_lines":[{"line_number":404,"context_line":"#     read: admin,member,reader,_member_"},{"line_number":405,"context_line":"#     update: admin"},{"line_number":406,"context_line":"#     delete: admin"},{"line_number":407,"context_line":"#   .*:"},{"line_number":408,"context_line":"#     create: admin,member,reader,_member_"},{"line_number":409,"context_line":"#     read: admin,member,reader,_member_"},{"line_number":410,"context_line":"#     update: admin,member,_member_"},{"line_number":411,"context_line":"#     delete: admin,member,_member_"},{"line_number":412,"context_line":"glance_property_protection_file_overrides: {}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"271d5a21_9dd34f81","line":411,"range":{"start_line":407,"start_character":0,"end_line":411,"end_character":35},"updated":"2024-02-24 09:21:06.000000000","message":"i don\u0027t know if it is valid to always deploy this section as \"sensible defaults\", or if there would be unintended side effects of that for existing deployments.\n\nif we did deploy a default set it would make the logic in other parts of this patch simpler or even not required","commit_id":"3fbbfc81b7774717d424c9dcfcc58b90ef129086"},{"author":{"_account_id":35983,"name":"Aleksandr Chudinov","email":"silentirk@me.com","username":"silentirk"},"change_message_id":"f97aadac7434c54feb24891def7a78ee95e1de00","unresolved":true,"context_lines":[{"line_number":404,"context_line":"#     read: admin,member,reader,_member_"},{"line_number":405,"context_line":"#     update: admin"},{"line_number":406,"context_line":"#     delete: admin"},{"line_number":407,"context_line":"#   .*:"},{"line_number":408,"context_line":"#     create: admin,member,reader,_member_"},{"line_number":409,"context_line":"#     read: admin,member,reader,_member_"},{"line_number":410,"context_line":"#     update: admin,member,_member_"},{"line_number":411,"context_line":"#     delete: admin,member,_member_"},{"line_number":412,"context_line":"glance_property_protection_file_overrides: {}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"64ee0a92_e3dbf3b4","line":411,"range":{"start_line":407,"start_character":0,"end_line":411,"end_character":35},"in_reply_to":"271d5a21_9dd34f81","updated":"2024-02-26 08:12:36.000000000","message":"Property protections is not something enabled by default in glance afaics so maybe better to don\u0027t turn them on by default to avoid unintended side effects.","commit_id":"3fbbfc81b7774717d424c9dcfcc58b90ef129086"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"34a8316b08115de2d9d488b1651e7182d7a68607","unresolved":true,"context_lines":[{"line_number":404,"context_line":"#     read: admin,member,reader,_member_"},{"line_number":405,"context_line":"#     update: admin"},{"line_number":406,"context_line":"#     delete: admin"},{"line_number":407,"context_line":"#   .*:"},{"line_number":408,"context_line":"#     create: admin,member,reader,_member_"},{"line_number":409,"context_line":"#     read: admin,member,reader,_member_"},{"line_number":410,"context_line":"#     update: admin,member,_member_"},{"line_number":411,"context_line":"#     delete: admin,member,_member_"},{"line_number":412,"context_line":"glance_property_protection_file_overrides: {}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a7f600b0_94c345d3","line":411,"range":{"start_line":407,"start_character":0,"end_line":411,"end_character":35},"in_reply_to":"64ee0a92_e3dbf3b4","updated":"2024-02-27 12:15:55.000000000","message":"+1, let\u0027s not enable them be default.","commit_id":"3fbbfc81b7774717d424c9dcfcc58b90ef129086"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"6c9fc1fcf89a949da96c18adfff13bd514565337","unresolved":true,"context_lines":[{"line_number":409,"context_line":"#     read: admin,member,reader,_member_"},{"line_number":410,"context_line":"#     update: admin,member,_member_"},{"line_number":411,"context_line":"#     delete: admin,member,_member_"},{"line_number":412,"context_line":"glance_property_protection_file_overrides: {}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"305776ba_2930b337","line":412,"range":{"start_line":412,"start_character":0,"end_line":412,"end_character":41},"updated":"2024-02-22 16:08:59.000000000","message":"Let\u0027s also call that like... `glance_property_protection_file_content`? as this is basically content - no default content is expected here.","commit_id":"3fbbfc81b7774717d424c9dcfcc58b90ef129086"},{"author":{"_account_id":35983,"name":"Aleksandr Chudinov","email":"silentirk@me.com","username":"silentirk"},"change_message_id":"f97aadac7434c54feb24891def7a78ee95e1de00","unresolved":true,"context_lines":[{"line_number":409,"context_line":"#     read: admin,member,reader,_member_"},{"line_number":410,"context_line":"#     update: admin,member,_member_"},{"line_number":411,"context_line":"#     delete: admin,member,_member_"},{"line_number":412,"context_line":"glance_property_protection_file_overrides: {}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6f2a7ccc_fc3452be","line":412,"range":{"start_line":412,"start_character":0,"end_line":412,"end_character":41},"in_reply_to":"305776ba_2930b337","updated":"2024-02-26 08:12:36.000000000","message":"Won\u0027t it bring some confusion, as \u0027content\u0027 supposes .ini format? It would be less confusing then to pass it as \u0027content\u0027 parameter to openstack.config_template.config_template module. For me it\u0027s not really critical, as I may set variable like this:\nglance_property_protection_file_content: |\n  [.*]\n  create \u003d admin,member...\nThough I\u0027m not sure if this is a really idiomatic way here...","commit_id":"3fbbfc81b7774717d424c9dcfcc58b90ef129086"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"34a8316b08115de2d9d488b1651e7182d7a68607","unresolved":true,"context_lines":[{"line_number":409,"context_line":"#     read: admin,member,reader,_member_"},{"line_number":410,"context_line":"#     update: admin,member,_member_"},{"line_number":411,"context_line":"#     delete: admin,member,_member_"},{"line_number":412,"context_line":"glance_property_protection_file_overrides: {}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e0552182_dea00c63","line":412,"range":{"start_line":412,"start_character":0,"end_line":412,"end_character":41},"in_reply_to":"6f2a7ccc_fc3452be","updated":"2024-02-27 12:15:55.000000000","message":"Oh, yes, ok, makes sense then. We can actually leave it as is.\n\nI guess I was mostly thinking about the usecase, where you wanna have same \"base\" content, and then extend it by some overrides in group_vars, instead of defining a content twice.\n\nBut given it\u0027s glance, and it shouldn\u0027t differ between hosts, this usecase probably is not valid one.","commit_id":"3fbbfc81b7774717d424c9dcfcc58b90ef129086"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"68f3b3c550cca7e2ba6c9062cbbf9b1d5d84d910","unresolved":false,"context_lines":[{"line_number":409,"context_line":"#     read: admin,member,reader,_member_"},{"line_number":410,"context_line":"#     update: admin,member,_member_"},{"line_number":411,"context_line":"#     delete: admin,member,_member_"},{"line_number":412,"context_line":"glance_property_protection_file_overrides: {}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b8ce7e68_153134ca","line":412,"range":{"start_line":412,"start_character":0,"end_line":412,"end_character":41},"in_reply_to":"e0552182_dea00c63","updated":"2024-02-28 08:07:30.000000000","message":"Done","commit_id":"3fbbfc81b7774717d424c9dcfcc58b90ef129086"}],"tasks/glance_post_install.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"6c9fc1fcf89a949da96c18adfff13bd514565337","unresolved":true,"context_lines":[{"line_number":84,"context_line":"    owner: \"root\""},{"line_number":85,"context_line":"    group: \"{{ glance_system_group_name }}\""},{"line_number":86,"context_line":"    mode: \"0640\""},{"line_number":87,"context_line":"    config_overrides: \"{{ glance_property_protection_file_overrides }}\""},{"line_number":88,"context_line":"  when: glance_property_protection_file | length \u003e 0"},{"line_number":89,"context_line":"  tags:"},{"line_number":90,"context_line":"    - glance-property-protection"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3885cdfd_ec91b6f9","line":87,"range":{"start_line":87,"start_character":4,"end_line":87,"end_character":20},"updated":"2024-02-22 16:08:59.000000000","message":"this actually can be `content` as well. and there\u0027s possibility to have overrides to the content, fwiw.\nbut I\u0027m fine keeping it as overrides as well - doesn\u0027t matter much I guess.","commit_id":"3fbbfc81b7774717d424c9dcfcc58b90ef129086"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"68f3b3c550cca7e2ba6c9062cbbf9b1d5d84d910","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    owner: \"root\""},{"line_number":85,"context_line":"    group: \"{{ glance_system_group_name }}\""},{"line_number":86,"context_line":"    mode: \"0640\""},{"line_number":87,"context_line":"    config_overrides: \"{{ glance_property_protection_file_overrides }}\""},{"line_number":88,"context_line":"  when: glance_property_protection_file | length \u003e 0"},{"line_number":89,"context_line":"  tags:"},{"line_number":90,"context_line":"    - glance-property-protection"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"724980a7_6e294085","line":87,"range":{"start_line":87,"start_character":4,"end_line":87,"end_character":20},"in_reply_to":"3885cdfd_ec91b6f9","updated":"2024-02-28 08:07:30.000000000","message":"Done","commit_id":"3fbbfc81b7774717d424c9dcfcc58b90ef129086"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"6c9fc1fcf89a949da96c18adfff13bd514565337","unresolved":true,"context_lines":[{"line_number":85,"context_line":"    group: \"{{ glance_system_group_name }}\""},{"line_number":86,"context_line":"    mode: \"0640\""},{"line_number":87,"context_line":"    config_overrides: \"{{ glance_property_protection_file_overrides }}\""},{"line_number":88,"context_line":"  when: glance_property_protection_file | length \u003e 0"},{"line_number":89,"context_line":"  tags:"},{"line_number":90,"context_line":"    - glance-property-protection"},{"line_number":91,"context_line":"  notify:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2519e98e_5c765b97","line":88,"range":{"start_line":88,"start_character":8,"end_line":88,"end_character":39},"updated":"2024-02-22 16:08:59.000000000","message":"`glance_property_protection_file_overrides`","commit_id":"3fbbfc81b7774717d424c9dcfcc58b90ef129086"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"68f3b3c550cca7e2ba6c9062cbbf9b1d5d84d910","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    group: \"{{ glance_system_group_name }}\""},{"line_number":86,"context_line":"    mode: \"0640\""},{"line_number":87,"context_line":"    config_overrides: \"{{ glance_property_protection_file_overrides }}\""},{"line_number":88,"context_line":"  when: glance_property_protection_file | length \u003e 0"},{"line_number":89,"context_line":"  tags:"},{"line_number":90,"context_line":"    - glance-property-protection"},{"line_number":91,"context_line":"  notify:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d0bd0b51_04197cd7","line":88,"range":{"start_line":88,"start_character":8,"end_line":88,"end_character":39},"in_reply_to":"2519e98e_5c765b97","updated":"2024-02-28 08:07:30.000000000","message":"Done","commit_id":"3fbbfc81b7774717d424c9dcfcc58b90ef129086"}],"templates/glance-api.conf.j2":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"6c9fc1fcf89a949da96c18adfff13bd514565337","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"enabled_backends \u003d {% for backend in glance_available_stores %}{{ backend[\u0027name\u0027] }}:{{ backend[\u0027type\u0027] }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"{% if glance_property_protection_file | length \u003e 0 %}"},{"line_number":33,"context_line":"property_protection_file \u003d {{ glance_property_protection_file }}"},{"line_number":34,"context_line":"property_protection_rule_format \u003d {{ glance_property_protection_rule_format }}"},{"line_number":35,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"887cdfb1_eed5a996","line":32,"range":{"start_line":32,"start_character":6,"end_line":32,"end_character":37},"updated":"2024-02-22 16:08:59.000000000","message":"`glance_property_protection_file_overrides`","commit_id":"3fbbfc81b7774717d424c9dcfcc58b90ef129086"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"68f3b3c550cca7e2ba6c9062cbbf9b1d5d84d910","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"enabled_backends \u003d {% for backend in glance_available_stores %}{{ backend[\u0027name\u0027] }}:{{ backend[\u0027type\u0027] }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"{% if glance_property_protection_file | length \u003e 0 %}"},{"line_number":33,"context_line":"property_protection_file \u003d {{ glance_property_protection_file }}"},{"line_number":34,"context_line":"property_protection_rule_format \u003d {{ glance_property_protection_rule_format }}"},{"line_number":35,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"a6e51598_a8ee784a","line":32,"range":{"start_line":32,"start_character":6,"end_line":32,"end_character":37},"in_reply_to":"887cdfb1_eed5a996","updated":"2024-02-28 08:07:30.000000000","message":"Done","commit_id":"3fbbfc81b7774717d424c9dcfcc58b90ef129086"}]}