)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"f64c609a36457db46531683f8f2cab2cde33637c","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Enable Barbican Secrets Support for Glance in OpenStack Compute"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Glance was not being configured to use Barbican for secret management when Barbican support was enabled. This patch ensures that Glance is efficiently configured to interact with Barbican, allowing proper handling of secrets (such as image encryption keys) in OpenStack compute environments."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- Adds necessary configuration for Glance to use Barbican as a secrets backend."},{"line_number":12,"context_line":"- Improves integration between Glance and Barbican for secure operations."},{"line_number":13,"context_line":"- Addresses misconfiguration that previously prevented Glance from recognizing Barbican support."},{"line_number":14,"context_line":"- Addressed the review comments...."},{"line_number":15,"context_line":"- Added release note.."},{"line_number":16,"context_line":"Related-Bug: #2118763"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Co-authored-by: Jobin Jospeh \u003cjobinathirampuzha@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"dd444807_2b8f1a10","line":15,"range":{"start_line":10,"start_character":0,"end_line":15,"end_character":22},"updated":"2025-07-25 13:33:14.000000000","message":"You also don\u0027t need to maintain the whole changelog in commit message","commit_id":"245ed9e994f15559b241a628ae02ccf07c4cdc06"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"d84ecdae60c0f9c665a64528815f991621905271","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Enable Barbican Secrets Support for Glance in OpenStack Compute"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Glance was not being configured to use Barbican for secret management when Barbican support was enabled. This patch ensures that Glance is efficiently configured to interact with Barbican, allowing proper handling of secrets (such as image encryption keys) in OpenStack compute environments."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- Adds necessary configuration for Glance to use Barbican as a secrets backend."},{"line_number":12,"context_line":"- Improves integration between Glance and Barbican for secure operations."},{"line_number":13,"context_line":"- Addresses misconfiguration that previously prevented Glance from recognizing Barbican support."},{"line_number":14,"context_line":"- Addressed the review comments...."},{"line_number":15,"context_line":"- Added release note.."},{"line_number":16,"context_line":"Related-Bug: #2118763"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Co-authored-by: Jobin Jospeh \u003cjobinathirampuzha@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"4e4abad4_4e1426f5","line":15,"range":{"start_line":10,"start_character":0,"end_line":15,"end_character":22},"in_reply_to":"dd444807_2b8f1a10","updated":"2025-08-05 12:31:31.000000000","message":"Done","commit_id":"245ed9e994f15559b241a628ae02ccf07c4cdc06"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5ff1a41f5f735586cc1563d2af38cef745ce8344","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"eb1c362d_7bf7f1be","updated":"2025-07-25 12:12:03.000000000","message":"Thanks for pushing that! It looks good overall, just couple of comments.\n\nAlso, can you kindly add a release note mentioning the feature?\n\nA reno tool is used for that: https://docs.openstack.org/reno/latest/user/usage.html","commit_id":"9750bbc028b3b89271b9e4c41a94a5e159d916b0"}],"defaults/main.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2dfa9ebceb2245cda073e4f08c5cf31a604d7666","unresolved":true,"context_lines":[{"line_number":205,"context_line":"## load balancer."},{"line_number":206,"context_line":"glance_proxy_headers_parsing: true"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"# Enable/Disable barbican configurations ### bug/2118763"},{"line_number":209,"context_line":"glance_barbican_enabled: \"{{ (groups[\u0027barbican_all\u0027] is defined) and (groups[\u0027barbican_all\u0027] | length \u003e 0) }}\""},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"## Swift Options"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a5bcff8_b1a6c09f","line":208,"range":{"start_line":208,"start_character":40,"end_line":208,"end_character":56},"updated":"2025-07-25 12:47:25.000000000","message":"no need to reference bug here either, btw","commit_id":"5f2a7d777b78663c7f7506238561f5b913dce347"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"ea81c23de9e97a9815a3d21d47017660ac1f6289","unresolved":false,"context_lines":[{"line_number":205,"context_line":"## load balancer."},{"line_number":206,"context_line":"glance_proxy_headers_parsing: true"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"# Enable/Disable barbican configurations ### bug/2118763"},{"line_number":209,"context_line":"glance_barbican_enabled: \"{{ (groups[\u0027barbican_all\u0027] is defined) and (groups[\u0027barbican_all\u0027] | length \u003e 0) }}\""},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"## Swift Options"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4773d3f9_ba5d0c73","line":208,"range":{"start_line":208,"start_character":40,"end_line":208,"end_character":56},"in_reply_to":"7a5bcff8_b1a6c09f","updated":"2025-07-25 13:31:39.000000000","message":"Done","commit_id":"5f2a7d777b78663c7f7506238561f5b913dce347"}],"releasenotes/notes/glance_barbican_integration-f493d11d6343e3c0.yaml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"ae11db758415c20c00335878ad73ee694218b4b3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features: "},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Enable Barbican Secrets Support for Glance in OpenStack-Ansible, "},{"line_number":5,"context_line":"    Glance was not being configured to use Barbican for secret management when Barbican support was enabled. "}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f128ffa5_80ef3cea","line":2,"range":{"start_line":2,"start_character":9,"end_line":2,"end_character":10},"updated":"2025-07-25 12:54:07.000000000","message":"please, remove trailing whitespaces from the note.","commit_id":"0ef989885a84076343fd101044442f70f33892ee"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"ea81c23de9e97a9815a3d21d47017660ac1f6289","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features: "},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Enable Barbican Secrets Support for Glance in OpenStack-Ansible, "},{"line_number":5,"context_line":"    Glance was not being configured to use Barbican for secret management when Barbican support was enabled. "}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7b3ae0e2_77473168","line":2,"range":{"start_line":2,"start_character":9,"end_line":2,"end_character":10},"in_reply_to":"f128ffa5_80ef3cea","updated":"2025-07-25 13:31:39.000000000","message":"Done","commit_id":"0ef989885a84076343fd101044442f70f33892ee"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"ae11db758415c20c00335878ad73ee694218b4b3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features: "},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Enable Barbican Secrets Support for Glance in OpenStack-Ansible, "},{"line_number":5,"context_line":"    Glance was not being configured to use Barbican for secret management when Barbican support was enabled. "},{"line_number":6,"context_line":"    This patch ensures that Glance is efficiently configured to interact with Barbican, "},{"line_number":7,"context_line":"    allowing proper handling of secrets (such as image encryption keys) in OpenStack compute environments."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"343ac718_688c95b9","line":4,"range":{"start_line":4,"start_character":67,"end_line":4,"end_character":68},"updated":"2025-07-25 12:54:07.000000000","message":"`.`?","commit_id":"0ef989885a84076343fd101044442f70f33892ee"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"ea81c23de9e97a9815a3d21d47017660ac1f6289","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features: "},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Enable Barbican Secrets Support for Glance in OpenStack-Ansible, "},{"line_number":5,"context_line":"    Glance was not being configured to use Barbican for secret management when Barbican support was enabled. "},{"line_number":6,"context_line":"    This patch ensures that Glance is efficiently configured to interact with Barbican, "},{"line_number":7,"context_line":"    allowing proper handling of secrets (such as image encryption keys) in OpenStack compute environments."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9dc2e9b7_86ca5050","line":4,"range":{"start_line":4,"start_character":67,"end_line":4,"end_character":68},"in_reply_to":"343ac718_688c95b9","updated":"2025-07-25 13:31:39.000000000","message":"Done","commit_id":"0ef989885a84076343fd101044442f70f33892ee"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"ae11db758415c20c00335878ad73ee694218b4b3","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features: "},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Enable Barbican Secrets Support for Glance in OpenStack-Ansible, "},{"line_number":5,"context_line":"    Glance was not being configured to use Barbican for secret management when Barbican support was enabled. "},{"line_number":6,"context_line":"    This patch ensures that Glance is efficiently configured to interact with Barbican, "},{"line_number":7,"context_line":"    allowing proper handling of secrets (such as image encryption keys) in OpenStack compute environments."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fb451d9d_893cf4a1","line":5,"range":{"start_line":5,"start_character":56,"end_line":5,"end_character":73},"updated":"2025-07-25 12:54:07.000000000","message":"`verifying image signatures` -\u003e https://docs.openstack.org/glance/latest/user/signature.html ?\n\nAs I think this might be a bit different and/or require more config: https://specs.openstack.org/openstack/cinder-specs/specs/zed/image-encryption.html","commit_id":"0ef989885a84076343fd101044442f70f33892ee"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"29fb4df0693406c040fc3b4026cbce58cfae42b3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features: "},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Enable Barbican Secrets Support for Glance in OpenStack-Ansible, "},{"line_number":5,"context_line":"    Glance was not being configured to use Barbican for secret management when Barbican support was enabled. "},{"line_number":6,"context_line":"    This patch ensures that Glance is efficiently configured to interact with Barbican, "},{"line_number":7,"context_line":"    allowing proper handling of secrets (such as image encryption keys) in OpenStack compute environments."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"54b582f1_e14dc6b1","line":5,"range":{"start_line":5,"start_character":56,"end_line":5,"end_character":73},"in_reply_to":"fb451d9d_893cf4a1","updated":"2025-07-27 13:07:10.000000000","message":"Done","commit_id":"0ef989885a84076343fd101044442f70f33892ee"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"ae11db758415c20c00335878ad73ee694218b4b3","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Enable Barbican Secrets Support for Glance in OpenStack-Ansible, "},{"line_number":5,"context_line":"    Glance was not being configured to use Barbican for secret management when Barbican support was enabled. "},{"line_number":6,"context_line":"    This patch ensures that Glance is efficiently configured to interact with Barbican, "},{"line_number":7,"context_line":"    allowing proper handling of secrets (such as image encryption keys) in OpenStack compute environments."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0e1a5786_2d165052","line":7,"range":{"start_line":7,"start_character":85,"end_line":7,"end_character":92},"updated":"2025-07-25 12:54:07.000000000","message":"probably compute is superfluous here","commit_id":"0ef989885a84076343fd101044442f70f33892ee"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"dab94a88cdb00dd0ace8bbb65403d8d09da82cfe","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Enable Barbican Secrets Support for Glance in OpenStack-Ansible, "},{"line_number":5,"context_line":"    Glance was not being configured to use Barbican for secret management when Barbican support was enabled. "},{"line_number":6,"context_line":"    This patch ensures that Glance is efficiently configured to interact with Barbican, "},{"line_number":7,"context_line":"    allowing proper handling of secrets (such as image encryption keys) in OpenStack compute environments."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"694c561d_832244f6","line":7,"range":{"start_line":7,"start_character":85,"end_line":7,"end_character":92},"in_reply_to":"0e1a5786_2d165052","updated":"2025-07-25 13:32:18.000000000","message":"Done","commit_id":"0ef989885a84076343fd101044442f70f33892ee"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"dab94a88cdb00dd0ace8bbb65403d8d09da82cfe","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Enable Barbican Secrets Support for Glance in OpenStack-Ansible."},{"line_number":5,"context_line":"    Glance was not being configured to use Barbican for secret management when Barbican support was enabled."},{"line_number":6,"context_line":"    This patch ensures that Glance is efficiently configured to interact with Barbican and allowing proper handling of secrets (such as image encryption keys) in OpenStack  environments."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"60235953_5ad406fa","line":6,"range":{"start_line":6,"start_character":172,"end_line":6,"end_character":173},"updated":"2025-07-25 13:32:18.000000000","message":"extra space","commit_id":"245ed9e994f15559b241a628ae02ccf07c4cdc06"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"29fb4df0693406c040fc3b4026cbce58cfae42b3","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Enable Barbican Secrets Support for Glance in OpenStack-Ansible."},{"line_number":5,"context_line":"    Glance was not being configured to use Barbican for secret management when Barbican support was enabled."},{"line_number":6,"context_line":"    This patch ensures that Glance is efficiently configured to interact with Barbican and allowing proper handling of secrets (such as image encryption keys) in OpenStack  environments."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"26a5f0fe_42bfccbd","line":6,"range":{"start_line":6,"start_character":172,"end_line":6,"end_character":173},"in_reply_to":"60235953_5ad406fa","updated":"2025-07-27 13:07:10.000000000","message":"Done","commit_id":"245ed9e994f15559b241a628ae02ccf07c4cdc06"}],"templates/glance-api.conf.j2":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5ff1a41f5f735586cc1563d2af38cef745ce8344","unresolved":true,"context_lines":[{"line_number":47,"context_line":"pool_timeout \u003d {{ glance_db_pool_timeout }}"},{"line_number":48,"context_line":"connection_recycle_time \u003d {{ glance_db_connection_recycle_time }}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"### bug-2118763"},{"line_number":51,"context_line":"{% if glance_barbican_enabled %}"},{"line_number":52,"context_line":"[barbican]"},{"line_number":53,"context_line":"auth_endpoint \u003d {{ keystone_service_internaluri }}/v3"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ce60d149_eac1553f","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":15},"updated":"2025-07-25 12:12:03.000000000","message":"we don\u0027t really need it template","commit_id":"9750bbc028b3b89271b9e4c41a94a5e159d916b0"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"ea81c23de9e97a9815a3d21d47017660ac1f6289","unresolved":false,"context_lines":[{"line_number":47,"context_line":"pool_timeout \u003d {{ glance_db_pool_timeout }}"},{"line_number":48,"context_line":"connection_recycle_time \u003d {{ glance_db_connection_recycle_time }}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"### bug-2118763"},{"line_number":51,"context_line":"{% if glance_barbican_enabled %}"},{"line_number":52,"context_line":"[barbican]"},{"line_number":53,"context_line":"auth_endpoint \u003d {{ keystone_service_internaluri }}/v3"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5d5b3c68_c124b27b","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":15},"in_reply_to":"ce60d149_eac1553f","updated":"2025-07-25 13:31:39.000000000","message":"Done","commit_id":"9750bbc028b3b89271b9e4c41a94a5e159d916b0"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5ff1a41f5f735586cc1563d2af38cef745ce8344","unresolved":true,"context_lines":[{"line_number":53,"context_line":"auth_endpoint \u003d {{ keystone_service_internaluri }}/v3"},{"line_number":54,"context_line":"barbican_endpoint_type \u003d internal"},{"line_number":55,"context_line":"send_service_user_token \u003d {{ glance_service_token_roles_required | bool }}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"[barbican_service_user]"},{"line_number":58,"context_line":"auth_section \u003d keystone_authtoken"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"d0f95f01_dbcf262c","line":56,"updated":"2025-07-25 12:12:03.000000000","message":"I\u0027d guess it might need `barbican_region_name \u003d {{ keystone_service_region }}`?","commit_id":"9750bbc028b3b89271b9e4c41a94a5e159d916b0"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5ff1a41f5f735586cc1563d2af38cef745ce8344","unresolved":true,"context_lines":[{"line_number":60,"context_line":"[key_manager]"},{"line_number":61,"context_line":"backend \u003d barbican"},{"line_number":62,"context_line":"{% endif %}"},{"line_number":63,"context_line":"###"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"[keystone_authtoken]"},{"line_number":66,"context_line":"insecure \u003d {{ keystone_service_internaluri_insecure | bool }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"36cb16aa_23ce4196","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":3},"updated":"2025-07-25 12:12:03.000000000","message":"ditto","commit_id":"9750bbc028b3b89271b9e4c41a94a5e159d916b0"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"ea81c23de9e97a9815a3d21d47017660ac1f6289","unresolved":false,"context_lines":[{"line_number":60,"context_line":"[key_manager]"},{"line_number":61,"context_line":"backend \u003d barbican"},{"line_number":62,"context_line":"{% endif %}"},{"line_number":63,"context_line":"###"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"[keystone_authtoken]"},{"line_number":66,"context_line":"insecure \u003d {{ keystone_service_internaluri_insecure | bool }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5cde3114_09b2d3b8","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":3},"in_reply_to":"36cb16aa_23ce4196","updated":"2025-07-25 13:31:39.000000000","message":"Done","commit_id":"9750bbc028b3b89271b9e4c41a94a5e159d916b0"}]}