)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"6fa74fc0af1ad0f824fe5d0c9c947ec4c1ec0dd2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Robert Donovan \u003crob@cleansafecloud.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-06-11 12:44:03 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for the default_dns_nameservers variable, introduced in Newton, which allows you to specify default DNS servers populated when creating a tenant subnet."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7c6767bb883296c55b7a7302d7af8a8721fd2844"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_4f0eb58c","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":164},"updated":"2018-06-11 11:49:25.000000000","message":"Please break this line\n\nIn git commits, the first line should be a summary of the change (max 72 chars if possible). Then you should provide more information in the subsequent lines\n\nLook here for some ideas\n\nhttps://chris.beams.io/posts/git-commit/","commit_id":"acdcbb9ec5a01500d581f6f9b8566144f1ddf048"}],"templates/horizon_local_settings.py.j2":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"b2893b36380270b26fb3a0ed048f761e5789a99a","unresolved":false,"context_lines":[{"line_number":317,"context_line":"    # Set to empty list or None to disable VNIC type selection."},{"line_number":318,"context_line":"    \u0027supported_vnic_types\u0027: [\u0027*\u0027],"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    # Default DNS servers you would like to use when a subnet is created. "},{"line_number":321,"context_line":"    # This is only a default. Users can still choose a different list of "},{"line_number":322,"context_line":"    # dns servers."},{"line_number":323,"context_line":"    \u0027default_dns_nameservers\u0027: ["}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5f7c97a3_3d7e13e3","line":320,"range":{"start_line":320,"start_character":73,"end_line":320,"end_character":74},"updated":"2018-06-11 13:10:13.000000000","message":"nit: could you remove the two whitespaces here and at the next line?","commit_id":"5277c842e217990341b114ee388d81617313a28e"},{"author":{"_account_id":28443,"name":"Robert Donovan","email":"rob@cleansafecloud.com","username":"pingfrog"},"change_message_id":"9d926874b31407db67bf2d6d87aa1a75c1865511","unresolved":false,"context_lines":[{"line_number":317,"context_line":"    # Set to empty list or None to disable VNIC type selection."},{"line_number":318,"context_line":"    \u0027supported_vnic_types\u0027: [\u0027*\u0027],"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    # Default DNS servers you would like to use when a subnet is created. "},{"line_number":321,"context_line":"    # This is only a default. Users can still choose a different list of "},{"line_number":322,"context_line":"    # dns servers."},{"line_number":323,"context_line":"    \u0027default_dns_nameservers\u0027: ["}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5f7c97a3_3852a113","line":320,"range":{"start_line":320,"start_character":73,"end_line":320,"end_character":74},"in_reply_to":"5f7c97a3_3d7e13e3","updated":"2018-06-13 09:16:29.000000000","message":"Done","commit_id":"5277c842e217990341b114ee388d81617313a28e"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"b2893b36380270b26fb3a0ed048f761e5789a99a","unresolved":false,"context_lines":[{"line_number":320,"context_line":"    # Default DNS servers you would like to use when a subnet is created. "},{"line_number":321,"context_line":"    # This is only a default. Users can still choose a different list of "},{"line_number":322,"context_line":"    # dns servers."},{"line_number":323,"context_line":"    \u0027default_dns_nameservers\u0027: ["},{"line_number":324,"context_line":"      {% for item in horizon_default_dns_nameservers %}"},{"line_number":325,"context_line":"        \u0027{{ item }}\u0027,"},{"line_number":326,"context_line":"      {% endfor %}"},{"line_number":327,"context_line":"    ]"},{"line_number":328,"context_line":"}"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"# The OPENSTACK_HEAT_STACK settings can be used to disable password"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5f7c97a3_dd47dfa2","line":327,"range":{"start_line":323,"start_character":0,"end_line":327,"end_character":5},"updated":"2018-06-11 13:10:13.000000000","message":"I see no conditional wrapping default_dns_nameservers, is that fine if we have \u0027default_dns_nameservers\u0027: [] in here?\n\nShouldn\u0027t we wrap it with {% if default_dns_nameservers | length \u003e 0 %} ... {% endif %} ?","commit_id":"5277c842e217990341b114ee388d81617313a28e"},{"author":{"_account_id":28443,"name":"Robert Donovan","email":"rob@cleansafecloud.com","username":"pingfrog"},"change_message_id":"9d926874b31407db67bf2d6d87aa1a75c1865511","unresolved":false,"context_lines":[{"line_number":320,"context_line":"    # Default DNS servers you would like to use when a subnet is created. "},{"line_number":321,"context_line":"    # This is only a default. Users can still choose a different list of "},{"line_number":322,"context_line":"    # dns servers."},{"line_number":323,"context_line":"    \u0027default_dns_nameservers\u0027: ["},{"line_number":324,"context_line":"      {% for item in horizon_default_dns_nameservers %}"},{"line_number":325,"context_line":"        \u0027{{ item }}\u0027,"},{"line_number":326,"context_line":"      {% endfor %}"},{"line_number":327,"context_line":"    ]"},{"line_number":328,"context_line":"}"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"# The OPENSTACK_HEAT_STACK settings can be used to disable password"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5f7c97a3_3d361304","line":327,"range":{"start_line":323,"start_character":0,"end_line":327,"end_character":5},"in_reply_to":"5f7c97a3_dd47dfa2","updated":"2018-06-13 09:16:29.000000000","message":"Hi Jean-Philippe, yes it is fine to have an empty array in here, which is the default value. The DNS Nameserver box will simply be empty when a new subnet is created (tested and verified). Thanks.","commit_id":"5277c842e217990341b114ee388d81617313a28e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f394efc1e7eb46018abd506f645288527ecc5d8f","unresolved":false,"context_lines":[{"line_number":317,"context_line":"    # Set to empty list or None to disable VNIC type selection."},{"line_number":318,"context_line":"    \u0027supported_vnic_types\u0027: [\u0027*\u0027],"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    {% if horizon_default_dns_nameservers is defined %}"},{"line_number":321,"context_line":"    # Default DNS servers you would like to use when a subnet is created."},{"line_number":322,"context_line":"    # This is only a default. Users can still choose a different list of"},{"line_number":323,"context_line":"    # dns servers."}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5f7c97a3_258c357f","line":320,"range":{"start_line":320,"start_character":0,"end_line":320,"end_character":55},"updated":"2018-07-12 08:50:20.000000000","message":"Given that its defined in defaults, this conditional is a no-op as may as well be removed.","commit_id":"b88e5f601558c2ab85a44e182e18cbb7f12787ee"}]}