)]}'
{"defaults/main.yml":[{"author":{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},"change_message_id":"241e821d868291cd3ca5d3dbed16cd8ff5721222","unresolved":false,"context_lines":[{"line_number":246,"context_line":"horizon_keystone_multidomain_support: False"},{"line_number":247,"context_line":"# It is strongly advised NOT to enable dropdown for public clouds, as advertising enabled domains"},{"line_number":248,"context_line":"# to unauthenticated customers irresponsibly exposes private information."},{"line_number":249,"context_line":"horizon_keystone_multidomain_dropdown: False"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"horizon_keystone_default_domain: Default"},{"line_number":252,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1fa4df85_c8653de3","line":249,"range":{"start_line":249,"start_character":0,"end_line":249,"end_character":44},"updated":"2020-03-13 18:16:32.000000000","message":"can you use this one instead of domain_dropdown ?","commit_id":"0184594e95b1d14ff705a6f2d2c097d64db2c02e"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"c4e134d4dcab9b2e1b5a328b84696677e0f55795","unresolved":false,"context_lines":[{"line_number":251,"context_line":"# Option to set the available domains to choose from. This is"},{"line_number":252,"context_line":"# a list of pairs whose first value is the domain name and the"},{"line_number":253,"context_line":"# second is the display name."},{"line_number":254,"context_line":"horizon_keystone_multidomain_choices: \"((\u0027Default\u0027, \u0027Default\u0027))\""},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"horizon_keystone_default_domain: Default"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_975c2fee","line":254,"range":{"start_line":254,"start_character":0,"end_line":254,"end_character":64},"updated":"2020-03-16 14:08:50.000000000","message":"Since this is optional I\u0027d comment it out by default","commit_id":"b56a99126b0cdda947d3f41c519d7ec018c4b3b9"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e261a7c8eeb6f3733c37c576f6d4a42cab56af2a","unresolved":false,"context_lines":[{"line_number":251,"context_line":"# Option to set the available domains to choose from. This is"},{"line_number":252,"context_line":"# a list of pairs whose first value is the domain name and the"},{"line_number":253,"context_line":"# second is the display name."},{"line_number":254,"context_line":"horizon_keystone_multidomain_choices: \"((\u0027Default\u0027, \u0027Default\u0027))\""},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"horizon_keystone_default_domain: Default"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df33271e_247c7cea","line":254,"range":{"start_line":254,"start_character":38,"end_line":254,"end_character":64},"updated":"2020-04-03 13:45:35.000000000","message":"can we set it this way then?\n\"((\u0027{{ horizon_keystone_default_domain }}\u0027, \u0027{{ horizon_keystone_default_domain }}\u0027))\"\n\nor smth like this to correspond to what\u0027s set for horizon_keystone_default_domain to not change behaviour?","commit_id":"b56a99126b0cdda947d3f41c519d7ec018c4b3b9"},{"author":{"_account_id":31722,"name":"Edvin Linge","email":"edvin.linge@gmail.com","username":"elinge"},"change_message_id":"712d08bf9be5a3e7a3d1d5f0eb18c818d153ffdb","unresolved":false,"context_lines":[{"line_number":251,"context_line":"# Option to set the available domains to choose from. This is"},{"line_number":252,"context_line":"# a list of pairs whose first value is the domain name and the"},{"line_number":253,"context_line":"# second is the display name."},{"line_number":254,"context_line":"horizon_keystone_multidomain_choices: \"((\u0027Default\u0027, \u0027Default\u0027))\""},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"horizon_keystone_default_domain: Default"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df33271e_cc3daade","line":254,"range":{"start_line":254,"start_character":38,"end_line":254,"end_character":64},"in_reply_to":"df33271e_247c7cea","updated":"2020-04-14 07:46:08.000000000","message":"Sure, works for me.","commit_id":"b56a99126b0cdda947d3f41c519d7ec018c4b3b9"}],"templates/horizon_local_settings.py.j2":[{"author":{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},"change_message_id":"b72d8dfcb152658ac8b563669a731a90908efc2c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"OPENSTACK_KEYSTONE_MULTIDOMAIN_SUPPORT \u003d {{ horizon_keystone_multidomain_support | bool }}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"{%   if horizon_keystone_multidomain_support | bool %}"},{"line_number":82,"context_line":"OPENSTACK_KEYSTONE_DOMAIN_DROPDOWN \u003d {{ horizon_keystone_multidomain_dropdown | bool }}"},{"line_number":83,"context_line":"{%   endif %}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"{%   if not horizon_keystone_multidomain_support | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1fa4df85_ed44cb76","line":82,"range":{"start_line":82,"start_character":1,"end_line":82,"end_character":33},"updated":"2020-03-13 18:05:16.000000000","message":"hmm, maybe this needs to be adjusted ?","commit_id":"0184594e95b1d14ff705a6f2d2c097d64db2c02e"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"c4e134d4dcab9b2e1b5a328b84696677e0f55795","unresolved":false,"context_lines":[{"line_number":84,"context_line":"OPENSTACK_KEYSTONE_DEFAULT_DOMAIN \u003d \"{{ horizon_keystone_default_domain }}\""},{"line_number":85,"context_line":"{%   else %}"},{"line_number":86,"context_line":"OPENSTACK_KEYSTONE_DOMAIN_DROPDOWN \u003d \"{{ horizon_keystone_multidomain_dropdown | bool }}\""},{"line_number":87,"context_line":"OPENSTACK_KEYSTONE_DOMAIN_CHOICES \u003d \"{{ horizon_keystone_multidomain_choices }}\""},{"line_number":88,"context_line":"{%   endif %}"},{"line_number":89,"context_line":"{% endif %}"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"1fa4df85_b75febe3","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":80},"updated":"2020-03-16 14:08:50.000000000","message":"This is optional setting when OPENSTACK_KEYSTONE_DEFAULT_DOMAIN is true. If it\u0027s not defined, dropdown list still should be present, just domain name would be equal to display name.\nSo I\u0027d add additional conditional to check if OPENSTACK_KEYSTONE_DOMAIN_CHOICES defined or not empty.","commit_id":"b56a99126b0cdda947d3f41c519d7ec018c4b3b9"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e261a7c8eeb6f3733c37c576f6d4a42cab56af2a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"OPENSTACK_KEYSTONE_DEFAULT_DOMAIN \u003d \"{{ horizon_keystone_default_domain }}\""},{"line_number":85,"context_line":"{%   else %}"},{"line_number":86,"context_line":"OPENSTACK_KEYSTONE_DOMAIN_DROPDOWN \u003d \"{{ horizon_keystone_multidomain_dropdown | bool }}\""},{"line_number":87,"context_line":"OPENSTACK_KEYSTONE_DOMAIN_CHOICES \u003d \"{{ horizon_keystone_multidomain_choices }}\""},{"line_number":88,"context_line":"{%   endif %}"},{"line_number":89,"context_line":"{% endif %}"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"df33271e_c43cb032","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":80},"in_reply_to":"1fa4df85_19eb8edc","updated":"2020-04-03 13:45:35.000000000","message":"Oh, hm, indeed. It even looks like horizon bug actually...","commit_id":"b56a99126b0cdda947d3f41c519d7ec018c4b3b9"},{"author":{"_account_id":31722,"name":"Edvin Linge","email":"edvin.linge@gmail.com","username":"elinge"},"change_message_id":"4e1d2466fb64ac44979c082db7aaba993886a296","unresolved":false,"context_lines":[{"line_number":84,"context_line":"OPENSTACK_KEYSTONE_DEFAULT_DOMAIN \u003d \"{{ horizon_keystone_default_domain }}\""},{"line_number":85,"context_line":"{%   else %}"},{"line_number":86,"context_line":"OPENSTACK_KEYSTONE_DOMAIN_DROPDOWN \u003d \"{{ horizon_keystone_multidomain_dropdown | bool }}\""},{"line_number":87,"context_line":"OPENSTACK_KEYSTONE_DOMAIN_CHOICES \u003d \"{{ horizon_keystone_multidomain_choices }}\""},{"line_number":88,"context_line":"{%   endif %}"},{"line_number":89,"context_line":"{% endif %}"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"1fa4df85_19eb8edc","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":80},"in_reply_to":"1fa4df85_b75febe3","updated":"2020-03-16 20:06:02.000000000","message":"OPENSTACK_KEYSTONE_DEFAULT_DOMAIN is not a boolean, it is a string, and it is currently not even present in the file if horizon_keystone_multidomain_support is true.\n\nPlease correct me if I\u0027m wrong, but the current implementation does not work at all from what I can see. The documentation at https://github.com/openstack/horizon/blob/master/openstack_auth/defaults.py does indeed imply that OPENSTACK_KEYSTONE_DOMAIN_CHOICES is optional (\"can be used\"), but I would argue that the comment is imisleading. The default value is an empty tuple, and looking at where it is used (https://github.com/openstack/horizon/blob/d8ff9cf0ea17fe6bc644a9f531003ff276f0aeb0/openstack_auth/forms.py#L85) a Django ChoiceField is instanciated using that empty tuple. This means that the dropdown is empty, and I cannot login at all, which is the behavior I currently see when I try to use this functionality. Therefore I would argue that horizon_keystone_multidomain_choices cannot be optional either, given that horizon_keystone_multidomain_dropdown is True.","commit_id":"b56a99126b0cdda947d3f41c519d7ec018c4b3b9"}]}