)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"bc43848eaf44ed06bbd8c1bbda93e2d73946a27a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e3e9d1cb_2a9c54f5","updated":"2021-12-27 22:35:50.000000000","message":"I only have one minor question.\n\nEverything else looks legit for me.","commit_id":"4aca299bd806797654ee62f4ed671b188b74ab16"}],"tasks/horizon_install_source.yml":[{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"bc43848eaf44ed06bbd8c1bbda93e2d73946a27a","unresolved":true,"context_lines":[{"line_number":99,"context_line":"  tags:"},{"line_number":100,"context_line":"    - horizon-config"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"- name: Create horizon link for venv"},{"line_number":103,"context_line":"  file:"},{"line_number":104,"context_line":"    src: \"{{ horizon_lib_dir | dirname }}/site-packages\""},{"line_number":105,"context_line":"    dest: \"{{ horizon_lib_dir }}\""},{"line_number":106,"context_line":"    owner: \"{{ horizon_system_user_name }}\""},{"line_number":107,"context_line":"    group: \"{{ horizon_system_group_name }}\""},{"line_number":108,"context_line":"    state: \"link\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"- name: Create static horizon dir"},{"line_number":111,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f9d1f46b_91ccd456","side":"PARENT","line":108,"range":{"start_line":102,"start_character":0,"end_line":108,"end_character":17},"updated":"2021-12-27 22:35:50.000000000","message":"I wonder what happened to this task. It wasn\u0027t moved anywhere like the other ones, it was just deleted.\n\nIs it not needed anymore?","commit_id":"060bf6c513ba5561f722e109eb4b1adefce7f5d4"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"7295936830011a42708cdb97951889ebe6b3bfa6","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  tags:"},{"line_number":100,"context_line":"    - horizon-config"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"- name: Create horizon link for venv"},{"line_number":103,"context_line":"  file:"},{"line_number":104,"context_line":"    src: \"{{ horizon_lib_dir | dirname }}/site-packages\""},{"line_number":105,"context_line":"    dest: \"{{ horizon_lib_dir }}\""},{"line_number":106,"context_line":"    owner: \"{{ horizon_system_user_name }}\""},{"line_number":107,"context_line":"    group: \"{{ horizon_system_group_name }}\""},{"line_number":108,"context_line":"    state: \"link\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"- name: Create static horizon dir"},{"line_number":111,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf03eea3_ab22199a","side":"PARENT","line":108,"range":{"start_line":102,"start_character":0,"end_line":108,"end_character":17},"in_reply_to":"b315b743_09823078","updated":"2021-12-28 17:59:12.000000000","message":"ack, thanks","commit_id":"060bf6c513ba5561f722e109eb4b1adefce7f5d4"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e5c8f7af50ac093acf31defdb68bd0e4c0dcbea8","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  tags:"},{"line_number":100,"context_line":"    - horizon-config"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"- name: Create horizon link for venv"},{"line_number":103,"context_line":"  file:"},{"line_number":104,"context_line":"    src: \"{{ horizon_lib_dir | dirname }}/site-packages\""},{"line_number":105,"context_line":"    dest: \"{{ horizon_lib_dir }}\""},{"line_number":106,"context_line":"    owner: \"{{ horizon_system_user_name }}\""},{"line_number":107,"context_line":"    group: \"{{ horizon_system_group_name }}\""},{"line_number":108,"context_line":"    state: \"link\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"- name: Create static horizon dir"},{"line_number":111,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d86b1777_eb01563e","side":"PARENT","line":108,"range":{"start_line":102,"start_character":0,"end_line":108,"end_character":17},"in_reply_to":"bf03eea3_ab22199a","updated":"2021-12-29 14:53:18.000000000","message":"well, that task actually leads to failure... So dropping it :)\n\nI guess it\u0027s needed because of https://opendev.org/openstack/openstack-ansible-os_horizon/src/commit/9b8cdbc525df71ea12af727c43e3dfb4b897d745/tasks/horizon_install_source.yml#L96-L100\n\nand we drop this as well","commit_id":"060bf6c513ba5561f722e109eb4b1adefce7f5d4"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"83f4d5cb057dc939b99283b9497f5ec28a93a646","unresolved":true,"context_lines":[{"line_number":99,"context_line":"  tags:"},{"line_number":100,"context_line":"    - horizon-config"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"- name: Create horizon link for venv"},{"line_number":103,"context_line":"  file:"},{"line_number":104,"context_line":"    src: \"{{ horizon_lib_dir | dirname }}/site-packages\""},{"line_number":105,"context_line":"    dest: \"{{ horizon_lib_dir }}\""},{"line_number":106,"context_line":"    owner: \"{{ horizon_system_user_name }}\""},{"line_number":107,"context_line":"    group: \"{{ horizon_system_group_name }}\""},{"line_number":108,"context_line":"    state: \"link\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"- name: Create static horizon dir"},{"line_number":111,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b315b743_09823078","side":"PARENT","line":108,"range":{"start_line":102,"start_character":0,"end_line":108,"end_character":17},"in_reply_to":"f9d1f46b_91ccd456","updated":"2021-12-28 17:57:48.000000000","message":"That is good question. I actually wonder wtf we were doing it. I could assume it\u0027s smth for \"mixed\" installs (distro+source bits) but I can\u0027t even find anything from that - we likely wiped that approach?\n\nSo the only thing why this might be needed, so that https://opendev.org/openstack/openstack-ansible-os_horizon/src/branch/master/tasks/horizon_install_source.yml#L122-L130 was finding panels installed from source that are provided by distro packages.\n\nBut probably youre right and worth dropping it with another PR.","commit_id":"060bf6c513ba5561f722e109eb4b1adefce7f5d4"}]}