)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"57347795c14bf47e2ba37b0bba1ee3545db91d2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9f335baf_01f1e56b","updated":"2022-09-12 09:22:29.000000000","message":"lgtm","commit_id":"ec789d984f9ddb2f7935e1ffbf8e821aa1564b8e"}],"defaults/main.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"a9c60e625087ea3c082e0bd99056c8e9b25f0220","unresolved":true,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"horizon_server_name: \"{{ ansible_facts[\u0027fqdn\u0027] | default(\u0027horizon\u0027) }}\""},{"line_number":156,"context_line":"# Enable or disable apache. If disabled a basic uwsgi deployment will be setup for this service."},{"line_number":157,"context_line":"horizon_apache_enabled: true"},{"line_number":158,"context_line":"horizon_apache_servertokens: \"Prod\""},{"line_number":159,"context_line":"horizon_apache_serversignature: \"Off\""},{"line_number":160,"context_line":"horizon_log_level: info"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6dc0cbb8_dfa9d4b9","line":157,"range":{"start_line":157,"start_character":0,"end_line":157,"end_character":22},"updated":"2022-09-08 07:37:21.000000000","message":"Tbh, I\u0027d love variable to be named as `horizon_use_uwsgi` for consistency reasons.\nAs at very least we do have already glance_use_uwsgi and neutron_use_uwsgi, so naming variable as `horizon_use_uwsgi` makes more sense to me.","commit_id":"a06c9441dbfac437ea8f59324177bbaf22b26622"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"cfb4a4cc907e548d7e3b5d96c26d1d49711e2c7d","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"horizon_server_name: \"{{ ansible_facts[\u0027fqdn\u0027] | default(\u0027horizon\u0027) }}\""},{"line_number":156,"context_line":"# Enable or disable apache. If disabled a basic uwsgi deployment will be setup for this service."},{"line_number":157,"context_line":"horizon_apache_enabled: true"},{"line_number":158,"context_line":"horizon_apache_servertokens: \"Prod\""},{"line_number":159,"context_line":"horizon_apache_serversignature: \"Off\""},{"line_number":160,"context_line":"horizon_log_level: info"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"70b93759_94fe0eee","line":157,"range":{"start_line":157,"start_character":0,"end_line":157,"end_character":22},"in_reply_to":"6dc0cbb8_dfa9d4b9","updated":"2022-09-08 16:30:11.000000000","message":"Ack","commit_id":"a06c9441dbfac437ea8f59324177bbaf22b26622"},{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"af005cb0a154a6429df7d53bbf2ed2c32e4d1a48","unresolved":true,"context_lines":[{"line_number":504,"context_line":"horizon_policy_overrides: {}"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"horizon_init_overrides: {}"},{"line_number":507,"context_line":"horizon_uwsgi_ini_overrides: {}"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"horizon_keystone_admin_roles:"},{"line_number":510,"context_line":"  - admin"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"60a1a6ac_fbd373df","line":507,"updated":"2022-09-13 08:20:55.000000000","message":"I\u0027m not sure I can see these variables referenced anywhere. It looks like the uwsgi one may need merging with some static config in uwsgi_horizon_services perhaps?","commit_id":"ec789d984f9ddb2f7935e1ffbf8e821aa1564b8e"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"68f0e6f9f58a5b348329321e6affdf791deaecbe","unresolved":false,"context_lines":[{"line_number":504,"context_line":"horizon_policy_overrides: {}"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"horizon_init_overrides: {}"},{"line_number":507,"context_line":"horizon_uwsgi_ini_overrides: {}"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"horizon_keystone_admin_roles:"},{"line_number":510,"context_line":"  - admin"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3ab46fa0_3cbe0ad6","line":507,"in_reply_to":"60a1a6ac_fbd373df","updated":"2022-09-13 13:41:21.000000000","message":"Ack","commit_id":"ec789d984f9ddb2f7935e1ffbf8e821aa1564b8e"}],"tasks/main.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"a9c60e625087ea3c082e0bd99056c8e9b25f0220","unresolved":true,"context_lines":[{"line_number":103,"context_line":"  tags:"},{"line_number":104,"context_line":"    - horizon-config"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"- include_tasks: \"{{ (horizon_apache_enabled | bool) | ternary(\u0027horizon_apache.yml\u0027, \u0027horizon_uwsgi.yml\u0027) }}\""},{"line_number":107,"context_line":"  tags:"},{"line_number":108,"context_line":"    - horizon-config"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"- import_tasks: horizon_translations_update.yml"},{"line_number":111,"context_line":"  when: horizon_translations_update | bool"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6f9a5f0b_2522de4f","line":108,"range":{"start_line":106,"start_character":0,"end_line":108,"end_character":20},"updated":"2022-09-08 07:37:21.000000000","message":"tags should be properly applied if switching from import to include.","commit_id":"a06c9441dbfac437ea8f59324177bbaf22b26622"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"cfb4a4cc907e548d7e3b5d96c26d1d49711e2c7d","unresolved":true,"context_lines":[{"line_number":103,"context_line":"  tags:"},{"line_number":104,"context_line":"    - horizon-config"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"- include_tasks: \"{{ (horizon_apache_enabled | bool) | ternary(\u0027horizon_apache.yml\u0027, \u0027horizon_uwsgi.yml\u0027) }}\""},{"line_number":107,"context_line":"  tags:"},{"line_number":108,"context_line":"    - horizon-config"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"- import_tasks: horizon_translations_update.yml"},{"line_number":111,"context_line":"  when: horizon_translations_update | bool"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ed155e16_12213edf","line":108,"range":{"start_line":106,"start_character":0,"end_line":108,"end_character":20},"in_reply_to":"6f9a5f0b_2522de4f","updated":"2022-09-08 16:30:11.000000000","message":"IDK if we can use import here? if not should I tag everything in the respective tasks?","commit_id":"a06c9441dbfac437ea8f59324177bbaf22b26622"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"bef323024d8ede2f9cece584a5cc9a1268407c95","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  tags:"},{"line_number":104,"context_line":"    - horizon-config"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"- include_tasks: \"{{ (horizon_apache_enabled | bool) | ternary(\u0027horizon_apache.yml\u0027, \u0027horizon_uwsgi.yml\u0027) }}\""},{"line_number":107,"context_line":"  tags:"},{"line_number":108,"context_line":"    - horizon-config"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"- import_tasks: horizon_translations_update.yml"},{"line_number":111,"context_line":"  when: horizon_translations_update | bool"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"75943c4d_5d65bff8","line":108,"range":{"start_line":106,"start_character":0,"end_line":108,"end_character":20},"in_reply_to":"ed155e16_12213edf","updated":"2022-09-08 16:43:09.000000000","message":"Ack","commit_id":"a06c9441dbfac437ea8f59324177bbaf22b26622"}],"vars/main.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"9361d43276404aa89c47471c4c09eda406bb827e","unresolved":true,"context_lines":[{"line_number":59,"context_line":"    uwsgi_threads: \"{{ horizon_wsgi_threads }}\""},{"line_number":60,"context_line":"    uwsgi_bind_address: \"{{ horizon_bind_address }}\""},{"line_number":61,"context_line":"    uwsgi_port: 80"},{"line_number":62,"context_line":"    uwsgi_overrides:"},{"line_number":63,"context_line":"      uwsgi:"},{"line_number":64,"context_line":"        static-map: \"/static\u003d{{ horizon_lib_dir }}/static/\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ef099fb9_dce3d75e","line":64,"range":{"start_line":62,"start_character":0,"end_line":64,"end_character":59},"updated":"2022-09-13 11:36:41.000000000","message":"Andrew is right. This should be placed into some _horizon_uwsgi_default_overrides which will be combined with horizon_uwsgi_ini_overrides.","commit_id":"ec789d984f9ddb2f7935e1ffbf8e821aa1564b8e"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"82564774afc24f5ae14351d6f41939ece775d233","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    uwsgi_threads: \"{{ horizon_wsgi_threads }}\""},{"line_number":60,"context_line":"    uwsgi_bind_address: \"{{ horizon_bind_address }}\""},{"line_number":61,"context_line":"    uwsgi_port: 80"},{"line_number":62,"context_line":"    uwsgi_overrides:"},{"line_number":63,"context_line":"      uwsgi:"},{"line_number":64,"context_line":"        static-map: \"/static\u003d{{ horizon_lib_dir }}/static/\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b205ad39_d99f3987","line":64,"range":{"start_line":62,"start_character":0,"end_line":64,"end_character":59},"in_reply_to":"6b553f62_98852467","updated":"2022-09-13 13:47:07.000000000","message":"Done","commit_id":"ec789d984f9ddb2f7935e1ffbf8e821aa1564b8e"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"68f0e6f9f58a5b348329321e6affdf791deaecbe","unresolved":true,"context_lines":[{"line_number":59,"context_line":"    uwsgi_threads: \"{{ horizon_wsgi_threads }}\""},{"line_number":60,"context_line":"    uwsgi_bind_address: \"{{ horizon_bind_address }}\""},{"line_number":61,"context_line":"    uwsgi_port: 80"},{"line_number":62,"context_line":"    uwsgi_overrides:"},{"line_number":63,"context_line":"      uwsgi:"},{"line_number":64,"context_line":"        static-map: \"/static\u003d{{ horizon_lib_dir }}/static/\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6b553f62_98852467","line":64,"range":{"start_line":62,"start_character":0,"end_line":64,"end_character":59},"in_reply_to":"ef099fb9_dce3d75e","updated":"2022-09-13 13:41:21.000000000","message":"yup good catch Andrew. I\u0027m updating now.","commit_id":"ec789d984f9ddb2f7935e1ffbf8e821aa1564b8e"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"c00076882ad9db930f27850692646bb2c6fa336c","unresolved":true,"context_lines":[{"line_number":53,"context_line":"  uwsgi:"},{"line_number":54,"context_line":"    static-map: \"/static\u003d{{ horizon_lib_dir }}/static/\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"_horizon_uwsgi_ini_overrides: \"{{ _horizon_uwsgi_ini_requirements | combine(horizon_uwsgi_ini_overrides) }}\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"uwsgi_horizon_services:"},{"line_number":59,"context_line":"  horizon-dashboard:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5e009d12_c662edb8","line":56,"range":{"start_line":56,"start_character":103,"end_line":56,"end_character":104},"updated":"2022-09-13 14:26:20.000000000","message":"it should be `recursive\u003dTrue` to merge nested dicts properly.","commit_id":"372d5dd0853f83c3fad075d5e95e916f40fde9ca"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"52a626267c5d28d3c30c9b78774f331df1fc9471","unresolved":true,"context_lines":[{"line_number":53,"context_line":"  uwsgi:"},{"line_number":54,"context_line":"    static-map: \"/static\u003d{{ horizon_lib_dir }}/static/\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"_horizon_uwsgi_ini_overrides: \"{{ _horizon_uwsgi_ini_requirements | combine(horizon_uwsgi_ini_overrides) }}\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"uwsgi_horizon_services:"},{"line_number":59,"context_line":"  horizon-dashboard:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"be94afef_4bb7ed59","line":56,"range":{"start_line":56,"start_character":103,"end_line":56,"end_character":104},"in_reply_to":"5e009d12_c662edb8","updated":"2022-09-13 14:27:02.000000000","message":"https://docs.ansible.com/ansible/latest/user_guide/playbooks_filters.html#combining-hashes-dictionaries","commit_id":"372d5dd0853f83c3fad075d5e95e916f40fde9ca"}]}