)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"d8489c52311579b7af849d81d101781f11d6872c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2eabe5d6_c40fce2e","updated":"2025-12-01 08:34:17.000000000","message":"LGTM","commit_id":"7b37f7c9f4aad5f871561727d67301bcdd91f7ba"},{"author":{"_account_id":37632,"name":"Dmitriy Chubinidze","email":"dcu995@gmail.com","username":"chubinidzedr"},"change_message_id":"164b0c840e4fc45d1773648708d611c3d1fae00b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4a2d58a6_a33bdb18","updated":"2025-12-02 07:21:00.000000000","message":"recheck","commit_id":"4a09fdefd9aefb6175767a75a31dfc777fb536fd"},{"author":{"_account_id":37632,"name":"Dmitriy Chubinidze","email":"dcu995@gmail.com","username":"chubinidzedr"},"change_message_id":"92d8dc6f2702399c922353b311b87688a77c6554","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"1e24b155_fad2affd","updated":"2025-12-02 15:18:40.000000000","message":"recheck","commit_id":"04649ae812b55b5548b166a08ceaeb07bee98a86"}],"tasks/main.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"086246a48470a572b9af0e57f4b0ca20b5c64203","unresolved":true,"context_lines":[{"line_number":67,"context_line":"    - horizon-install"},{"line_number":68,"context_line":"    - post-install"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"- name: Configure source-installed dashboards"},{"line_number":71,"context_line":"  ansible.builtin.include_tasks: horizon_post_install_source.yml"},{"line_number":72,"context_line":"  when: horizon_install_method \u003d\u003d \u0027source\u0027"},{"line_number":73,"context_line":"  tags:"},{"line_number":74,"context_line":"    - post-install"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"- name: Importing horizon_post_install tasks"},{"line_number":77,"context_line":"  ansible.builtin.import_tasks: horizon_post_install.yml"},{"line_number":78,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1ba9a5db_d4089ba1","line":75,"range":{"start_line":70,"start_character":0,"end_line":75,"end_character":0},"updated":"2025-12-01 17:30:11.000000000","message":"Do we need to move it from post_install? As I\u0027d prefer to leave it there.\n\nAlso tags are not applied like that to dynamic includes:\nhttps://docs.ansible.com/projects/ansible/latest/collections/ansible/builtin/include_tasks_module.html#examples","commit_id":"c228e6eac1419184234bed3d1b8981a0e0aa5ac5"},{"author":{"_account_id":37632,"name":"Dmitriy Chubinidze","email":"dcu995@gmail.com","username":"chubinidzedr"},"change_message_id":"2e523e039877a35c7fca8afd309f3fd1d8c9162b","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    - horizon-install"},{"line_number":68,"context_line":"    - post-install"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"- name: Configure source-installed dashboards"},{"line_number":71,"context_line":"  ansible.builtin.include_tasks: horizon_post_install_source.yml"},{"line_number":72,"context_line":"  when: horizon_install_method \u003d\u003d \u0027source\u0027"},{"line_number":73,"context_line":"  tags:"},{"line_number":74,"context_line":"    - post-install"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"- name: Importing horizon_post_install tasks"},{"line_number":77,"context_line":"  ansible.builtin.import_tasks: horizon_post_install.yml"},{"line_number":78,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"dae50ca4_c3a226d7","line":75,"range":{"start_line":70,"start_character":0,"end_line":75,"end_character":0},"in_reply_to":"1ba9a5db_d4089ba1","updated":"2025-12-02 11:14:11.000000000","message":"Indeed it was unnecessary, moved only horizon-lib-dir defining.","commit_id":"c228e6eac1419184234bed3d1b8981a0e0aa5ac5"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"29eb5c44f788364ac8ba2ac36396558bbff993ad","unresolved":true,"context_lines":[{"line_number":64,"context_line":"      ansible.builtin.set_fact:"},{"line_number":65,"context_line":"        horizon_lib_dir: \"{{ _horizon_python_venv_details.stdout | dirname | dirname }}\""},{"line_number":66,"context_line":"  tags:"},{"line_number":67,"context_line":"    - horizon-install"},{"line_number":68,"context_line":"    - post-install"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"- name: Importing horizon_post_install tasks"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"dd801775_9c189991","line":67,"updated":"2025-12-02 08:40:24.000000000","message":"should it also be `- horizon-config` ?","commit_id":"4a09fdefd9aefb6175767a75a31dfc777fb536fd"},{"author":{"_account_id":37632,"name":"Dmitriy Chubinidze","email":"dcu995@gmail.com","username":"chubinidzedr"},"change_message_id":"f7c48037ec2ccf1b34f61457581227f0b65b4bf5","unresolved":false,"context_lines":[{"line_number":64,"context_line":"      ansible.builtin.set_fact:"},{"line_number":65,"context_line":"        horizon_lib_dir: \"{{ _horizon_python_venv_details.stdout | dirname | dirname }}\""},{"line_number":66,"context_line":"  tags:"},{"line_number":67,"context_line":"    - horizon-install"},{"line_number":68,"context_line":"    - post-install"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"- name: Importing horizon_post_install tasks"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"d4f5bf2e_127b4d55","line":67,"in_reply_to":"dd801775_9c189991","updated":"2025-12-02 11:12:41.000000000","message":"You\u0027re right, missed that moment, thanks.","commit_id":"4a09fdefd9aefb6175767a75a31dfc777fb536fd"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"3ec867d7c6bd75eb0a0f0dc504c6ccbc29bacb79","unresolved":true,"context_lines":[{"line_number":64,"context_line":"      ansible.builtin.set_fact:"},{"line_number":65,"context_line":"        horizon_lib_dir: \"{{ _horizon_python_venv_details.stdout | dirname | dirname }}\""},{"line_number":66,"context_line":"  tags:"},{"line_number":67,"context_line":"    - horizon-install"},{"line_number":68,"context_line":"    - post-install"},{"line_number":69,"context_line":"    - horizon-config"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- name: Importing horizon_post_install tasks"},{"line_number":72,"context_line":"  ansible.builtin.import_tasks: horizon_post_install.yml"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"4f9241b3_2c02105c","line":69,"range":{"start_line":67,"start_character":0,"end_line":69,"end_character":20},"updated":"2025-12-03 10:26:23.000000000","message":"this feels like it could be a `- always`","commit_id":"04649ae812b55b5548b166a08ceaeb07bee98a86"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"c2635f6725d9d52d2fd578e9bf3533b2fd0210cc","unresolved":false,"context_lines":[{"line_number":64,"context_line":"      ansible.builtin.set_fact:"},{"line_number":65,"context_line":"        horizon_lib_dir: \"{{ _horizon_python_venv_details.stdout | dirname | dirname }}\""},{"line_number":66,"context_line":"  tags:"},{"line_number":67,"context_line":"    - horizon-install"},{"line_number":68,"context_line":"    - post-install"},{"line_number":69,"context_line":"    - horizon-config"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- name: Importing horizon_post_install tasks"},{"line_number":72,"context_line":"  ansible.builtin.import_tasks: horizon_post_install.yml"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"cf330ece_44bf1fe4","line":69,"range":{"start_line":67,"start_character":0,"end_line":69,"end_character":20},"in_reply_to":"466a68d4_3a380696","updated":"2025-12-03 11:06:08.000000000","message":"`always` may have other side effect, when expected venv doesn\u0027t exist for instance. As previously task was limited to tags applied to post-install.","commit_id":"04649ae812b55b5548b166a08ceaeb07bee98a86"},{"author":{"_account_id":37632,"name":"Dmitriy Chubinidze","email":"dcu995@gmail.com","username":"chubinidzedr"},"change_message_id":"aaffbc98219408eb6f3dcc3acbe97e500d0b7b82","unresolved":false,"context_lines":[{"line_number":64,"context_line":"      ansible.builtin.set_fact:"},{"line_number":65,"context_line":"        horizon_lib_dir: \"{{ _horizon_python_venv_details.stdout | dirname | dirname }}\""},{"line_number":66,"context_line":"  tags:"},{"line_number":67,"context_line":"    - horizon-install"},{"line_number":68,"context_line":"    - post-install"},{"line_number":69,"context_line":"    - horizon-config"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- name: Importing horizon_post_install tasks"},{"line_number":72,"context_line":"  ansible.builtin.import_tasks: horizon_post_install.yml"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"466a68d4_3a380696","line":69,"range":{"start_line":67,"start_character":0,"end_line":69,"end_character":20},"in_reply_to":"4f9241b3_2c02105c","updated":"2025-12-03 10:43:03.000000000","message":"I think it makes sense, thanks.","commit_id":"04649ae812b55b5548b166a08ceaeb07bee98a86"}]}