)]}'
{"defaults/main.yml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"202eaf9f2d2e4b7a7af889dbd07a5736c0a2392d","unresolved":false,"context_lines":[{"line_number":368,"context_line":"# regenerated each run."},{"line_number":369,"context_line":"ironic_inspector_recreate_keys: False"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"# venv_download, even when true, will use the fallback method of building the"},{"line_number":372,"context_line":"# venv from scratch if the venv download fails."},{"line_number":373,"context_line":"ironic_inspector_venv_download: \"{{ not ironic_inspector_developer_mode | bool }}\""},{"line_number":374,"context_line":"ironic_inspector_venv_download_url: http://127.0.0.1/venvs/untagged/ubuntu/ironic-inspector.tgz"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"ironic_inspector_tftp_server_address: \"{{ ansible_host }}\""},{"line_number":377,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_091886ca","line":374,"range":{"start_line":371,"start_character":0,"end_line":374,"end_character":95},"updated":"2019-09-05 15:53:31.000000000","message":"i\u0027m not sure this is relevant on master any more with the changes to the repo server","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"91a018eb4d6d30969c6b022aa3c2e4474d5abb8b","unresolved":false,"context_lines":[{"line_number":368,"context_line":"# regenerated each run."},{"line_number":369,"context_line":"ironic_inspector_recreate_keys: False"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"# venv_download, even when true, will use the fallback method of building the"},{"line_number":372,"context_line":"# venv from scratch if the venv download fails."},{"line_number":373,"context_line":"ironic_inspector_venv_download: \"{{ not ironic_inspector_developer_mode | bool }}\""},{"line_number":374,"context_line":"ironic_inspector_venv_download_url: http://127.0.0.1/venvs/untagged/ubuntu/ironic-inspector.tgz"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"ironic_inspector_tftp_server_address: \"{{ ansible_host }}\""},{"line_number":377,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_50c7fa98","line":374,"range":{"start_line":371,"start_character":0,"end_line":374,"end_character":95},"in_reply_to":"7faddb67_091886ca","updated":"2019-09-05 21:16:47.000000000","message":"Done","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"202eaf9f2d2e4b7a7af889dbd07a5736c0a2392d","unresolved":false,"context_lines":[{"line_number":377,"context_line":""},{"line_number":378,"context_line":"ironic_inspector_pip_install_args: \"{{ pip_install_options | default(\u0027\u0027) }}\""},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"ironic_inspector_requires_pip_packages:"},{"line_number":381,"context_line":"  - virtualenv"},{"line_number":382,"context_line":"  - virtualenv-tools"},{"line_number":383,"context_line":"  - python-keystoneclient # Keystoneclient needed for the OSA keystone lib"},{"line_number":384,"context_line":"  - httplib2 # for Ansible\u0027s uri module"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"ironic_inspector_pip_packages:"},{"line_number":387,"context_line":"  - cryptography"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_890c7693","line":384,"range":{"start_line":380,"start_character":0,"end_line":384,"end_character":39},"updated":"2019-09-05 15:53:31.000000000","message":"i don\u0027t think any of this should be required - virtualenv will be dealt with via the python_venv_build role and the ansible requirements are not the responsibility of roles","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"91a018eb4d6d30969c6b022aa3c2e4474d5abb8b","unresolved":false,"context_lines":[{"line_number":377,"context_line":""},{"line_number":378,"context_line":"ironic_inspector_pip_install_args: \"{{ pip_install_options | default(\u0027\u0027) }}\""},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"ironic_inspector_requires_pip_packages:"},{"line_number":381,"context_line":"  - virtualenv"},{"line_number":382,"context_line":"  - virtualenv-tools"},{"line_number":383,"context_line":"  - python-keystoneclient # Keystoneclient needed for the OSA keystone lib"},{"line_number":384,"context_line":"  - httplib2 # for Ansible\u0027s uri module"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"ironic_inspector_pip_packages:"},{"line_number":387,"context_line":"  - cryptography"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_10c5028e","line":384,"range":{"start_line":380,"start_character":0,"end_line":384,"end_character":39},"in_reply_to":"7faddb67_890c7693","updated":"2019-09-05 21:16:47.000000000","message":"Done","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"202eaf9f2d2e4b7a7af889dbd07a5736c0a2392d","unresolved":false,"context_lines":[{"line_number":390,"context_line":"  - python-ironicclient"},{"line_number":391,"context_line":"  - python-memcached"},{"line_number":392,"context_line":"  - python-swiftclient"},{"line_number":393,"context_line":"  - amqp\u003d\u003d2.5.0"},{"line_number":394,"context_line":"  - vine\u003d\u003d1.3.0"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"# Auth"},{"line_number":397,"context_line":"ironic_inspector_service_user_name: \"ironic_inspector\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_697edae3","line":394,"range":{"start_line":393,"start_character":0,"end_line":394,"end_character":15},"updated":"2019-09-05 15:53:31.000000000","message":"should we be pinning package versions here - doesnt requirements deal with this","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"91a018eb4d6d30969c6b022aa3c2e4474d5abb8b","unresolved":false,"context_lines":[{"line_number":390,"context_line":"  - python-ironicclient"},{"line_number":391,"context_line":"  - python-memcached"},{"line_number":392,"context_line":"  - python-swiftclient"},{"line_number":393,"context_line":"  - amqp\u003d\u003d2.5.0"},{"line_number":394,"context_line":"  - vine\u003d\u003d1.3.0"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"# Auth"},{"line_number":397,"context_line":"ironic_inspector_service_user_name: \"ironic_inspector\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_30c03e7c","line":394,"range":{"start_line":393,"start_character":0,"end_line":394,"end_character":15},"in_reply_to":"7faddb67_697edae3","updated":"2019-09-05 21:16:47.000000000","message":"Done","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"202eaf9f2d2e4b7a7af889dbd07a5736c0a2392d","unresolved":false,"context_lines":[{"line_number":414,"context_line":"# ironic_inspector_swift_auth_account: AUTH_1234567890"},{"line_number":415,"context_line":"# ironic_inspector_swift_endpoint: https://localhost:8080"},{"line_number":416,"context_line":"# Ironic inspector"},{"line_number":417,"context_line":"ironic_inspector_enable_discovery: True"},{"line_number":418,"context_line":"ironic_inspector_valid_interfaces: internal,public"},{"line_number":419,"context_line":"ironic_inspector_manage_firewall: True"},{"line_number":420,"context_line":"ironic_inspector_dhcp_interface: br-vlan"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_e9716a0e","line":417,"range":{"start_line":417,"start_character":0,"end_line":417,"end_character":33},"updated":"2019-09-05 15:53:31.000000000","message":"there are many many variables defined here which don\u0027t seem to be used? This is just one of them","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"91a018eb4d6d30969c6b022aa3c2e4474d5abb8b","unresolved":false,"context_lines":[{"line_number":414,"context_line":"# ironic_inspector_swift_auth_account: AUTH_1234567890"},{"line_number":415,"context_line":"# ironic_inspector_swift_endpoint: https://localhost:8080"},{"line_number":416,"context_line":"# Ironic inspector"},{"line_number":417,"context_line":"ironic_inspector_enable_discovery: True"},{"line_number":418,"context_line":"ironic_inspector_valid_interfaces: internal,public"},{"line_number":419,"context_line":"ironic_inspector_manage_firewall: True"},{"line_number":420,"context_line":"ironic_inspector_dhcp_interface: br-vlan"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_30927ea0","line":417,"range":{"start_line":417,"start_character":0,"end_line":417,"end_character":33},"in_reply_to":"7faddb67_e9716a0e","updated":"2019-09-05 21:16:47.000000000","message":"i\u0027ll address the excess variables next iteration","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"9f709ae42e534ac49f84a360f6c4b11b907fc140","unresolved":false,"context_lines":[{"line_number":284,"context_line":"# to build an environment directly from a git source without the presence"},{"line_number":285,"context_line":"# of an OpenStack-Ansible repo_server."},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"ironic_inspector_developer_mode: false"},{"line_number":288,"context_line":"ironic_inspector_developer_constraints:"},{"line_number":289,"context_line":"  - \"git+{{ ironic_inspector_git_repo }}@{{ ironic_inspector_git_install_branch }}#egg\u003dironic-inspector\""},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"# Name of the virtual env to deploy into"},{"line_number":292,"context_line":"ironic_inspector_venv_tag: 8.2.2"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5faad753_fcefbae6","line":289,"range":{"start_line":287,"start_character":0,"end_line":289,"end_character":104},"updated":"2019-09-06 21:33:42.000000000","message":"i think that both of these are redundant now - i\u0027m not sure developer mode is really a thing any more. Check what is done on master branch for something like os_glance / os_cinder","commit_id":"0194b2c5e66a3f9022d3723b9bea8ccfb58ed46a"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"a604f32ec3335f763b556b47df560638d3e979a4","unresolved":false,"context_lines":[{"line_number":284,"context_line":"# to build an environment directly from a git source without the presence"},{"line_number":285,"context_line":"# of an OpenStack-Ansible repo_server."},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"ironic_inspector_developer_mode: false"},{"line_number":288,"context_line":"ironic_inspector_developer_constraints:"},{"line_number":289,"context_line":"  - \"git+{{ ironic_inspector_git_repo }}@{{ ironic_inspector_git_install_branch }}#egg\u003dironic-inspector\""},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"# Name of the virtual env to deploy into"},{"line_number":292,"context_line":"ironic_inspector_venv_tag: 8.2.2"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5faad753_265f7942","line":289,"range":{"start_line":287,"start_character":0,"end_line":289,"end_character":104},"in_reply_to":"5faad753_fcefbae6","updated":"2019-09-07 13:56:00.000000000","message":"Done","commit_id":"0194b2c5e66a3f9022d3723b9bea8ccfb58ed46a"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"9f709ae42e534ac49f84a360f6c4b11b907fc140","unresolved":false,"context_lines":[{"line_number":289,"context_line":"  - \"git+{{ ironic_inspector_git_repo }}@{{ ironic_inspector_git_install_branch }}#egg\u003dironic-inspector\""},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"# Name of the virtual env to deploy into"},{"line_number":292,"context_line":"ironic_inspector_venv_tag: 8.2.2"},{"line_number":293,"context_line":"ironic_inspector_bin: \"/openstack/venvs/ironic-inspector-{{ ironic_inspector_venv_tag }}/bin\""},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"# System info"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5faad753_1c18961b","line":292,"range":{"start_line":292,"start_character":27,"end_line":292,"end_character":32},"updated":"2019-09-06 21:33:42.000000000","message":"this should be generated dynamically, see http://codesearch.openstack.org/?q\u003dglance_venv_tag","commit_id":"0194b2c5e66a3f9022d3723b9bea8ccfb58ed46a"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"a604f32ec3335f763b556b47df560638d3e979a4","unresolved":false,"context_lines":[{"line_number":289,"context_line":"  - \"git+{{ ironic_inspector_git_repo }}@{{ ironic_inspector_git_install_branch }}#egg\u003dironic-inspector\""},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"# Name of the virtual env to deploy into"},{"line_number":292,"context_line":"ironic_inspector_venv_tag: 8.2.2"},{"line_number":293,"context_line":"ironic_inspector_bin: \"/openstack/venvs/ironic-inspector-{{ ironic_inspector_venv_tag }}/bin\""},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"# System info"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5faad753_465cf54a","line":292,"range":{"start_line":292,"start_character":27,"end_line":292,"end_character":32},"in_reply_to":"5faad753_1c18961b","updated":"2019-09-07 13:56:00.000000000","message":"Done","commit_id":"0194b2c5e66a3f9022d3723b9bea8ccfb58ed46a"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"9f709ae42e534ac49f84a360f6c4b11b907fc140","unresolved":false,"context_lines":[{"line_number":376,"context_line":""},{"line_number":377,"context_line":"ironic_inspector_dhcp_type: dnsmasq # isc_dhcp"},{"line_number":378,"context_line":"ironic_inspector_boot_mode: http #tftp"},{"line_number":379,"context_line":"ironic_inspector_pxe_boot_mode: \"{{ ironic_inspector_boot_mode | default(\u0027http\u0027) }}\""},{"line_number":380,"context_line":"ironic_inspector_ipa_httpboot_image_dir: /httpboot"},{"line_number":381,"context_line":"ironic_inspector_ipa_tftpboot_image_dir: /tftpboot"},{"line_number":382,"context_line":"ironic_inspector_ipa_kernel_url: https://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-stable-stein.vmlinuz"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5faad753_3c279215","line":379,"range":{"start_line":379,"start_character":63,"end_line":379,"end_character":80},"updated":"2019-09-06 21:33:42.000000000","message":"no need to default this, its already defined","commit_id":"0194b2c5e66a3f9022d3723b9bea8ccfb58ed46a"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"a604f32ec3335f763b556b47df560638d3e979a4","unresolved":false,"context_lines":[{"line_number":376,"context_line":""},{"line_number":377,"context_line":"ironic_inspector_dhcp_type: dnsmasq # isc_dhcp"},{"line_number":378,"context_line":"ironic_inspector_boot_mode: http #tftp"},{"line_number":379,"context_line":"ironic_inspector_pxe_boot_mode: \"{{ ironic_inspector_boot_mode | default(\u0027http\u0027) }}\""},{"line_number":380,"context_line":"ironic_inspector_ipa_httpboot_image_dir: /httpboot"},{"line_number":381,"context_line":"ironic_inspector_ipa_tftpboot_image_dir: /tftpboot"},{"line_number":382,"context_line":"ironic_inspector_ipa_kernel_url: https://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-stable-stein.vmlinuz"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5faad753_c63545f9","line":379,"range":{"start_line":379,"start_character":63,"end_line":379,"end_character":80},"in_reply_to":"5faad753_3c279215","updated":"2019-09-07 13:56:00.000000000","message":"Done","commit_id":"0194b2c5e66a3f9022d3723b9bea8ccfb58ed46a"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"9f709ae42e534ac49f84a360f6c4b11b907fc140","unresolved":false,"context_lines":[{"line_number":379,"context_line":"ironic_inspector_pxe_boot_mode: \"{{ ironic_inspector_boot_mode | default(\u0027http\u0027) }}\""},{"line_number":380,"context_line":"ironic_inspector_ipa_httpboot_image_dir: /httpboot"},{"line_number":381,"context_line":"ironic_inspector_ipa_tftpboot_image_dir: /tftpboot"},{"line_number":382,"context_line":"ironic_inspector_ipa_kernel_url: https://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-stable-stein.vmlinuz"},{"line_number":383,"context_line":"ironic_inspector_ipa_kernel_name: ipa_kernel"},{"line_number":384,"context_line":"ironic_inspector_ipa_kernel_sha256_url: https://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-stable-stein.vmlinuz.sha256"},{"line_number":385,"context_line":"ironic_inspector_ipa_initrd_url: https://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-stable-stein.gz"},{"line_number":386,"context_line":"ironic_inspector_ipa_initrd_name: ipa_ramdisk"},{"line_number":387,"context_line":"ironic_inspector_ipa_initrd_sha256_url: https://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-stable-stein.gz.sha256"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"ironic_inspector_oslomsg_rpc_host_group: \"{{ oslomsg_rpc_host_group | default(\u0027rabbitmq_all\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5faad753_fcf25a9a","line":387,"range":{"start_line":382,"start_character":0,"end_line":387,"end_character":135},"updated":"2019-09-06 21:33:42.000000000","message":"look in the tempest role for a neater way of doing this by turning it to a list. Generally vendoring the sha256 string into the role guarantees that the upstream image does not change unexpectedly - unless of course it is regularly rebuilt?","commit_id":"0194b2c5e66a3f9022d3723b9bea8ccfb58ed46a"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"a604f32ec3335f763b556b47df560638d3e979a4","unresolved":false,"context_lines":[{"line_number":379,"context_line":"ironic_inspector_pxe_boot_mode: \"{{ ironic_inspector_boot_mode | default(\u0027http\u0027) }}\""},{"line_number":380,"context_line":"ironic_inspector_ipa_httpboot_image_dir: /httpboot"},{"line_number":381,"context_line":"ironic_inspector_ipa_tftpboot_image_dir: /tftpboot"},{"line_number":382,"context_line":"ironic_inspector_ipa_kernel_url: https://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-stable-stein.vmlinuz"},{"line_number":383,"context_line":"ironic_inspector_ipa_kernel_name: ipa_kernel"},{"line_number":384,"context_line":"ironic_inspector_ipa_kernel_sha256_url: https://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-stable-stein.vmlinuz.sha256"},{"line_number":385,"context_line":"ironic_inspector_ipa_initrd_url: https://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-stable-stein.gz"},{"line_number":386,"context_line":"ironic_inspector_ipa_initrd_name: ipa_ramdisk"},{"line_number":387,"context_line":"ironic_inspector_ipa_initrd_sha256_url: https://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-stable-stein.gz.sha256"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"ironic_inspector_oslomsg_rpc_host_group: \"{{ oslomsg_rpc_host_group | default(\u0027rabbitmq_all\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5faad753_e6588157","line":387,"range":{"start_line":382,"start_character":0,"end_line":387,"end_character":135},"in_reply_to":"5faad753_fcf25a9a","updated":"2019-09-07 13:56:00.000000000","message":"Done","commit_id":"0194b2c5e66a3f9022d3723b9bea8ccfb58ed46a"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"9f709ae42e534ac49f84a360f6c4b11b907fc140","unresolved":false,"context_lines":[{"line_number":396,"context_line":"ironic_inspector_oslomsg_rpc_userid: ironic"},{"line_number":397,"context_line":"ironic_inspector_oslomsg_rpc_vhost: /ironic"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"ironic_inspector_ipa_kernel_suffix_url: \"{{ ironic_inspector_nginx_port}}{{ ironic_inspector_ipa_httpboot_image_dir }}/{{ ironic_inspector_ipa_kernel_name }}\""},{"line_number":400,"context_line":"ironic_inspector_ipa_initrd_suffix_url: \"{{ ironic_inspector_nginx_port}}{{ ironic_inspector_ipa_httpboot_image_dir }}/{{ ironic_inspector_ipa_initrd_name}}\""},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"### Config Overrides"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5faad753_1c73b617","line":399,"range":{"start_line":399,"start_character":44,"end_line":399,"end_character":71},"updated":"2019-09-06 21:33:42.000000000","message":"is this defined anywhere?","commit_id":"0194b2c5e66a3f9022d3723b9bea8ccfb58ed46a"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"a604f32ec3335f763b556b47df560638d3e979a4","unresolved":false,"context_lines":[{"line_number":396,"context_line":"ironic_inspector_oslomsg_rpc_userid: ironic"},{"line_number":397,"context_line":"ironic_inspector_oslomsg_rpc_vhost: /ironic"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"ironic_inspector_ipa_kernel_suffix_url: \"{{ ironic_inspector_nginx_port}}{{ ironic_inspector_ipa_httpboot_image_dir }}/{{ ironic_inspector_ipa_kernel_name }}\""},{"line_number":400,"context_line":"ironic_inspector_ipa_initrd_suffix_url: \"{{ ironic_inspector_nginx_port}}{{ ironic_inspector_ipa_httpboot_image_dir }}/{{ ironic_inspector_ipa_initrd_name}}\""},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"### Config Overrides"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5faad753_a6304909","line":399,"range":{"start_line":399,"start_character":44,"end_line":399,"end_character":71},"in_reply_to":"5faad753_1c73b617","updated":"2019-09-07 13:56:00.000000000","message":"Done","commit_id":"0194b2c5e66a3f9022d3723b9bea8ccfb58ed46a"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5deb72a7af57929aeca675d1fbc10822f0f546b7","unresolved":false,"context_lines":[{"line_number":276,"context_line":"  - agent_ipmitool"},{"line_number":277,"context_line":"  - pxe_ipmitool"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"ironic_inspector_developer_mode: false"},{"line_number":280,"context_line":"ironic_inspector_venv_python_executable: \"{{ openstack_venv_python_executable | default(\u0027python2\u0027) }}\""},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"ironic_inspector_venv_tag: \"{{ venv_tag | default(\u0027untagged\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":49,"id":"3fa7e38b_e455a851","line":279,"range":{"start_line":279,"start_character":0,"end_line":279,"end_character":38},"updated":"2019-09-20 10:04:46.000000000","message":"Are you sure this variable is needed? IIRC we get rid of such stuff","commit_id":"4ff577a5d3ced65734e99adb7ff727a23659b54f"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5deb72a7af57929aeca675d1fbc10822f0f546b7","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"### OpenStack Services to integrate with"},{"line_number":334,"context_line":"# Ironic swift store information"},{"line_number":335,"context_line":"ironic_inspector_swift_user_name: swift-inspector"},{"line_number":336,"context_line":"ironic_inspector_swift_role_names:"},{"line_number":337,"context_line":"  - _member_"},{"line_number":338,"context_line":"  - swiftoperator"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"# Ironic inspector"},{"line_number":341,"context_line":"ironic_inspector_enable_discovery: True"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"3fa7e38b_24d180ce","line":338,"range":{"start_line":335,"start_character":0,"end_line":338,"end_character":17},"updated":"2019-09-20 10:04:46.000000000","message":"Does it mean that we\u0027ll need to adjust swift role as well to create these users when inspector hosts present in inventory?","commit_id":"4ff577a5d3ced65734e99adb7ff727a23659b54f"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5deb72a7af57929aeca675d1fbc10822f0f546b7","unresolved":false,"context_lines":[{"line_number":361,"context_line":"ironic_inspector_init_config_overrides: {}"},{"line_number":362,"context_line":"# pxe boot"},{"line_number":363,"context_line":"ironic_inspector_pxe_append_params: \"ipa-debug\u003d1 systemd.journald.forward_to_console\u003dyes\" #ipa-inspection-collectors\u003ddefault,logs,extra_hardware"},{"line_number":364,"context_line":"ironic_inspector_optional_oslomsg_amqp1_pip_packages:"},{"line_number":365,"context_line":"  - oslo.messaging[amqp1]"},{"line_number":366,"context_line":"ironic_inspector_oslomsg_amqp1_enabled: True"},{"line_number":367,"context_line":"ironic_inspector_upper_constraints_url: \"{{ requirements_git_url | default(\u0027https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt?h\u003d\u0027 ~ requirements_git_install_branch | default(\u0027master\u0027)) }}\""}],"source_content_type":"text/x-yaml","patch_set":49,"id":"3fa7e38b_e43e0828","line":364,"range":{"start_line":364,"start_character":0,"end_line":364,"end_character":52},"updated":"2019-09-20 10:04:46.000000000","message":"can we set it to be default in ironic_optional_oslomsg_amqp1_pip_packages ?","commit_id":"4ff577a5d3ced65734e99adb7ff727a23659b54f"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5deb72a7af57929aeca675d1fbc10822f0f546b7","unresolved":false,"context_lines":[{"line_number":363,"context_line":"ironic_inspector_pxe_append_params: \"ipa-debug\u003d1 systemd.journald.forward_to_console\u003dyes\" #ipa-inspection-collectors\u003ddefault,logs,extra_hardware"},{"line_number":364,"context_line":"ironic_inspector_optional_oslomsg_amqp1_pip_packages:"},{"line_number":365,"context_line":"  - oslo.messaging[amqp1]"},{"line_number":366,"context_line":"ironic_inspector_oslomsg_amqp1_enabled: True"},{"line_number":367,"context_line":"ironic_inspector_upper_constraints_url: \"{{ requirements_git_url | default(\u0027https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt?h\u003d\u0027 ~ requirements_git_install_branch | default(\u0027master\u0027)) }}\""},{"line_number":368,"context_line":"ironic_inspector_git_constraints:"},{"line_number":369,"context_line":"  - \"git+{{ ironic_git_repo }}@{{ ironic_git_install_branch }}#egg\u003dironic-inspector\""}],"source_content_type":"text/x-yaml","patch_set":49,"id":"3fa7e38b_a44810cc","line":366,"range":{"start_line":366,"start_character":0,"end_line":366,"end_character":38},"updated":"2019-09-20 10:04:46.000000000","message":"Can it be defaulted to ironic_oslomsg_amqp1_enabled ?","commit_id":"4ff577a5d3ced65734e99adb7ff727a23659b54f"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5deb72a7af57929aeca675d1fbc10822f0f546b7","unresolved":false,"context_lines":[{"line_number":364,"context_line":"ironic_inspector_optional_oslomsg_amqp1_pip_packages:"},{"line_number":365,"context_line":"  - oslo.messaging[amqp1]"},{"line_number":366,"context_line":"ironic_inspector_oslomsg_amqp1_enabled: True"},{"line_number":367,"context_line":"ironic_inspector_upper_constraints_url: \"{{ requirements_git_url | default(\u0027https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt?h\u003d\u0027 ~ requirements_git_install_branch | default(\u0027master\u0027)) }}\""},{"line_number":368,"context_line":"ironic_inspector_git_constraints:"},{"line_number":369,"context_line":"  - \"git+{{ ironic_git_repo }}@{{ ironic_git_install_branch }}#egg\u003dironic-inspector\""},{"line_number":370,"context_line":"  - \"--constraint {{ ironic_inspector_upper_constraints_url }}\""}],"source_content_type":"text/x-yaml","patch_set":49,"id":"3fa7e38b_6479b8fa","line":367,"range":{"start_line":367,"start_character":0,"end_line":367,"end_character":38},"updated":"2019-09-20 10:04:46.000000000","message":"can it be defaulted to ironic_upper_constraints_url?","commit_id":"4ff577a5d3ced65734e99adb7ff727a23659b54f"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"5ed0a1cd35463163e0163ab87c00e773a3d33126","unresolved":false,"context_lines":[{"line_number":184,"context_line":"ironic_pip_packages:"},{"line_number":185,"context_line":"  - cryptography"},{"line_number":186,"context_line":"  - ironic"},{"line_number":187,"context_line":"  - ironic-inspector"},{"line_number":188,"context_line":"  - osprofiler"},{"line_number":189,"context_line":"  - proliantutils"},{"line_number":190,"context_line":"  - PyMySQL"}],"source_content_type":"text/x-yaml","patch_set":61,"id":"3fa7e38b_f5cdfb84","line":187,"range":{"start_line":187,"start_character":4,"end_line":187,"end_character":20},"updated":"2019-09-25 15:29:15.000000000","message":"does this install the inspector package on the conductor too?","commit_id":"67cd57cc1ab76fa0b4e15b20cd4c2c6f54e72a1e"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"5ed0a1cd35463163e0163ab87c00e773a3d33126","unresolved":false,"context_lines":[{"line_number":372,"context_line":"ironic_inspector_oslomsg_notify_port: \"{{ oslomsg_notify_port | default(\u00275672\u0027) }}\""},{"line_number":373,"context_line":"ironic_inspector_oslomsg_notify_use_ssl: \"False\""},{"line_number":374,"context_line":"ironic_inspector_oslomsg_notify_userid: \"{{ ironic_inspector_oslomsg_rpc_userid }}\""},{"line_number":375,"context_line":"ironic_inspector_oslomsg_notify_password: \"{{ ironic__oslomsg_rpc_password }}\""},{"line_number":376,"context_line":"ironic_inspector_oslomsg_notify_vhost: \"{{ ironic_inspector_oslomsg_rpc_vhost }}\""},{"line_number":377,"context_line":"ironic_inspector_optional_oslomsg_amqp1_pip_packages:"},{"line_number":378,"context_line":"  - oslo.messaging[amqp1]"}],"source_content_type":"text/x-yaml","patch_set":61,"id":"3fa7e38b_0275ffca","line":375,"range":{"start_line":375,"start_character":46,"end_line":375,"end_character":75},"updated":"2019-09-25 15:29:15.000000000","message":"this looks like a cut/paste error? ironic_inspector_oslomsg_rpc_password?","commit_id":"67cd57cc1ab76fa0b4e15b20cd4c2c6f54e72a1e"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2936a5f527c6c317f689ab1e9c1686ca943b8b89","unresolved":false,"context_lines":[{"line_number":231,"context_line":"ironic_wsgi_threads: 1"},{"line_number":232,"context_line":"ironic_wsgi_processes_max: 16"},{"line_number":233,"context_line":"ironic_wsgi_processes: \"{{ [[ansible_processor_vcpus|default(4) // 4, 1] | max, ironic_wsgi_processes_max] | min }}\""},{"line_number":234,"context_line":"ironic_uwsgi_bind_address: \"{{ openstack_service_bind_address | default(\u00270.0.0.0\u0027) }}\""},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"### OpenStack Services to integrate with"},{"line_number":237,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":72,"id":"3fa7e38b_857e59e1","side":"PARENT","line":234,"range":{"start_line":234,"start_character":27,"end_line":234,"end_character":86},"updated":"2019-11-28 14:28:41.000000000","message":"Why this has been changed? It was added in terms of bind-to-mgmt topic","commit_id":"122fa765b3aa67c520babfbc5f42f689d7762a39"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2936a5f527c6c317f689ab1e9c1686ca943b8b89","unresolved":false,"context_lines":[{"line_number":298,"context_line":"ironic_inspector_service_role_name: \"admin\""},{"line_number":299,"context_line":"ironic_inspector_service_project_name: \"service\""},{"line_number":300,"context_line":"ironic_inspector_service_in_ldap: False"},{"line_number":301,"context_line":"ironic_inspector_service_domain_id: Default"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"# Database"},{"line_number":304,"context_line":"ironic_inspector_db_setup_host: \"{{ (\u0027galera_all\u0027 in groups) | ternary(groups[\u0027galera_all\u0027][0], \u0027localhost\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":72,"id":"3fa7e38b_2548c5b1","line":301,"range":{"start_line":301,"start_character":36,"end_line":301,"end_character":43},"updated":"2019-11-28 14:28:41.000000000","message":"isn\u0027t domain_id \"default\" while \"Default\" is domain_name?","commit_id":"9900faf3f3ef2d718408aa11441fbf9070228bd6"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2936a5f527c6c317f689ab1e9c1686ca943b8b89","unresolved":false,"context_lines":[{"line_number":340,"context_line":"ironic_inspector_boot_mode: http #tftp"},{"line_number":341,"context_line":"ironic_inspector_pxe_boot_mode: \"{{ ironic_inspector_boot_mode }}\""},{"line_number":342,"context_line":"ironic_inspector_httpboot_dir: /httpboot"},{"line_number":343,"context_line":"ironic_inspector_tftpboot_dir: /tftpboot"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"ironic_inspector_dhcp_interface: br-ironic"},{"line_number":346,"context_line":"ironic_inspector_valid_interfaces: internal,public"}],"source_content_type":"text/x-yaml","patch_set":72,"id":"3fa7e38b_a8700ca6","line":343,"range":{"start_line":343,"start_character":32,"end_line":343,"end_character":40},"updated":"2019-11-28 14:28:41.000000000","message":"I\u0027m not sure but I have doubts if this dir is valid not only for debian. Maybe it should be defaulted to ironic_tftpd_root?","commit_id":"9900faf3f3ef2d718408aa11441fbf9070228bd6"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"55288c9b2a971c4ae19ce0591df6cef6770c9338","unresolved":false,"context_lines":[{"line_number":139,"context_line":"ironic_erase_devices_priority: 10"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"# Database"},{"line_number":142,"context_line":"ironic_inspector_db:"},{"line_number":143,"context_line":"  - setup_host: \"{{ ironic_db_setup_host }}\""},{"line_number":144,"context_line":"    galera_address: \"{{ ironic_galera_address }}\""},{"line_number":145,"context_line":"    galera_user: \"{{ ironic_galera_user }}\""},{"line_number":146,"context_line":"    galera_database: \"{{ ironic_galera_database }}\""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"ironic_db_setup_host: \"{{ (\u0027galera_all\u0027 in groups) | ternary(groups[\u0027galera_all\u0027][0], \u0027localhost\u0027) }}\""},{"line_number":149,"context_line":"ironic_galera_address: \"{{ galera_address | default(\u0027127.0.0.1\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":80,"id":"3fa7e38b_2625ebae","line":146,"range":{"start_line":142,"start_character":0,"end_line":146,"end_character":51},"updated":"2019-12-04 10:05:54.000000000","message":"I think it\u0027s worth placing in vars/main.yml as has no sense in defaults","commit_id":"c9862428e2bc0f356efb1176b28d205cf8796751"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"55288c9b2a971c4ae19ce0591df6cef6770c9338","unresolved":false,"context_lines":[{"line_number":190,"context_line":"ironic_pip_packages:"},{"line_number":191,"context_line":"  - cryptography"},{"line_number":192,"context_line":"  - ironic"},{"line_number":193,"context_line":"  - ironic-inspector"},{"line_number":194,"context_line":"  - osprofiler"},{"line_number":195,"context_line":"  - proliantutils"},{"line_number":196,"context_line":"  - PyMySQL"}],"source_content_type":"text/x-yaml","patch_set":80,"id":"3fa7e38b_6660c3d0","line":193,"range":{"start_line":193,"start_character":0,"end_line":193,"end_character":20},"updated":"2019-12-04 10:05:54.000000000","message":"Just noticed that. We should make this either conditionally, like:\n\n\"{{ (inventory_hostname in groups[ironic_services[\u0027ironic-inspector\u0027][\u0027group\u0027]]) | ternary(\u0027ironic-inspector\u0027, \u0027\u0027) }}\"\n\nOr add another var and do like masakari monitors [1] [2] \n\nSecond option is better as allows not to install ironic on inspector hosts and vice versa.\n\n[1] https://opendev.org/openstack/openstack-ansible-os_masakari/src/branch/master/defaults/main.yml#L75\n[2] https://opendev.org/openstack/openstack-ansible-os_masakari/src/branch/master/vars/main.yml#L16-L27","commit_id":"c9862428e2bc0f356efb1176b28d205cf8796751"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"0fa1d94838b36fd1dab6b0777eec2c616d8c4ab7","unresolved":false,"context_lines":[{"line_number":190,"context_line":"ironic_pip_packages:"},{"line_number":191,"context_line":"  - cryptography"},{"line_number":192,"context_line":"  - ironic"},{"line_number":193,"context_line":"  - ironic-inspector"},{"line_number":194,"context_line":"  - osprofiler"},{"line_number":195,"context_line":"  - proliantutils"},{"line_number":196,"context_line":"  - PyMySQL"}],"source_content_type":"text/x-yaml","patch_set":80,"id":"3fa7e38b_e67a7375","line":193,"range":{"start_line":193,"start_character":0,"end_line":193,"end_character":20},"in_reply_to":"3fa7e38b_6660c3d0","updated":"2019-12-04 10:08:35.000000000","message":"In terms of first opton it\u0027s better to do that way:\n\"{{ (ironic_services[\u0027ironic-inspector\u0027][\u0027group\u0027] in group_names) | ternary(\u0027ironic-inspector\u0027, \u0027\u0027) }}\"","commit_id":"c9862428e2bc0f356efb1176b28d205cf8796751"}],"tasks/inspector_install.yml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"9f709ae42e534ac49f84a360f6c4b11b907fc140","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  tags:"},{"line_number":29,"context_line":"    - ironic-inspector-install"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Install the python venv"},{"line_number":32,"context_line":"  import_role:"},{"line_number":33,"context_line":"    name: \"python_venv_build\""},{"line_number":34,"context_line":"  vars:"},{"line_number":35,"context_line":"    venv_build_constraints: \"{{ ironic_inspector_developer_constraints }}\""},{"line_number":36,"context_line":"    venv_build_distro_package_list: \"{{ ironic_inspector_developer_mode_distro_packages }}\""},{"line_number":37,"context_line":"    venv_install_destination_path: \"{{ ironic_inspector_bin | dirname }}\""},{"line_number":38,"context_line":"    venv_install_distro_package_list: \"{{ ironic_inspector_packages_list }}\""},{"line_number":39,"context_line":"    venv_pip_install_args: \"{{ ironic_inspector_pip_install_args }}\""},{"line_number":40,"context_line":"    venv_pip_packages: \"{{ (ironic_inspector_oslomsg_amqp1_enabled | bool) | ternary(ironic_inspector_pip_packages + ironic_inspector_optional_oslomsg_amqp1_pip_packages, ironic_inspector_pip_packages) }}\""},{"line_number":41,"context_line":"    venv_facts_when_changed:"},{"line_number":42,"context_line":"      - section: \"ironic-inspector\""},{"line_number":43,"context_line":"        option: \"venv_tag\""},{"line_number":44,"context_line":"        value: \"{{ ironic_inspector_venv_tag }}\""},{"line_number":45,"context_line":"    tags:"},{"line_number":46,"context_line":"      - ironic-inspector-install"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- include: ironic_inspector_post_install.yml"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5faad753_dc8e7e2d","line":46,"range":{"start_line":31,"start_character":0,"end_line":46,"end_character":32},"updated":"2019-09-06 21:33:42.000000000","message":"why do we need a venv specifically for the inspector components? They seem to install to the same host as conductor and are no doubt co-installable into the existing venv?\n\nAlternatively, if you intend the inspector to have its own hosts/containers then this task should be made conditional, as should the one for conductor.","commit_id":"0194b2c5e66a3f9022d3723b9bea8ccfb58ed46a"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"a604f32ec3335f763b556b47df560638d3e979a4","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  tags:"},{"line_number":29,"context_line":"    - ironic-inspector-install"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Install the python venv"},{"line_number":32,"context_line":"  import_role:"},{"line_number":33,"context_line":"    name: \"python_venv_build\""},{"line_number":34,"context_line":"  vars:"},{"line_number":35,"context_line":"    venv_build_constraints: \"{{ ironic_inspector_developer_constraints }}\""},{"line_number":36,"context_line":"    venv_build_distro_package_list: \"{{ ironic_inspector_developer_mode_distro_packages }}\""},{"line_number":37,"context_line":"    venv_install_destination_path: \"{{ ironic_inspector_bin | dirname }}\""},{"line_number":38,"context_line":"    venv_install_distro_package_list: \"{{ ironic_inspector_packages_list }}\""},{"line_number":39,"context_line":"    venv_pip_install_args: \"{{ ironic_inspector_pip_install_args }}\""},{"line_number":40,"context_line":"    venv_pip_packages: \"{{ (ironic_inspector_oslomsg_amqp1_enabled | bool) | ternary(ironic_inspector_pip_packages + ironic_inspector_optional_oslomsg_amqp1_pip_packages, ironic_inspector_pip_packages) }}\""},{"line_number":41,"context_line":"    venv_facts_when_changed:"},{"line_number":42,"context_line":"      - section: \"ironic-inspector\""},{"line_number":43,"context_line":"        option: \"venv_tag\""},{"line_number":44,"context_line":"        value: \"{{ ironic_inspector_venv_tag }}\""},{"line_number":45,"context_line":"    tags:"},{"line_number":46,"context_line":"      - ironic-inspector-install"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- include: ironic_inspector_post_install.yml"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5faad753_213be3d1","line":46,"range":{"start_line":31,"start_character":0,"end_line":46,"end_character":32},"in_reply_to":"5faad753_9c71e6e3","updated":"2019-09-07 13:56:00.000000000","message":"I think I added a new group in the integrated repo.","commit_id":"0194b2c5e66a3f9022d3723b9bea8ccfb58ed46a"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2daff440d4687b6ee63c4ed8886f01b78833f47b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  tags:"},{"line_number":29,"context_line":"    - ironic-inspector-install"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Install the python venv"},{"line_number":32,"context_line":"  import_role:"},{"line_number":33,"context_line":"    name: \"python_venv_build\""},{"line_number":34,"context_line":"  vars:"},{"line_number":35,"context_line":"    venv_build_constraints: \"{{ ironic_inspector_developer_constraints }}\""},{"line_number":36,"context_line":"    venv_build_distro_package_list: \"{{ ironic_inspector_developer_mode_distro_packages }}\""},{"line_number":37,"context_line":"    venv_install_destination_path: \"{{ ironic_inspector_bin | dirname }}\""},{"line_number":38,"context_line":"    venv_install_distro_package_list: \"{{ ironic_inspector_packages_list }}\""},{"line_number":39,"context_line":"    venv_pip_install_args: \"{{ ironic_inspector_pip_install_args }}\""},{"line_number":40,"context_line":"    venv_pip_packages: \"{{ (ironic_inspector_oslomsg_amqp1_enabled | bool) | ternary(ironic_inspector_pip_packages + ironic_inspector_optional_oslomsg_amqp1_pip_packages, ironic_inspector_pip_packages) }}\""},{"line_number":41,"context_line":"    venv_facts_when_changed:"},{"line_number":42,"context_line":"      - section: \"ironic-inspector\""},{"line_number":43,"context_line":"        option: \"venv_tag\""},{"line_number":44,"context_line":"        value: \"{{ ironic_inspector_venv_tag }}\""},{"line_number":45,"context_line":"    tags:"},{"line_number":46,"context_line":"      - ironic-inspector-install"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- include: ironic_inspector_post_install.yml"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5faad753_1c2bb694","line":46,"range":{"start_line":31,"start_character":0,"end_line":46,"end_character":32},"in_reply_to":"5faad753_9c71e6e3","updated":"2019-09-06 21:43:06.000000000","message":"So I\u0027d merged this task with the main one as well as merged list of required pip packages, just set them conditionally based on the host group against which role is runned.\nSo for example added inside vars/source_install (or main) extra var where merged lists for ironic and for inspector based on the group like it\u0027s made here https://opendev.org/openstack/openstack-ansible-os_nova/src/branch/master/vars/distro_install.yml#L36","commit_id":"0194b2c5e66a3f9022d3723b9bea8ccfb58ed46a"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"a604f32ec3335f763b556b47df560638d3e979a4","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  tags:"},{"line_number":29,"context_line":"    - ironic-inspector-install"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Install the python venv"},{"line_number":32,"context_line":"  import_role:"},{"line_number":33,"context_line":"    name: \"python_venv_build\""},{"line_number":34,"context_line":"  vars:"},{"line_number":35,"context_line":"    venv_build_constraints: \"{{ ironic_inspector_developer_constraints }}\""},{"line_number":36,"context_line":"    venv_build_distro_package_list: \"{{ ironic_inspector_developer_mode_distro_packages }}\""},{"line_number":37,"context_line":"    venv_install_destination_path: \"{{ ironic_inspector_bin | dirname }}\""},{"line_number":38,"context_line":"    venv_install_distro_package_list: \"{{ ironic_inspector_packages_list }}\""},{"line_number":39,"context_line":"    venv_pip_install_args: \"{{ ironic_inspector_pip_install_args }}\""},{"line_number":40,"context_line":"    venv_pip_packages: \"{{ (ironic_inspector_oslomsg_amqp1_enabled | bool) | ternary(ironic_inspector_pip_packages + ironic_inspector_optional_oslomsg_amqp1_pip_packages, ironic_inspector_pip_packages) }}\""},{"line_number":41,"context_line":"    venv_facts_when_changed:"},{"line_number":42,"context_line":"      - section: \"ironic-inspector\""},{"line_number":43,"context_line":"        option: \"venv_tag\""},{"line_number":44,"context_line":"        value: \"{{ ironic_inspector_venv_tag }}\""},{"line_number":45,"context_line":"    tags:"},{"line_number":46,"context_line":"      - ironic-inspector-install"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- include: ironic_inspector_post_install.yml"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5faad753_41385fd2","line":46,"range":{"start_line":31,"start_character":0,"end_line":46,"end_character":32},"in_reply_to":"5faad753_dc8e7e2d","updated":"2019-09-07 13:56:00.000000000","message":"I do have an ironic_inspector group","commit_id":"0194b2c5e66a3f9022d3723b9bea8ccfb58ed46a"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"53a7dea99a3ccad54a6f7b14d6c5803761a99ea5","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  tags:"},{"line_number":29,"context_line":"    - ironic-inspector-install"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Install the python venv"},{"line_number":32,"context_line":"  import_role:"},{"line_number":33,"context_line":"    name: \"python_venv_build\""},{"line_number":34,"context_line":"  vars:"},{"line_number":35,"context_line":"    venv_build_constraints: \"{{ ironic_inspector_developer_constraints }}\""},{"line_number":36,"context_line":"    venv_build_distro_package_list: \"{{ ironic_inspector_developer_mode_distro_packages }}\""},{"line_number":37,"context_line":"    venv_install_destination_path: \"{{ ironic_inspector_bin | dirname }}\""},{"line_number":38,"context_line":"    venv_install_distro_package_list: \"{{ ironic_inspector_packages_list }}\""},{"line_number":39,"context_line":"    venv_pip_install_args: \"{{ ironic_inspector_pip_install_args }}\""},{"line_number":40,"context_line":"    venv_pip_packages: \"{{ (ironic_inspector_oslomsg_amqp1_enabled | bool) | ternary(ironic_inspector_pip_packages + ironic_inspector_optional_oslomsg_amqp1_pip_packages, ironic_inspector_pip_packages) }}\""},{"line_number":41,"context_line":"    venv_facts_when_changed:"},{"line_number":42,"context_line":"      - section: \"ironic-inspector\""},{"line_number":43,"context_line":"        option: \"venv_tag\""},{"line_number":44,"context_line":"        value: \"{{ ironic_inspector_venv_tag }}\""},{"line_number":45,"context_line":"    tags:"},{"line_number":46,"context_line":"      - ironic-inspector-install"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- include: ironic_inspector_post_install.yml"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5faad753_9c71e6e3","line":46,"range":{"start_line":31,"start_character":0,"end_line":46,"end_character":32},"in_reply_to":"5faad753_dc8e7e2d","updated":"2019-09-06 21:37:53.000000000","message":"Probably we don\u0027t need separate venv, but I\u0027d defenitely add extra group for inspector so that deployer could setup them separately from ironic itself","commit_id":"0194b2c5e66a3f9022d3723b9bea8ccfb58ed46a"}],"tasks/ironic_db_setup.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"d2d5255960030dc2faa1654d3ac644c67f94099d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  notify:"},{"line_number":22,"context_line":"    - Restart ironic services"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Update database schema"},{"line_number":25,"context_line":"  command: \"{{ ironic_bin }}/ironic-inspector-dbsync --config-file /etc/ironic-inspector/ironic-inspector.conf upgrade\""},{"line_number":26,"context_line":"  become: yes"},{"line_number":27,"context_line":"  changed_when: false"},{"line_number":28,"context_line":"  notify:"},{"line_number":29,"context_line":"    - Restart ironic services"}],"source_content_type":"text/x-yaml","patch_set":80,"id":"3fa7e38b_ab3be636","line":29,"range":{"start_line":24,"start_character":0,"end_line":29,"end_character":29},"updated":"2019-12-04 09:58:16.000000000","message":"This file is included only for ironic_conductor. In real deployments ironic_conductor host may not have ironic-inspector-dbsync in it\u0027s venv. So I think that this task should be runned against ironic-inspector host only (correct me if I\u0027m wrong)","commit_id":"c9862428e2bc0f356efb1176b28d205cf8796751"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"c1c26ecde455dd2799232396bb3bbbd1ab6fdb2c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  become: yes"},{"line_number":19,"context_line":"  become_user: \"{{ ironic_system_user_name }}\""},{"line_number":20,"context_line":"  changed_when: false"},{"line_number":21,"context_line":"  notify:"},{"line_number":22,"context_line":"    - Restart ironic services"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Update database schema"}],"source_content_type":"text/x-yaml","patch_set":81,"id":"3fa7e38b_481ef1bb","line":21,"updated":"2019-12-04 15:18:07.000000000","message":"add the following:\nwhen: inventory_hostname \u003d\u003d groups[\u0027ironic_conductor\u0027][0]","commit_id":"4edeb87cf6390c800a3f9c073c775350d0f4bcfb"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"c1c26ecde455dd2799232396bb3bbbd1ab6fdb2c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  command: \"{{ ironic_bin }}/ironic-inspector-dbsync --config-file /etc/ironic-inspector/ironic-inspector.conf upgrade\""},{"line_number":26,"context_line":"  become: yes"},{"line_number":27,"context_line":"  changed_when: false"},{"line_number":28,"context_line":"  when: inventory_hostname in groups[\u0027ironic_inspector\u0027]"},{"line_number":29,"context_line":"  notify:"},{"line_number":30,"context_line":"    - Restart ironic services"}],"source_content_type":"text/x-yaml","patch_set":81,"id":"3fa7e38b_2814d59e","line":28,"range":{"start_line":28,"start_character":8,"end_line":28,"end_character":56},"updated":"2019-12-04 15:18:07.000000000","message":"Set this to \"\u0027ironic-inspector\u0027 in groups and inventory_hostname \u003d\u003d groups[\u0027ironic_conductor\u0027][0]\"","commit_id":"4edeb87cf6390c800a3f9c073c775350d0f4bcfb"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"55d3d2ff46eb8462be7075a13302ec0cb75e3768","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  command: \"{{ ironic_bin }}/ironic-inspector-dbsync --config-file /etc/ironic-inspector/ironic-inspector.conf upgrade\""},{"line_number":26,"context_line":"  become: yes"},{"line_number":27,"context_line":"  changed_when: false"},{"line_number":28,"context_line":"  when: inventory_hostname in groups[\u0027ironic_inspector\u0027]"},{"line_number":29,"context_line":"  notify:"},{"line_number":30,"context_line":"    - Restart ironic services"}],"source_content_type":"text/x-yaml","patch_set":81,"id":"3fa7e38b_08ed598d","line":28,"range":{"start_line":28,"start_character":8,"end_line":28,"end_character":56},"in_reply_to":"3fa7e38b_2814d59e","updated":"2019-12-04 15:21:38.000000000","message":"\"\u0027ironic_inspector\u0027 in groups and inventory_hostname \u003d\u003d groups[\u0027ironic_inspector\u0027][0]\"","commit_id":"4edeb87cf6390c800a3f9c073c775350d0f4bcfb"}],"tasks/ironic_inspector_db_setup.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"cb48829161191664cc6fd31b76e073ab3833b9ec","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Create DB for service"},{"line_number":17,"context_line":"  mysql_db:"},{"line_number":18,"context_line":"    login_user: \"{{ galera_root_user }}\""},{"line_number":19,"context_line":"    login_password: \"{{ galera_root_password }}\""},{"line_number":20,"context_line":"    login_host: \"{{ ironic_inspector_galera_address }}\""},{"line_number":21,"context_line":"    name: \"{{ ironic_inspector_galera_database }}\""},{"line_number":22,"context_line":"    state: \"present\""},{"line_number":23,"context_line":"  delegate_to: \"{{ ironic_inspector_db_setup_host }}\""},{"line_number":24,"context_line":"  no_log: False"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"- name: Grant access to the DB for the service"},{"line_number":27,"context_line":"  mysql_user:"},{"line_number":28,"context_line":"    login_user: \"{{ galera_root_user }}\""},{"line_number":29,"context_line":"    login_password: \"{{ galera_root_password }}\""},{"line_number":30,"context_line":"    login_host: \"{{ ironic_inspector_galera_address }}\""},{"line_number":31,"context_line":"    name: \"{{ ironic_inspector_galera_user }}\""},{"line_number":32,"context_line":"    password: \"{{ ironic_inspector_container_mysql_password }}\""},{"line_number":33,"context_line":"    host: \"{{ item }}\""},{"line_number":34,"context_line":"    state: \"present\""},{"line_number":35,"context_line":"    priv: \"{{ ironic_inspector_galera_database }}.*:ALL\""},{"line_number":36,"context_line":"  delegate_to: \"{{ ironic_inspector_db_setup_host }}\""},{"line_number":37,"context_line":"  with_items:"},{"line_number":38,"context_line":"    - \"localhost\""},{"line_number":39,"context_line":"    - \"%\""},{"line_number":40,"context_line":"  no_log: True"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: Update database schema"},{"line_number":43,"context_line":"  command: \"{{ ironic_inspector_bin }}/ironic-inspector-dbsync --config-file /etc/ironic-inspector/ironic-inspector.conf upgrade\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_a7cba747","line":40,"range":{"start_line":16,"start_character":0,"end_line":40,"end_character":14},"updated":"2019-09-05 06:31:17.000000000","message":"Please use https://opendev.org/openstack/openstack-ansible-os_ironic/src/branch/master/tasks/db_setup.yml by populating this variable https://opendev.org/openstack/openstack-ansible-os_ironic/src/branch/master/tasks/main.yml#L33","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"91a018eb4d6d30969c6b022aa3c2e4474d5abb8b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Create DB for service"},{"line_number":17,"context_line":"  mysql_db:"},{"line_number":18,"context_line":"    login_user: \"{{ galera_root_user }}\""},{"line_number":19,"context_line":"    login_password: \"{{ galera_root_password }}\""},{"line_number":20,"context_line":"    login_host: \"{{ ironic_inspector_galera_address }}\""},{"line_number":21,"context_line":"    name: \"{{ ironic_inspector_galera_database }}\""},{"line_number":22,"context_line":"    state: \"present\""},{"line_number":23,"context_line":"  delegate_to: \"{{ ironic_inspector_db_setup_host }}\""},{"line_number":24,"context_line":"  no_log: False"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"- name: Grant access to the DB for the service"},{"line_number":27,"context_line":"  mysql_user:"},{"line_number":28,"context_line":"    login_user: \"{{ galera_root_user }}\""},{"line_number":29,"context_line":"    login_password: \"{{ galera_root_password }}\""},{"line_number":30,"context_line":"    login_host: \"{{ ironic_inspector_galera_address }}\""},{"line_number":31,"context_line":"    name: \"{{ ironic_inspector_galera_user }}\""},{"line_number":32,"context_line":"    password: \"{{ ironic_inspector_container_mysql_password }}\""},{"line_number":33,"context_line":"    host: \"{{ item }}\""},{"line_number":34,"context_line":"    state: \"present\""},{"line_number":35,"context_line":"    priv: \"{{ ironic_inspector_galera_database }}.*:ALL\""},{"line_number":36,"context_line":"  delegate_to: \"{{ ironic_inspector_db_setup_host }}\""},{"line_number":37,"context_line":"  with_items:"},{"line_number":38,"context_line":"    - \"localhost\""},{"line_number":39,"context_line":"    - \"%\""},{"line_number":40,"context_line":"  no_log: True"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: Update database schema"},{"line_number":43,"context_line":"  command: \"{{ ironic_inspector_bin }}/ironic-inspector-dbsync --config-file /etc/ironic-inspector/ironic-inspector.conf upgrade\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_70b476f1","line":40,"range":{"start_line":16,"start_character":0,"end_line":40,"end_character":14},"in_reply_to":"7faddb67_a7cba747","updated":"2019-09-05 21:16:47.000000000","message":"Done","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"cb48829161191664cc6fd31b76e073ab3833b9ec","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    - \"%\""},{"line_number":40,"context_line":"  no_log: True"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: Update database schema"},{"line_number":43,"context_line":"  command: \"{{ ironic_inspector_bin }}/ironic-inspector-dbsync --config-file /etc/ironic-inspector/ironic-inspector.conf upgrade\""},{"line_number":44,"context_line":"  become: yes"},{"line_number":45,"context_line":"  become_user: \"{{ ironic_inspector_system_user_name }}\""},{"line_number":46,"context_line":"  changed_when: false"},{"line_number":47,"context_line":"  notify:"},{"line_number":48,"context_line":"    - Restart ironic inspector services"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_47d673f4","line":48,"range":{"start_line":42,"start_character":0,"end_line":48,"end_character":39},"updated":"2019-09-05 06:31:17.000000000","message":"This is supposed to be placed in https://opendev.org/openstack/openstack-ansible-os_ironic/src/branch/master/tasks/ironic_db_setup.yml","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"91a018eb4d6d30969c6b022aa3c2e4474d5abb8b","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    - \"%\""},{"line_number":40,"context_line":"  no_log: True"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: Update database schema"},{"line_number":43,"context_line":"  command: \"{{ ironic_inspector_bin }}/ironic-inspector-dbsync --config-file /etc/ironic-inspector/ironic-inspector.conf upgrade\""},{"line_number":44,"context_line":"  become: yes"},{"line_number":45,"context_line":"  become_user: \"{{ ironic_inspector_system_user_name }}\""},{"line_number":46,"context_line":"  changed_when: false"},{"line_number":47,"context_line":"  notify:"},{"line_number":48,"context_line":"    - Restart ironic inspector services"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_d068ca88","line":48,"range":{"start_line":42,"start_character":0,"end_line":48,"end_character":39},"in_reply_to":"7faddb67_47d673f4","updated":"2019-09-05 21:16:47.000000000","message":"Done","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"49855be3be1f5dcfa64ac0c5fa52b522b99660a8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2018, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5faad753_8501a2b2","line":1,"updated":"2019-09-05 21:30:54.000000000","message":"I guess you may drop this now","commit_id":"7131e21f7651d546651e760b78fae1790957a6a6"}],"tasks/ironic_inspector_dhcp_post_install.yml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"202eaf9f2d2e4b7a7af889dbd07a5736c0a2392d","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Copy in dhcpd config file"},{"line_number":17,"context_line":"  template:"},{"line_number":18,"context_line":"    src: \"dhcpd.conf.j2\""},{"line_number":19,"context_line":"    dest: \"/etc/dhcp/dhcpd.conf\""},{"line_number":20,"context_line":"  notify:"},{"line_number":21,"context_line":"    - Restart isc-dhcp-server"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_c9beeed2","line":18,"range":{"start_line":18,"start_character":10,"end_line":18,"end_character":23},"updated":"2019-09-05 15:53:31.000000000","message":"where is this template file?","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"91a018eb4d6d30969c6b022aa3c2e4474d5abb8b","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Copy in dhcpd config file"},{"line_number":17,"context_line":"  template:"},{"line_number":18,"context_line":"    src: \"dhcpd.conf.j2\""},{"line_number":19,"context_line":"    dest: \"/etc/dhcp/dhcpd.conf\""},{"line_number":20,"context_line":"  notify:"},{"line_number":21,"context_line":"    - Restart isc-dhcp-server"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_6e41f862","line":18,"range":{"start_line":18,"start_character":10,"end_line":18,"end_character":23},"in_reply_to":"7faddb67_c9beeed2","updated":"2019-09-05 21:16:47.000000000","message":"Done","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"}],"tasks/ironic_inspector_dnsmasq_post_install.yml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"202eaf9f2d2e4b7a7af889dbd07a5736c0a2392d","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Copy in dnsmqsq config file"},{"line_number":33,"context_line":"  template:"},{"line_number":34,"context_line":"    src: \"dnsmasq.conf.j2\""},{"line_number":35,"context_line":"    dest: \"/etc/dnsmasq.conf\""},{"line_number":36,"context_line":"  notify:"},{"line_number":37,"context_line":"    - Restart dnsmasq"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_a9a052a6","line":34,"range":{"start_line":34,"start_character":10,"end_line":34,"end_character":25},"updated":"2019-09-05 15:53:31.000000000","message":"where is this template","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"91a018eb4d6d30969c6b022aa3c2e4474d5abb8b","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Copy in dnsmqsq config file"},{"line_number":33,"context_line":"  template:"},{"line_number":34,"context_line":"    src: \"dnsmasq.conf.j2\""},{"line_number":35,"context_line":"    dest: \"/etc/dnsmasq.conf\""},{"line_number":36,"context_line":"  notify:"},{"line_number":37,"context_line":"    - Restart dnsmasq"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_9d6b50ee","line":34,"range":{"start_line":34,"start_character":10,"end_line":34,"end_character":25},"in_reply_to":"7faddb67_a9a052a6","updated":"2019-09-05 21:16:47.000000000","message":"Done","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"202eaf9f2d2e4b7a7af889dbd07a5736c0a2392d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  notify:"},{"line_number":37,"context_line":"    - Restart dnsmasq"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Ensure bind-interfaces/enable-tftp is not present"},{"line_number":40,"context_line":"  lineinfile:"},{"line_number":41,"context_line":"    dest: /etc/dnsmasq.conf"},{"line_number":42,"context_line":"    line: \"{{ item }}\""},{"line_number":43,"context_line":"    state: absent"},{"line_number":44,"context_line":"  with_items:"},{"line_number":45,"context_line":"    - \u0027bind-interfaces\u0027"},{"line_number":46,"context_line":"    - \u0027enable-tftp\u0027"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- name: Create  directories"},{"line_number":49,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_49cafe6d","line":46,"range":{"start_line":39,"start_character":0,"end_line":46,"end_character":19},"updated":"2019-09-05 15:53:31.000000000","message":"why does this task modify the file that has just been templated? Just remove these things from the template?","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"91a018eb4d6d30969c6b022aa3c2e4474d5abb8b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  notify:"},{"line_number":37,"context_line":"    - Restart dnsmasq"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Ensure bind-interfaces/enable-tftp is not present"},{"line_number":40,"context_line":"  lineinfile:"},{"line_number":41,"context_line":"    dest: /etc/dnsmasq.conf"},{"line_number":42,"context_line":"    line: \"{{ item }}\""},{"line_number":43,"context_line":"    state: absent"},{"line_number":44,"context_line":"  with_items:"},{"line_number":45,"context_line":"    - \u0027bind-interfaces\u0027"},{"line_number":46,"context_line":"    - \u0027enable-tftp\u0027"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- name: Create  directories"},{"line_number":49,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5faad753_2526aeb9","line":46,"range":{"start_line":39,"start_character":0,"end_line":46,"end_character":19},"in_reply_to":"7faddb67_49cafe6d","updated":"2019-09-05 21:16:47.000000000","message":"Its not in the template.","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"}],"tasks/ironic_inspector_httpboot_post_install.yml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"9f709ae42e534ac49f84a360f6c4b11b907fc140","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2019, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5faad753_9ceb26af","line":1,"updated":"2019-09-06 21:33:42.000000000","message":"does this really warrant it\u0027s own file - ideally fold this into the existing task which creates directories","commit_id":"0194b2c5e66a3f9022d3723b9bea8ccfb58ed46a"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"a604f32ec3335f763b556b47df560638d3e979a4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2019, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5faad753_460ab526","line":1,"in_reply_to":"5faad753_9ceb26af","updated":"2019-09-07 13:56:00.000000000","message":"Done","commit_id":"0194b2c5e66a3f9022d3723b9bea8ccfb58ed46a"}],"tasks/ironic_inspector_init_systemd.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"cb48829161191664cc6fd31b76e073ab3833b9ec","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2016, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_4750b3d5","line":1,"updated":"2019-09-05 06:31:17.000000000","message":"I\u0027d say you don\u0027t need this - use https://opendev.org/openstack/ansible-role-systemd_service just by adding service into the list https://opendev.org/openstack/openstack-ansible-os_ironic/src/branch/master/defaults/main.yml#L58","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"91a018eb4d6d30969c6b022aa3c2e4474d5abb8b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2016, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5faad753_851be271","line":1,"in_reply_to":"7faddb67_4750b3d5","updated":"2019-09-05 21:16:47.000000000","message":"Done","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"}],"tasks/ironic_inspector_ipa_download.yml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"202eaf9f2d2e4b7a7af889dbd07a5736c0a2392d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    ironic_inspector_ipa_download_path: \"{{ ironic_inspector_ipa_tftpboot_image_dir }}\""},{"line_number":29,"context_line":"  when: ironic_inspector_pxe_boot_mode \u003d\u003d \"tftp\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Download ipa kernel image"},{"line_number":32,"context_line":"  get_url:"},{"line_number":33,"context_line":"    url: \"{{ ironic_inspector_ipa_kernel_url }}\""},{"line_number":34,"context_line":"    dest: \"{{ ironic_inspector_ipa_download_path }}/{{ ironic_inspector_ipa_kernel_name }}\""},{"line_number":35,"context_line":"    checksum: \"sha256:{{ironic_inspector_ipa_kernel_sha256.split(\u0027 \u0027)[0]}}\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- name: Download ipa initrd image"},{"line_number":38,"context_line":"  get_url:"},{"line_number":39,"context_line":"    url: \"{{ ironic_inspector_ipa_initrd_url }}\""},{"line_number":40,"context_line":"    dest: \"{{ ironic_inspector_ipa_download_path }}/{{ ironic_inspector_ipa_initrd_name }}\""},{"line_number":41,"context_line":"    checksum: \"sha256:{{ironic_inspector_ipa_initrd_sha256.split(\u0027 \u0027)[0]}}\""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_29946243","line":41,"range":{"start_line":31,"start_character":0,"end_line":41,"end_character":75},"updated":"2019-09-05 15:53:31.000000000","message":"collapse this to one task with a loop","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"91a018eb4d6d30969c6b022aa3c2e4474d5abb8b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    ironic_inspector_ipa_download_path: \"{{ ironic_inspector_ipa_tftpboot_image_dir }}\""},{"line_number":29,"context_line":"  when: ironic_inspector_pxe_boot_mode \u003d\u003d \"tftp\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Download ipa kernel image"},{"line_number":32,"context_line":"  get_url:"},{"line_number":33,"context_line":"    url: \"{{ ironic_inspector_ipa_kernel_url }}\""},{"line_number":34,"context_line":"    dest: \"{{ ironic_inspector_ipa_download_path }}/{{ ironic_inspector_ipa_kernel_name }}\""},{"line_number":35,"context_line":"    checksum: \"sha256:{{ironic_inspector_ipa_kernel_sha256.split(\u0027 \u0027)[0]}}\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- name: Download ipa initrd image"},{"line_number":38,"context_line":"  get_url:"},{"line_number":39,"context_line":"    url: \"{{ ironic_inspector_ipa_initrd_url }}\""},{"line_number":40,"context_line":"    dest: \"{{ ironic_inspector_ipa_download_path }}/{{ ironic_inspector_ipa_initrd_name }}\""},{"line_number":41,"context_line":"    checksum: \"sha256:{{ironic_inspector_ipa_initrd_sha256.split(\u0027 \u0027)[0]}}\""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_ce97ccea","line":41,"range":{"start_line":31,"start_character":0,"end_line":41,"end_character":75},"in_reply_to":"7faddb67_29946243","updated":"2019-09-05 21:16:47.000000000","message":"Done","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"}],"tasks/ironic_inspector_nginx_post_install.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"cb48829161191664cc6fd31b76e073ab3833b9ec","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2018, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_471753ef","line":1,"updated":"2019-09-05 06:31:17.000000000","message":"Are you sure about nginx? Is this for uwsgi? Since we\u0027re moving right now to use bare uwsgi with https://opendev.org/openstack/ansible-role-uwsgi\n\nhere\u0027s PR for ironic https://review.opendev.org/#/c/680078/","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"91a018eb4d6d30969c6b022aa3c2e4474d5abb8b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2018, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_0ebc04b3","line":1,"in_reply_to":"7faddb67_471753ef","updated":"2019-09-05 21:16:47.000000000","message":"i\u0027ll wait until the ironic PR is in before I make this change.","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"9f709ae42e534ac49f84a360f6c4b11b907fc140","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Configure virtual hosts"},{"line_number":32,"context_line":"  template:"},{"line_number":33,"context_line":"    src: ironic_inspector_nginx.conf.j2"},{"line_number":34,"context_line":"    dest: \"/etc/nginx/{{ ironic_inspector_nginx_conf_path }}/{{ item }}.conf\""},{"line_number":35,"context_line":"  with_items:"},{"line_number":36,"context_line":"     - ironic_inspector"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5faad753_5c692e23","line":33,"range":{"start_line":33,"start_character":9,"end_line":33,"end_character":39},"updated":"2019-09-06 21:33:42.000000000","message":"is this missing?","commit_id":"0194b2c5e66a3f9022d3723b9bea8ccfb58ed46a"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"a604f32ec3335f763b556b47df560638d3e979a4","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Configure virtual hosts"},{"line_number":32,"context_line":"  template:"},{"line_number":33,"context_line":"    src: ironic_inspector_nginx.conf.j2"},{"line_number":34,"context_line":"    dest: \"/etc/nginx/{{ ironic_inspector_nginx_conf_path }}/{{ item }}.conf\""},{"line_number":35,"context_line":"  with_items:"},{"line_number":36,"context_line":"     - ironic_inspector"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5faad753_812657b7","line":33,"range":{"start_line":33,"start_character":9,"end_line":33,"end_character":39},"in_reply_to":"5faad753_5c692e23","updated":"2019-09-07 13:56:00.000000000","message":"removing file for the uwsgi change, if needed i\u0027ll re-add it","commit_id":"0194b2c5e66a3f9022d3723b9bea8ccfb58ed46a"}],"tasks/ironic_inspector_post_install.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"605deece60d041d9e414daf9e14e668e71e9518f","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    group: \"{{ ironic_inspector_system_group_name }}\""},{"line_number":7,"context_line":"    mode: \"0755\""},{"line_number":8,"context_line":"  with_items:"},{"line_number":9,"context_line":"    - /ironic"},{"line_number":10,"context_line":"    - /ironic/log"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Generate ironic inspector config"},{"line_number":13,"context_line":"  config_template:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5faad753_e53ad632","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":17},"updated":"2019-09-05 21:41:33.000000000","message":"What\u0027s the purpose of these directories?","commit_id":"7131e21f7651d546651e760b78fae1790957a6a6"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"605deece60d041d9e414daf9e14e668e71e9518f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    config_overrides: \"{{ item.config_overrides }}\""},{"line_number":20,"context_line":"    config_type: \"{{ item.config_type }}\""},{"line_number":21,"context_line":"  with_items:"},{"line_number":22,"context_line":"    - src: \"inspector.conf.j2\""},{"line_number":23,"context_line":"      dest: \"/etc/ironic-inspector/ironic-inspector.conf\""},{"line_number":24,"context_line":"      config_overrides: \"{{ ironic_inspector_conf_overrides }}\""},{"line_number":25,"context_line":"      config_type: \"ini\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5faad753_c5f8fa7d","line":22,"range":{"start_line":22,"start_character":12,"end_line":22,"end_character":29},"updated":"2019-09-05 21:41:33.000000000","message":"that template is also missing","commit_id":"7131e21f7651d546651e760b78fae1790957a6a6"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"ca952f84f35f0a02ac027d81469f741e324a8064","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    config_overrides: \"{{ item.config_overrides }}\""},{"line_number":20,"context_line":"    config_type: \"{{ item.config_type }}\""},{"line_number":21,"context_line":"  with_items:"},{"line_number":22,"context_line":"    - src: \"inspector.conf.j2\""},{"line_number":23,"context_line":"      dest: \"/etc/ironic-inspector/ironic-inspector.conf\""},{"line_number":24,"context_line":"      config_overrides: \"{{ ironic_inspector_conf_overrides }}\""},{"line_number":25,"context_line":"      config_type: \"ini\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5faad753_48897f24","line":22,"range":{"start_line":22,"start_character":12,"end_line":22,"end_character":29},"in_reply_to":"5faad753_c5f8fa7d","updated":"2019-09-06 14:25:59.000000000","message":"Done","commit_id":"7131e21f7651d546651e760b78fae1790957a6a6"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"605deece60d041d9e414daf9e14e668e71e9518f","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- name: Include sudoers file"},{"line_number":45,"context_line":"  template:"},{"line_number":46,"context_line":"    src: \"ironic-inspector-sudoers.j2\""},{"line_number":47,"context_line":"    dest: \"/etc/sudoers.d/{{ ironic_inspector_system_user_name }}_sudoers\""},{"line_number":48,"context_line":"    mode: \"0440\""},{"line_number":49,"context_line":"    owner: \"root\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5faad753_c56b1a1d","line":46,"range":{"start_line":46,"start_character":10,"end_line":46,"end_character":37},"updated":"2019-09-05 21:41:33.000000000","message":"no template as well","commit_id":"7131e21f7651d546651e760b78fae1790957a6a6"},{"author":{"_account_id":14552,"name":"Bjoern Teipel","email":"bjoern.teipel@rackspace.com","username":"bjoern"},"change_message_id":"30ad3e5ad88c9eaced520e006a25c6d9bb403ead","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    path: /etc/default/isc-dhcp-server"},{"line_number":26,"context_line":"    state: present"},{"line_number":27,"context_line":"    regexp: \u0027^INTERFACES\u003d\u0027"},{"line_number":28,"context_line":"    line: \u0027INTERFACES\u003d\"{{ ironic_inspector_dhcp_interface }}\"\u0027"},{"line_number":29,"context_line":"  notify:"},{"line_number":30,"context_line":"    - Restart isc-dhcp-server"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5faad753_45db5dec","line":28,"updated":"2019-09-10 14:08:22.000000000","message":"This could interfere with already installed services for other purposes, we should keep the ironic dhcp config complete separate from other DHCP servers. Perhaps we only deploy dnsmasq for now to simplify","commit_id":"0c538d85e1532f73161634e811c5326d1b9b0d13"},{"author":{"_account_id":14552,"name":"Bjoern Teipel","email":"bjoern.teipel@rackspace.com","username":"bjoern"},"change_message_id":"30ad3e5ad88c9eaced520e006a25c6d9bb403ead","unresolved":false,"context_lines":[{"line_number":57,"context_line":"- name: Copy in dnsmqsq config file"},{"line_number":58,"context_line":"  template:"},{"line_number":59,"context_line":"    src: \"dnsmasq.conf.j2\""},{"line_number":60,"context_line":"    dest: \"/etc/dnsmasq.conf\""},{"line_number":61,"context_line":"  notify:"},{"line_number":62,"context_line":"    - Restart dnsmasq"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5faad753_653a1935","line":60,"updated":"2019-09-10 14:08:22.000000000","message":"The inspector (dnsmasq-ironic.conf) should use it\u0027s own dnsmasq file, not to collide with system, like lxc or other service configuration","commit_id":"0c538d85e1532f73161634e811c5326d1b9b0d13"},{"author":{"_account_id":14552,"name":"Bjoern Teipel","email":"bjoern.teipel@rackspace.com","username":"bjoern"},"change_message_id":"30ad3e5ad88c9eaced520e006a25c6d9bb403ead","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- name: Ensure bind-interfaces/enable-tftp is not present"},{"line_number":65,"context_line":"  lineinfile:"},{"line_number":66,"context_line":"    dest: /etc/dnsmasq.conf"},{"line_number":67,"context_line":"    line: \"{{ item }}\""},{"line_number":68,"context_line":"    state: absent"},{"line_number":69,"context_line":"  with_items:"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5faad753_c5f0ad6a","line":66,"updated":"2019-09-10 14:08:22.000000000","message":"Sams as above","commit_id":"0c538d85e1532f73161634e811c5326d1b9b0d13"},{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"9c1d6ffa2333af65be231c47884fb3fc4c19ac23","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    src: \"dnsmasq.conf.j2\""},{"line_number":42,"context_line":"    dest: \"/etc/dnsmasq.d/inspector-dnsmasq.conf\""},{"line_number":43,"context_line":"  notify:"},{"line_number":44,"context_line":"    - Restart dnsmasq"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: Ensure bind-interfaces/enable-tftp is not present"},{"line_number":47,"context_line":"  lineinfile:"}],"source_content_type":"text/x-yaml","patch_set":63,"id":"3fa7e38b_45d81a1d","line":44,"updated":"2019-11-14 16:47:00.000000000","message":"I think you only need to restart dnsmasq once, by restarting 3 times your just adding execution time.","commit_id":"c145fb1c7e8207c64931cc4602e677bffd431c4e"},{"author":{"_account_id":16011,"name":"James Denton","email":"james.denton@outlook.com","username":"busterswt"},"change_message_id":"69decb683ee6f04cb19f47e0b65ad6282223299b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  notify:"},{"line_number":21,"context_line":"    - Restart isc-dhcp-server"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- lineinfile:"},{"line_number":24,"context_line":"    path: /etc/default/dnsmasq"},{"line_number":25,"context_line":"    state: present"},{"line_number":26,"context_line":"    line: \u0027DNSMASQ_EXCEPT\u003dlo\u0027"}],"source_content_type":"text/x-yaml","patch_set":64,"id":"3fa7e38b_4c1a7ec6","line":23,"updated":"2019-11-15 04:31:53.000000000","message":"This task should be named and the module and respective params spaced accordingly.","commit_id":"1e304ec3144c25c86706194b571294a61d4c9a1f"},{"author":{"_account_id":16011,"name":"James Denton","email":"james.denton@outlook.com","username":"busterswt"},"change_message_id":"69decb683ee6f04cb19f47e0b65ad6282223299b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    - Restart isc-dhcp-server"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- lineinfile:"},{"line_number":24,"context_line":"    path: /etc/default/dnsmasq"},{"line_number":25,"context_line":"    state: present"},{"line_number":26,"context_line":"    line: \u0027DNSMASQ_EXCEPT\u003dlo\u0027"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":64,"id":"3fa7e38b_8c4e36c0","line":24,"range":{"start_line":24,"start_character":10,"end_line":24,"end_character":30},"updated":"2019-11-15 04:31:53.000000000","message":"This file may not exist on all distros tested (e.g. CentOS)","commit_id":"1e304ec3144c25c86706194b571294a61d4c9a1f"},{"author":{"_account_id":16011,"name":"James Denton","email":"james.denton@outlook.com","username":"busterswt"},"change_message_id":"69decb683ee6f04cb19f47e0b65ad6282223299b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    state: present"},{"line_number":26,"context_line":"    line: \u0027DNSMASQ_EXCEPT\u003dlo\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- lineinfile:"},{"line_number":29,"context_line":"    path: /etc/default/dnsmasq"},{"line_number":30,"context_line":"    state: present"},{"line_number":31,"context_line":"    regexp: \u0027^#IGNORE_RESOLVCONF\u003d.*\u0027"}],"source_content_type":"text/x-yaml","patch_set":64,"id":"3fa7e38b_ec76ca0c","line":28,"updated":"2019-11-15 04:31:53.000000000","message":"This task should be named and the module and respective params spaced accordingly.","commit_id":"1e304ec3144c25c86706194b571294a61d4c9a1f"},{"author":{"_account_id":16011,"name":"James Denton","email":"james.denton@outlook.com","username":"busterswt"},"change_message_id":"69decb683ee6f04cb19f47e0b65ad6282223299b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    line: \u0027DNSMASQ_EXCEPT\u003dlo\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- lineinfile:"},{"line_number":29,"context_line":"    path: /etc/default/dnsmasq"},{"line_number":30,"context_line":"    state: present"},{"line_number":31,"context_line":"    regexp: \u0027^#IGNORE_RESOLVCONF\u003d.*\u0027"},{"line_number":32,"context_line":"    line: \u0027IGNORE_RESOLVCONF\u003dyes\u0027"}],"source_content_type":"text/x-yaml","patch_set":64,"id":"3fa7e38b_2c4dc2c3","line":29,"range":{"start_line":29,"start_character":10,"end_line":29,"end_character":30},"updated":"2019-11-15 04:31:53.000000000","message":"ditto","commit_id":"1e304ec3144c25c86706194b571294a61d4c9a1f"},{"author":{"_account_id":14552,"name":"Bjoern Teipel","email":"bjoern.teipel@rackspace.com","username":"bjoern"},"change_message_id":"5c0d94c013458c6a75e4a8945a5bc9c6d2bbc507","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    path: /etc/default/dnsmasq"},{"line_number":26,"context_line":"    state: present"},{"line_number":27,"context_line":"    line: \u0027DNSMASQ_EXCEPT\u003dlo\u0027"},{"line_number":28,"context_line":"  when: ansible_os_family \u003d\u003d \u0027Ubuntu\u0027"},{"line_number":29,"context_line":"  notify:"},{"line_number":30,"context_line":"    - Restart dnsmasq"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":69,"id":"3fa7e38b_ac7fce67","line":28,"updated":"2019-11-27 17:45:32.000000000","message":"That should be Debian","commit_id":"d5bcd3ecdd1e29b5a7aa68200dbd91acc7586859"}],"tasks/ironic_inspector_pre_install.yml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"202eaf9f2d2e4b7a7af889dbd07a5736c0a2392d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    home: \"{{ ironic_inspector_system_home_folder }}\""},{"line_number":41,"context_line":"    generate_ssh_key: \"yes\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- name: Create ironic inspector dir"},{"line_number":44,"context_line":"  file:"},{"line_number":45,"context_line":"    path: \"{{ item.path }}\""},{"line_number":46,"context_line":"    state: directory"},{"line_number":47,"context_line":"    owner: \"{{ item.owner|default(ironic_inspector_system_user_name) }}\""},{"line_number":48,"context_line":"    group: \"{{ item.group|default(ironic_inspector_system_group_name) }}\""},{"line_number":49,"context_line":"    mode: \"{{ item.mode|default(\u00270755\u0027) }}\""},{"line_number":50,"context_line":"  with_items:"},{"line_number":51,"context_line":"    - { path: \"/openstack/venvs\", mode: \"0755\", owner: \"root\", group: \"root\" }"},{"line_number":52,"context_line":"    - { path: \"/etc/ironic-inspector\" }"},{"line_number":53,"context_line":"    - { path: \"/etc/ironic-inspector/rootwrap.d\" }"},{"line_number":54,"context_line":"    - { path: \"/etc/sudoers.d\", mode: \"0750\", owner: \"root\", group: \"root\" }"},{"line_number":55,"context_line":"    - { path: \"/var/cache/ironic-inspector\" }"},{"line_number":56,"context_line":"    - { path: \"{{ ironic_inspector_system_home_folder }}\" }"},{"line_number":57,"context_line":"    - { path: \"{{ ironic_inspector_system_home_folder }}/.ssh\", mode: \"0700\" }"},{"line_number":58,"context_line":"    - { path: \"{{ ironic_inspector_lock_path }}\" }"},{"line_number":59,"context_line":"    - { path: \"/var/run/ironic-inspector\" }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"- name: Test for log directory or link"},{"line_number":62,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_0995e63c","line":59,"range":{"start_line":43,"start_character":0,"end_line":59,"end_character":43},"updated":"2019-09-05 15:53:31.000000000","message":"there are other dirs made in other tasks, why not do them all here? You can also make them conditional","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"6f79459385955dacbf42ea8d08a269e420815fc5","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  failed_when: false"},{"line_number":71,"context_line":"  changed_when: log_dir.rc !\u003d 0"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"- name: Create ironic inspector log dir"},{"line_number":74,"context_line":"  file:"},{"line_number":75,"context_line":"    path: \"{{ item.path }}\""},{"line_number":76,"context_line":"    state: directory"},{"line_number":77,"context_line":"    owner: \"{{ item.owner|default(ironic_inspector_system_user_name) }}\""},{"line_number":78,"context_line":"    group: \"{{ item.group|default(ironic_inspector_system_group_name) }}\""},{"line_number":79,"context_line":"    mode: \"{{ item.mode|default(\u00270755\u0027) }}\""},{"line_number":80,"context_line":"  with_items:"},{"line_number":81,"context_line":"    - { path: \"{{ ironic_inspector_system_log_folder }}\" }"},{"line_number":82,"context_line":"  when: log_dir.rc !\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5faad753_a5c5be5d","line":82,"range":{"start_line":73,"start_character":0,"end_line":82,"end_character":23},"updated":"2019-09-05 21:35:38.000000000","message":"We\u0027ve moved to systemd-journald so no log dir needed","commit_id":"7131e21f7651d546651e760b78fae1790957a6a6"}],"tasks/ironic_inspector_service_setup.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"cb48829161191664cc6fd31b76e073ab3833b9ec","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2016, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_e70d1fe7","line":1,"updated":"2019-09-05 06:31:17.000000000","message":"You don\u0027t need this either, just add extra users and stuff to this list https://opendev.org/openstack/openstack-ansible-os_ironic/src/branch/master/tasks/main.yml#L118","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"91a018eb4d6d30969c6b022aa3c2e4474d5abb8b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2016, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_eea728a7","line":1,"in_reply_to":"7faddb67_e70d1fe7","updated":"2019-09-05 21:16:47.000000000","message":"Done","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"}],"tasks/ironic_inspector_tftpboot_post_install.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"cb48829161191664cc6fd31b76e073ab3833b9ec","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2018, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_47c5135b","line":1,"updated":"2019-09-05 06:31:17.000000000","message":"I\u0027d say this is kinda duplicates https://opendev.org/openstack/openstack-ansible-os_ironic/src/branch/master/tasks/ironic_conductor_post_install.yml\n\nIf it\u0027s smth different and ironic_conductor_post_install.yml can\u0027t be used, at least use \"{{ ironic_tftpd_root }}\"","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"91a018eb4d6d30969c6b022aa3c2e4474d5abb8b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2018, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_939d7f0a","line":1,"in_reply_to":"7faddb67_47c5135b","updated":"2019-09-05 21:16:47.000000000","message":"Done","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"202eaf9f2d2e4b7a7af889dbd07a5736c0a2392d","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: Default pxelinux.0 config"},{"line_number":28,"context_line":"  template:"},{"line_number":29,"context_line":"    src: pxelinux-default.j2"},{"line_number":30,"context_line":"    dest: /tftpboot/pxelinux.cfg/default"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Copy in tftpd-hpa map file"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_096e4663","line":29,"range":{"start_line":29,"start_character":9,"end_line":29,"end_character":28},"updated":"2019-09-05 15:53:31.000000000","message":"where is this template?","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"91a018eb4d6d30969c6b022aa3c2e4474d5abb8b","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: Default pxelinux.0 config"},{"line_number":28,"context_line":"  template:"},{"line_number":29,"context_line":"    src: pxelinux-default.j2"},{"line_number":30,"context_line":"    dest: /tftpboot/pxelinux.cfg/default"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Copy in tftpd-hpa map file"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_33884bc4","line":29,"range":{"start_line":29,"start_character":9,"end_line":29,"end_character":28},"in_reply_to":"7faddb67_096e4663","updated":"2019-09-05 21:16:47.000000000","message":"Done","commit_id":"fa98f26b58f5185d2ada6a3d808b81f227403ff3"}],"tasks/ironic_post_install.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"6b93d4c4cf3ef552c39e20a0e5fdc799eea7cbd7","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    mode: \"0644\""},{"line_number":93,"context_line":"    config_overrides: \"{{ item.config_overrides }}\""},{"line_number":94,"context_line":"    config_type: \"{{ item.config_type }}\""},{"line_number":95,"context_line":"  with_items:"},{"line_number":96,"context_line":"    - src: \"ironic.conf.j2\""},{"line_number":97,"context_line":"      dest: \"/etc/ironic/ironic.conf\""},{"line_number":98,"context_line":"      config_overrides: \"{{ ironic_ironic_conf_overrides }}\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5faad753_7ad75d25","line":95,"updated":"2019-09-06 07:04:37.000000000","message":"add here\n\n  when: item.condition | default(True)\n\nto be able to use conditionals where needed","commit_id":"a693e521e761613285c2015a0f0067d04a7d026f"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"6b93d4c4cf3ef552c39e20a0e5fdc799eea7cbd7","unresolved":false,"context_lines":[{"line_number":107,"context_line":"      dest: \"/etc/ironic-inspector/ironic-inspector.conf\""},{"line_number":108,"context_line":"      config_overrides: \"{{ ironic_inspector_conf_overrides }}\""},{"line_number":109,"context_line":"      config_type: \"ini\""},{"line_number":110,"context_line":"      owner: \"{{ ironic_inspector_system_user_name }}\""},{"line_number":111,"context_line":"    - src: \"rootwrap.conf.j2\""},{"line_number":112,"context_line":"      dest: \"/etc/ironic-inspector/rootwrap.conf\""},{"line_number":113,"context_line":"      owner: \"root\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5faad753_facb4d6f","line":110,"updated":"2019-09-06 07:04:37.000000000","message":"add here\n      condition: \"{{ inventory_hostname in groups[\u0027ironic_inspector\u0027] }}\"","commit_id":"a693e521e761613285c2015a0f0067d04a7d026f"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"6b93d4c4cf3ef552c39e20a0e5fdc799eea7cbd7","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    owner: \"root\""},{"line_number":143,"context_line":"    group: \"root\""},{"line_number":144,"context_line":"  with_items:"},{"line_number":145,"context_line":"    - {{ ironic_system_user_name }}"},{"line_number":146,"context_line":"    - {{ ironic_inspector_system_user_name }}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5faad753_3a88051e","line":145,"range":{"start_line":145,"start_character":6,"end_line":145,"end_character":35},"updated":"2019-09-06 07:04:37.000000000","message":"missing quotes around","commit_id":"a693e521e761613285c2015a0f0067d04a7d026f"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"ca952f84f35f0a02ac027d81469f741e324a8064","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    owner: \"root\""},{"line_number":143,"context_line":"    group: \"root\""},{"line_number":144,"context_line":"  with_items:"},{"line_number":145,"context_line":"    - {{ ironic_system_user_name }}"},{"line_number":146,"context_line":"    - {{ ironic_inspector_system_user_name }}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5faad753_5345a66f","line":145,"range":{"start_line":145,"start_character":6,"end_line":145,"end_character":35},"in_reply_to":"5faad753_3a88051e","updated":"2019-09-06 14:25:59.000000000","message":"Done","commit_id":"a693e521e761613285c2015a0f0067d04a7d026f"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"6b93d4c4cf3ef552c39e20a0e5fdc799eea7cbd7","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    group: \"root\""},{"line_number":144,"context_line":"  with_items:"},{"line_number":145,"context_line":"    - {{ ironic_system_user_name }}"},{"line_number":146,"context_line":"    - {{ ironic_inspector_system_user_name }}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5faad753_1a83c906","line":146,"range":{"start_line":146,"start_character":4,"end_line":146,"end_character":45},"updated":"2019-09-06 07:04:37.000000000","message":"Let\u0027s try to transform this to smth conditional, like:\n\"{{ inventory_hostname in groups[\u0027ironic_inspector\u0027] | ternary(ironic_inspector_system_user_name, \u0027\u0027) }}\"","commit_id":"a693e521e761613285c2015a0f0067d04a7d026f"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"9e00c1a32ea1c7f20709b0babe6921e6fcb44572","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    config_type: \"{{ item.config_type }}\""},{"line_number":95,"context_line":"  when: item.condition | default(True)"},{"line_number":96,"context_line":"  with_items:"},{"line_number":97,"context_line":"    - src: \"ironic.conf.j2\""},{"line_number":98,"context_line":"      dest: \"/etc/ironic/ironic.conf\""},{"line_number":99,"context_line":"      config_overrides: \"{{ ironic_ironic_conf_overrides }}\""},{"line_number":100,"context_line":"      config_type: \"ini\""},{"line_number":101,"context_line":"    - src: \"rootwrap.conf.j2\""},{"line_number":102,"context_line":"      dest: \"/etc/ironic/rootwrap.conf\""},{"line_number":103,"context_line":"      owner: \"root\""},{"line_number":104,"context_line":"      group: \"root\""},{"line_number":105,"context_line":"      config_overrides: \"{{ ironic_rootwrap_conf_overrides }}\""},{"line_number":106,"context_line":"      config_type: \"ini\""},{"line_number":107,"context_line":"    - src: \"inspector.conf.j2\""},{"line_number":108,"context_line":"      dest: \"/etc/ironic-inspector/ironic-inspector.conf\""},{"line_number":109,"context_line":"      config_overrides: \"{{ ironic_inspector_conf_overrides }}\""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"5faad753_c36f6ec3","line":106,"range":{"start_line":97,"start_character":0,"end_line":106,"end_character":24},"updated":"2019-09-08 17:58:21.000000000","message":"do you need these to be installed in the inspector host? if not, add a condition to them too","commit_id":"080637bc896d5fb5e584f233ba4ab4e5f4c3221f"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2936a5f527c6c317f689ab1e9c1686ca943b8b89","unresolved":false,"context_lines":[{"line_number":104,"context_line":"      group: \"root\""},{"line_number":105,"context_line":"      config_overrides: \"{{ ironic_rootwrap_conf_overrides }}\""},{"line_number":106,"context_line":"      config_type: \"ini\""},{"line_number":107,"context_line":"    - src: \"inspector.conf.j2\""},{"line_number":108,"context_line":"      dest: \"/etc/ironic-inspector/ironic-inspector.conf\""},{"line_number":109,"context_line":"      config_overrides: \"{{ ironic_inspector_conf_overrides }}\""},{"line_number":110,"context_line":"      config_type: \"ini\""},{"line_number":111,"context_line":"    - src: \"rootwrap.conf.j2\""},{"line_number":112,"context_line":"      dest: \"/etc/ironic-inspector/rootwrap.conf\""},{"line_number":113,"context_line":"      owner: \"root\""},{"line_number":114,"context_line":"      group: \"root\""},{"line_number":115,"context_line":"      config_overrides: \"{{ ironic_inspector_rootwrap_conf_overrides }}\""},{"line_number":116,"context_line":"      config_type: \"ini\""},{"line_number":117,"context_line":"  notify: Restart ironic services"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":72,"id":"3fa7e38b_05a7c952","line":115,"range":{"start_line":107,"start_character":0,"end_line":115,"end_character":72},"updated":"2019-11-28 14:28:41.000000000","message":"shouldn\u0027t these 2 items being deployed only when inventory_hostname in groups[\u0027ironic_inspector\u0027]?","commit_id":"9900faf3f3ef2d718408aa11441fbf9070228bd6"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2936a5f527c6c317f689ab1e9c1686ca943b8b89","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    - rootwrap.d/*"},{"line_number":134,"context_line":"  notify: Restart ironic services"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"- name: Include sudoers file"},{"line_number":137,"context_line":"  template:"},{"line_number":138,"context_line":"    src: \"{{ item.file }}\""},{"line_number":139,"context_line":"    dest: \"/etc/sudoers.d/{{ item.name }}_sudoers\""},{"line_number":140,"context_line":"    mode: \"0440\""},{"line_number":141,"context_line":"    owner: \"root\""},{"line_number":142,"context_line":"    group: \"root\""},{"line_number":143,"context_line":"  with_items:"},{"line_number":144,"context_line":"    - name: \"{{ ironic_system_user_name }}\""},{"line_number":145,"context_line":"      file: sudoers.j2"}],"source_content_type":"text/x-yaml","patch_set":72,"id":"3fa7e38b_856899f4","line":145,"range":{"start_line":136,"start_character":0,"end_line":145,"end_character":22},"updated":"2019-11-28 14:28:41.000000000","message":"Why this has been changed?","commit_id":"9900faf3f3ef2d718408aa11441fbf9070228bd6"}],"tasks/ironic_pre_install.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"6b93d4c4cf3ef552c39e20a0e5fdc799eea7cbd7","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    system: \"yes\""},{"line_number":45,"context_line":"    createhome: \"yes\""},{"line_number":46,"context_line":"    home: \"{{ item.home }}\""},{"line_number":47,"context_line":"    generate_ssh_key: \"yes\""},{"line_number":48,"context_line":"  with_items:"},{"line_number":49,"context_line":"    - name: \"{{ ironic_system_user_name }}\""},{"line_number":50,"context_line":"      group: \"{{ ironic_system_group_name }}\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5faad753_daa1b197","line":47,"updated":"2019-09-06 07:04:37.000000000","message":"please add here:\n  when: item.condition | default(True)\n\nnot to create all users for all hosts","commit_id":"a693e521e761613285c2015a0f0067d04a7d026f"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"6b93d4c4cf3ef552c39e20a0e5fdc799eea7cbd7","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      group: \"{{ ironic_inspector_system_group_name }}\""},{"line_number":56,"context_line":"      comment: \"{{ ironic_inspector_system_comment }\""},{"line_number":57,"context_line":"      shell: \"{{ ironic_system_shell }}\""},{"line_number":58,"context_line":"      home: \"{{ ironic_inspector_system_home_folder }}\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- name: Create ironic dir"},{"line_number":61,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5faad753_fac7cd44","line":58,"updated":"2019-09-06 07:04:37.000000000","message":"add here:\n      condition: \"{{ inventory_hostname in groups[\u0027ironic_inspector\u0027] }}\"","commit_id":"a693e521e761613285c2015a0f0067d04a7d026f"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"6b93d4c4cf3ef552c39e20a0e5fdc799eea7cbd7","unresolved":false,"context_lines":[{"line_number":57,"context_line":"      shell: \"{{ ironic_system_shell }}\""},{"line_number":58,"context_line":"      home: \"{{ ironic_inspector_system_home_folder }}\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- name: Create ironic dir"},{"line_number":61,"context_line":"  file:"},{"line_number":62,"context_line":"    path: \"{{ item.path }}\""},{"line_number":63,"context_line":"    state: directory"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5faad753_bac15531","line":60,"updated":"2019-09-06 07:04:37.000000000","message":"ditto with conditions here","commit_id":"a693e521e761613285c2015a0f0067d04a7d026f"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2936a5f527c6c317f689ab1e9c1686ca943b8b89","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Create the system group"},{"line_number":17,"context_line":"  group:"},{"line_number":18,"context_line":"    name: \"{{ item }}\""},{"line_number":19,"context_line":"    state: \"present\""},{"line_number":20,"context_line":"    system: \"yes\""},{"line_number":21,"context_line":"  with_items:"},{"line_number":22,"context_line":"    - \"{{ ironic_system_group_name }}\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Remove old key file(s) if found"},{"line_number":25,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":72,"id":"3fa7e38b_4572a1e6","line":22,"range":{"start_line":18,"start_character":0,"end_line":22,"end_character":38},"updated":"2019-11-28 14:28:41.000000000","message":"why this change is needed?","commit_id":"9900faf3f3ef2d718408aa11441fbf9070228bd6"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2936a5f527c6c317f689ab1e9c1686ca943b8b89","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    - \"{{ ironic_system_home_folder }}/.ssh/id_rsa.pub\""},{"line_number":32,"context_line":"  when: ironic_recreate_keys | bool"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Create ironic system users"},{"line_number":35,"context_line":"  user:"},{"line_number":36,"context_line":"    name: \"{{ item.name }}\""},{"line_number":37,"context_line":"    group: \"{{ item.group }}\""},{"line_number":38,"context_line":"    comment: \"{{ item.comment }}\""},{"line_number":39,"context_line":"    shell: \"{{ item.shell }}\""},{"line_number":40,"context_line":"    system: \"yes\""},{"line_number":41,"context_line":"    createhome: \"yes\""},{"line_number":42,"context_line":"    home: \"{{ item.home }}\""},{"line_number":43,"context_line":"    generate_ssh_key: \"yes\""},{"line_number":44,"context_line":"  when: item.condition | default(True)"},{"line_number":45,"context_line":"  with_items:"},{"line_number":46,"context_line":"    - name: \"{{ ironic_system_user_name }}\""},{"line_number":47,"context_line":"      group: \"{{ ironic_system_group_name }}\""},{"line_number":48,"context_line":"      comment: \"{{ ironic_system_comment }}\""},{"line_number":49,"context_line":"      shell: \"{{ ironic_system_shell }}\""},{"line_number":50,"context_line":"      home: \"{{ ironic_system_home_folder }}\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"- name: Create ironic dir"},{"line_number":53,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":72,"id":"3fa7e38b_2579a5c4","line":50,"range":{"start_line":34,"start_character":0,"end_line":50,"end_character":45},"updated":"2019-11-28 14:28:41.000000000","message":"why this change is needed?","commit_id":"9900faf3f3ef2d718408aa11441fbf9070228bd6"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2936a5f527c6c317f689ab1e9c1686ca943b8b89","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  with_items:"},{"line_number":61,"context_line":"    - { path: \"/openstack/venvs\", mode: \"0755\", owner: \"root\", group: \"root\" }"},{"line_number":62,"context_line":"    - { path: \"/etc/ironic\" }"},{"line_number":63,"context_line":"    - { path: \"/etc/ironic-inspector\" }"},{"line_number":64,"context_line":"    - { path: \"/etc/ironic/rootwrap.d\" }"},{"line_number":65,"context_line":"    - { path: \"/etc/ironic-inspector/rootwrap.d\" }"},{"line_number":66,"context_line":"    - { path: \"/etc/sudoers.d\", mode: \"0750\", owner: \"root\", group: \"root\" }"}],"source_content_type":"text/x-yaml","patch_set":72,"id":"3fa7e38b_e54ced9e","line":63,"range":{"start_line":63,"start_character":14,"end_line":63,"end_character":37},"updated":"2019-11-28 14:28:41.000000000","message":"This should have condition to be present only for inspector hosts","commit_id":"9900faf3f3ef2d718408aa11441fbf9070228bd6"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2936a5f527c6c317f689ab1e9c1686ca943b8b89","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    - { path: \"/etc/ironic\" }"},{"line_number":63,"context_line":"    - { path: \"/etc/ironic-inspector\" }"},{"line_number":64,"context_line":"    - { path: \"/etc/ironic/rootwrap.d\" }"},{"line_number":65,"context_line":"    - { path: \"/etc/ironic-inspector/rootwrap.d\" }"},{"line_number":66,"context_line":"    - { path: \"/etc/sudoers.d\", mode: \"0750\", owner: \"root\", group: \"root\" }"},{"line_number":67,"context_line":"    - { path: \"/var/cache/ironic\" }"},{"line_number":68,"context_line":"    - { path: \"/var/cache/ironic-inspector\" }"}],"source_content_type":"text/x-yaml","patch_set":72,"id":"3fa7e38b_85417966","line":65,"range":{"start_line":65,"start_character":14,"end_line":65,"end_character":48},"updated":"2019-11-28 14:28:41.000000000","message":"ditto","commit_id":"9900faf3f3ef2d718408aa11441fbf9070228bd6"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2936a5f527c6c317f689ab1e9c1686ca943b8b89","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    - { path: \"/etc/ironic-inspector/rootwrap.d\" }"},{"line_number":66,"context_line":"    - { path: \"/etc/sudoers.d\", mode: \"0750\", owner: \"root\", group: \"root\" }"},{"line_number":67,"context_line":"    - { path: \"/var/cache/ironic\" }"},{"line_number":68,"context_line":"    - { path: \"/var/cache/ironic-inspector\" }"},{"line_number":69,"context_line":"    - { path: \"{{ ironic_system_home_folder }}\" }"},{"line_number":70,"context_line":"    - { path: \"{{ ironic_system_home_folder }}/.ssh\", mode: \"0700\" }"},{"line_number":71,"context_line":"    - { path: \"{{ ironic_system_home_folder }}/images\" }"}],"source_content_type":"text/x-yaml","patch_set":72,"id":"3fa7e38b_a546f57a","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":43},"updated":"2019-11-28 14:28:41.000000000","message":"ditto","commit_id":"9900faf3f3ef2d718408aa11441fbf9070228bd6"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2936a5f527c6c317f689ab1e9c1686ca943b8b89","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    - { path: \"{{ ironic_system_home_folder }}/master_images\" }"},{"line_number":73,"context_line":"    - { path: \"{{ ironic_system_home_folder }}/cache/api\", mode: \"0700\" }"},{"line_number":74,"context_line":"    - { path: \"{{ ironic_lock_path }}\" }"},{"line_number":75,"context_line":"    - { path: \"{{ ironic_inspector_lock_path }}\" }"},{"line_number":76,"context_line":"    - { path: \"/var/run/ironic\" }"},{"line_number":77,"context_line":"    - { path: \"/var/run/ironic-inspector\" }"},{"line_number":78,"context_line":"    - { path: \"{{ ironic_inspector_tftpboot_dir }}/pxelinux.cfg\" }"}],"source_content_type":"text/x-yaml","patch_set":72,"id":"3fa7e38b_6558fd56","line":75,"range":{"start_line":75,"start_character":7,"end_line":75,"end_character":49},"updated":"2019-11-28 14:28:41.000000000","message":"ditto","commit_id":"9900faf3f3ef2d718408aa11441fbf9070228bd6"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2936a5f527c6c317f689ab1e9c1686ca943b8b89","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    - { path: \"{{ ironic_lock_path }}\" }"},{"line_number":75,"context_line":"    - { path: \"{{ ironic_inspector_lock_path }}\" }"},{"line_number":76,"context_line":"    - { path: \"/var/run/ironic\" }"},{"line_number":77,"context_line":"    - { path: \"/var/run/ironic-inspector\" }"},{"line_number":78,"context_line":"    - { path: \"{{ ironic_inspector_tftpboot_dir }}/pxelinux.cfg\" }"},{"line_number":79,"context_line":"    - { path: \"/httpboot\" }"}],"source_content_type":"text/x-yaml","patch_set":72,"id":"3fa7e38b_0555891e","line":78,"range":{"start_line":77,"start_character":0,"end_line":78,"end_character":66},"updated":"2019-11-28 14:28:41.000000000","message":"ditto","commit_id":"9900faf3f3ef2d718408aa11441fbf9070228bd6"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"d2d5255960030dc2faa1654d3ac644c67f94099d","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  with_items:"},{"line_number":52,"context_line":"    - { path: \"/openstack/venvs\", mode: \"0755\", owner: \"root\", group: \"root\" }"},{"line_number":53,"context_line":"    - { path: \"/etc/ironic\" }"},{"line_number":54,"context_line":"    - { path: \"/etc/ironic-inspector\" }"},{"line_number":55,"context_line":"    - { path: \"/etc/ironic/rootwrap.d\" }"},{"line_number":56,"context_line":"    - path: \"/etc/ironic-inspector/rootwrap.d\""},{"line_number":57,"context_line":"      condition: inventory_hostname in groups[\u0027ironic-inspector\u0027]"}],"source_content_type":"text/x-yaml","patch_set":80,"id":"3fa7e38b_cb1f42b6","line":54,"range":{"start_line":54,"start_character":0,"end_line":54,"end_character":39},"updated":"2019-12-04 09:58:16.000000000","message":"Add the same condition here as well please","commit_id":"c9862428e2bc0f356efb1176b28d205cf8796751"}],"tasks/main.yml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"9e00c1a32ea1c7f20709b0babe6921e6fcb44572","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  import_role:"},{"line_number":71,"context_line":"    name: \"python_venv_build\""},{"line_number":72,"context_line":"  with_items:"},{"line_number":73,"context_line":"    - constraints: \"{{ ironic_git_constraints }}\""},{"line_number":74,"context_line":"      distro_packages: \"{{ ironic_devel_distro_packages }}\""},{"line_number":75,"context_line":"      dest_path: \"{{ ironic_bin | dirname }}\""},{"line_number":76,"context_line":"      distro_package_list:  \"{{ ironic_packages_list }}\""},{"line_number":77,"context_line":"      pip_install_args: \"{{ ironic_pip_install_args }}\""},{"line_number":78,"context_line":"      pip_packages: \"{{ (ironic_oslomsg_amqp1_enabled | bool) | ternary(ironic_pip_packages + ironic_optional_oslomsg_amqp1_pip_packages, ironic_pip_packages) }}\""},{"line_number":79,"context_line":"    - constraints: \"{{ ironic_inspector_git_constraints }}\""},{"line_number":80,"context_line":"      distro_packages: \"{{ ironic_inspector_devel_distro_packages }}\""},{"line_number":81,"context_line":"      distro_package_list:  \"{{ ironic_inspector_packages_list }}\""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"5faad753_43637edd","line":78,"range":{"start_line":73,"start_character":0,"end_line":78,"end_character":64},"updated":"2019-09-08 17:58:21.000000000","message":"careful with this first section, there is no condition so i think you get the ironic venv installed also for the inspector hosts?","commit_id":"080637bc896d5fb5e584f233ba4ab4e5f4c3221f"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"4ddffa984e99ec0541454728e04e63ec6917c3f3","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    - ironic-install"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- name: Install the python venv"},{"line_number":66,"context_line":"  include_role:"},{"line_number":67,"context_line":"    name: \"python_venv_build\""},{"line_number":68,"context_line":"  with_items:"},{"line_number":69,"context_line":"    - venv_python_executable: \"{{ ironic_venv_python_executable }}\""}],"source_content_type":"text/x-yaml","patch_set":43,"id":"3fa7e38b_1005b3c2","line":66,"range":{"start_line":66,"start_character":2,"end_line":66,"end_character":14},"updated":"2019-09-19 10:01:31.000000000","message":"include means that a tag ironic-install won\u0027t work.\n\nWe were getting rid of with_items from main for some time, so make appropriate vars in vars/main.yml and pass already prepared ones, like it\u0027s made for ironic_packages_list\n\nFor example, you can create a dict and store lists in values for keys. ie:\n\npython_venv_build_vars: |-\n  {% set vars \u003d {} %}\n  {% if inventory_hostname in groups[\u0027ironic_inspector\u0027] %}\n  {%   set _ \u003d vars.update({\u0027constraints\u0027: ironic_inspector_git_constraints})\n  {% else %}\n  {%   set _ \u003d vars.update({\u0027constraints\u0027: ironic_git_constraints})\n  {% endif %}\n  {{ vars }}\n\nand pass them to vars like this:\n\nvars:\n  venv_build_constraints: \"{{ python_venv_build_vars.constraints }}\"","commit_id":"affe594529fa94964fcd835a913faf36ef481370"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"4ddffa984e99ec0541454728e04e63ec6917c3f3","unresolved":false,"context_lines":[{"line_number":165,"context_line":"      - name: \"{{ ironic_service_name }}\""},{"line_number":166,"context_line":"        type: \"{{ ironic_service_type }}\""},{"line_number":167,"context_line":"        description: \"{{ ironic_service_description }}\""},{"line_number":168,"context_line":"  when:"},{"line_number":169,"context_line":"    - \"{{ inventory_hostname in groups[\u0027ironic_api\u0027][0] }}\""},{"line_number":170,"context_line":"  tags:"},{"line_number":171,"context_line":"    - ironic-config"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":43,"id":"3fa7e38b_f0e1f7ff","line":169,"range":{"start_line":168,"start_character":0,"end_line":169,"end_character":59},"updated":"2019-09-19 10:01:31.000000000","message":"Why this change was made?","commit_id":"affe594529fa94964fcd835a913faf36ef481370"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"80377afa6e5f6a7cb9322d2a8f308dc701c09d1a","unresolved":false,"context_lines":[{"line_number":165,"context_line":"      - name: \"{{ ironic_service_name }}\""},{"line_number":166,"context_line":"        type: \"{{ ironic_service_type }}\""},{"line_number":167,"context_line":"        description: \"{{ ironic_service_description }}\""},{"line_number":168,"context_line":"  when:"},{"line_number":169,"context_line":"    - \"{{ inventory_hostname in groups[\u0027ironic_api\u0027][0] }}\""},{"line_number":170,"context_line":"  tags:"},{"line_number":171,"context_line":"    - ironic-config"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":43,"id":"3fa7e38b_5bb6e7fc","line":169,"range":{"start_line":168,"start_character":0,"end_line":169,"end_character":59},"in_reply_to":"3fa7e38b_f0e1f7ff","updated":"2019-09-21 02:57:06.000000000","message":"Done","commit_id":"affe594529fa94964fcd835a913faf36ef481370"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"4ddffa984e99ec0541454728e04e63ec6917c3f3","unresolved":false,"context_lines":[{"line_number":170,"context_line":"  tags:"},{"line_number":171,"context_line":"    - ironic-config"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"- include_tasks: ironic_inspector_post_install.yml"},{"line_number":174,"context_line":"  when: inventory_hostname in groups[\u0027ironic_inspector\u0027] | default([])"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"3fa7e38b_f02c9748","line":173,"range":{"start_line":173,"start_character":2,"end_line":173,"end_character":15},"updated":"2019-09-19 10:01:31.000000000","message":"this should be import_tasks","commit_id":"affe594529fa94964fcd835a913faf36ef481370"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"80377afa6e5f6a7cb9322d2a8f308dc701c09d1a","unresolved":false,"context_lines":[{"line_number":170,"context_line":"  tags:"},{"line_number":171,"context_line":"    - ironic-config"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"- include_tasks: ironic_inspector_post_install.yml"},{"line_number":174,"context_line":"  when: inventory_hostname in groups[\u0027ironic_inspector\u0027] | default([])"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"3fa7e38b_7bb963e7","line":173,"range":{"start_line":173,"start_character":2,"end_line":173,"end_character":15},"in_reply_to":"3fa7e38b_f02c9748","updated":"2019-09-21 02:57:06.000000000","message":"Done","commit_id":"affe594529fa94964fcd835a913faf36ef481370"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"4ddffa984e99ec0541454728e04e63ec6917c3f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"3fa7e38b_b01e1f0a","line":175,"updated":"2019-09-19 10:01:31.000000000","message":"Please add a tag for inspector","commit_id":"affe594529fa94964fcd835a913faf36ef481370"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"80377afa6e5f6a7cb9322d2a8f308dc701c09d1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"3fa7e38b_3bcbeb72","line":175,"in_reply_to":"3fa7e38b_b01e1f0a","updated":"2019-09-21 02:57:06.000000000","message":"Done","commit_id":"affe594529fa94964fcd835a913faf36ef481370"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f8e4dc1fd76ce538d44086993cadb7b69d37524d","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        value: \"{{ ironic_venv_tag }}\""},{"line_number":80,"context_line":"  tags:"},{"line_number":81,"context_line":"    - ironic-install"},{"line_number":82,"context_line":"  when: item.condition | default(True)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"- import_tasks: ironic_post_install.yml"},{"line_number":85,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"3fa7e38b_663b0aeb","line":82,"range":{"start_line":82,"start_character":8,"end_line":82,"end_character":13},"updated":"2019-09-19 17:18:24.000000000","message":"There is no loop here, so what defines \u0027item\u0027?","commit_id":"c302a266b747400a623af0ce18a91c11e2305769"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"25c7c1e6442d45debb99f760b3c0036d9e964fe0","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    - ironic-config"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"- import_tasks: ironic_inspector_post_install.yml"},{"line_number":156,"context_line":"  when: inventory_hostname in groups[\u0027ironic_inspector\u0027] | default([])"},{"line_number":157,"context_line":"  tags:"},{"line_number":158,"context_line":"    - inronic-inspector"}],"source_content_type":"text/x-yaml","patch_set":50,"id":"3fa7e38b_089812be","line":156,"range":{"start_line":156,"start_character":67,"end_line":156,"end_character":69},"updated":"2019-09-20 14:39:51.000000000","message":"boolean is supposed to be passed to the when statement, not list","commit_id":"ba1c30ced5959886cce04f1847d9c90805198186"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2936a5f527c6c317f689ab1e9c1686ca943b8b89","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        users:"},{"line_number":36,"context_line":"          - username: \"{{ ironic_galera_user }}\""},{"line_number":37,"context_line":"            password: \"{{ ironic_container_mysql_password }}\""},{"line_number":38,"context_line":"      - name: \"{{ ironic_inspector_galera_database }}\""},{"line_number":39,"context_line":"        users:"},{"line_number":40,"context_line":"          - username: \"{{ ironic_inspector_galera_user }}\""},{"line_number":41,"context_line":"            password: \"{{ ironic_inspector_container_mysql_password }}\""},{"line_number":42,"context_line":"  tags:"},{"line_number":43,"context_line":"    - common-db"},{"line_number":44,"context_line":"    - ironic-config"}],"source_content_type":"text/x-yaml","patch_set":72,"id":"3fa7e38b_85365902","line":41,"range":{"start_line":38,"start_character":0,"end_line":41,"end_character":71},"updated":"2019-11-28 14:28:41.000000000","message":"This is not really correct, as it will be runned against ironic-api, while it\u0027s needed for inspector hosts. \n\nI\u0027d move _oslodb_databases generation into vars to generate correct list there (like it\u0027s done for ironic_packages_list) and just pass it via variable here.","commit_id":"9900faf3f3ef2d718408aa11441fbf9070228bd6"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2936a5f527c6c317f689ab1e9c1686ca943b8b89","unresolved":false,"context_lines":[{"line_number":138,"context_line":"      - name: \"{{ ironic_service_user_name }}\""},{"line_number":139,"context_line":"        password: \"{{ ironic_service_password }}\""},{"line_number":140,"context_line":"        role: \"{{ ironic_service_role_name }}\""},{"line_number":141,"context_line":"      - name: \"{{ ironic_inspector_service_user_name }}\""},{"line_number":142,"context_line":"        password: \"{{ ironic_inspector_service_password }}\""},{"line_number":143,"context_line":"        role: \"{{ ironic_inspector_service_role_name }}\""},{"line_number":144,"context_line":"    _service_endpoints:"},{"line_number":145,"context_line":"      - service: \"{{ ironic_service_name }}\""},{"line_number":146,"context_line":"        interface: \"public\""}],"source_content_type":"text/x-yaml","patch_set":72,"id":"3fa7e38b_88043016","line":143,"range":{"start_line":141,"start_character":0,"end_line":143,"end_character":56},"updated":"2019-11-28 14:28:41.000000000","message":"ditto","commit_id":"9900faf3f3ef2d718408aa11441fbf9070228bd6"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2936a5f527c6c317f689ab1e9c1686ca943b8b89","unresolved":false,"context_lines":[{"line_number":151,"context_line":"      - service: \"{{ ironic_service_name }}\""},{"line_number":152,"context_line":"        interface: \"admin\""},{"line_number":153,"context_line":"        url: \"{{ ironic_service_adminurl }}\""},{"line_number":154,"context_line":"      - service: \"{{ ironic_inspector_service_name }}\""},{"line_number":155,"context_line":"        interface: \"public\""},{"line_number":156,"context_line":"        url: \"{{ ironic_inspector_service_publicurl }}\""},{"line_number":157,"context_line":"      - service: \"{{ ironic_inspector_service_name }}\""},{"line_number":158,"context_line":"        interface: \"internal\""},{"line_number":159,"context_line":"        url: \"{{ ironic_inspector_service_internalurl }}\""},{"line_number":160,"context_line":"      - service: \"{{ ironic_inspector_service_name }}\""},{"line_number":161,"context_line":"        interface: \"admin\""},{"line_number":162,"context_line":"        url: \"{{ ironic_inspector_service_adminurl }}\""},{"line_number":163,"context_line":"    _service_catalog:"},{"line_number":164,"context_line":"      - name: \"{{ ironic_service_name }}\""},{"line_number":165,"context_line":"        type: \"{{ ironic_service_type }}\""}],"source_content_type":"text/x-yaml","patch_set":72,"id":"3fa7e38b_480e3834","line":162,"range":{"start_line":154,"start_character":0,"end_line":162,"end_character":54},"updated":"2019-11-28 14:28:41.000000000","message":"ditto","commit_id":"9900faf3f3ef2d718408aa11441fbf9070228bd6"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2936a5f527c6c317f689ab1e9c1686ca943b8b89","unresolved":false,"context_lines":[{"line_number":164,"context_line":"      - name: \"{{ ironic_service_name }}\""},{"line_number":165,"context_line":"        type: \"{{ ironic_service_type }}\""},{"line_number":166,"context_line":"        description: \"{{ ironic_service_description }}\""},{"line_number":167,"context_line":"      - name: \"{{ ironic_inspector_service_name }}\""},{"line_number":168,"context_line":"        type: \"{{ ironic_inspector_service_type }}\""},{"line_number":169,"context_line":"        description: \"{{ ironic_inspector_service_description }}\""},{"line_number":170,"context_line":"  when: inventory_hostname \u003d\u003d groups[\u0027ironic_api\u0027][0]"},{"line_number":171,"context_line":"  tags:"},{"line_number":172,"context_line":"    - ironic-config"}],"source_content_type":"text/x-yaml","patch_set":72,"id":"3fa7e38b_08184074","line":169,"range":{"start_line":167,"start_character":0,"end_line":169,"end_character":65},"updated":"2019-11-28 14:28:41.000000000","message":"ditto","commit_id":"9900faf3f3ef2d718408aa11441fbf9070228bd6"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"c1c26ecde455dd2799232396bb3bbbd1ab6fdb2c","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    - ironic-config"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"- import_tasks: ironic_db_setup.yml"},{"line_number":118,"context_line":"  when: inventory_hostname \u003d\u003d groups[\u0027ironic_conductor\u0027][0]"},{"line_number":119,"context_line":"  tags:"},{"line_number":120,"context_line":"    - ironic-config"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":81,"id":"3fa7e38b_287935fa","line":118,"range":{"start_line":118,"start_character":0,"end_line":118,"end_character":59},"updated":"2019-12-04 15:18:07.000000000","message":"drop this","commit_id":"4edeb87cf6390c800a3f9c073c775350d0f4bcfb"}],"tasks/mq_setup.yml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"9f709ae42e534ac49f84a360f6c4b11b907fc140","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2019, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5faad753_3c555251","line":2,"updated":"2019-09-06 21:33:42.000000000","message":"this file should not be modified outside of openstack-ansible-tests repo","commit_id":"0194b2c5e66a3f9022d3723b9bea8ccfb58ed46a"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"a604f32ec3335f763b556b47df560638d3e979a4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2019, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5faad753_6121db9f","line":2,"in_reply_to":"5faad753_3c555251","updated":"2019-09-07 13:56:00.000000000","message":"Done","commit_id":"0194b2c5e66a3f9022d3723b9bea8ccfb58ed46a"}],"templates/dnsmasq.conf.j2":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"9f709ae42e534ac49f84a360f6c4b11b907fc140","unresolved":false,"context_lines":[{"line_number":9,"context_line":"dhcp-match\u003dset:efi,option:client-arch,7"},{"line_number":10,"context_line":"dhcp-boot\u003dtag:efi,syslinux.efi"},{"line_number":11,"context_line":"{% if ironic_inspector_boot_mode \u003d\u003d \"http\" %}"},{"line_number":12,"context_line":"dhcp-boot\u003dpxelinux.0,localhost.localdomain,192.168.0.100"},{"line_number":13,"context_line":"{% else %}"},{"line_number":14,"context_line":"dhcp-boot\u003dpxelinux.0,localhost.localdomain,192.168.0.100"},{"line_number":15,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"5faad753_bcc62216","line":12,"range":{"start_line":12,"start_character":43,"end_line":12,"end_character":56},"updated":"2019-09-06 21:33:42.000000000","message":"do you intend to hardcode this here?","commit_id":"0194b2c5e66a3f9022d3723b9bea8ccfb58ed46a"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"a604f32ec3335f763b556b47df560638d3e979a4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"dhcp-match\u003dset:efi,option:client-arch,7"},{"line_number":10,"context_line":"dhcp-boot\u003dtag:efi,syslinux.efi"},{"line_number":11,"context_line":"{% if ironic_inspector_boot_mode \u003d\u003d \"http\" %}"},{"line_number":12,"context_line":"dhcp-boot\u003dpxelinux.0,localhost.localdomain,192.168.0.100"},{"line_number":13,"context_line":"{% else %}"},{"line_number":14,"context_line":"dhcp-boot\u003dpxelinux.0,localhost.localdomain,192.168.0.100"},{"line_number":15,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"5faad753_01190778","line":12,"range":{"start_line":12,"start_character":43,"end_line":12,"end_character":56},"in_reply_to":"5faad753_bcc62216","updated":"2019-09-07 13:56:00.000000000","message":"not really sure what we should set this to. i\u0027ll think on it for a day or two","commit_id":"0194b2c5e66a3f9022d3723b9bea8ccfb58ed46a"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"9f709ae42e534ac49f84a360f6c4b11b907fc140","unresolved":false,"context_lines":[{"line_number":11,"context_line":"{% if ironic_inspector_boot_mode \u003d\u003d \"http\" %}"},{"line_number":12,"context_line":"dhcp-boot\u003dpxelinux.0,localhost.localdomain,192.168.0.100"},{"line_number":13,"context_line":"{% else %}"},{"line_number":14,"context_line":"dhcp-boot\u003dpxelinux.0,localhost.localdomain,192.168.0.100"},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":"conf-dir\u003d/etc/dnsmasq.d/,*.conf"},{"line_number":17,"context_line":"dhcp-hostsdir\u003d/etc/dnsmasq.d/dhcp-hostsdir"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"5faad753_dccbde1b","line":14,"range":{"start_line":14,"start_character":43,"end_line":14,"end_character":56},"updated":"2019-09-06 21:33:42.000000000","message":"same as above","commit_id":"0194b2c5e66a3f9022d3723b9bea8ccfb58ed46a"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"a604f32ec3335f763b556b47df560638d3e979a4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"{% if ironic_inspector_boot_mode \u003d\u003d \"http\" %}"},{"line_number":12,"context_line":"dhcp-boot\u003dpxelinux.0,localhost.localdomain,192.168.0.100"},{"line_number":13,"context_line":"{% else %}"},{"line_number":14,"context_line":"dhcp-boot\u003dpxelinux.0,localhost.localdomain,192.168.0.100"},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":"conf-dir\u003d/etc/dnsmasq.d/,*.conf"},{"line_number":17,"context_line":"dhcp-hostsdir\u003d/etc/dnsmasq.d/dhcp-hostsdir"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"5faad753_a127d3b6","line":14,"range":{"start_line":14,"start_character":43,"end_line":14,"end_character":56},"in_reply_to":"5faad753_dccbde1b","updated":"2019-09-07 13:56:00.000000000","message":"same as above","commit_id":"0194b2c5e66a3f9022d3723b9bea8ccfb58ed46a"}],"templates/inspector.conf.j2":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"9f709ae42e534ac49f84a360f6c4b11b907fc140","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[database]"},{"line_number":16,"context_line":"connection \u003d {{ ironic_inspector_openstack_db_connection_string }}"},{"line_number":17,"context_line":"max_overflow \u003d {{ ironic_inspector_db_max_overflow }}"},{"line_number":18,"context_line":"max_pool_size \u003d {{ ironic_inspector_db_max_pool_size }}"},{"line_number":19,"context_line":"pool_timeout \u003d {{ ironic_inspector_db_pool_timeout }}"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"5faad753_9cba46dc","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":53},"updated":"2019-09-06 21:33:42.000000000","message":"every time that you have a variable in this file that just takes its value from defaults/main.yml, and the default is not used anywhere else in the ansible code, remove the var from defaults/main.yml and put the required default value directly into the template.\n\nThe template default values can be overridden directly with config_template.\n\nThis is just one example of many in this file.","commit_id":"0194b2c5e66a3f9022d3723b9bea8ccfb58ed46a"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"4ddffa984e99ec0541454728e04e63ec6917c3f3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# {{ ansible_managed }}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[DEFAULT]"},{"line_number":4,"context_line":"rootwrap_config \u003d /etc/ironic-inspector/rootwrap.conf"}],"source_content_type":"text/x-jinja2","patch_set":43,"id":"3fa7e38b_50c9eb75","line":1,"updated":"2019-09-19 10:01:31.000000000","message":"Can\u0027t judje on it as not aware about how inspector should be configured","commit_id":"affe594529fa94964fcd835a913faf36ef481370"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"5ed0a1cd35463163e0163ab87c00e773a3d33126","unresolved":false,"context_lines":[{"line_number":33,"context_line":"{% if ironic_inspector_pxe_filter \u003d\u003d \"iptables\" %}"},{"line_number":34,"context_line":"manage_firewall \u003d True"},{"line_number":35,"context_line":"{% endif %}"},{"line_number":36,"context_line":"dnsmasq_interface \u003d  br-vlan"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"[ironic]"},{"line_number":39,"context_line":"username \u003d ironic_inspector"}],"source_content_type":"text/x-jinja2","patch_set":61,"id":"3fa7e38b_9545a7b6","line":36,"range":{"start_line":36,"start_character":21,"end_line":36,"end_character":28},"updated":"2019-09-25 15:29:15.000000000","message":"in \"standard\" OSA setup the untagged traffic on br-vlan is the external network - we really shouldnt be bringing up dnsmasq on this interface?","commit_id":"67cd57cc1ab76fa0b4e15b20cd4c2c6f54e72a1e"},{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"9c1d6ffa2333af65be231c47884fb3fc4c19ac23","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[dnsmasq_pxe_filter]"},{"line_number":26,"context_line":"{% if ironic_inspector_pxe_filter \u003d\u003d \"dnsmasq\" %}"},{"line_number":27,"context_line":"dhcp_hostsdir \u003d /etc/dnsmasq.d/dhcp-hostsdir"},{"line_number":28,"context_line":"dnsmasq_start_command \u003d systemctl start dnsmasq"},{"line_number":29,"context_line":"dnsmasq_stop_command  \u003d systemctl stop dnsmasq"}],"source_content_type":"text/x-jinja2","patch_set":63,"id":"3fa7e38b_e58346ca","line":26,"updated":"2019-11-14 16:47:00.000000000","message":"I think this if statement should be moved up one line so that you don\u0027t have an empty dnsmasq_pxe_filter section if the conditional is false.","commit_id":"c145fb1c7e8207c64931cc4602e677bffd431c4e"}],"templates/ironic.conf.j2":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2936a5f527c6c317f689ab1e9c1686ca943b8b89","unresolved":false,"context_lines":[{"line_number":97,"context_line":"use_web_server_for_images \u003d True"},{"line_number":98,"context_line":"{% endif %}"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"[inspector]"},{"line_number":101,"context_line":"auth_type \u003d {{ ironic_keystone_auth_plugin }}"},{"line_number":102,"context_line":"auth_url \u003d {{ keystone_service_adminuri }}"},{"line_number":103,"context_line":"insecure \u003d {{ keystone_service_internaluri_insecure | bool }}"},{"line_number":104,"context_line":"password \u003d {{ ironic_inspector_service_password  }}"},{"line_number":105,"context_line":"project_domain_name \u003d {{ ironic_inspector_service_domain_id }}"},{"line_number":106,"context_line":"project_name \u003d{{ ironic_inspector_service_project_name }}"},{"line_number":107,"context_line":"user_domain_name \u003d {{ ironic_inspector_service_domain_id }}"},{"line_number":108,"context_line":"username \u003d {{ ironic_inspector_service_user_name }}"},{"line_number":109,"context_line":"valid_interfaces \u003d {{ ironic_inspector_valid_interfaces }}"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"[ipmi]"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":72,"id":"3fa7e38b_083120ee","line":109,"range":{"start_line":100,"start_character":0,"end_line":109,"end_character":58},"updated":"2019-11-28 14:28:41.000000000","message":"I think we should define this part of code only when ironic_services[\u0027ironic-inspector\u0027][\u0027group\u0027] in group_names","commit_id":"9900faf3f3ef2d718408aa11441fbf9070228bd6"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"d2d5255960030dc2faa1654d3ac644c67f94099d","unresolved":false,"context_lines":[{"line_number":97,"context_line":"use_web_server_for_images \u003d True"},{"line_number":98,"context_line":"{% endif %}"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"[inspector]"},{"line_number":101,"context_line":"auth_type \u003d {{ ironic_keystone_auth_plugin }}"},{"line_number":102,"context_line":"auth_url \u003d {{ keystone_service_adminuri }}"},{"line_number":103,"context_line":"insecure \u003d {{ keystone_service_internaluri_insecure | bool }}"},{"line_number":104,"context_line":"password \u003d {{ ironic_inspector_service_password  }}"},{"line_number":105,"context_line":"project_domain_name \u003d {{ ironic_inspector_service_domain_id }}"},{"line_number":106,"context_line":"project_name \u003d{{ ironic_inspector_service_project_name }}"},{"line_number":107,"context_line":"user_domain_name \u003d {{ ironic_inspector_service_domain_id }}"},{"line_number":108,"context_line":"username \u003d {{ ironic_inspector_service_user_name }}"},{"line_number":109,"context_line":"valid_interfaces \u003d {{ ironic_inspector_valid_interfaces }}"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"[ipmi]"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":80,"id":"3fa7e38b_ab8526b0","line":109,"range":{"start_line":100,"start_character":0,"end_line":109,"end_character":58},"updated":"2019-12-04 09:58:16.000000000","message":"Add conditional for this block - I dunno if this block should be only on inspector hosts or on all but only when inspector hosts present.\nAnyway this block is useless if no inspector hosts in groups\n\nPS As I previously wrote:\n\"I think we should define this part of code only when ironic_services[\u0027ironic-inspector\u0027][\u0027group\u0027] in group_names\"","commit_id":"c9862428e2bc0f356efb1176b28d205cf8796751"}],"templates/pxelinux-default.j2":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"9f709ae42e534ac49f84a360f6c4b11b907fc140","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"label inspect"},{"line_number":4,"context_line":"kernel {{ ironic_inspector_ipa_kernel_name }}"},{"line_number":5,"context_line":"append initrd\u003d{{ ironic_inspector_ipa_initrd_name }} ipa-inspection-callback-url\u003dhttp://{{ internal_lb_vip_address }}:5050/v1/continue nomodeset vga\u003dnormal console\u003dtty0 console\u003dttyS0,115200n8 {{ ironic_inspector_pxe_append_params | default(\u0027\u0027) }}"},{"line_number":6,"context_line":"ipappend 3"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"5faad753_dcf43e5e","line":5,"range":{"start_line":5,"start_character":118,"end_line":5,"end_character":122},"updated":"2019-09-06 21:33:42.000000000","message":"this should probably be a var too, which drives into the haproxy config","commit_id":"0194b2c5e66a3f9022d3723b9bea8ccfb58ed46a"}],"templates/sudoers.j2":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2936a5f527c6c317f689ab1e9c1686ca943b8b89","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Defaults:{{ ironic_system_user_name }} secure_path\u003d\"{{ ironic_bin }}:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{{ ironic_system_user_name }} ALL \u003d (root) NOPASSWD: {{ ironic_bin }}/{{ ironic_service_name }}-rootwrap"},{"line_number":7,"context_line":"{{ ironic_system_user_name }} ALL \u003d (root) NOPASSWD: {{ ironic_bin }}/{{ ironic_inspector_service_name }}-rootwrap"}],"source_content_type":"text/x-jinja2","patch_set":72,"id":"3fa7e38b_e84da471","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":114},"updated":"2019-11-28 14:28:41.000000000","message":"We should include this line only when ironic_services[\u0027ironic-inspector\u0027][\u0027group\u0027] in group_names","commit_id":"9900faf3f3ef2d718408aa11441fbf9070228bd6"}],"templates/tftpd-hpa.j2":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2936a5f527c6c317f689ab1e9c1686ca943b8b89","unresolved":false,"context_lines":[{"line_number":1,"context_line":"TFTP_USERNAME\u003d\"tftp\""},{"line_number":2,"context_line":"TFTP_DIRECTORY\u003d\"{{ ironic_inspector_tftpboot_dir }}\""},{"line_number":3,"context_line":"TFTP_ADDRESS\u003d\"{{ ironic_tftp_server_address }}:69\""},{"line_number":4,"context_line":"TFTP_OPTIONS\u003d\"-vvvv --map-file {{ ironic_inspector_tftpboot_dir }}/map-file\""}],"source_content_type":"text/x-jinja2","patch_set":72,"id":"3fa7e38b_c896a8a1","line":2,"range":{"start_line":2,"start_character":19,"end_line":2,"end_character":48},"updated":"2019-11-28 14:28:41.000000000","message":"why this change was made?","commit_id":"9900faf3f3ef2d718408aa11441fbf9070228bd6"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2936a5f527c6c317f689ab1e9c1686ca943b8b89","unresolved":false,"context_lines":[{"line_number":1,"context_line":"TFTP_USERNAME\u003d\"tftp\""},{"line_number":2,"context_line":"TFTP_DIRECTORY\u003d\"{{ ironic_inspector_tftpboot_dir }}\""},{"line_number":3,"context_line":"TFTP_ADDRESS\u003d\"{{ ironic_tftp_server_address }}:69\""},{"line_number":4,"context_line":"TFTP_OPTIONS\u003d\"-vvvv --map-file {{ ironic_inspector_tftpboot_dir }}/map-file\""}],"source_content_type":"text/x-jinja2","patch_set":72,"id":"3fa7e38b_88a0b0f5","line":4,"range":{"start_line":4,"start_character":34,"end_line":4,"end_character":63},"updated":"2019-11-28 14:28:41.000000000","message":"ditto","commit_id":"9900faf3f3ef2d718408aa11441fbf9070228bd6"}],"vars/debian.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"4ddffa984e99ec0541454728e04e63ec6917c3f3","unresolved":false,"context_lines":[{"line_number":57,"context_line":"   - libxslt1-dev"},{"line_number":58,"context_line":"   - libpq-dev"},{"line_number":59,"context_line":"   - python-yaml"},{"line_number":60,"context_line":"   - ipmitool"},{"line_number":61,"context_line":"ironic_inspector_http_distro_packages:"},{"line_number":62,"context_line":"   - nginx"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":43,"id":"3fa7e38b_709bc771","line":60,"updated":"2019-09-19 10:01:31.000000000","message":"just a nit - new line here may make things more readable","commit_id":"affe594529fa94964fcd835a913faf36ef481370"},{"author":{"_account_id":21314,"name":"Cam J. Loader","display_name":"Cam J. Loader","email":"cameron@loaderusa.net","username":"4-cameron"},"change_message_id":"80377afa6e5f6a7cb9322d2a8f308dc701c09d1a","unresolved":false,"context_lines":[{"line_number":57,"context_line":"   - libxslt1-dev"},{"line_number":58,"context_line":"   - libpq-dev"},{"line_number":59,"context_line":"   - python-yaml"},{"line_number":60,"context_line":"   - ipmitool"},{"line_number":61,"context_line":"ironic_inspector_http_distro_packages:"},{"line_number":62,"context_line":"   - nginx"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":43,"id":"3fa7e38b_7b9c035d","line":60,"in_reply_to":"3fa7e38b_709bc771","updated":"2019-09-21 02:57:06.000000000","message":"Done","commit_id":"affe594529fa94964fcd835a913faf36ef481370"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5deb72a7af57929aeca675d1fbc10822f0f546b7","unresolved":false,"context_lines":[{"line_number":48,"context_line":"ironic_tftpd_service_name: tftpd-hpa"},{"line_number":49,"context_line":"ironic_tftpd_root: /tftpboot"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"ironic_inspector_distro_packages:"},{"line_number":52,"context_line":"   - libxml2-dev"},{"line_number":53,"context_line":"   - pxelinux"},{"line_number":54,"context_line":"   - syslinux"},{"line_number":55,"context_line":"   - syslinux-common"},{"line_number":56,"context_line":"   - syslinux-efi"},{"line_number":57,"context_line":"   - libxslt1-dev"},{"line_number":58,"context_line":"   - libpq-dev"},{"line_number":59,"context_line":"   - python-yaml"},{"line_number":60,"context_line":"   - ipmitool"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"ironic_inspector_http_distro_packages:"},{"line_number":63,"context_line":"   - nginx"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"ironic_inspector_isc_dhcp_distro_packages:"},{"line_number":66,"context_line":"   - tftpd-hpa"},{"line_number":67,"context_line":"   - isc-dhcp-server"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"ironic_inspector_dnsmasq_distro_packages:"},{"line_number":70,"context_line":"   - dnsmasq"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"ironic_inspector_standalone_distro_packages:"},{"line_number":73,"context_line":"  - isc-dhcp-server"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"ironic_inspector_devel_distro_packages:"},{"line_number":76,"context_line":"  - git-core"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"3fa7e38b_84663429","line":73,"range":{"start_line":51,"start_character":0,"end_line":73,"end_character":19},"updated":"2019-09-20 10:04:46.000000000","message":"Where all these vars are used?","commit_id":"4ff577a5d3ced65734e99adb7ff727a23659b54f"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5deb72a7af57929aeca675d1fbc10822f0f546b7","unresolved":false,"context_lines":[{"line_number":77,"context_line":"  - libffi-dev"},{"line_number":78,"context_line":"  - libsystemd-dev"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"ironic_inspector_library_modules_paths:"},{"line_number":81,"context_line":"  - \"/usr/lib/PXELINUX/pxelinux.0\""},{"line_number":82,"context_line":"  - \"/usr/lib/PXELINUX/lpxelinux.0\""},{"line_number":83,"context_line":"  - \"/usr/lib/syslinux/modules/efi64/chain.c32\""},{"line_number":84,"context_line":"  - \"/usr/lib/syslinux/modules/bios/ldlinux.c32\""},{"line_number":85,"context_line":"  - \"/usr/lib/SYSLINUX.EFI/efi64/syslinux.efi\""},{"line_number":86,"context_line":"  - \"/usr/lib/syslinux/modules/efi64/ldlinux.e64\""}],"source_content_type":"text/x-yaml","patch_set":49,"id":"3fa7e38b_a480108d","line":86,"range":{"start_line":80,"start_character":0,"end_line":86,"end_character":49},"updated":"2019-09-20 10:04:46.000000000","message":"This var is not used anywhere as well","commit_id":"4ff577a5d3ced65734e99adb7ff727a23659b54f"}],"vars/main.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5c7867ef9a09782d7f69138d29d0c8ddc4add122","unresolved":false,"context_lines":[{"line_number":229,"context_line":"python_venv_build_vars: |-"},{"line_number":230,"context_line":"  {% set vars \u003d {} %}"},{"line_number":231,"context_line":"  {% if inventory_hostname in groups[\u0027ironic_inspector\u0027] %}"},{"line_number":232,"context_line":"  {%   set _ \u003d vars.update({\u0027constraints\u0027: ironic_inspector_git_constraints}) %}"},{"line_number":233,"context_line":"  {%   set _ \u003d vars.update({\u0027dest_path: ironic_inspector_bin | dirname}) %}"},{"line_number":234,"context_line":"  {%   set _ \u003d vars.update({\u0027distro_packages: ironic_inspector_devel_distro_packages}) %}"},{"line_number":235,"context_line":"  {%   set _ \u003d vars.update({\u0027distro_package_list: ironic_inspector_packages_list}) %}"},{"line_number":236,"context_line":"  {%   set _ \u003d vars.update({\u0027pip_install_args: ironic_inspector_pip_install_args}) %}"},{"line_number":237,"context_line":"  {%   set _ \u003d vars.update({\u0027pip_packages: (ironic_inspector_oslomsg_amqp1_enabled | bool) | ternary(ironic_inspector_pip_packages + ironic_inspector_optional_oslomsg_amqp1_pip_packages, ironic_inspector_pip_packages)}) %}"},{"line_number":238,"context_line":"  {%   set _ \u003d vars.update({\u0027venv_python_executable: ironic_inspector_venv_python_executable}) %}"},{"line_number":239,"context_line":"  {% else %}"},{"line_number":240,"context_line":"  {%   set _ \u003d vars.update({\u0027constraints\u0027: ironic_git_constraints}) %}"},{"line_number":241,"context_line":"  {%   set _ \u003d vars.update({\u0027dest_path: ironic_bin | dirname}) %}"}],"source_content_type":"text/x-yaml","patch_set":45,"id":"3fa7e38b_e191249b","line":238,"range":{"start_line":232,"start_character":0,"end_line":238,"end_character":97},"updated":"2019-09-19 17:29:26.000000000","message":"1. Missing quotes\n\n2. I guess this might be done with one update to speed up things like this:\n  {%   set _ \u003d vars.update({\n         \u0027constraints\u0027: ironic_inspector_git_constraints,\n         \u0027dest_path\u0027: ironic_inspector_bin | dirname,\n         \u0027distro_packages\u0027: ironic_inspector_devel_distro_packages}\n         \u0027distro_package_list\u0027: ironic_inspector_packages_list\n       }) %}","commit_id":"9e23f352e0cd46ae7d98e7f726d23778238b50fe"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5deb72a7af57929aeca675d1fbc10822f0f546b7","unresolved":false,"context_lines":[{"line_number":207,"context_line":"  {% endfor %}"},{"line_number":208,"context_line":"  {{ concat_drivers }}"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"ironic_inspector_packages_list: \u003e"},{"line_number":211,"context_line":"  {%- set package_list \u003d [] %}"},{"line_number":212,"context_line":"  {%- if ironic_inspector_developer_mode | bool %}"},{"line_number":213,"context_line":"  {%-   set package_list \u003d package_list + ironic_inspector_developer_mode_distro_packages %}"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"3fa7e38b_8498741b","line":210,"range":{"start_line":210,"start_character":0,"end_line":210,"end_character":30},"updated":"2019-09-20 10:04:46.000000000","message":"Since ironic_inspector_developer_mode_distro_packages is not defined, this whole var doesn\u0027t make sense to me. You can easily set it to the empty list or even drop it, since","commit_id":"4ff577a5d3ced65734e99adb7ff727a23659b54f"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5deb72a7af57929aeca675d1fbc10822f0f546b7","unresolved":false,"context_lines":[{"line_number":210,"context_line":"ironic_inspector_packages_list: \u003e"},{"line_number":211,"context_line":"  {%- set package_list \u003d [] %}"},{"line_number":212,"context_line":"  {%- if ironic_inspector_developer_mode | bool %}"},{"line_number":213,"context_line":"  {%-   set package_list \u003d package_list + ironic_inspector_developer_mode_distro_packages %}"},{"line_number":214,"context_line":"  {%- endif %}"},{"line_number":215,"context_line":"  {{- package_list -}}"},{"line_number":216,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":49,"id":"3fa7e38b_a4e490ad","line":213,"range":{"start_line":213,"start_character":42,"end_line":213,"end_character":89},"updated":"2019-09-20 10:04:46.000000000","message":"This variable is not defined in your patch","commit_id":"4ff577a5d3ced65734e99adb7ff727a23659b54f"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"57087488032095f3fe2425cdf2d235b4b31e88bb","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"python_venv_build_vars: |-"},{"line_number":230,"context_line":"  {% set vars \u003d {} %}"},{"line_number":231,"context_line":"  {% if inventory_hostname in groups[\u0027ironic_inspector\u0027] | default([]) %}"},{"line_number":232,"context_line":"  {%   set _ \u003d vars.update("},{"line_number":233,"context_line":"        {"},{"line_number":234,"context_line":"         \u0027constraints\u0027: ironic_inspector_git_constraints,"}],"source_content_type":"text/x-yaml","patch_set":50,"id":"3fa7e38b_68cf46b0","line":231,"range":{"start_line":231,"start_character":67,"end_line":231,"end_character":69},"updated":"2019-09-20 14:40:40.000000000","message":"This should be bool as well","commit_id":"ba1c30ced5959886cce04f1847d9c90805198186"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"5ed0a1cd35463163e0163ab87c00e773a3d33126","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    management: ucsm"},{"line_number":138,"context_line":"    power: ucsm"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"ironic_packages_list: \u003e"},{"line_number":141,"context_line":"  {%- set package_list \u003d [] %}"},{"line_number":142,"context_line":"  {%- if ironic_services[\u0027ironic-api\u0027][\u0027group\u0027] in group_names %}"},{"line_number":143,"context_line":"  {%-   set package_list \u003d package_list + ironic_api_distro_packages %}"},{"line_number":144,"context_line":"  {%- endif %}"},{"line_number":145,"context_line":"  {%- if ironic_services[\u0027ironic-conductor\u0027][\u0027group\u0027] in group_names %}"},{"line_number":146,"context_line":"  {%-   set package_list \u003d package_list + ironic_conductor_distro_packages %}"},{"line_number":147,"context_line":"  {%-   if ironic_standalone | bool %}"},{"line_number":148,"context_line":"  {%-     set package_list \u003d package_list + ironic_conductor_standalone_distro_packages %}"},{"line_number":149,"context_line":"  {%-   endif %}"},{"line_number":150,"context_line":"  {%- endif %}"},{"line_number":151,"context_line":"  {{- package_list -}}"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"filtered_ironic_services: |-"},{"line_number":154,"context_line":"  {% set services \u003d [] %}"}],"source_content_type":"text/x-yaml","patch_set":61,"id":"3fa7e38b_7566ebc3","line":151,"range":{"start_line":140,"start_character":0,"end_line":151,"end_character":22},"updated":"2019-09-25 15:29:15.000000000","message":"would i expect to see ironic_inspector_distro_packages added in here?","commit_id":"67cd57cc1ab76fa0b4e15b20cd4c2c6f54e72a1e"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2936a5f527c6c317f689ab1e9c1686ca943b8b89","unresolved":false,"context_lines":[{"line_number":148,"context_line":"  {%-     set package_list \u003d package_list + ironic_conductor_standalone_distro_packages %}"},{"line_number":149,"context_line":"  {%-   endif %}"},{"line_number":150,"context_line":"  {%- endif %}"},{"line_number":151,"context_line":"  {%- if ironic_inspector_dhcp_type \u003d\u003d \"dnsmasq\" %}"},{"line_number":152,"context_line":"  {%-   set package_list \u003d package_list + ironic_inspector_dnsmasq_distro_packages %}"},{"line_number":153,"context_line":"  {%- else %}"},{"line_number":154,"context_line":"  {%-   set package_list \u003d package_list + ironic_inspector_isc_dhcp_distro_packages %}"},{"line_number":155,"context_line":"  {%- endif %}"},{"line_number":156,"context_line":"  {%- if ironic_inspector_boot_mode \u003d\u003d \"http\" %}"},{"line_number":157,"context_line":"  {%-   set package_list \u003d package_list + ironic_inspector_http_distro_packages %}"},{"line_number":158,"context_line":"  {%- endif %}"},{"line_number":159,"context_line":"  {{- package_list -}}"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"filtered_ironic_services: |-"}],"source_content_type":"text/x-yaml","patch_set":72,"id":"3fa7e38b_08b4c035","line":158,"range":{"start_line":151,"start_character":0,"end_line":158,"end_character":14},"updated":"2019-11-28 14:28:41.000000000","message":"I think this block should be inside \n{% if ironic_services[\u0027ironic-inspector\u0027][\u0027group\u0027] in group_names }%\n...\n{% endif %}","commit_id":"9900faf3f3ef2d718408aa11441fbf9070228bd6"}]}