)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16011,"name":"James Denton","email":"james.denton@outlook.com","username":"busterswt"},"change_message_id":"3a0c3057438f4ea028c28e1a270750f4b1cddb0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"30ebf3b0_a9149a6b","updated":"2022-08-04 12:51:26.000000000","message":"Will want to test this on metal and lxc to ensure the behavior is correct in both places.","commit_id":"42928d5d70539a3d2ecd79fa783bf5363c0286db"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"194107a0ef69f27776ba585e30ac6f352ea85edb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"488783ff_6184cbe1","updated":"2022-08-14 09:07:11.000000000","message":"Ah - i think that maybe this patch needs to be applied first https://review.opendev.org/c/openstack/openstack-ansible/+/852174","commit_id":"3875e750c3356f39daf482b85f6862836518513b"},{"author":{"_account_id":16011,"name":"James Denton","email":"james.denton@outlook.com","username":"busterswt"},"change_message_id":"1b34c68292e2cac5abcbedd42da10165e3c44e29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"340d94f9_bf9683ea","updated":"2022-08-14 02:29:33.000000000","message":"Seems this is only gating against metal. In an AIO LXC deploy, I\u0027m finding that container_networks is missing addresses for everything except mgmt, including tunnel, storage, and bmaas. This is observable in the inventory as well.\n\n{\u0027bmaas_address\u0027: {\u0027bridge\u0027: \u0027br-bmaas\u0027, \u0027netmask\u0027: \u0027255.255.252.0\u0027, \u0027type\u0027: \u0027veth\u0027}, \u0027container_address\u0027: {\u0027address\u0027: \u0027172.29.236.100\u0027, \u0027bridge\u0027: \u0027br-mgmt\u0027, \u0027netmask\u0027: \u0027255.255.252.0\u0027, \u0027static_routes\u0027: [{\u0027cidr\u0027: \u0027172.29.248.0/22\u0027, \u0027gateway\u0027: \u0027172.29.236.100\u0027}], \u0027type\u0027: \u0027veth\u0027}, \u0027eth11_address\u0027: {\u0027bridge\u0027: \u0027br-vlan\u0027, \u0027netmask\u0027: None, \u0027type\u0027: \u0027veth\u0027}, \u0027eth12_address\u0027: {\u0027bridge\u0027: \u0027br-vlan\u0027, \u0027netmask\u0027: None, \u0027type\u0027: \u0027veth\u0027}, \u0027storage_address\u0027: {\u0027bridge\u0027: \u0027br-storage\u0027, \u0027netmask\u0027: \u0027255.255.252.0\u0027, \u0027type\u0027: \u0027veth\u0027}, \u0027tunnel_address\u0027: {\u0027bridge\u0027: \u0027br-vxlan\u0027, \u0027netmask\u0027: \u0027255.255.252.0\u0027, \u0027type\u0027: \u0027veth\u0027}}\n\nAs a result, I\u0027m hitting undefined address.","commit_id":"3875e750c3356f39daf482b85f6862836518513b"},{"author":{"_account_id":16011,"name":"James Denton","email":"james.denton@outlook.com","username":"busterswt"},"change_message_id":"6e82ee7dfca7935359e0c5720e46f8329a4966fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b2efb6ad_ae712086","in_reply_to":"488783ff_6184cbe1","updated":"2022-08-14 12:16:11.000000000","message":"FWIW, I had already applied that patch and confirmed that openstack_user_config.yml is being populated. Looking at inventory, it seems like none of the IPs are being picked up for the \"host\" container, except for br-mgmt.","commit_id":"3875e750c3356f39daf482b85f6862836518513b"},{"author":{"_account_id":16011,"name":"James Denton","email":"james.denton@outlook.com","username":"busterswt"},"change_message_id":"986b17eceb1ac8cd4eaa81e55d86b15531d3edf4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f0e7c901_fb4a87e8","updated":"2022-08-14 12:46:58.000000000","message":"Might be worth mentioning both cinder and neutron use this dynamic address fact mechanism for what I assume are similar reasons:\n\nhttps://github.com/openstack/openstack-ansible/blob/master/playbooks/common-playbooks/cinder.yml#L60-L65\n\nhttps://github.com/openstack/openstack-ansible/blob/master/playbooks/common-playbooks/neutron.yml#L60-L65\n\nMaybe Ironic will need something similar?","commit_id":"b0d7948fc9b67d3826e419e3b0a177305f234c44"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"21565e88805d45e29a200e51bf43af0bd5bebe20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"44e1235f_da6d96e0","updated":"2022-08-29 10:52:38.000000000","message":"lgtm, but relation chain looks out of order","commit_id":"3c162c376f30d27fc1a34ce499e9c4445bcbd3a4"}],"defaults/main.yml":[{"author":{"_account_id":16011,"name":"James Denton","email":"james.denton@outlook.com","username":"busterswt"},"change_message_id":"3a0c3057438f4ea028c28e1a270750f4b1cddb0a","unresolved":true,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"# The name of the entry in container_networks for the bmaas network"},{"line_number":120,"context_line":"# This is the default provisioning / inspection / cleaning network for this role"},{"line_number":121,"context_line":"ironic_container_network_name: \"bmaass_address\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"# The address of this host on the bmaas network"},{"line_number":124,"context_line":"ironic_bmaas_address: \"{{ container_networks[ironic_container_network_name][\u0027address\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"88d5fab0_f2317bcd","line":121,"range":{"start_line":121,"start_character":32,"end_line":121,"end_character":46},"updated":"2022-08-04 12:51:26.000000000","message":"typo?","commit_id":"42928d5d70539a3d2ecd79fa783bf5363c0286db"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"2fb29ea469f98635d543d261344c7cbf0b529301","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"# The name of the entry in container_networks for the bmaas network"},{"line_number":120,"context_line":"# This is the default provisioning / inspection / cleaning network for this role"},{"line_number":121,"context_line":"ironic_container_network_name: \"bmaass_address\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"# The address of this host on the bmaas network"},{"line_number":124,"context_line":"ironic_bmaas_address: \"{{ container_networks[ironic_container_network_name][\u0027address\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"90a348be_1a239f89","line":121,"range":{"start_line":121,"start_character":32,"end_line":121,"end_character":46},"in_reply_to":"88d5fab0_f2317bcd","updated":"2022-08-04 14:59:07.000000000","message":"Done","commit_id":"42928d5d70539a3d2ecd79fa783bf5363c0286db"}]}