)]}'
{"defaults/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7d27e0c68ca0418f04169d2088bab40cc896b776","unresolved":false,"context_lines":[{"line_number":87,"context_line":"## Memcached servers used within keystone."},{"line_number":88,"context_line":"# String or Comma separated list of servers."},{"line_number":89,"context_line":"keystone_memcached_servers: 127.0.0.1"},{"line_number":90,"context_line":"keystone_cache_backend_argument: url:127.0.0.1:11211"},{"line_number":91,"context_line":"keystone_memcached_max_compare_and_set_retry: 16"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"## DB info"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba5da102_a26bdb83","line":90,"range":{"start_line":90,"start_character":0,"end_line":90,"end_character":52},"updated":"2016-11-03 17:05:23.000000000","message":"See https://github.com/openstack/openstack-ansible-os_keystone/blob/master/defaults/main.yml#L243 - this is an optional setting at this stage which is populated via group_vars in the integrated build. IT\u0027s specifically designed so that memcache can be deployed where the deployer chooses to do so in their playbooks, then this var is set to consume it.","commit_id":"724292836534c4101d3b3921dffa462cd07d274a"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"5c0f7a4c9ec7b343e9a11f42081f227bd3ca7de0","unresolved":false,"context_lines":[{"line_number":87,"context_line":"## Memcached servers used within keystone."},{"line_number":88,"context_line":"# String or Comma separated list of servers."},{"line_number":89,"context_line":"keystone_memcached_servers: 127.0.0.1"},{"line_number":90,"context_line":"keystone_cache_backend_argument: url:127.0.0.1:11211"},{"line_number":91,"context_line":"keystone_memcached_max_compare_and_set_retry: 16"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"## DB info"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba5da102_e27b13f3","line":90,"range":{"start_line":90,"start_character":0,"end_line":90,"end_character":52},"in_reply_to":"ba5da102_a26bdb83","updated":"2016-11-03 17:22:12.000000000","message":"If that helps on the contributions, I\u0027m enclined to have this included.\n\nBut I agree, it\u0027s not mandatory.\n\ngroup_vars in openstack-ansible/ are indeed well configured and are doing the right thing for the deployers automatically.\n\nThis would only change for os_keystone role","commit_id":"724292836534c4101d3b3921dffa462cd07d274a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4cab1a68d89b8e783b05d51edae6b1375baeb76c","unresolved":false,"context_lines":[{"line_number":87,"context_line":"## Memcached servers used within keystone."},{"line_number":88,"context_line":"# String or Comma separated list of servers."},{"line_number":89,"context_line":"keystone_memcached_servers: 127.0.0.1"},{"line_number":90,"context_line":"keystone_cache_backend_argument: url:127.0.0.1:11211"},{"line_number":91,"context_line":"keystone_memcached_max_compare_and_set_retry: 16"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"## DB info"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba5da102_3d436c14","line":90,"range":{"start_line":90,"start_character":0,"end_line":90,"end_character":52},"in_reply_to":"ba5da102_e27b13f3","updated":"2016-11-03 17:24:55.000000000","message":"If this is included, then we would have to force inclusion of memcached as a dep, which I don\u0027t think is appropriate.","commit_id":"724292836534c4101d3b3921dffa462cd07d274a"}],"meta/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7d27e0c68ca0418f04169d2088bab40cc896b776","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  - role: galera_client"},{"line_number":39,"context_line":"    when:"},{"line_number":40,"context_line":"      - keystone_database_enabled | bool"},{"line_number":41,"context_line":"  - role: memcached_server"},{"line_number":42,"context_line":"    when:"},{"line_number":43,"context_line":"      - \"\u0027memcache\u0027 in keystone_token_driver\""},{"line_number":44,"context_line":"      - \"\u0027fernet\u0027 not in keystone_token_provider\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba5da102_e2d2335b","side":"PARENT","line":41,"updated":"2016-11-03 17:05:23.000000000","message":"This is specifically designed not to deploy the memcache role onto the keystone containers if fernet tokens are used. This is due to the fact that the integrated deployment has memcache containers and keystone is wired to use those: https://github.com/openstack/openstack-ansible/blob/master/playbooks/inventory/group_vars/keystone_all.yml#L18\n\nIs this patch suggesting that memcache *must* be deployed on the same host as the keystone containers?","commit_id":"89a0d7d58665caa8cb6c2e1e9c954af93373c8af"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"5c0f7a4c9ec7b343e9a11f42081f227bd3ca7de0","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  - role: galera_client"},{"line_number":39,"context_line":"    when:"},{"line_number":40,"context_line":"      - keystone_database_enabled | bool"},{"line_number":41,"context_line":"  - role: memcached_server"},{"line_number":42,"context_line":"    when:"},{"line_number":43,"context_line":"      - \"\u0027memcache\u0027 in keystone_token_driver\""},{"line_number":44,"context_line":"      - \"\u0027fernet\u0027 not in keystone_token_provider\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba5da102_c248cfb5","side":"PARENT","line":41,"in_reply_to":"ba5da102_e2d2335b","updated":"2016-11-03 17:22:12.000000000","message":"Agreed.","commit_id":"89a0d7d58665caa8cb6c2e1e9c954af93373c8af"},{"author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"change_message_id":"ddd87a22911a09e7996d1c4b94faa22ea0a69622","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  - role: memcached_server"},{"line_number":42,"context_line":"    when:"},{"line_number":43,"context_line":"      - \"\u0027memcache\u0027 in keystone_token_driver\""},{"line_number":44,"context_line":"      - \"\u0027fernet\u0027 not in keystone_token_provider\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba5da102_0e48a65a","side":"PARENT","line":44,"updated":"2016-11-01 09:09:15.000000000","message":"How about removing the second condition (L44), then use the condition on L43 around the cache section in the template?","commit_id":"89a0d7d58665caa8cb6c2e1e9c954af93373c8af"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6e5c2bbf042453982bafe2881bdd25b64a5a4183","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  - role: memcached_server"},{"line_number":42,"context_line":"    when:"},{"line_number":43,"context_line":"      - \"\u0027memcache\u0027 in keystone_token_driver\""},{"line_number":44,"context_line":"      - \"\u0027fernet\u0027 not in keystone_token_provider\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba5da102_be151641","side":"PARENT","line":44,"in_reply_to":"ba5da102_0e48a65a","updated":"2016-11-01 16:30:03.000000000","message":"In this case, we want to deploy memcache regardless of memcache being the token driver. If someone configures fernet as the token provider this is especially true since the tokens references are built from scratch on validation (which isn\u0027t the case for UUID tokens up to Newton).","commit_id":"89a0d7d58665caa8cb6c2e1e9c954af93373c8af"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"5c0f7a4c9ec7b343e9a11f42081f227bd3ca7de0","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  - role: galera_client"},{"line_number":39,"context_line":"    when:"},{"line_number":40,"context_line":"      - keystone_database_enabled | bool"},{"line_number":41,"context_line":"  - memcached_server"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba5da102_620f0337","line":41,"range":{"start_line":41,"start_character":4,"end_line":41,"end_character":20},"updated":"2016-11-03 17:22:12.000000000","message":"I\u0027d be enclined to remove it completely from the role dependencies.\n\nWe should be able to use what\u0027s been provisionned, and not force collocation.","commit_id":"724292836534c4101d3b3921dffa462cd07d274a"}],"releasenotes/notes/always-use-caching-5b94640823555917.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"5c0f7a4c9ec7b343e9a11f42081f227bd3ca7de0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - Always deploy memcached with keystone. Caching has"},{"line_number":4,"context_line":"    drastic performance improvements to keystone sub-systems,"},{"line_number":5,"context_line":"    especially the token API."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba5da102_9d1c786b","line":5,"range":{"start_line":3,"start_character":4,"end_line":5,"end_character":29},"updated":"2016-11-03 17:22:12.000000000","message":"I\u0027d rephrase this to:\nKeystone role now always require memcached to be set up. Caching has drastic performance improvements to keystone sub-systems, especially the token API.","commit_id":"724292836534c4101d3b3921dffa462cd07d274a"}],"templates/keystone.conf.j2":[{"author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"change_message_id":"ddd87a22911a09e7996d1c4b94faa22ea0a69622","unresolved":false,"context_lines":[{"line_number":27,"context_line":"max_compare_and_set_retry \u003d {{ keystone_memcached_max_compare_and_set_retry }}"},{"line_number":28,"context_line":"{% endif %}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"{% if keystone_cache_backend_argument is defined %}"},{"line_number":31,"context_line":"[cache]"},{"line_number":32,"context_line":"backend \u003d dogpile.cache.memcached"},{"line_number":33,"context_line":"backend_argument \u003d {{ keystone_cache_backend_argument }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"ba5da102_eeba9222","side":"PARENT","line":30,"updated":"2016-11-01 09:09:15.000000000","message":"change to \u0027memcache\u0027 in keystone_token_driver\" ?","commit_id":"89a0d7d58665caa8cb6c2e1e9c954af93373c8af"}]}