)]}'
{"tasks/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"dfc259c21265bd8492c898f6157ee9b191f59078","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  when:"},{"line_number":28,"context_line":"    - not keystone_apache_enabled | bool"},{"line_number":29,"context_line":"    - keystone_mod_wsgi_enabled | bool"},{"line_number":30,"context_line":"  with_items: \"{{ keystone_required_secrets }}\""},{"line_number":31,"context_line":"  tags:"},{"line_number":32,"context_line":"    - always"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa7ab95a_df61b706","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":47},"updated":"2016-08-30 09:02:32.000000000","message":"I don\u0027t think this is necessary?","commit_id":"f603e6d3a04cd51c7bc3ad6cff1f584d3d7f4632"}],"tox.ini":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"8095ff0b4e5b85240d4c4a22b4a982ab4e8d9e46","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    bash -c \u0027rsync -av --ignore-errors /var/log/ /openstack/log/ {toxinidir}/logs/ || true\u0027"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"# NOTE(andymccr): this will test keystone with uwsgi \u0026 nginx"},{"line_number":172,"context_line":"[testenv:func_uwsgi-nginx]"},{"line_number":173,"context_line":"install_command \u003d"},{"line_number":174,"context_line":"    pip install -U --force-reinstall {opts} {packages}"},{"line_number":175,"context_line":"deps \u003d"}],"source_content_type":"text/x-properties","patch_set":8,"id":"fa7ab95a_929ee805","line":172,"range":{"start_line":172,"start_character":9,"end_line":172,"end_character":25},"updated":"2016-08-31 12:40:30.000000000","message":"This cannot include dashes. It will need to be \u0027uwsgi_nginx\u0027.","commit_id":"807fbfd47e87db4ffb003f80ca2a860230231786"},{"author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"change_message_id":"3bb050ef1db9e64acf00c4c6b2ba00164f0f7930","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    bash -c \u0027rsync -av --ignore-errors /var/log/ /openstack/log/ {toxinidir}/logs/ || true\u0027"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"[testenv:uwsgi_nginx]"},{"line_number":179,"context_line":"# Ignore_errors is set to true so that the logs are collected at the"},{"line_number":180,"context_line":"#  end of the run. This will not produce a failse positive. Any"},{"line_number":181,"context_line":"#  exception will be mark the run as \"failed\" and exit 1 after all of"}],"source_content_type":"text/x-properties","patch_set":9,"id":"fa7ab95a_76b5c3ce","line":178,"range":{"start_line":178,"start_character":9,"end_line":178,"end_character":20},"updated":"2016-08-31 17:04:00.000000000","message":"My understanding is that we set this to \"func_uwsgi_nginx\" or \"func_/,test_name\u003e\" for additional functional tests, because run_tests.sh will run through each tox env, which you wouldn\u0027t want, but will skip on func_*:\n\nhttps://github.com/openstack/openstack-ansible-os_keystone/blob/master/run_tests.sh#L48","commit_id":"7160215c7bfd249aba1c1f60c33245e47beb0519"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"495607e9ccf194ac8fe1050e96cb8fc4ac0bf697","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    bash -c \u0027rsync -av --ignore-errors /var/log/ /openstack/log/ {toxinidir}/logs/ || true\u0027"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"[testenv:uwsgi_nginx]"},{"line_number":179,"context_line":"# Ignore_errors is set to true so that the logs are collected at the"},{"line_number":180,"context_line":"#  end of the run. This will not produce a failse positive. Any"},{"line_number":181,"context_line":"#  exception will be mark the run as \"failed\" and exit 1 after all of"}],"source_content_type":"text/x-properties","patch_set":9,"id":"fa7ab95a_6cfed206","line":178,"range":{"start_line":178,"start_character":9,"end_line":178,"end_character":20},"in_reply_to":"fa7ab95a_76b5c3ce","updated":"2016-08-31 17:19:41.000000000","message":"Apologies - I changed the name. The reason to want it shorter is that the infra folder name used for the workspace in which jenkins runs has a limit, and many of our jobs are very close to that limit. We can try the name suggested and see whether it works - otherwise we\u0027ll have to do a follow on patch to rename it to something shorter and will have to change run_tests.sh to accommodate that.","commit_id":"7160215c7bfd249aba1c1f60c33245e47beb0519"}]}
