)]}'
{"tox.ini":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"47be6f5efdaa6df29a882ac2ab9c5968707426c7","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    bash -c \u0027rsync -av --ignore-errors /var/log/ /openstack/log/ {toxinidir}/logs/ || true\u0027"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"# NOTE(stevelle): this will test keystone with uwsgi \u0026 Apache"},{"line_number":172,"context_line":"[testenv:func_uwsgi-apache]"},{"line_number":173,"context_line":"install_command \u003d"},{"line_number":174,"context_line":"    pip install -U --force-reinstall {opts} {packages}"},{"line_number":175,"context_line":"deps \u003d"}],"source_content_type":"text/x-properties","patch_set":4,"id":"fa7ab95a_32a7dc50","line":172,"range":{"start_line":172,"start_character":9,"end_line":172,"end_character":26},"updated":"2016-08-31 12:40:53.000000000","message":"This cannot include dashes. It will need to be \u0027uwsgi_apache\u0027.","commit_id":"0c016c3370d2a7653b475031bc6bbac7822b937e"},{"author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"change_message_id":"f661d3f0e823b0527cf03323983d1647cad6b050","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    bash -c \u0027rsync -av --ignore-errors /var/log/ /openstack/log/ {toxinidir}/logs/ || true\u0027"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"[testenv:uwsgi_apache]"},{"line_number":179,"context_line":"# Ignore_errors is set to true so that the logs are collected at the"},{"line_number":180,"context_line":"#  end of the run. This will not produce a failse positive. Any"},{"line_number":181,"context_line":"#  exception will be mark the run as \"failed\" and exit 1 after all of"}],"source_content_type":"text/x-properties","patch_set":6,"id":"fa7ab95a_36f25b9b","line":178,"range":{"start_line":178,"start_character":9,"end_line":178,"end_character":21},"updated":"2016-08-31 17:03:55.000000000","message":"Similar to my review on the previous PR.\n\nI believe we set this to \"func_uwsgi_apache\" so that run_tests.sh can skip the additional non-default functional tasks.\n\nhttps://github.com/openstack/openstack-ansible-os_keystone/blob/master/run_tests.sh#L48","commit_id":"a09beedab252f4bdf752ce2d46716cc352e90183"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"dc24f2f458fe1062783ed5464245f79f64b28e86","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    bash -c \u0027rsync -av --ignore-errors /var/log/ /openstack/log/ {toxinidir}/logs/ || true\u0027"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"[testenv:uwsgi_apache]"},{"line_number":179,"context_line":"# Ignore_errors is set to true so that the logs are collected at the"},{"line_number":180,"context_line":"#  end of the run. This will not produce a failse positive. Any"},{"line_number":181,"context_line":"#  exception will be mark the run as \"failed\" and exit 1 after all of"}],"source_content_type":"text/x-properties","patch_set":6,"id":"fa7ab95a_6c25f2ac","line":178,"range":{"start_line":178,"start_character":9,"end_line":178,"end_character":21},"in_reply_to":"fa7ab95a_36f25b9b","updated":"2016-08-31 17:19:58.000000000","message":"Apologies - I changed the name. The reason to want it shorter is that the infra folder name used for the workspace in which jenkins runs has a limit, and many of our jobs are very close to that limit. We can try the name suggested and see whether it works - otherwise we\u0027ll have to do a follow on patch to rename it to something shorter and will have to change run_tests.sh to accommodate that.","commit_id":"a09beedab252f4bdf752ce2d46716cc352e90183"}]}
