)]}'
{"handlers/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"cf478a884daebeff6a35ad69c510663c8a46ecf1","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    timeout: 25"},{"line_number":35,"context_line":"    delay: 10"},{"line_number":36,"context_line":"  register: keystone_wait_check"},{"line_number":37,"context_line":"  until: keystone_wait_check | success"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Restart service on other nodes"},{"line_number":40,"context_line":"  service:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1a95cdbc_840a6324","line":37,"updated":"2016-10-10 14:36:39.000000000","message":"The failure is in a type error here: http://logs.openstack.org/69/384269/5/check/gate-openstack-ansible-os_keystone-ansible-func-ubuntu-trusty/ae7ea9c/console.html#_2016-10-10_14_27_42_532072","commit_id":"2d6546eecc7358cd78587d027211ff70d2270408"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"8e260f700351b38bdd1bc7ec75c640f2b6c53e23","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    timeout: 25"},{"line_number":35,"context_line":"    delay: 10"},{"line_number":36,"context_line":"  register: keystone_wait_check"},{"line_number":37,"context_line":"  until: keystone_wait_check | success"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Restart service on other nodes"},{"line_number":40,"context_line":"  service:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1a95cdbc_3a0b6425","line":37,"in_reply_to":"1a95cdbc_840a6324","updated":"2016-10-10 15:32:25.000000000","message":"Apparently there\u0027s a bug in ansible 2.1.1.0 with retries not being set correctly.\nhttps://github.com/ansible/ansible/pull/16962","commit_id":"2d6546eecc7358cd78587d027211ff70d2270408"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"fac581132309ee489e63eb622ce262465abfadb8","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  delay: 2"},{"line_number":61,"context_line":"  when: not keystone_apache_enabled | bool"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"- name: Restart Keystone APIs on first node"},{"line_number":64,"context_line":"  service:"},{"line_number":65,"context_line":"    name: \"{{ item }}\""},{"line_number":66,"context_line":"    state: \"restarted\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a95cdbc_7c76c706","line":63,"updated":"2016-10-10 16:45:06.000000000","message":"This needs to be moved above the port check handler to make sure that the order is restart first node \u003e wait for port \u003e restart other nodes for uwsgi_nginx.","commit_id":"71bb6d1489e4c1f25912b56745fdcdb6aa4e9c5d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"26e171fcc198e494ee7522cafefd0d87cf9ac175","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"7a77a97e_a1636a19","updated":"2016-11-16 11:03:42.000000000","message":"Through the use of some ternaries and conditionals I expect that we could probably cut down the number of handlers here to a smaller set - however, these are fine as-is and can be optimised in a follow up patch.","commit_id":"ded0bbd936b821b5b808856ace3b0db5e0316802"}],"tasks/keystone_apache.yml":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f92caadee0c73c9d5b784e9214e0d13cab5ec9b7","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  with_items: \"{{ keystone_apache_configs }}\""},{"line_number":35,"context_line":"  notify:"},{"line_number":36,"context_line":"    - Restart service on first node"},{"line_number":37,"context_line":"    - Restart service on other nodes"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Disable default apache site"},{"line_number":40,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fa6399be_e010565c","line":37,"updated":"2016-10-17 15:00:25.000000000","message":"These are alway done serially based on the order or the notifications in the list, right?","commit_id":"52fa5d874d73a4b95b7e8fd7a6e50a5293ce0ed0"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"0e3fd83669ddf2d813d3029f3540b6ac0adf58c1","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  with_items: \"{{ keystone_apache_configs }}\""},{"line_number":35,"context_line":"  notify:"},{"line_number":36,"context_line":"    - Restart service on first node"},{"line_number":37,"context_line":"    - Restart service on other nodes"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Disable default apache site"},{"line_number":40,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fa6399be_1df20107","line":37,"in_reply_to":"fa6399be_e010565c","updated":"2016-10-17 23:20:39.000000000","message":"Right.\nrestart on first node \u003e wait for port to be available\nrestart on other nodes\ndb_sync --contract","commit_id":"52fa5d874d73a4b95b7e8fd7a6e50a5293ce0ed0"}],"tasks/keystone_db_setup.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"3578c094e94c7c1123fbf6033dbcad64d6b14897","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- name: Ensure keystone service stopped on first node"},{"line_number":17,"context_line":"  service:"},{"line_number":18,"context_line":"    name: \"{{ item }}\""},{"line_number":19,"context_line":"    state: started"},{"line_number":20,"context_line":"  register: keystone_stop"},{"line_number":21,"context_line":"  failed_when:"},{"line_number":22,"context_line":"    - keystone_stop.msg is defined"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fa6399be_39127263","line":19,"range":{"start_line":19,"start_character":11,"end_line":19,"end_character":18},"updated":"2016-10-11 11:55:31.000000000","message":"is that what we want here?","commit_id":"1358010384fb039050798d097ff26c2383cbe25f"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"8b96710263463c225f89b7156a864ff0ce567ff9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- name: Ensure keystone service stopped on first node"},{"line_number":17,"context_line":"  service:"},{"line_number":18,"context_line":"    name: \"{{ item }}\""},{"line_number":19,"context_line":"    state: started"},{"line_number":20,"context_line":"  register: keystone_stop"},{"line_number":21,"context_line":"  failed_when:"},{"line_number":22,"context_line":"    - keystone_stop.msg is defined"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fa6399be_444f28bd","line":19,"range":{"start_line":19,"start_character":11,"end_line":19,"end_character":18},"in_reply_to":"fa6399be_39127263","updated":"2016-10-11 17:47:19.000000000","message":"good catch","commit_id":"1358010384fb039050798d097ff26c2383cbe25f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f92caadee0c73c9d5b784e9214e0d13cab5ec9b7","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    - \"{{ keystone_system_service_name }}\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Perform a Keystone DB sync expand"},{"line_number":30,"context_line":"  command: \"{{ keystone_bin }}/keystone-manage db_sync --expand\""},{"line_number":31,"context_line":"  become: yes"},{"line_number":32,"context_line":"  become_user: \"{{ keystone_system_user_name }}\""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fa6399be_e356a0cd","line":30,"updated":"2016-10-17 15:00:25.000000000","message":"Do we make sure this is only run on a single node in the deployment?\n\nThis also means that the os-keystone role will only support zero downtime upgrades, will there be a case where someone wants to just upgrade?","commit_id":"52fa5d874d73a4b95b7e8fd7a6e50a5293ce0ed0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"948a53abe4afc02a1ff205b5bbf4e51a1aa25056","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    - \"{{ keystone_system_service_name }}\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Perform a Keystone DB sync expand"},{"line_number":30,"context_line":"  command: \"{{ keystone_bin }}/keystone-manage db_sync --expand\""},{"line_number":31,"context_line":"  become: yes"},{"line_number":32,"context_line":"  become_user: \"{{ keystone_system_user_name }}\""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fa6399be_fc2f133c","line":30,"in_reply_to":"fa6399be_0e13bb0e","updated":"2016-10-17 21:16:12.000000000","message":"I agree - just curious if that was we should account for. Also, does this need to have a `when` statement so that it\u0027s only run against a single keystone node? If keystone[0] is going to be the node that is upgraded first I think we\u0027ll need to make sure this is run from that node so we can be sure we\u0027re running the latest migrations.","commit_id":"52fa5d874d73a4b95b7e8fd7a6e50a5293ce0ed0"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d0660c5d837f3a5e31cfa0fffd96e416efd530eb","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    - \"{{ keystone_system_service_name }}\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Perform a Keystone DB sync expand"},{"line_number":30,"context_line":"  command: \"{{ keystone_bin }}/keystone-manage db_sync --expand\""},{"line_number":31,"context_line":"  become: yes"},{"line_number":32,"context_line":"  become_user: \"{{ keystone_system_user_name }}\""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fa6399be_0e13bb0e","line":30,"in_reply_to":"fa6399be_e356a0cd","updated":"2016-10-17 15:14:25.000000000","message":"Is there a reason why we would *not* want to do this form of upgrade?\n\nWe could obviously provide an option for either, but it seems a bit silly to carry code for an option that\u0027ll never be used.","commit_id":"52fa5d874d73a4b95b7e8fd7a6e50a5293ce0ed0"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"0e3fd83669ddf2d813d3029f3540b6ac0adf58c1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    - \"{{ keystone_system_service_name }}\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Perform a Keystone DB sync expand"},{"line_number":30,"context_line":"  command: \"{{ keystone_bin }}/keystone-manage db_sync --expand\""},{"line_number":31,"context_line":"  become: yes"},{"line_number":32,"context_line":"  become_user: \"{{ keystone_system_user_name }}\""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fa6399be_fd770d9d","line":30,"in_reply_to":"fa6399be_fc2f133c","updated":"2016-10-17 23:20:39.000000000","message":"Yep, the include in the main taskfile provides the when: keystone[0] clause for these tasks.\nhttps://review.openstack.org/#/c/384269/11/tasks/main.yml\n\nI\u0027ve also added another clause to only run these tasks when there\u0027s a change within the keystone venv to avoid unnecessarily stopping keystone on the first node.","commit_id":"52fa5d874d73a4b95b7e8fd7a6e50a5293ce0ed0"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"26e171fcc198e494ee7522cafefd0d87cf9ac175","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Ensure keystone service stopped on first node"},{"line_number":17,"context_line":"  service:"},{"line_number":18,"context_line":"    name: \"{{ item }}\""},{"line_number":19,"context_line":"    state: stopped"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"7a77a97e_d2075e7f","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":53},"updated":"2016-11-16 11:03:42.000000000","message":"Would it be possible, in some way, to detect whether this needs to be done? ie we don\u0027t execute keystone_db_setup at all unless there is no db or a migration is required?\n\nPerhaps there is some sort of --dry-run option?\n\nEDIT:\nAh, I see that you\u0027ve keyed off of the venv changing - good call.\n\nFYI I\u0027ve registered https://bugs.launchpad.net/keystone/+bug/1642212 in the hopes that we can get return codes to act on, instead of having to interpret stdout. Hopefully we can get that in the future. Raise some heat on that bug. :)","commit_id":"ded0bbd936b821b5b808856ace3b0db5e0316802"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"26e171fcc198e494ee7522cafefd0d87cf9ac175","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Perform a Keystone DB sync expand"},{"line_number":31,"context_line":"  command: \"{{ keystone_bin }}/keystone-manage db_sync --expand\""},{"line_number":32,"context_line":"  changed_when: true"},{"line_number":33,"context_line":"  become: yes"},{"line_number":34,"context_line":"  become_user: \"{{ keystone_system_user_name }}\""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"7a77a97e_327df21c","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":20},"updated":"2016-11-16 11:03:42.000000000","message":"This is the default behaviour for the command module, isn\u0027t it?","commit_id":"ded0bbd936b821b5b808856ace3b0db5e0316802"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"b5270a2a0372de1f53eff78810bf471ea6f8e3aa","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Perform a Keystone DB sync expand"},{"line_number":31,"context_line":"  command: \"{{ keystone_bin }}/keystone-manage db_sync --expand\""},{"line_number":32,"context_line":"  changed_when: true"},{"line_number":33,"context_line":"  become: yes"},{"line_number":34,"context_line":"  become_user: \"{{ keystone_system_user_name }}\""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"7a77a97e_8583d055","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":20},"in_reply_to":"7a77a97e_327df21c","updated":"2016-11-16 15:22:39.000000000","message":"This was to avoid a linter error: ANSIBLE0012 \u0027Commands should not change things if nothing needs doing\u0027.","commit_id":"ded0bbd936b821b5b808856ace3b0db5e0316802"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"26e171fcc198e494ee7522cafefd0d87cf9ac175","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"- name: Perform a Keystone DB sync migrate"},{"line_number":37,"context_line":"  command: \"{{ keystone_bin }}/keystone-manage db_sync --migrate\""},{"line_number":38,"context_line":"  changed_when: true"},{"line_number":39,"context_line":"  become: yes"},{"line_number":40,"context_line":"  become_user: \"{{ keystone_system_user_name }}\""},{"line_number":41,"context_line":"  notify:"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"7a77a97e_92724648","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":20},"updated":"2016-11-16 11:03:42.000000000","message":"This is the default behaviour for the command module, isn\u0027t it?","commit_id":"ded0bbd936b821b5b808856ace3b0db5e0316802"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"b5270a2a0372de1f53eff78810bf471ea6f8e3aa","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"- name: Perform a Keystone DB sync migrate"},{"line_number":37,"context_line":"  command: \"{{ keystone_bin }}/keystone-manage db_sync --migrate\""},{"line_number":38,"context_line":"  changed_when: true"},{"line_number":39,"context_line":"  become: yes"},{"line_number":40,"context_line":"  become_user: \"{{ keystone_system_user_name }}\""},{"line_number":41,"context_line":"  notify:"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"7a77a97e_05b18047","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":20},"in_reply_to":"7a77a97e_92724648","updated":"2016-11-16 15:22:39.000000000","message":"This was to avoid a linter error: ANSIBLE0012 \u0027Commands should not change things if nothing needs doing\u0027.\n\nThis task needs to be changed to notify the handler.","commit_id":"ded0bbd936b821b5b808856ace3b0db5e0316802"}],"tests/test-install-previous-keystone.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"26e171fcc198e494ee7522cafefd0d87cf9ac175","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      db_name: \"{{ keystone_galera_database }}\""},{"line_number":31,"context_line":"      db_password: \"{{ keystone_container_mysql_password }}\""},{"line_number":32,"context_line":"  roles:"},{"line_number":33,"context_line":"    - role: \"os_previous_keystone\""},{"line_number":34,"context_line":"  vars_files:"},{"line_number":35,"context_line":"    - common/test-vars.yml"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"7a77a97e_416456e4","line":33,"updated":"2016-11-16 11:03:42.000000000","message":"Unfortunately this is using the stable/newton role, but still installing the keystone from master, all thanks to the test-vars.yml\n\nI think you may have to also grab the stable/newton tests repo and include the vars from there in this playbook in order to get the right implementation done.","commit_id":"ded0bbd936b821b5b808856ace3b0db5e0316802"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"b5270a2a0372de1f53eff78810bf471ea6f8e3aa","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      db_name: \"{{ keystone_galera_database }}\""},{"line_number":31,"context_line":"      db_password: \"{{ keystone_container_mysql_password }}\""},{"line_number":32,"context_line":"  roles:"},{"line_number":33,"context_line":"    - role: \"os_previous_keystone\""},{"line_number":34,"context_line":"  vars_files:"},{"line_number":35,"context_line":"    - common/test-vars.yml"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"7a77a97e_e5f724f3","line":33,"in_reply_to":"7a77a97e_416456e4","updated":"2016-11-16 15:22:39.000000000","message":"Ah, makes sense. Thanks for catching this.","commit_id":"ded0bbd936b821b5b808856ace3b0db5e0316802"}]}
