)]}'
{"handlers/main.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"36cf2ec0ff3940d8525dc1fa55108a46198cd9f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ffe62b97_22e5430b","updated":"2017-03-30 12:46:03.000000000","message":"This is quite an ugly beast.\nWhat I meant is that:\nhttp://docs.ansible.com/ansible/playbooks_intro.html , section listen:","commit_id":"128795442ef832db8a810130c17c3f2e00e2835f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d4cdb440e4c12567b7df757259c0f99e5a2fa5c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ffe62b97_3d0c4841","in_reply_to":"ffe62b97_22e5430b","updated":"2017-03-30 13:12:16.000000000","message":"Oh nice - yes I can rework it to use listen instead - it\u0027s better than flushing handlers. :)","commit_id":"128795442ef832db8a810130c17c3f2e00e2835f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"379c5a87bc40345adb80d92af1e48540782119a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ffe62b97_ee6184d5","in_reply_to":"ffe62b97_3d0c4841","updated":"2017-03-30 13:47:55.000000000","message":"OK, I misunderstood how it worked. So the reasons for not using listen are two-fold:\n\n1. I want to control the order in which the handlers used when, for example, restarting the web server, are fired. It appears that listen would not give the same control.\n2. I want to be able to control when things happen on the bootstrap node versus the other nodes, so the controlling handler is inventory scoped to handle that.\n\nIf you can bash out a sample of an alternative way of doing this that achieves these goals then I\u0027m all ears!","commit_id":"128795442ef832db8a810130c17c3f2e00e2835f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"36cf2ec0ff3940d8525dc1fa55108a46198cd9f6","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- name: Ensure other web server is not running/enabled"},{"line_number":45,"context_line":"  service:"},{"line_number":46,"context_line":"    name: \"{{ (keystone_web_server \u003d\u003d \u0027nginx\u0027) | ternary(keystone_system_service_name, \u0027nginx\u0027) }}\""},{"line_number":47,"context_line":"    enabled: no"},{"line_number":48,"context_line":"    state: stopped"},{"line_number":49,"context_line":"  failed_when: false"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ffe62b97_e2751b34","line":46,"updated":"2017-03-30 12:46:03.000000000","message":"you can call a cat a cat, and remove apache directly :p\n\nBut I\u0027d say it\u0027s maybe good we have an upgrade path instead of doing that into the role handlers. Like another include that just lives for the upgrade period, removing and replacing.","commit_id":"128795442ef832db8a810130c17c3f2e00e2835f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d4cdb440e4c12567b7df757259c0f99e5a2fa5c2","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- name: Ensure other web server is not running/enabled"},{"line_number":45,"context_line":"  service:"},{"line_number":46,"context_line":"    name: \"{{ (keystone_web_server \u003d\u003d \u0027nginx\u0027) | ternary(keystone_system_service_name, \u0027nginx\u0027) }}\""},{"line_number":47,"context_line":"    enabled: no"},{"line_number":48,"context_line":"    state: stopped"},{"line_number":49,"context_line":"  failed_when: false"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ffe62b97_7d39b0f0","line":46,"in_reply_to":"ffe62b97_e2751b34","updated":"2017-03-30 13:12:16.000000000","message":"There may be a need to remove either nginx or apache, which is why this is being done. If the deployer implements Federation, they would have to switch from nginx to apache. If they remove federation then they would need to remove apache and deploy nginx.\n\nThe reason for using a handler is so that we can stage the removal in time with the replacement of the web server. It needs to be done on the bootstrap node first, then the others. This keeps the service up and running during an upgrade so that it does not lose any transactions.","commit_id":"128795442ef832db8a810130c17c3f2e00e2835f"}],"tasks/keystone_install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2856dc412b83b495220499d3862898297eaf1fdc","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  package:"},{"line_number":71,"context_line":"    name: \"{{ item }}\""},{"line_number":72,"context_line":"    state: \"{{ (keystone_web_server \u003d\u003d \u0027apache\u0027) | ternary(keystone_package_state, \u0027absent\u0027) }}\""},{"line_number":73,"context_line":"    autoremove: yes"},{"line_number":74,"context_line":"  register: install_packages"},{"line_number":75,"context_line":"  until: install_packages|success"},{"line_number":76,"context_line":"  retries: 5"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ffe62b97_57824e02","line":73,"range":{"start_line":73,"start_character":4,"end_line":73,"end_character":19},"updated":"2017-03-30 11:21:45.000000000","message":"This is unsupported for the underlying yum module for CentOS, so change this to:\n\nautoremove: {{ (ansible_pkg_mgr \u003d\u003d \u0027apt\u0027) | ternary(yes, omit) }}","commit_id":"32843d61db40ddbea59795e917377e8c927369ee"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2856dc412b83b495220499d3862898297eaf1fdc","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  package:"},{"line_number":82,"context_line":"    name: \"{{ item }}\""},{"line_number":83,"context_line":"    state: \"{{ (keystone_web_server \u003d\u003d \u0027nginx\u0027) | ternary(keystone_package_state, \u0027absent\u0027) }}\""},{"line_number":84,"context_line":"    autoremove: yes"},{"line_number":85,"context_line":"  register: install_packages"},{"line_number":86,"context_line":"  until: install_packages|success"},{"line_number":87,"context_line":"  retries: 5"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ffe62b97_d7753e34","line":84,"range":{"start_line":84,"start_character":4,"end_line":84,"end_character":19},"updated":"2017-03-30 11:21:45.000000000","message":"This is unsupported for the underlying yum module for CentOS, so change this to:\n\nautoremove: {{ (ansible_pkg_mgr \u003d\u003d \u0027apt\u0027) | ternary(yes, omit) }}","commit_id":"32843d61db40ddbea59795e917377e8c927369ee"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2856dc412b83b495220499d3862898297eaf1fdc","unresolved":false,"context_lines":[{"line_number":92,"context_line":"  package:"},{"line_number":93,"context_line":"    name: \"{{ item }}\""},{"line_number":94,"context_line":"    state: \"{{ (keystone_idp !\u003d {}) | ternary(keystone_package_state, \u0027absent\u0027) }}\""},{"line_number":95,"context_line":"    autoremove: yes"},{"line_number":96,"context_line":"  register: install_packages"},{"line_number":97,"context_line":"  until: install_packages|success"},{"line_number":98,"context_line":"  retries: 5"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ffe62b97_7792f24d","line":95,"range":{"start_line":95,"start_character":4,"end_line":95,"end_character":19},"updated":"2017-03-30 11:21:45.000000000","message":"This is unsupported for the underlying yum module for CentOS, so change this to:\n\nautoremove: {{ (ansible_pkg_mgr \u003d\u003d \u0027apt\u0027) | ternary(yes, omit) }}","commit_id":"32843d61db40ddbea59795e917377e8c927369ee"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2856dc412b83b495220499d3862898297eaf1fdc","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  package:"},{"line_number":104,"context_line":"    name: \"{{ item }}\""},{"line_number":105,"context_line":"    state: \"{{ (keystone_sp !\u003d {}) | ternary(keystone_package_state, \u0027absent\u0027) }}\""},{"line_number":106,"context_line":"    autoremove: yes"},{"line_number":107,"context_line":"  register: install_packages"},{"line_number":108,"context_line":"  until: install_packages|success"},{"line_number":109,"context_line":"  retries: 5"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ffe62b97_379c6a5c","line":106,"range":{"start_line":106,"start_character":4,"end_line":106,"end_character":19},"updated":"2017-03-30 11:21:45.000000000","message":"This is unsupported for the underlying yum module for CentOS, so change this to:\n\nautoremove: {{ (ansible_pkg_mgr \u003d\u003d \u0027apt\u0027) | ternary(yes, omit) }}","commit_id":"32843d61db40ddbea59795e917377e8c927369ee"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2856dc412b83b495220499d3862898297eaf1fdc","unresolved":false,"context_lines":[{"line_number":114,"context_line":"  package:"},{"line_number":115,"context_line":"    name: \"{{ item }}\""},{"line_number":116,"context_line":"    state: \"{{ (keystone_developer_mode | bool) | ternary(keystone_package_state, \u0027absent\u0027) }}\""},{"line_number":117,"context_line":"    autoremove: yes"},{"line_number":118,"context_line":"  register: install_packages"},{"line_number":119,"context_line":"  until: install_packages|success"},{"line_number":120,"context_line":"  retries: 5"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ffe62b97_17a16696","line":117,"range":{"start_line":117,"start_character":4,"end_line":117,"end_character":19},"updated":"2017-03-30 11:21:45.000000000","message":"This is unsupported for the underlying yum module for CentOS, so change this to:\n\nautoremove: {{ (ansible_pkg_mgr \u003d\u003d \u0027apt\u0027) | ternary(yes, omit) }}","commit_id":"32843d61db40ddbea59795e917377e8c927369ee"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"1ff1f166539933527b89a33ce5b37fa0809ff886","unresolved":false,"context_lines":[{"line_number":172,"context_line":"  notify:"},{"line_number":173,"context_line":"    - Restart uWSGI on first node"},{"line_number":174,"context_line":"    - Restart uWSGI on other nodes"},{"line_number":175,"context_line":"    - Restart web server on first node"},{"line_number":176,"context_line":"    - Restart web server on other nodes"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"- name: Install pip packages"},{"line_number":179,"context_line":"  pip:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ffe62b97_3c87b112","line":176,"range":{"start_line":175,"start_character":0,"end_line":176,"end_character":39},"updated":"2017-03-30 11:11:01.000000000","message":"This handler should actually be fired if the packages change in the above tasks, not here.","commit_id":"32843d61db40ddbea59795e917377e8c927369ee"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"1ff1f166539933527b89a33ce5b37fa0809ff886","unresolved":false,"context_lines":[{"line_number":193,"context_line":"  notify:"},{"line_number":194,"context_line":"    - Restart uWSGI on first node"},{"line_number":195,"context_line":"    - Restart uWSGI on other nodes"},{"line_number":196,"context_line":"    - Restart web server on first node"},{"line_number":197,"context_line":"    - Restart web server on other nodes"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"- name: CentOS remove python from path first"},{"line_number":200,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ffe62b97_1c7ced1e","line":197,"range":{"start_line":196,"start_character":0,"end_line":197,"end_character":39},"updated":"2017-03-30 11:11:01.000000000","message":"This handler should actually be fired if the packages change in the above tasks, not here.","commit_id":"32843d61db40ddbea59795e917377e8c927369ee"}],"tasks/keystone_uwsgi.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"1ff1f166539933527b89a33ce5b37fa0809ff886","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    - Restart uWSGI on first node"},{"line_number":53,"context_line":"    - Restart uWSGI on other nodes"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"- name: Ensure uwsgi service started"},{"line_number":56,"context_line":"  service:"},{"line_number":57,"context_line":"    name: \"{{ item }}\""},{"line_number":58,"context_line":"    state: started"},{"line_number":59,"context_line":"  register: keystone_start"},{"line_number":60,"context_line":"  until: keystone_start | success"},{"line_number":61,"context_line":"  retries: 5"},{"line_number":62,"context_line":"  delay: 2"},{"line_number":63,"context_line":"  with_items: \"{{ keystone_wsgi_program_names }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ffe62b97_dc7e85ae","line":63,"range":{"start_line":55,"start_character":0,"end_line":63,"end_character":49},"updated":"2017-03-30 11:11:01.000000000","message":"The handlers flush immediately after this, so I\u0027m quite sure this can be removed.","commit_id":"32843d61db40ddbea59795e917377e8c927369ee"}],"vars/ubuntu-16.04.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"1ff1f166539933527b89a33ce5b37fa0809ff886","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  - apache2-utils"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"keystone_mod_wsgi_distro_packages:"},{"line_number":37,"context_line":"  - libapache2-mod-wsgi"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"keystone_mod_proxy_uwsgi_distro_packages:"},{"line_number":40,"context_line":"  - libapache2-mod-proxy-uwsgi"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ffe62b97_7c09b993","side":"PARENT","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":23},"updated":"2017-03-30 11:11:01.000000000","message":"ideally this package should be cleaned up, even if apache is the web server","commit_id":"329a7819e4e056b7ff052d5530ac76d127488701"}]}
