)]}'
{"id":"openstack%2Fopenstack-ansible-os_keystone~667201","triplet_id":"openstack%2Fopenstack-ansible-os_keystone~stable%2Fstein~Ide611fd3d88e352367220f05dbcf4186ac20319f","project":"openstack/openstack-ansible-os_keystone","branch":"stable/stein","topic":"bug/1833414-stable/stein","hashtags":[],"change_id":"Ide611fd3d88e352367220f05dbcf4186ac20319f","subject":"Fix loss of fernet and credential keys during Rocky to Stein upgrade","status":"MERGED","created":"2019-06-24 19:26:59.000000000","updated":"2019-06-25 19:19:32.000000000","submitted":"2019-06-25 19:19:32.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"667201-1561490372913-f9ed76da","meta_rev_id":"0e7a8cc9094f6126cb1ac1553f72c99012012157","_number":667201,"virtual_id_number":667201,"owner":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":2,"date":"2019-06-25 19:19:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"all":[{"value":2,"date":"2019-06-24 19:27:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":2,"date":"2019-06-25 07:51:35.000000000","_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-06-24 22:37:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"all":[{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":1,"date":"2019-06-25 07:51:35.000000000","_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-24 19:27:47.000000000","updated_by":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"reviewer":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"state":"REVIEWER"},{"updated":"2019-06-24 22:37:41.000000000","updated_by":{"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"},"reviewer":{"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"},"state":"REVIEWER"},{"updated":"2019-06-25 07:51:35.000000000","updated_by":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"reviewer":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"state":"REVIEWER"},{"updated":"2019-06-25 19:19:32.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"20585b2857541f708dac78daf21236f55e882e8d","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2019-06-24 19:26:59.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"b17f9fea0b93781783c9266a363f66be66211523","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2019-06-24 19:27:47.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"6e75034dc0c6a4f9c00789b9ae7d378780603f0a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-24 20:53:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-ansible-linters http://logs.openstack.org/01/667201/1/check/openstack-ansible-linters/c7d5bf6/ : SUCCESS in 6m 43s\n- openstack-ansible-deploy-aio_metal-debian-stable http://logs.openstack.org/01/667201/1/check/openstack-ansible-deploy-aio_metal-debian-stable/5a9d237/ : SUCCESS in 1h 01m 13s\n- openstack-ansible-deploy-aio_metal-centos-7 http://logs.openstack.org/01/667201/1/check/openstack-ansible-deploy-aio_metal-centos-7/f66fb0d/ : SUCCESS in 1h 19m 12s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic http://logs.openstack.org/01/667201/1/check/openstack-ansible-deploy-aio_metal-ubuntu-bionic/3a7d945/ : SUCCESS in 57m 23s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 http://logs.openstack.org/01/667201/1/check/openstack-ansible-deploy-aio_distro_metal-centos-7/4fb03ec/ : FAILURE in 39m 47s (non-voting)\n- openstack-tox-docs http://logs.openstack.org/01/667201/1/check/openstack-tox-docs/6b3c46c/html/ : SUCCESS in 3m 17s\n- openstack-ansible-uw_apache-centos-7 http://logs.openstack.org/01/667201/1/check/openstack-ansible-uw_apache-centos-7/c631c3a/ : SUCCESS in 40m 35s\n- openstack-ansible-uw_apache-ubuntu-bionic http://logs.openstack.org/01/667201/1/check/openstack-ansible-uw_apache-ubuntu-bionic/7c315b3/ : SUCCESS in 43m 57s","accounts_in_message":[],"_revision_number":1},{"id":"4228d274a6d0520717711858152452629b5cc5c6","author":{"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"},"date":"2019-06-24 22:37:41.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"c5f37147bb5f2c54606c761fe6c363efd4f001e7","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2019-06-25 07:51:35.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"ef9dceada75973aef9ca8446c1ead67862c95811","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-25 07:51:46.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"684cb2cf68efe5d38fe8fd056a3e6d40a9022ef4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-25 11:09:10.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-ansible-linters http://logs.openstack.org/01/667201/1/gate/openstack-ansible-linters/2db2800/ : SUCCESS in 4m 18s\n- openstack-ansible-deploy-aio_metal-debian-stable finger://ze02.openstack.org/089d83d22bcd412bac5459cba788f04c : RETRY_LIMIT in 54m 42s\n- openstack-ansible-deploy-aio_metal-centos-7 finger://ze05.openstack.org/c433453fcc9e467198a400c6fb8acb31 : RETRY_LIMIT in 52m 27s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic http://logs.openstack.org/01/667201/1/gate/openstack-ansible-deploy-aio_metal-ubuntu-bionic/f27c7eb/ : SUCCESS in 55m 26s\n- openstack-tox-docs http://logs.openstack.org/01/667201/1/gate/openstack-tox-docs/4c28419/html/ : SUCCESS in 2m 52s\n- openstack-ansible-uw_apache-centos-7 http://logs.openstack.org/01/667201/1/gate/openstack-ansible-uw_apache-centos-7/a031749/ : SUCCESS in 43m 44s\n- openstack-ansible-uw_apache-ubuntu-bionic http://logs.openstack.org/01/667201/1/gate/openstack-ansible-uw_apache-ubuntu-bionic/fd87f3e/ : FAILURE in 26m 59s","accounts_in_message":[],"_revision_number":1},{"id":"6242d7f6a4442c91b1048a6ab08c09db769ddffd","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2019-06-25 13:12:34.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"26277f691746293523bea4569dac4b7f1b063ca0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-25 17:55:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-ansible-linters http://logs.openstack.org/01/667201/1/check/openstack-ansible-linters/c0a06c0/ : SUCCESS in 5m 26s\n- openstack-ansible-deploy-aio_metal-debian-stable http://logs.openstack.org/01/667201/1/check/openstack-ansible-deploy-aio_metal-debian-stable/ee108be/ : SUCCESS in 1h 02m 30s\n- openstack-ansible-deploy-aio_metal-centos-7 http://logs.openstack.org/01/667201/1/check/openstack-ansible-deploy-aio_metal-centos-7/08eef9a/ : SUCCESS in 1h 12m 09s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic http://logs.openstack.org/01/667201/1/check/openstack-ansible-deploy-aio_metal-ubuntu-bionic/50492fc/ : SUCCESS in 53m 28s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 http://logs.openstack.org/01/667201/1/check/openstack-ansible-deploy-aio_distro_metal-centos-7/314426b/ : FAILURE in 40m 10s (non-voting)\n- openstack-tox-docs http://logs.openstack.org/01/667201/1/check/openstack-tox-docs/c6438b8/html/ : SUCCESS in 2m 21s\n- openstack-ansible-uw_apache-centos-7 http://logs.openstack.org/01/667201/1/check/openstack-ansible-uw_apache-centos-7/ed523f8/ : SUCCESS in 43m 09s\n- openstack-ansible-uw_apache-ubuntu-bionic http://logs.openstack.org/01/667201/1/check/openstack-ansible-uw_apache-ubuntu-bionic/2fa598e/ : SUCCESS in 36m 32s","accounts_in_message":[],"_revision_number":1},{"id":"e65d30b47f3dbb00a67c4b27f77976c18af7e357","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-25 17:55:39.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"fbac840be1ee17365987cc2877fe1ce2bc4745e5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-25 19:19:32.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"7707956fbdffc3fee7f01af629bc812d055c5cf5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-25 19:19:32.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-ansible-linters http://logs.openstack.org/01/667201/1/gate/openstack-ansible-linters/7e63715/ : SUCCESS in 7m 35s\n- openstack-ansible-deploy-aio_metal-debian-stable http://logs.openstack.org/01/667201/1/gate/openstack-ansible-deploy-aio_metal-debian-stable/5fea5ac/ : SUCCESS in 59m 55s\n- openstack-ansible-deploy-aio_metal-centos-7 http://logs.openstack.org/01/667201/1/gate/openstack-ansible-deploy-aio_metal-centos-7/ed24326/ : SUCCESS in 1h 18m 08s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic http://logs.openstack.org/01/667201/1/gate/openstack-ansible-deploy-aio_metal-ubuntu-bionic/03f474b/ : SUCCESS in 57m 23s\n- openstack-tox-docs http://logs.openstack.org/01/667201/1/gate/openstack-tox-docs/d939bf6/html/ : SUCCESS in 3m 17s\n- openstack-ansible-uw_apache-centos-7 http://logs.openstack.org/01/667201/1/gate/openstack-ansible-uw_apache-centos-7/74471d4/ : SUCCESS in 44m 17s\n- openstack-ansible-uw_apache-ubuntu-bionic http://logs.openstack.org/01/667201/1/gate/openstack-ansible-uw_apache-ubuntu-bionic/19918f6/ : SUCCESS in 37m 08s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8fc9bbb88bf677ddbb5f2780e9ed2b7dcd668458","revisions":{"8fc9bbb88bf677ddbb5f2780e9ed2b7dcd668458":{"kind":"REWORK","_number":1,"created":"2019-06-24 19:26:59.000000000","uploader":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"ref":"refs/changes/01/667201/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-os_keystone","ref":"refs/changes/01/667201/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_keystone refs/changes/01/667201/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_keystone refs/changes/01/667201/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_keystone refs/changes/01/667201/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-os_keystone refs/changes/01/667201/1"}}},"commit":{"parents":[{"commit":"b7e1dd720085eca55fd75ec05ae453dd0af10359","subject":"Updated from OpenStack Ansible Tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_keystone/commit/b7e1dd720085eca55fd75ec05ae453dd0af10359"}]}],"author":{"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","date":"2019-06-19 19:17:02.000000000","tz":60},"committer":{"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","date":"2019-06-24 19:26:59.000000000","tz":0},"subject":"Fix loss of fernet and credential keys during Rocky to Stein upgrade","message":"Fix loss of fernet and credential keys during Rocky to Stein upgrade\n\nThis applies only to source based installations.\n\nThe introduction of smart-sources in [1] created a code path\nwhich deletes the /etc/keystone directory before symlinking it\ninto the keystone venv and creating the necessary config files.\n\nUnfortunatley this has the side effect of also deleting any fernet\nand credential keys which pre-existed in the case of an upgrade from\nRocky. The original keys were deleted simulataneously across the whole\nkeystone_all group in a way which is makes them unrecoverable in\nthe absence of a backup taken by the operator.\n\nThis change simplifies the smart-sources code to always keep the\nkeystone config files and fernet keys in the host /etc/keystone.\nThis ensures that the lifecycle of the fernet keys is not coupled\nto the lifecycle of the keystone venvs.\n\nIn addition, a task is added to rescue any keys which have been\ncreated in the keystone venv by installations from the Stein\nrelease-candidate.\n\n[1] https://review.opendev.org/#/c/588960/\n\nCloses-Bug: 1833414\nChange-Id: Ide611fd3d88e352367220f05dbcf4186ac20319f\n(cherry picked from commit 8e1f7f4ad8918af9e467387144c7eede7f19f92a)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_keystone/commit/8fc9bbb88bf677ddbb5f2780e9ed2b7dcd668458"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_keystone/commit/8fc9bbb88bf677ddbb5f2780e9ed2b7dcd668458"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}