)]}'
{"id":"openstack%2Fopenstack-ansible-os_keystone~736257","triplet_id":"openstack%2Fopenstack-ansible-os_keystone~master~Id2248e93f2636407396d4ac8fe29c8943e4a3a57","project":"openstack/openstack-ansible-os_keystone","branch":"master","topic":"add-params-to-httpd.conf-template","hashtags":[],"change_id":"Id2248e93f2636407396d4ac8fe29c8943e4a3a57","subject":"Add Paramaters to httpd.conf template","status":"MERGED","created":"2020-06-17 15:10:04.000000000","updated":"2020-06-24 17:37:56.000000000","submitted":"2020-06-24 17:34:45.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"736257-1593020086180-48842415","meta_rev_id":"5e9131874c92be547f8cb8a069509e5a264f6bd3","_number":736257,"virtual_id_number":736257,"owner":{"_account_id":31750,"name":"Daniel Meloy","email":"danny.meloy@bbc.co.uk","username":"meloyd01"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-06-24 17:34:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-06-24 12:54:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},{"value":2,"date":"2020-06-17 17:52:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-06-24 12:54:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-17 17:52:30.000000000","updated_by":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"reviewer":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"state":"REVIEWER"},{"updated":"2020-06-24 12:54:17.000000000","updated_by":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"reviewer":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"state":"REVIEWER"},{"updated":"2020-06-24 17:34:45.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1b948a227176fd3bc3952cc9ce3aa227fee801da","author":{"_account_id":31750,"name":"Daniel Meloy","email":"danny.meloy@bbc.co.uk","username":"meloyd01"},"date":"2020-06-17 15:10:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6bc5221df94a118eb9bf26a36c90298909d7fc17","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2020-06-17 15:17:38.000000000","message":"Patch Set 1: Code-Review-1\n\nCould you also add the new vars to the example in defaults/main.yml, here https://github.com/openstack/openstack-ansible-os_keystone/blob/master/defaults/main.yml#L433-L460\n\nThe idea is that the defaults file should form the documentation/external interface for the role so all of the overridable variables should eithe be defined or described there.\n\nYou\u0027ve also fixed a typo, which really should a patch on it\u0027s own.","accounts_in_message":[],"_revision_number":1},{"id":"280f2f718858009815b06116d54035c1dbbed400","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-17 17:21:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-ansible-linters https://zuul.opendev.org/t/openstack/build/025684aae6224dd5b9291ba51b5008c8 : SUCCESS in 11m 52s\n- openstack-ansible-deploy-aio_metal-debian-buster https://zuul.opendev.org/t/openstack/build/343b9305f1ca4af2bf53019c09778400 : SUCCESS in 1h 06m 30s\n- openstack-ansible-deploy-aio_metal-centos-7 https://zuul.opendev.org/t/openstack/build/3f1536176e8b49c584fd2c406096c9ad : SUCCESS in 1h 45m 08s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/9515682f009a452eb4ae6c4cf1f9ad67 : SUCCESS in 1h 21m 42s\n- openstack-ansible-upgrade-aio_metal-centos-7 https://zuul.opendev.org/t/openstack/build/985f6eb05a274daa89d8a6554df8d8ce : FAILURE in 1h 38m 41s (non-voting)\n- openstack-ansible-upgrade-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/84d053d1ff5b468db68a8351e8f33faf : SUCCESS in 1h 57m 17s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 https://zuul.opendev.org/t/openstack/build/40628f61ac8c4b86b41df8efb049be50 : SUCCESS in 1h 16m 09s\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/fac2b2882bd443cf81031c8524738d33 : SUCCESS in 58m 46s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f6e139b3d7ae42408f91a2a6dde20c70 : SUCCESS in 8m 03s\n- openstack-ansible-uw_apache-centos-7 https://zuul.opendev.org/t/openstack/build/e8973be815ea4d728c939968ca2f19aa : SUCCESS in 40m 32s\n- openstack-ansible-uw_apache-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/58a70952cae445a8a1fb3a53870e2a7e : SUCCESS in 41m 56s","accounts_in_message":[],"_revision_number":1},{"id":"98b59820008435be587d8a31f8b5eec21b31d754","author":{"_account_id":31750,"name":"Daniel Meloy","email":"danny.meloy@bbc.co.uk","username":"meloyd01"},"date":"2020-06-17 17:31:45.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9dc4727375dd45aa09b8eb479f886328ef283be1","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2020-06-17 17:52:30.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"af8d42a594a4dd38f8934f1b2a6d2c9f6fe5f51b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-17 19:33:58.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-ansible-linters https://zuul.opendev.org/t/openstack/build/65bf4b0247cb4cbdaf5779a3427d3a12 : SUCCESS in 7m 45s\n- openstack-ansible-deploy-aio_metal-debian-buster https://zuul.opendev.org/t/openstack/build/905d563006044801a0e547e244e2537d : SUCCESS in 1h 33m 44s\n- openstack-ansible-deploy-aio_metal-centos-7 https://zuul.opendev.org/t/openstack/build/ef1dfbcfffc04e03b6362197cb38d725 : SUCCESS in 1h 05m 39s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/03d1e075c8d44b07b6e86c33d1d4bb33 : SUCCESS in 57m 33s\n- openstack-ansible-upgrade-aio_metal-centos-7 https://zuul.opendev.org/t/openstack/build/f0948227d7824853b8e30928ec0ed690 : FAILURE in 1h 38m 09s (non-voting)\n- openstack-ansible-upgrade-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/debc2e4cdd694cb4a1b1450e75f7d09f : SUCCESS in 1h 52m 31s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 https://zuul.opendev.org/t/openstack/build/e24454ffd3e844f28c41f5b1c42d2e11 : SUCCESS in 1h 11m 03s\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/394b5e39e6b9404b8321ac9b42caf917 : SUCCESS in 1h 02m 59s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b0d7e7722abd4617b56298ca5b9c2125 : SUCCESS in 6m 00s\n- openstack-ansible-uw_apache-centos-7 https://zuul.opendev.org/t/openstack/build/7cd5d4a18cec45fe9aa2e7232ac4ffed : SUCCESS in 42m 04s\n- openstack-ansible-uw_apache-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/d0c24333e8fa47278e08d903d426fd74 : SUCCESS in 40m 25s","accounts_in_message":[],"_revision_number":2},{"id":"c9a66c669ef3be980039c202be6e5acd453bfa1a","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2020-06-24 12:54:17.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"9565acdbea011dbee7c8a87b6798101372957593","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-24 12:54:29.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"718dacf1870630acb5dda9cd313e44b57d5d5c3e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-24 17:34:45.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-ansible-linters https://zuul.opendev.org/t/openstack/build/87ab62007696481597b433c495f5e39f : SUCCESS in 6m 44s\n- openstack-ansible-deploy-aio_metal-debian-buster https://zuul.opendev.org/t/openstack/build/d955422227174f30aa02cd596bfe0dc1 : SUCCESS in 1h 06m 28s\n- openstack-ansible-deploy-aio_metal-centos-7 https://zuul.opendev.org/t/openstack/build/c64f91fd98bf4ff9821558ead6bc8285 : SUCCESS in 59m 22s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/197dc0fa02d54e899f50fc36c1d58823 : SUCCESS in 1h 05m 56s\n- openstack-ansible-deploy-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/6ebca1bc49764daa842a170dfa1767eb : SUCCESS in 48m 51s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 https://zuul.opendev.org/t/openstack/build/7e09b59b4b49422d83396692a3954eb1 : SUCCESS in 1h 11m 08s\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/8f9aba7ea5ee4dd9be3ee07df44506a1 : SUCCESS in 1h 01m 57s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a6ad537f591b435fbe18804f3007e91b : SUCCESS in 6m 28s\n- openstack-ansible-uw_apache-centos-7 https://zuul.opendev.org/t/openstack/build/900c346698064913985717181d349698 : SUCCESS in 38m 38s\n- openstack-ansible-uw_apache-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/89fd58a649c54e1098d99e67cbce8413 : SUCCESS in 34m 04s","accounts_in_message":[],"_revision_number":2},{"id":"34534863dbf8a72e92b02d890aa03010362a8bc8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-24 17:34:46.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"eecf7f0c1c92ad9e0fa46ec4b951e2bb2f8f8295","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-24 17:37:56.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0dd43bab4a2b4f2f8017efc8657d2636 : SUCCESS in 2m 37s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"eda646382a53364078d87bf30877a5ea22f5a082","revisions":{"c5a660db67d0c50b298290b5ae12f3e6c15bc277":{"kind":"REWORK","_number":1,"created":"2020-06-17 15:10:04.000000000","uploader":{"_account_id":31750,"name":"Daniel Meloy","email":"danny.meloy@bbc.co.uk","username":"meloyd01"},"ref":"refs/changes/57/736257/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-os_keystone","ref":"refs/changes/57/736257/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_keystone refs/changes/57/736257/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_keystone refs/changes/57/736257/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_keystone refs/changes/57/736257/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-os_keystone refs/changes/57/736257/1"}}},"commit":{"parents":[{"commit":"7199dcd543f2e4001def7ce2836acf6b9edc14a9","subject":"Merge \"Add OIDCAuthRequestParams parameter to template\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_keystone/commit/7199dcd543f2e4001def7ce2836acf6b9edc14a9"}]}],"author":{"name":"Danny Meloy","email":"danny.meloy@bbc.co.uk","date":"2020-06-17 15:01:28.000000000","tz":60},"committer":{"name":"Danny Meloy","email":"danny.meloy@bbc.co.uk","date":"2020-06-17 15:01:28.000000000","tz":60},"subject":"Add Paramaters to httpd.conf template","message":"Add Paramaters to httpd.conf template\n\nAdded the following parameters to the httpd.conf template\nto be used with mod_auth_openidc Apache mod. Params include:\n- OIDCStateMaxNumberOfCookies - this takes parameters in the form\n\u003cnumber\u003e \u003cfalse|true\u003e where number is the maximum number of state\ncookies stored in parallel for outstanding auth requests, and the\nboolean indicates whether cookies that are still valid over this\namount are deleted\n- OIDCDefaultURL - Defines a default URL to be used in case of\n3rd-party or OP initiated SSO when no explicit target_link_uri has\nbeen provided. The user is also sent to this URL is in case an\ninvalid authorization response was received\n(ref: https://github.com/zmartzone/mod_auth_openidc/blob/master/auth_openidc.conf)\n\nThe reason these have been added is due to some stability issues\nthat have been seen regarding cached session cookies that subsequently\ncause a \"state mismatch\" error. Being able to limit the number of active cookies\nappears to resolve this issue.\n\nChange-Id: Id2248e93f2636407396d4ac8fe29c8943e4a3a57\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_keystone/commit/c5a660db67d0c50b298290b5ae12f3e6c15bc277"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_keystone/commit/c5a660db67d0c50b298290b5ae12f3e6c15bc277"}]},"branch":"refs/heads/master"},"eda646382a53364078d87bf30877a5ea22f5a082":{"kind":"REWORK","_number":2,"created":"2020-06-17 17:31:45.000000000","uploader":{"_account_id":31750,"name":"Daniel Meloy","email":"danny.meloy@bbc.co.uk","username":"meloyd01"},"ref":"refs/changes/57/736257/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-os_keystone","ref":"refs/changes/57/736257/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_keystone refs/changes/57/736257/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_keystone refs/changes/57/736257/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_keystone refs/changes/57/736257/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-os_keystone refs/changes/57/736257/2"}}},"commit":{"parents":[{"commit":"7199dcd543f2e4001def7ce2836acf6b9edc14a9","subject":"Merge \"Add OIDCAuthRequestParams parameter to template\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_keystone/commit/7199dcd543f2e4001def7ce2836acf6b9edc14a9"}]}],"author":{"name":"Danny Meloy","email":"danny.meloy@bbc.co.uk","date":"2020-06-17 15:01:28.000000000","tz":60},"committer":{"name":"Danny Meloy","email":"danny.meloy@bbc.co.uk","date":"2020-06-17 17:31:13.000000000","tz":60},"subject":"Add Paramaters to httpd.conf template","message":"Add Paramaters to httpd.conf template\n\nAdded the following parameters to the httpd.conf template\nto be used with mod_auth_openidc Apache mod. Params include:\n- OIDCStateMaxNumberOfCookies - this takes parameters in the form\n\u003cnumber\u003e \u003cfalse|true\u003e where number is the maximum number of state\ncookies stored in parallel for outstanding auth requests, and the\nboolean indicates whether cookies that are still valid over this\namount are deleted\n- OIDCDefaultURL - Defines a default URL to be used in case of\n3rd-party or OP initiated SSO when no explicit target_link_uri has\nbeen provided. The user is also sent to this URL is in case an\ninvalid authorization response was received\n(ref: https://github.com/zmartzone/mod_auth_openidc/blob/master/auth_openidc.conf)\n\nThe reason these have been added is due to some stability issues\nthat have been seen regarding cached session cookies that subsequently\ncause a \"state mismatch\" error. Being able to limit the number of active cookies\nappears to resolve this issue.\n\nChange-Id: Id2248e93f2636407396d4ac8fe29c8943e4a3a57\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_keystone/commit/eda646382a53364078d87bf30877a5ea22f5a082"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_keystone/commit/eda646382a53364078d87bf30877a5ea22f5a082"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}