)]}'
{"templates/keystone-credential-rotate.sh.j2":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"655b14347936742dbf4bdc916aaa437296181e3e","unresolved":true,"context_lines":[{"line_number":50,"context_line":"          -avz \\"},{"line_number":51,"context_line":"          --delete \\"},{"line_number":52,"context_line":"          {{ keystone_credential_key_repository }}/ \\"},{"line_number":53,"context_line":"          {{ keystone_system_user_name }}@{{ destination_host }}:{{ keystone_credential_key_repository }}/"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    {%- endif %}"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"25a7d980_816e1405","line":53,"range":{"start_line":53,"start_character":45,"end_line":53,"end_character":61},"updated":"2021-08-16 07:42:20.000000000","message":"won\u0027t default filter work here as well? Ie:\n\n  hostvars[host][\u0027ansible_host\u0027] | default(inventory_hostname)","commit_id":"16e5373d07025edb067e2c9c26d9fa611f0266ee"},{"author":{"_account_id":33872,"name":"Sven Anders","email":"sanders@scaleuptech.com","username":"tabacha"},"change_message_id":"6bce3e9ecf75a6752e75b39aa776c9a33d5a572e","unresolved":true,"context_lines":[{"line_number":50,"context_line":"          -avz \\"},{"line_number":51,"context_line":"          --delete \\"},{"line_number":52,"context_line":"          {{ keystone_credential_key_repository }}/ \\"},{"line_number":53,"context_line":"          {{ keystone_system_user_name }}@{{ destination_host }}:{{ keystone_credential_key_repository }}/"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    {%- endif %}"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"26e00d7b_be1a75b3","line":53,"range":{"start_line":53,"start_character":45,"end_line":53,"end_character":61},"in_reply_to":"25a7d980_816e1405","updated":"2021-08-19 12:52:57.000000000","message":"Yes, the line will is a bit long, perhabs we skip the if condition in line 43 and do a *set* with *default* there?","commit_id":"16e5373d07025edb067e2c9c26d9fa611f0266ee"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"50c1bf960c77e3270cfe1f93e4b9328ecbbb4f38","unresolved":true,"context_lines":[{"line_number":50,"context_line":"          -avz \\"},{"line_number":51,"context_line":"          --delete \\"},{"line_number":52,"context_line":"          {{ keystone_credential_key_repository }}/ \\"},{"line_number":53,"context_line":"          {{ keystone_system_user_name }}@{{ destination_host }}:{{ keystone_credential_key_repository }}/"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    {%- endif %}"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"b9c134fd_df5e7661","line":53,"range":{"start_line":53,"start_character":45,"end_line":53,"end_character":61},"in_reply_to":"26e00d7b_be1a75b3","updated":"2021-08-23 07:49:01.000000000","message":"does it need a \u0027set\u0027 at all?\n\n{{ keystone_system_user_name }}@{{ hostvars[host][\u0027ansible_host\u0027] | default(inventory_hostname) }}:{{ keystone_credential_key_repository }}\n\nThere seems to be additional logic in your code {% if inventory_hostname !\u003d host %} which is not really covered by the commit message - is more needed than just covering unset ansible_host?","commit_id":"16e5373d07025edb067e2c9c26d9fa611f0266ee"}]}
