)]}'
{"id":"openstack%2Fopenstack-ansible-os_keystone~804207","triplet_id":"openstack%2Fopenstack-ansible-os_keystone~master~I94dfa9e450eaf8923efe205f319c01a5cd06f65d","project":"openstack/openstack-ansible-os_keystone","branch":"master","topic":"keystone_all_group_configurable","attention_set":{"33872":{"account":{"_account_id":33872,"name":"Sven Anders","email":"sanders@scaleuptech.com","username":"tabacha"},"last_update":"2021-12-02 10:45:04.000000000","reason":"Dmitriy Rabotyagov replied on the change"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I94dfa9e450eaf8923efe205f319c01a5cd06f65d","subject":"Make Keystone_all group configurable","status":"NEW","created":"2021-08-11 06:44:19.000000000","updated":"2021-12-02 10:45:04.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":2,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"a7c44e417a90b29adb0329cfa775459915cb8f99","_number":804207,"virtual_id_number":804207,"owner":{"_account_id":33872,"name":"Sven Anders","email":"sanders@scaleuptech.com","username":"tabacha"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-08-11 14:41:06.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"date":"2021-12-02 10:45:04.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-11 07:56:28.000000000","updated_by":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"reviewer":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"state":"REVIEWER"},{"updated":"2021-08-11 08:57:04.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-12 04:19:42.000000000","updated_by":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"reviewer":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"state":"REVIEWER"}],"messages":[{"id":"c644fd7f71f117e56750c2c63ee3c331a8864551","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33872,"name":"Sven Anders","email":"sanders@scaleuptech.com","username":"tabacha"},"date":"2021-08-11 06:44:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cfcba68a20ad3ca416f74c6ab3ff3bceea5e709b","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2021-08-11 07:56:28.000000000","message":"Patch Set 1: Code-Review-1\n\nThis needs an explanation in the commit message why the keystone_all group may not be present - I would be thinking that it should always be present and there is a problem with your inventory?","accounts_in_message":[],"_revision_number":1},{"id":"0f702f8bde4314eb307cbafaddad17836881444c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-11 08:57:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-ansible-linters-ubuntu-focal https://zuul.opendev.org/t/openstack/build/ccbf1cce0b9d414ead45ed4f591898a8 : SUCCESS in 16m 39s\n- openstack-ansible-deploy-aio_metal-debian-buster https://zuul.opendev.org/t/openstack/build/11c4d0a5e71f48f88fa2c4fdb08a0594 : SUCCESS in 1h 15m 06s\n- openstack-ansible-deploy-aio_metal-debian-bullseye https://zuul.opendev.org/t/openstack/build/add5c736e36c4e0eb9f006ad59329eab : SUCCESS in 1h 13m 53s (non-voting)\n- openstack-ansible-deploy-aio_metal-centos-8 https://zuul.opendev.org/t/openstack/build/0e62338697094a639a4b39078778f3a7 : SUCCESS in 1h 23m 12s\n- openstack-ansible-deploy-aio_metal-centos-8-stream https://zuul.opendev.org/t/openstack/build/89bf6a8bfb1c4f2ea6f04e555f715cc8 : SUCCESS in 1h 25m 07s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/d2e08213c51d4397bd3846efb12e5da5 : SUCCESS in 1h 18m 25s\n- openstack-ansible-deploy-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/180a80627488437987ff07904a2864cb : SUCCESS in 1h 15m 10s\n- openstack-ansible-upgrade-aio_metal-centos-8 https://zuul.opendev.org/t/openstack/build/12502c07ac164dfebf766af534d7d79b : SUCCESS in 2h 07m 47s (non-voting)\n- openstack-ansible-upgrade-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/248dc888e635499c81ec4f52f2491d1c : SUCCESS in 1h 50m 40s\n- openstack-ansible-deploy-aio_distro_metal-centos-8-stream https://zuul.opendev.org/t/openstack/build/fcc54f3c97b6414e8ca8ef5aeb8af7cb : FAILURE in 47m 23s (non-voting)\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/6d456f08088f4d06896a6aabe9b745dd : SUCCESS in 1h 04m 35s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/58be708618ad47ebbd02037d59723fba : SUCCESS in 7m 32s\n- openstack-ansible-uw_apache-centos-8 https://zuul.opendev.org/t/openstack/build/6f9fb2057c6c44e6986acad6b9ab45b9 : SUCCESS in 42m 59s\n- openstack-ansible-uw_apache-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/c753d905cb074c9eb431dacb66a2e33f : SUCCESS in 39m 34s\n- openstack-ansible-uw_apache-ubuntu-focal https://zuul.opendev.org/t/openstack/build/73c7f953379f43ed84aa327f57323e47 : SUCCESS in 45m 37s","accounts_in_message":[],"_revision_number":1},{"id":"f0c98a8bde56edef141f1173f0cd5ae2ea920430","author":{"_account_id":33872,"name":"Sven Anders","email":"sanders@scaleuptech.com","username":"tabacha"},"date":"2021-08-11 09:34:16.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1: Code-Review-1\n\u003e \n\u003e This needs an explanation in the commit message why the keystone_all group may not be present - I would be thinking that it should always be present and there is a problem with your inventory?\n\nHi Jonathan,\nthank you for your review. I updated the commit message. Hope it is clear now.\n\nSven","accounts_in_message":[],"_revision_number":1},{"id":"3672a2eaf954cf3753848d5f9fbb4e9719aaed22","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2021-08-11 09:39:08.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e \u003e Patch Set 1: Code-Review-1\n\u003e \u003e \n\u003e \u003e This needs an explanation in the commit message why the keystone_all group may not be present - I would be thinking that it should always be present and there is a problem with your inventory?\n\u003e \n\u003e Hi Jonathan,\n\u003e thank you for your review. I updated the commit message. Hope it is clear now.\n\u003e \n\u003e Sven\n\nRemember to run git review again to push a new revision of the patch. It might be really helpful if you could join our IRC channel at #openstack-ansible on OFTC (guide here https://docs.openstack.org/contributors/common/irc.html)","accounts_in_message":[],"_revision_number":1},{"id":"ecf97fb6f170c066f8dfcfb9434aaad921bc2091","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33872,"name":"Sven Anders","email":"sanders@scaleuptech.com","username":"tabacha"},"date":"2021-08-11 12:42:36.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"a05850f51032790d684d7ec4e98598fbcb8ceeb9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-11 14:41:06.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-ansible-linters-ubuntu-focal https://zuul.opendev.org/t/openstack/build/72abffe40b024401b045d1a4c098dd29 : SUCCESS in 14m 26s\n- openstack-ansible-deploy-aio_metal-debian-buster https://zuul.opendev.org/t/openstack/build/c9339b7a9a9c458896cf481d9705f5b1 : SUCCESS in 1h 14m 18s\n- openstack-ansible-deploy-aio_metal-debian-bullseye https://zuul.opendev.org/t/openstack/build/feeab681c9374c1494d8d9ef3f3df703 : SUCCESS in 1h 02m 56s (non-voting)\n- openstack-ansible-deploy-aio_metal-centos-8 https://zuul.opendev.org/t/openstack/build/d5d596751d2544629e986200faf01ada : SUCCESS in 1h 27m 46s\n- openstack-ansible-deploy-aio_metal-centos-8-stream https://zuul.opendev.org/t/openstack/build/f82dc3d1fd4b4faaa043a2ef42a83bc8 : SUCCESS in 1h 23m 24s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/09f56601720f4584bf68c3b1df853977 : SUCCESS in 1h 23m 32s\n- openstack-ansible-deploy-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/16925c16c9a3496491fc3ea7697afe2b : SUCCESS in 1h 11m 05s\n- openstack-ansible-upgrade-aio_metal-centos-8 https://zuul.opendev.org/t/openstack/build/4adbfcae08e7425a87e5f75579484c02 : SUCCESS in 1h 54m 56s (non-voting)\n- openstack-ansible-upgrade-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/9a220c42b1c346baa1d68277a071d7f0 : SUCCESS in 1h 42m 10s\n- openstack-ansible-deploy-aio_distro_metal-centos-8-stream https://zuul.opendev.org/t/openstack/build/aa1127a10376464d91e8aeb49d92e2ce : FAILURE in 41m 35s (non-voting)\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/c282524545ba491faebf8b71d931af56 : SUCCESS in 59m 16s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/de60c0c2081b4d95a55713b9f7b196dc : SUCCESS in 5m 24s\n- openstack-ansible-uw_apache-centos-8 https://zuul.opendev.org/t/openstack/build/65b09a60381e46f88f3e8e08619e1865 : SUCCESS in 46m 11s\n- openstack-ansible-uw_apache-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/df51f10d9e98466a8fef02a0ff402e93 : SUCCESS in 43m 28s\n- openstack-ansible-uw_apache-ubuntu-focal https://zuul.opendev.org/t/openstack/build/91fe464b237646ee8518c0b675c7720e : SUCCESS in 40m 25s","accounts_in_message":[],"_revision_number":2},{"id":"38b1022d46cc83836aab59f339e8ae7807876c00","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2021-08-12 04:19:42.000000000","message":"Patch Set 2: Code-Review-1\n\nYou can override keystone_all group with providing different inventory to the ansible with -i flag. I think it is correct way to use ansible overall, rather than doing these workarounds.\n\nYou can also leverage ANSIBLE_INVENTORY env variable to define inventory you want to use.\n\nSo for me this patch doesn\u0027t make any sense, since if you want to use more then one cluster - just define more then one inventory file (or dynamic inventory script).","accounts_in_message":[],"_revision_number":2},{"id":"40b6ac009dac2ddb16ca1265a2f6eead74efec5e","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2021-08-12 04:25:04.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2: Code-Review-1\n\u003e \n\u003e You can override keystone_all group with providing different inventory to the ansible with -i flag. I think it is correct way to use ansible overall, rather than doing these workarounds.\n\u003e \n\u003e You can also leverage ANSIBLE_INVENTORY env variable to define inventory you want to use.\n\u003e \n\u003e So for me this patch doesn\u0027t make any sense, since if you want to use more then one cluster - just define more then one inventory file (or dynamic inventory script).\n\nOther that that, with OSA, we support multiple cluster deployments from single deployment host, since you can set OSA_CONFIG_DIR to different envs, so you\u0027re not locked up with /etc/openstack_deploy, but it can be /etc/openstack_deploy/{$ENV}/ for example. And before running OSA you would need to export proper OSA_CONFIG_DIR.","accounts_in_message":[],"_revision_number":2},{"id":"7065f2ec20d40b05610f6e0773c80e69bc0aba70","author":{"_account_id":33872,"name":"Sven Anders","email":"sanders@scaleuptech.com","username":"tabacha"},"date":"2021-08-12 06:02:03.000000000","message":"Patch Set 2:\n\nI do not understand you policy about this. \n\nEvery coding style will tell you that is better to use a variable / constant than repeat hard-coded values in your scripts.\n\nThis changeset will not break anything, in your enviroment. \n\nIf groups[\u0027keystone_all\u0027] is used in other ansible scripts it is posible to change it there as well.\n\nThe policy of Openstack is to submit small changsets, would it be better to make a big changeset and replace all hard coded groups in once?","accounts_in_message":[],"_revision_number":2},{"id":"0f1b58c7c73b6b16d39ea6f4d48e8807d9a7b22e","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2021-08-16 07:38:05.000000000","message":"Patch Set 2: Code-Review+1\n\n\u003e Patch Set 2:\n\u003e \n\u003e I do not understand you policy about this. \n\u003e \n\u003e Every coding style will tell you that is better to use a variable / constant than repeat hard-coded values in your scripts.\n\nWhile I totally agree with that, ansible runs slower with more variables in memory. Things goes the way worse with huge inventories when you define global variables for all hosts. \n\n\u003e This changeset will not break anything, in your enviroment. \n\nI guess I just don\u0027t see a good usecase for this. Since if you change keystone_all_group you will need to have a custom playbook as well that launch the role as well as run it independently for each group anyway.\nSo from my prespective having different inventories is easier and cleaner way.\n\n\u003e If groups[\u0027keystone_all\u0027] is used in other ansible scripts it is posible to change it there as well.\n\nYes we have logic based on the keystone_all group existance also outside of os_keystone role ie https://opendev.org/openstack/openstack-ansible-os_barbican/src/branch/master/defaults/main.yml#L34\n\n\u003e The policy of Openstack is to submit small changsets, would it be better to make a big changeset and replace all hard coded groups in once?\n\nIt would be better to iterate with small changes. But you may push series of them.\n\n\nSo my point was that all this topic would require a lot of work and might be not trivial with further maintaining it and fully integrating with OSA for the usecase that is not super clear for me.\n\n\nBut I may be opionated and eventually this patch as a standalone one is really fine.","accounts_in_message":[],"_revision_number":2},{"id":"a7c44e417a90b29adb0329cfa775459915cb8f99","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2021-12-02 10:45:04.000000000","message":"Patch Set 2: -Code-Review\n\n(2 comments)","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d296d76fc7de8955bc32faaaf9bd2b22eacbb926","revisions":{"63f4b6f1f89b7e65f78f28866096f630eb99bf55":{"kind":"REWORK","_number":1,"created":"2021-08-11 06:44:19.000000000","uploader":{"_account_id":33872,"name":"Sven Anders","email":"sanders@scaleuptech.com","username":"tabacha"},"ref":"refs/changes/07/804207/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-os_keystone","ref":"refs/changes/07/804207/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_keystone refs/changes/07/804207/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_keystone refs/changes/07/804207/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_keystone refs/changes/07/804207/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-os_keystone refs/changes/07/804207/1"}}},"commit":{"parents":[{"commit":"eeef3a48f413a702a1c0eb8c4b40db9a5f9d85bb","subject":"Merge \"Fix shibboleth compatibility for ubuntu 18.04\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_keystone/commit/eeef3a48f413a702a1c0eb8c4b40db9a5f9d85bb"}]}],"author":{"name":"Sven Anders","email":"sanders@scaleuptech.com","date":"2021-08-10 15:18:56.000000000","tz":120},"committer":{"name":"Sven Anders","email":"sanders@scaleuptech.com","date":"2021-08-11 06:44:09.000000000","tz":120},"subject":"Make Keystone_all group configurable","message":"Make Keystone_all group configurable\n\nChange-Id: I94dfa9e450eaf8923efe205f319c01a5cd06f65d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_keystone/commit/63f4b6f1f89b7e65f78f28866096f630eb99bf55"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_keystone/commit/63f4b6f1f89b7e65f78f28866096f630eb99bf55"}]},"branch":"refs/heads/master"},"d296d76fc7de8955bc32faaaf9bd2b22eacbb926":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-08-11 12:42:36.000000000","uploader":{"_account_id":33872,"name":"Sven Anders","email":"sanders@scaleuptech.com","username":"tabacha"},"ref":"refs/changes/07/804207/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-os_keystone","ref":"refs/changes/07/804207/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_keystone refs/changes/07/804207/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_keystone refs/changes/07/804207/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-os_keystone refs/changes/07/804207/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-os_keystone refs/changes/07/804207/2"}}},"commit":{"parents":[{"commit":"eeef3a48f413a702a1c0eb8c4b40db9a5f9d85bb","subject":"Merge \"Fix shibboleth compatibility for ubuntu 18.04\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_keystone/commit/eeef3a48f413a702a1c0eb8c4b40db9a5f9d85bb"}]}],"author":{"name":"Sven Anders","email":"sanders@scaleuptech.com","date":"2021-08-10 15:18:56.000000000","tz":120},"committer":{"name":"Sven Anders","email":"sanders@scaleuptech.com","date":"2021-08-11 09:04:46.000000000","tz":0},"subject":"Make Keystone_all group configurable","message":"Make Keystone_all group configurable\n\nWe want to be able use a big inventory with many hosts and we want to maintain more than one \nOpenStack Cluster, which different keystone machines. \n\nSo our Idea is to make a variable to allow to override the keystone_all group if needed.\n\nChange-Id: I94dfa9e450eaf8923efe205f319c01a5cd06f65d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_keystone/commit/d296d76fc7de8955bc32faaaf9bd2b22eacbb926"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-os_keystone/commit/d296d76fc7de8955bc32faaaf9bd2b22eacbb926"}]},"branch":"refs/heads/master","description":"Edit commit message"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}