)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6a5022353c6c02b18a290dd93821ca7d248fcf82","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Adding missing \u0027Restart magnum services\u0027 handler"},{"line_number":15,"context_line":"Removing libmysqlclient-dev from magnum_apt_packages due to conflict"},{"line_number":16,"context_line":"with Galera packages"},{"line_number":17,"context_line":"Correcting \u0027*_proto\u0027 to \u0027*_protocol\u0027"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I746ecb21ebfda70e207f239306e1ec38785917cb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_6737624d","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":36},"updated":"2016-06-08 15:09:05.000000000","message":"The other way \u0027around I think?","commit_id":"50dbbc35886cb05163cc099079d5a385c2b80ac6"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"334a6b2ebf62bba3e2e84444c481915bd613918d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Adding missing \u0027Restart magnum services\u0027 handler"},{"line_number":15,"context_line":"Removing libmysqlclient-dev from magnum_apt_packages due to conflict"},{"line_number":16,"context_line":"with Galera packages"},{"line_number":17,"context_line":"Correcting \u0027*_proto\u0027 to \u0027*_protocol\u0027"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I746ecb21ebfda70e207f239306e1ec38785917cb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7aa08908_0e7cb2b3","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":36},"updated":"2016-06-08 16:55:47.000000000","message":"nit: I think you mean \u0027*_protocol\u0027 to \u0027*_proto\u0027 which you had in the previous patch set. It\u0027s just a nit though, not worth another PS in my view.","commit_id":"67053d0b7f9596bac9ee93ba7d7c7b4eefc22802"}],"defaults/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"64fcf42b2d2cd05725ee0a216e29294d33c23432","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  - admin"},{"line_number":34,"context_line":"magnum_service_region: RegionOne"},{"line_number":35,"context_line":"magnum_bind_port: 9511"},{"line_number":36,"context_line":"magnum_service_publicuri_protocol: http"},{"line_number":37,"context_line":"magnum_service_publicurl: \"{{ magnum_service_publicuri_protocol }}://{{ external_lb_vip_address }}:{{ magnum_bind_port }}\""},{"line_number":38,"context_line":"magnum_service_internaluri_protocol: http"},{"line_number":39,"context_line":"magnum_service_internalurl: \"{{ magnum_service_internaluri_protocol }}://{{ internal_lb_vip_address }}:{{ magnum_bind_port }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7aa08908_b18b4f1e","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":33},"updated":"2016-06-08 14:22:11.000000000","message":"To keep with the convention set in the other roles, this should be \u0027proto\u0027 and not \u0027protocol\u0027.","commit_id":"d7dec7bd6d9a68a2186c97dd1756a8b73193a403"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"64fcf42b2d2cd05725ee0a216e29294d33c23432","unresolved":false,"context_lines":[{"line_number":35,"context_line":"magnum_bind_port: 9511"},{"line_number":36,"context_line":"magnum_service_publicuri_protocol: http"},{"line_number":37,"context_line":"magnum_service_publicurl: \"{{ magnum_service_publicuri_protocol }}://{{ external_lb_vip_address }}:{{ magnum_bind_port }}\""},{"line_number":38,"context_line":"magnum_service_internaluri_protocol: http"},{"line_number":39,"context_line":"magnum_service_internalurl: \"{{ magnum_service_internaluri_protocol }}://{{ internal_lb_vip_address }}:{{ magnum_bind_port }}\""},{"line_number":40,"context_line":"magnum_service_adminuri_protocol: http"},{"line_number":41,"context_line":"magnum_service_adminurl: \"{{ magnum_service_adminuri_protocol }}://{{ internal_lb_vip_address }}:{{ magnum_bind_port }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7aa08908_1194e340","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":35},"updated":"2016-06-08 14:22:11.000000000","message":"To keep with the convention set in the other roles, this should be \u0027proto\u0027 and not \u0027protocol\u0027.","commit_id":"d7dec7bd6d9a68a2186c97dd1756a8b73193a403"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"64fcf42b2d2cd05725ee0a216e29294d33c23432","unresolved":false,"context_lines":[{"line_number":37,"context_line":"magnum_service_publicurl: \"{{ magnum_service_publicuri_protocol }}://{{ external_lb_vip_address }}:{{ magnum_bind_port }}\""},{"line_number":38,"context_line":"magnum_service_internaluri_protocol: http"},{"line_number":39,"context_line":"magnum_service_internalurl: \"{{ magnum_service_internaluri_protocol }}://{{ internal_lb_vip_address }}:{{ magnum_bind_port }}\""},{"line_number":40,"context_line":"magnum_service_adminuri_protocol: http"},{"line_number":41,"context_line":"magnum_service_adminurl: \"{{ magnum_service_adminuri_protocol }}://{{ internal_lb_vip_address }}:{{ magnum_bind_port }}\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"magnum_config_overrides: {}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7aa08908_f1aaf783","line":40,"range":{"start_line":40,"start_character":24,"end_line":40,"end_character":32},"updated":"2016-06-08 14:22:11.000000000","message":"To keep with the convention set in the other roles, this should be \u0027proto\u0027 and not \u0027protocol\u0027.","commit_id":"d7dec7bd6d9a68a2186c97dd1756a8b73193a403"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"64fcf42b2d2cd05725ee0a216e29294d33c23432","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  - virtualenv-tools"},{"line_number":87,"context_line":"  - python-keystoneclient"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"magnum_pip_packages:"},{"line_number":90,"context_line":"  - Babel"},{"line_number":91,"context_line":"  - PrettyTable"},{"line_number":92,"context_line":"  - PyYAML"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7aa08908_31fd9fb4","line":89,"range":{"start_line":89,"start_character":0,"end_line":89,"end_character":20},"updated":"2016-06-08 14:22:11.000000000","message":"This list looks like it includes all the dependencies for Magnum which should not be needed as they should be defined in Magnum\u0027s requirements.txt - it\u0027d be great to remove this list and only include the necessary top-level requirements and any \u0027optional\u0027 requirements for better production implementation.","commit_id":"d7dec7bd6d9a68a2186c97dd1756a8b73193a403"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"3b250817f860303bd78627bb9ad5d6f495531580","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  - virtualenv-tools"},{"line_number":87,"context_line":"  - python-keystoneclient"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"magnum_pip_packages:"},{"line_number":90,"context_line":"  - Babel"},{"line_number":91,"context_line":"  - PrettyTable"},{"line_number":92,"context_line":"  - PyYAML"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7aa08908_31291f9f","line":89,"range":{"start_line":89,"start_character":0,"end_line":89,"end_character":20},"in_reply_to":"7aa08908_31fd9fb4","updated":"2016-06-08 14:22:52.000000000","message":"This can be done in a subsequent patch though.","commit_id":"d7dec7bd6d9a68a2186c97dd1756a8b73193a403"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"64fcf42b2d2cd05725ee0a216e29294d33c23432","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  - iso8601"},{"line_number":104,"context_line":"  - jsonpatch"},{"line_number":105,"context_line":"  - keystonemiddleware"},{"line_number":106,"context_line":"  - MySQL-python"},{"line_number":107,"context_line":"  - netaddr"},{"line_number":108,"context_line":"  - oslo.concurrency"},{"line_number":109,"context_line":"  - oslo.config"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7aa08908_11950386","line":106,"range":{"start_line":106,"start_character":4,"end_line":106,"end_character":16},"updated":"2016-06-08 14:22:11.000000000","message":"This should not actually be needed by the role itself as the service should be configured to make use of PyMySQL instead. See the neutron role as an example of the implementation:\n\nhttps://github.com/openstack/openstack-ansible-os_neutron/blob/master/defaults/main.yml#L426\nhttps://github.com/openstack/openstack-ansible-os_neutron/blob/master/templates/neutron.conf.j2#L151\n\nNote that the mysql_user tasks which should only be implemented in the test playbook will require MySQL-python, but that is installed by the galera_client role which is a meta dependency so it is not required in this list.","commit_id":"d7dec7bd6d9a68a2186c97dd1756a8b73193a403"},{"author":{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},"change_message_id":"6d1e0eedc6c27a70d2f8c94274663d561a926ca2","unresolved":false,"context_lines":[{"line_number":84,"context_line":"  - httplib2"},{"line_number":85,"context_line":"  - virtualenv"},{"line_number":86,"context_line":"  - virtualenv-tools"},{"line_number":87,"context_line":"  - python-keystoneclient"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"magnum_pip_packages:"},{"line_number":90,"context_line":"  - Babel"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7aa08908_f3579423","line":87,"updated":"2016-06-08 15:59:25.000000000","message":"Could you alphabetize this list?","commit_id":"cada2619fa3843490481b56a97d2ee2829339df0"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"fc2c62afbfa0cc74eeafd983000e60c8741f2450","unresolved":false,"context_lines":[{"line_number":84,"context_line":"  - httplib2"},{"line_number":85,"context_line":"  - virtualenv"},{"line_number":86,"context_line":"  - virtualenv-tools"},{"line_number":87,"context_line":"  - python-keystoneclient"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"magnum_pip_packages:"},{"line_number":90,"context_line":"  - Babel"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7aa08908_7ea40b07","line":87,"in_reply_to":"7aa08908_f3579423","updated":"2016-06-08 16:01:32.000000000","message":"You could, but note that this is the installation order so alphabetising this may not be appropriate.","commit_id":"cada2619fa3843490481b56a97d2ee2829339df0"},{"author":{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},"change_message_id":"6d1e0eedc6c27a70d2f8c94274663d561a926ca2","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  - iso8601"},{"line_number":104,"context_line":"  - jsonpatch"},{"line_number":105,"context_line":"  - keystonemiddleware"},{"line_number":106,"context_line":"  - MySQL-python"},{"line_number":107,"context_line":"  - netaddr"},{"line_number":108,"context_line":"  - oslo.concurrency"},{"line_number":109,"context_line":"  - oslo.config"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7aa08908_1e050710","line":106,"updated":"2016-06-08 15:59:25.000000000","message":"If you\u0027re going to keep this, it belongs on line 91.","commit_id":"cada2619fa3843490481b56a97d2ee2829339df0"}],"extras/group_vars_magnum.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"64fcf42b2d2cd05725ee0a216e29294d33c23432","unresolved":false,"context_lines":[{"line_number":8,"context_line":"magnum_service_project_name: service"},{"line_number":9,"context_line":"magnum_service_project_domain_id: default"},{"line_number":10,"context_line":"magnum_service_user_domain_id: default"},{"line_number":11,"context_line":"magnum_service_adminuri: \"{{ magnum_service_adminuri_protocol }}://{{ internal_lb_vip_address }}:{{ magnum_service_port }}\""},{"line_number":12,"context_line":"magnum_service_adminurl: \"{{ magnum_service_adminuri }}\""},{"line_number":13,"context_line":"magnum_service_region: \"{{ service_region }}\""},{"line_number":14,"context_line":"magnum_rabbitmq_userid: magnum"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7aa08908_51a82b77","line":11,"range":{"start_line":11,"start_character":58,"end_line":11,"end_character":61},"updated":"2016-06-08 14:22:11.000000000","message":"See comment in defaults file.","commit_id":"d7dec7bd6d9a68a2186c97dd1756a8b73193a403"}],"tasks/database-setup.yml":[{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"333f100a76c55261d96c562c63080c1153fc10a9","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    - magnum-setup"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: Perform a synchronization of the Magnum database"},{"line_number":47,"context_line":"  command: \"{{ magnum_venv_bin}}/magnum-db-manage upgrade\""},{"line_number":48,"context_line":"  sudo: yes"},{"line_number":49,"context_line":"  sudo_user: \"{{ magnum_system_user_name }}\""},{"line_number":50,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7aa08908_b55cc94b","line":47,"updated":"2016-06-08 18:28:16.000000000","message":"Minor spacing adjustment here after _bin, but no need for another patch unless something else is broken.","commit_id":"67053d0b7f9596bac9ee93ba7d7c7b4eefc22802"}]}