)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"9121e43d50cc026263c4a5dec291d100ef893a3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e70d5769_f5e2b7b4","updated":"2025-08-18 12:42:08.000000000","message":"recheck - likely intermittent","commit_id":"c1cbe97d9e4d5c4dca4b723b7440302c47d6a172"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"ea028d09df9fb669eb12527fe82e86c4b2ccb958","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d313be29_6445c5d5","updated":"2025-08-21 10:36:08.000000000","message":"recheck c10s should be fixed now","commit_id":"2be9b881c451abb151608ba8d989a5e1cfe532a4"}],"defaults/main.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"94a9448816e5636f0ea84698d9fbee8b8a32537f","unresolved":true,"context_lines":[{"line_number":41,"context_line":"  - \"--constraint {{ masakari_upper_constraints_url }}\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"## Libvirt Group"},{"line_number":44,"context_line":"libvirt_group: libvirt"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"## System info"},{"line_number":47,"context_line":"masakari_system_user_name: masakari"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"6cded9cb_5a4ca36d","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":22},"updated":"2025-08-13 12:16:27.000000000","message":"sorry, one last thing. would it make sense to do like:\n`masakari_monitor_libvirt_group: \"{{ libvirt_group | default(\u0027libvirt\u0027) }}\"`?\n\nAs this will get a proper variable name, while still respecting `libvirt_group` override if exists?","commit_id":"aad2d8ee0c07dec379a99e0b836352217dbd0892"}],"releasenotes/notes/Add_Masakari_User_to_Libvirt_Group-a0fc38ba3a53dd7f.yaml":[{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"c2bfd5a1491c977548f113a22f3e3f10cfd86a4a","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    prevent Masakari from monitoring and managing virtual machine instances"},{"line_number":7,"context_line":"    effectively. The fix ensures that the Masakari service can successfully"},{"line_number":8,"context_line":"    interact with the libvirt daemon for instance evacuation and recovery"},{"line_number":9,"context_line":"    operations during host failures. #2120450"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"732c4cdf_acc469f2","line":9,"updated":"2025-08-13 16:06:06.000000000","message":"```suggestion\n    operations during host failures. [:bug:`2120450`]\n```","commit_id":"7572ec82e8a808fadec5c61b4f1da20d9afb026e"}],"tasks/masakari_pre_install.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"dc7f30f44a9f17c8c79ed381f484c3b8613faf79","unresolved":true,"context_lines":[{"line_number":34,"context_line":"- name: Add masakari user to libvirt Group"},{"line_number":35,"context_line":"  ansible.builtin.user:"},{"line_number":36,"context_line":"    name: \"{{ masakari_system_user_name }}\""},{"line_number":37,"context_line":"    groups: \"{{ libvirt_group }}\""},{"line_number":38,"context_line":"    append: \"yes\""},{"line_number":39,"context_line":"  tags:"},{"line_number":40,"context_line":"    - masakari-config"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"310ae947_efa12ea1","line":37,"range":{"start_line":37,"start_character":16,"end_line":37,"end_character":29},"updated":"2025-08-12 14:17:31.000000000","message":"this variable is not defined in scope of the role","commit_id":"8f0c65fe09235e50e4ab22010813125434459485"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"dc7f30f44a9f17c8c79ed381f484c3b8613faf79","unresolved":true,"context_lines":[{"line_number":38,"context_line":"    append: \"yes\""},{"line_number":39,"context_line":"  tags:"},{"line_number":40,"context_line":"    - masakari-config"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: Create masakari dir"},{"line_number":43,"context_line":"  ansible.builtin.file:"},{"line_number":44,"context_line":"    path: \"{{ item.path | realpath }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0b52ba97_0213f5a4","line":41,"updated":"2025-08-12 14:17:31.000000000","message":"It\u0027s also missing condition on when to execute that, as the task is applicable only on nova-compute hosts (masakari-agents?)","commit_id":"8f0c65fe09235e50e4ab22010813125434459485"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"4112f1d5e97da51c57115239425c7299a7f1dc2d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    append: \"yes\""},{"line_number":39,"context_line":"  tags:"},{"line_number":40,"context_line":"    - masakari-config"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: Create masakari dir"},{"line_number":43,"context_line":"  ansible.builtin.file:"},{"line_number":44,"context_line":"    path: \"{{ item.path | realpath }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"39d9a98a_491dea43","line":41,"in_reply_to":"0b52ba97_0213f5a4","updated":"2025-08-13 08:34:20.000000000","message":"Done","commit_id":"8f0c65fe09235e50e4ab22010813125434459485"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"3bf67b23b5730313fc1d92578fb6ca87a8ac44de","unresolved":true,"context_lines":[{"line_number":34,"context_line":"- name: Add masakari user to libvirt Group"},{"line_number":35,"context_line":"  ansible.builtin.user:"},{"line_number":36,"context_line":"    name: \"{{ masakari_system_user_name }}\""},{"line_number":37,"context_line":"    groups: \"{{ libvirt_group }}\""},{"line_number":38,"context_line":"    append: \"yes\""},{"line_number":39,"context_line":"  when:"},{"line_number":40,"context_line":"    - \"masakari_services[\u0027masakari-hostmonitor\u0027][\u0027group\u0027] in group_names\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"44b0fd33_19c9f26b","line":37,"range":{"start_line":37,"start_character":16,"end_line":37,"end_character":29},"updated":"2025-08-18 12:42:47.000000000","message":"well, as the new variable is introduced, it should be used here: `masakari_monitor_libvirt_group`","commit_id":"c1cbe97d9e4d5c4dca4b723b7440302c47d6a172"}],"vars/debian.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"4112f1d5e97da51c57115239425c7299a7f1dc2d","unresolved":true,"context_lines":[{"line_number":16,"context_line":"## APT Cache options\r"},{"line_number":17,"context_line":"cache_timeout: 600\r"},{"line_number":18,"context_line":"\r"},{"line_number":19,"context_line":"libvirt_group: libvirt\r"},{"line_number":20,"context_line":"\r"},{"line_number":21,"context_line":"masakari_distro_packages:\r"},{"line_number":22,"context_line":"  - git\r"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"61e42870_90f82add","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":22},"updated":"2025-08-13 08:34:20.000000000","message":"can we please do that in defaults/main.yml instead?","commit_id":"70a7be8f1b7ae1c3448c1d8ade1829ec3b022018"}]}
