)]}'
{"tasks/monasca_agent_install.yml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"891043ad181f1c6416602e3d22f4483a8784837c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  file:"},{"line_number":64,"context_line":"    path: \"{{ monasca_agent_bin | dirname }}\""},{"line_number":65,"context_line":"    state: absent"},{"line_number":66,"context_line":"  when: monasca_agent_get_venv is changed"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"- name: Create monasca-agent venv dir"},{"line_number":69,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_7708ad27","line":66,"range":{"start_line":66,"start_character":8,"end_line":66,"end_character":41},"updated":"2018-08-06 14:41:57.000000000","message":"it would be preferable to propose a separate commit for these cosmetic changes, and keep changes for the addition of a new distro as clean as possible","commit_id":"af6a1240aeae8f0747507c562c1c5f3554d3e71d"}],"vars/suse-42.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"6544a63e1a2dc4c7cf7f1c04e6ccc85084d6f248","unresolved":false,"context_lines":[{"line_number":14,"context_line":"monasca_agent_distro_packages:"},{"line_number":15,"context_line":"  - git"},{"line_number":16,"context_line":"  - pkg-config"},{"line_number":17,"context_line":"  - libvirt-devel"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_545a1a2a","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":17},"updated":"2018-08-08 14:29:01.000000000","message":"why is this required?","commit_id":"cdb60258da6db7fb552c4654b685b1f7bc762bdf"},{"author":{"_account_id":27143,"name":"Kaio Oliveira","email":"kaio.kassiano.oliveira@gmail.com","username":"kaiokassiano"},"change_message_id":"9c9c2515ebf5cf6c1888f569ce378e351c73b3eb","unresolved":false,"context_lines":[{"line_number":14,"context_line":"monasca_agent_distro_packages:"},{"line_number":15,"context_line":"  - git"},{"line_number":16,"context_line":"  - pkg-config"},{"line_number":17,"context_line":"  - libvirt-devel"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_74f07668","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":17},"in_reply_to":"3f79a3b5_545a1a2a","updated":"2018-08-08 14:48:17.000000000","message":"Jean, by default this role configures the libvirt plugin from monasca-agent (https://github.com/openstack/monasca-agent/blob/master/monasca_agent/collector/checks_d/libvirt.py), what makes this package needed (https://github.com/openstack/openstack-ansible-os_monasca-agent/blob/master/defaults/main.yml#L271).","commit_id":"cdb60258da6db7fb552c4654b685b1f7bc762bdf"}],"zuul.d/project.yaml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"891043ad181f1c6416602e3d22f4483a8784837c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"            voting: false"},{"line_number":21,"context_line":"        - openstack-ansible-functional-opensuse-423"},{"line_number":22,"context_line":"        - openstack-ansible-functional-ubuntu-bionic:"},{"line_number":23,"context_line":"            voting: false"},{"line_number":24,"context_line":"        - openstack-ansible-functional-ubuntu-xenial"},{"line_number":25,"context_line":"    gate:"},{"line_number":26,"context_line":"      jobs:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_3c0d3c3e","line":23,"range":{"start_line":23,"start_character":12,"end_line":23,"end_character":25},"updated":"2018-08-06 14:41:57.000000000","message":"The bionic failure you see should be addressed by https://review.openstack.org/#/c/588962/","commit_id":"af6a1240aeae8f0747507c562c1c5f3554d3e71d"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"7e3412694cd29a88c01f772372256886200486ba","unresolved":false,"context_lines":[{"line_number":20,"context_line":"            voting: false"},{"line_number":21,"context_line":"        - openstack-ansible-functional-opensuse-423"},{"line_number":22,"context_line":"        - openstack-ansible-functional-ubuntu-bionic:"},{"line_number":23,"context_line":"            voting: false"},{"line_number":24,"context_line":"        - openstack-ansible-functional-ubuntu-xenial"},{"line_number":25,"context_line":"    gate:"},{"line_number":26,"context_line":"      jobs:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_e83110a4","line":23,"range":{"start_line":23,"start_character":12,"end_line":23,"end_character":25},"updated":"2018-08-08 13:07:27.000000000","message":"bionic is now passing","commit_id":"5dc9f5bf7d8e82351da3390fd3de23a05de73ff5"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"52fa39e8b544ef864442e979765e03f035e62fd3","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        # TODO(jrosser) Revert this once opensuse-150 passes"},{"line_number":24,"context_line":"        - openstack-ansible-functional-opensuse-150:"},{"line_number":25,"context_line":"            voting: false"},{"line_number":26,"context_line":"        # TODO(jrosser) Revert this once opensuse-423 passes"},{"line_number":27,"context_line":"        - openstack-ansible-functional-opensuse-423:"},{"line_number":28,"context_line":"            voting: false"},{"line_number":29,"context_line":"    gate:"},{"line_number":30,"context_line":"      jobs:"},{"line_number":31,"context_line":"        # TODO(jrosser) Revert this once centos-7 passes"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_0329bc36","line":28,"range":{"start_line":26,"start_character":0,"end_line":28,"end_character":25},"updated":"2018-08-09 06:03:55.000000000","message":"suse-42 is passing with this patch so maybe this block needs to be removed now","commit_id":"cdb60258da6db7fb552c4654b685b1f7bc762bdf"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"52fa39e8b544ef864442e979765e03f035e62fd3","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        # TODO(jrosser) Revert this once opensuse-150 passes"},{"line_number":35,"context_line":"        - openstack-ansible-functional-opensuse-150:"},{"line_number":36,"context_line":"            voting: false"},{"line_number":37,"context_line":"        # TODO(jrosser) Revert this once opensuse-423 passes"},{"line_number":38,"context_line":"        - openstack-ansible-functional-opensuse-423:"},{"line_number":39,"context_line":"             voting: false"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_432fb43e","line":39,"range":{"start_line":37,"start_character":0,"end_line":39,"end_character":26},"updated":"2018-08-09 06:03:55.000000000","message":"same","commit_id":"cdb60258da6db7fb552c4654b685b1f7bc762bdf"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"dbfd791765713825144046446774fc23c4021053","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        # TODO(jrosser) Revert this once opensuse-150 passes"},{"line_number":24,"context_line":"        - openstack-ansible-functional-opensuse-150:"},{"line_number":25,"context_line":"            voting: false"},{"line_number":26,"context_line":"        - openstack-ansible-functional-opensuse-423"},{"line_number":27,"context_line":"    gate:"},{"line_number":28,"context_line":"      jobs:"},{"line_number":29,"context_line":"        # TODO(jrosser) Revert this once centos-7 passes"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_ec99046e","line":26,"range":{"start_line":26,"start_character":9,"end_line":26,"end_character":51},"updated":"2018-08-09 15:13:47.000000000","message":"this also needs to be removed because it\u0027s part of the \u0027openstack-ansible-role-jobs\u0027 template","commit_id":"d4400386dd34ed51ea885aad85e189ef08336e83"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"dbfd791765713825144046446774fc23c4021053","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        # TODO(jrosser) Revert this once opensuse-150 passes"},{"line_number":33,"context_line":"        - openstack-ansible-functional-opensuse-150:"},{"line_number":34,"context_line":"            voting: false"},{"line_number":35,"context_line":"        - openstack-ansible-functional-opensuse-423"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_aca30c9e","line":35,"range":{"start_line":35,"start_character":10,"end_line":35,"end_character":51},"updated":"2018-08-09 15:13:47.000000000","message":"same","commit_id":"d4400386dd34ed51ea885aad85e189ef08336e83"},{"author":{"_account_id":27143,"name":"Kaio Oliveira","email":"kaio.kassiano.oliveira@gmail.com","username":"kaiokassiano"},"change_message_id":"d82da987525f8d77403009f7e35d7f0e154ee28e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        # TODO(jrosser) Revert this once opensuse-150 passes"},{"line_number":33,"context_line":"        - openstack-ansible-functional-opensuse-150:"},{"line_number":34,"context_line":"            voting: false"},{"line_number":35,"context_line":"        - openstack-ansible-functional-opensuse-423"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_cc68c822","line":35,"range":{"start_line":35,"start_character":10,"end_line":35,"end_character":51},"in_reply_to":"3f79a3b5_aca30c9e","updated":"2018-08-09 15:18:11.000000000","message":"Markos, can I leave only the template, since opensuse-150 and centos-7 are both part of the template?","commit_id":"d4400386dd34ed51ea885aad85e189ef08336e83"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"be09e82725c5b89eb35d6224ba57c100f82bb0eb","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        # TODO(jrosser) Revert this once opensuse-150 passes"},{"line_number":33,"context_line":"        - openstack-ansible-functional-opensuse-150:"},{"line_number":34,"context_line":"            voting: false"},{"line_number":35,"context_line":"        - openstack-ansible-functional-opensuse-423"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_c65c2080","line":35,"range":{"start_line":35,"start_character":10,"end_line":35,"end_character":51},"in_reply_to":"3f79a3b5_cc68c822","updated":"2018-08-09 17:53:27.000000000","message":"I am not sure I understand to be honest. The template has the openstack-ansible-functional-opensuse-423 and it is also set to voting, so you dont need to add it here again. You can leave centos7 and opensuse-150 as is.","commit_id":"d4400386dd34ed51ea885aad85e189ef08336e83"}]}