)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"5841bdb049f09654b1ab4a6b2cb37f056010a65e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-11-01 13:52:23 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactoring Monasca role to align more with OSA."},{"line_number":8,"context_line":" - This patch is to provide monasca backend services and monasca api,log-api"},{"line_number":9,"context_line":" - Adding the use of dictionary for service group mappings."},{"line_number":10,"context_line":" - Switching to use tested external roles for backend services."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":121,"id":"ba5da102_8e790fcb","line":8,"updated":"2016-11-01 12:47:48.000000000","message":"Add a line break between the subject and the content of the commit message.","commit_id":"29e04759db5ef614d19a189c46d5b340a7cf0e48"}],"defaults/main.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"033b5e4611693399f8ba5b5d43ce8522e1548afd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5a8bc5a2_2d900bec","updated":"2016-09-23 21:02:16.000000000","message":"I\u0027d like to see the various enable_XXX variables to be renamed to namespaced vars for monasca. Something like `monasca_enable_XXX`","commit_id":"f10147bd06dd271e959b57bb8876946a720908f9"}],"extras/conf.d/monasca.yml.example":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"4d0b9fe9ea885a5a6e802296ff70e7b67461bd75","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# The infra nodes that will be running the monasca services"},{"line_number":2,"context_line":"monasca-infra_hosts:"},{"line_number":3,"context_line":"  infra1:"},{"line_number":4,"context_line":"    ip: 172.20.236.111"},{"line_number":5,"context_line":"  infra2:"}],"source_content_type":"application/octet-stream","patch_set":102,"id":"ba5da102_fe48d25d","line":2,"updated":"2016-10-27 14:47:00.000000000","message":"Nit - Can you add a comment here explaining which containers/monasca daemons will reside on these hosts. Also, some commentary about the minimum and recommended number of hosts would be welcome.","commit_id":"e69406a58bd0553394cb03739361ff1d9baf38e9"}],"extras/haproxy_monasca.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"033b5e4611693399f8ba5b5d43ce8522e1548afd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5a8bc5a2_8d0d9f92","updated":"2016-09-23 21:02:16.000000000","message":"I\u0027m not sure what the backend looks like or if we need to but it may be good to add HAProxy backends for the various services like influxdb, grafana, kafaka, etc.","commit_id":"f10147bd06dd271e959b57bb8876946a720908f9"}],"extras/os-monasca-install.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"033b5e4611693399f8ba5b5d43ce8522e1548afd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5a8bc5a2_8d84bfd4","updated":"2016-09-23 21:02:16.000000000","message":"The botton of the playbook should have a like so:\n\ntags:\n  - monasca","commit_id":"f10147bd06dd271e959b57bb8876946a720908f9"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"4d0b9fe9ea885a5a6e802296ff70e7b67461bd75","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        log_dirs:"},{"line_number":28,"context_line":"          - src: \"/openstack/log/{{ inventory_hostname }}-monasca\""},{"line_number":29,"context_line":"            dest: \"/var/log/monasca\""},{"line_number":30,"context_line":"    - include: common-tasks/rabbitmq-servers-sort.yml"},{"line_number":31,"context_line":"      vars:"},{"line_number":32,"context_line":"        sort_group_name: \"monasca_all\""},{"line_number":33,"context_line":"    - include: common-tasks/rabbitmq-vhost-user.yml"}],"source_content_type":"text/x-yaml","patch_set":102,"id":"ba5da102_9ef996cb","line":30,"updated":"2016-10-27 14:47:00.000000000","message":"This can come out now, no longer necessary. See earlier patchs from odyssey4me","commit_id":"e69406a58bd0553394cb03739361ff1d9baf38e9"}],"handlers/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"61e5bd6bf9ba2f1d7d2fa2c46f756d012f16b7e6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# (c) 2016 Donovan Francesco \u003cdonovan.francesco@is.co.za\u003e"},{"line_number":17,"context_line":"# (c) 2016 Paul Stevens \u003cpaul.stevens@is.co.za\u003e"},{"line_number":18,"context_line":"- name: Reload systemd daemon"},{"line_number":19,"context_line":"  command: \"systemctl daemon-reload\""},{"line_number":20,"context_line":"  notify:"},{"line_number":21,"context_line":"    - Restart monasca services"}],"source_content_type":"text/x-yaml","patch_set":72,"id":"fa6399be_8dc93c7b","line":18,"updated":"2016-10-12 14:28:00.000000000","message":"Add a line break after before the first task to make it easier to read.","commit_id":"f07119a5581f6900aff598503b15e10229623026"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"61e5bd6bf9ba2f1d7d2fa2c46f756d012f16b7e6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  with_dict: \"{{ monasca_services }}\""},{"line_number":35,"context_line":"  when:"},{"line_number":36,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":37,"context_line":"    - \"{{ item.value.condition | default(true) }}\""}],"source_content_type":"text/x-yaml","patch_set":72,"id":"fa6399be_eda478ba","line":37,"range":{"start_line":37,"start_character":41,"end_line":37,"end_character":45},"updated":"2016-10-12 14:28:00.000000000","message":"I think that this will need to be \u0027True\u0027, not \u0027true\u0027.","commit_id":"f07119a5581f6900aff598503b15e10229623026"}],"meta/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e903f1240609bc602c48a5517b220770085c0a08","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  - sansible.users_and_groups"},{"line_number":40,"context_line":"  - zookeeper"},{"line_number":41,"context_line":"  - kafka"},{"line_number":42,"context_line":"  - storm"},{"line_number":43,"context_line":"  - influxdb"},{"line_number":44,"context_line":"  - monasca-ui"}],"source_content_type":"text/x-yaml","patch_set":78,"id":"fa6399be_f8b5f430","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":9},"updated":"2016-10-13 08:51:09.000000000","message":"Change this to:\n\n- storm\n  tags: skip_ansible_lint","commit_id":"9f001b24865e5b33bdc65a782b63d6ecaf4a074a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"9ea7c2eaffa00e2cda3b963c7fa0aca4de680b3e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    - openstack"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"dependencies:"},{"line_number":39,"context_line":"  - { role: sansible.users_and_groups, tags: skip_ansible_lint }"},{"line_number":40,"context_line":"  - { role: zookeeper, tags: skip_ansible_lint }"},{"line_number":41,"context_line":"  - { role: kafka, tags: skip_ansible_lint }"},{"line_number":42,"context_line":"  - { role: storm, tags: skip_ansible_lint }"}],"source_content_type":"text/x-yaml","patch_set":91,"id":"fa6399be_7bcf1029","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":64},"updated":"2016-10-13 13:30:09.000000000","message":"This role requires hash merging enabled, which OSA will not do. Don\u0027t use it.","commit_id":"1e57177059bbc87e01d377e8ab25268be977c52e"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"4d0b9fe9ea885a5a6e802296ff70e7b67461bd75","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    - openstack"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"dependencies:"},{"line_number":39,"context_line":"  - ansible-zookeeper"},{"line_number":40,"context_line":"  - ansible-kafka"},{"line_number":41,"context_line":"  - ansible-storm"},{"line_number":42,"context_line":"  - ansible-influxdb"}],"source_content_type":"text/x-yaml","patch_set":102,"id":"ba5da102_5eab7e89","line":39,"updated":"2016-10-27 14:47:00.000000000","message":"These look like monasca playbook deps, but not role deps.","commit_id":"e69406a58bd0553394cb03739361ff1d9baf38e9"}],"tasks/configure.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"6f1b3d1a043b013d122e3cad81013d1ce5755df5","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# (c) 2016 Paul Stevens \u003cpaul.stevens@is.co.za\u003e"},{"line_number":18,"context_line":"- include: configure_zookeeper.yml"},{"line_number":19,"context_line":"  when:"},{"line_number":20,"context_line":"    - enable_zookeeper is True"},{"line_number":21,"context_line":"    - inventory_hostname in groups[\u0027monasca_zookeeper\u0027]"},{"line_number":22,"context_line":"- include: configure_kafka.yml"},{"line_number":23,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a8bc5a2_6c277ab6","line":20,"range":{"start_line":20,"start_character":22,"end_line":20,"end_character":30},"updated":"2016-09-23 18:39:47.000000000","message":"you can omit this","commit_id":"206200375ae0865bd1aa7f113ee91e941f0333fd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"033b5e4611693399f8ba5b5d43ce8522e1548afd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5a8bc5a2_ada33b4e","updated":"2016-09-23 21:02:16.000000000","message":"I\u0027d like to see the various enable_XXX variables to be renamed to namespaced vars for monasca. Something like `monasca_enable_XXX`","commit_id":"f10147bd06dd271e959b57bb8876946a720908f9"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"033b5e4611693399f8ba5b5d43ce8522e1548afd","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# (c) 2016 Paul Stevens \u003cpaul.stevens@is.co.za\u003e"},{"line_number":18,"context_line":"- include: configure_zookeeper.yml"},{"line_number":19,"context_line":"  when:"},{"line_number":20,"context_line":"    - enable_zookeeper is defined"},{"line_number":21,"context_line":"    - inventory_hostname in groups[\u0027monasca_zookeeper\u0027]"},{"line_number":22,"context_line":"- include: configure_kafka.yml"},{"line_number":23,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5a8bc5a2_adec1b90","line":20,"range":{"start_line":20,"start_character":6,"end_line":20,"end_character":22},"updated":"2016-09-23 21:02:16.000000000","message":"being that this var will always be defined in defaults I think it should be cast to `bool`, Something like: \n\nwhen:\n  - enable_XXX | bool \n  ...","commit_id":"f10147bd06dd271e959b57bb8876946a720908f9"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"033b5e4611693399f8ba5b5d43ce8522e1548afd","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    - inventory_hostname in groups[\u0027monasca_zookeeper\u0027]"},{"line_number":22,"context_line":"- include: configure_kafka.yml"},{"line_number":23,"context_line":"  when:"},{"line_number":24,"context_line":"    - enable_kafka is defined"},{"line_number":25,"context_line":"    - inventory_hostname in groups[\u0027monasca_kafka\u0027]"},{"line_number":26,"context_line":"- include: configure_storm.yml"},{"line_number":27,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5a8bc5a2_cd032741","line":24,"range":{"start_line":24,"start_character":6,"end_line":24,"end_character":18},"updated":"2016-09-23 21:02:16.000000000","message":"being that this var will always be defined in defaults I think it should be cast to `bool`, Something like: \n\nwhen:\n  - enable_XXX | bool \n  ...","commit_id":"f10147bd06dd271e959b57bb8876946a720908f9"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"033b5e4611693399f8ba5b5d43ce8522e1548afd","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    - inventory_hostname in groups[\u0027monasca_kafka\u0027]"},{"line_number":26,"context_line":"- include: configure_storm.yml"},{"line_number":27,"context_line":"  when:"},{"line_number":28,"context_line":"    - enable_storm is defined"},{"line_number":29,"context_line":"    - inventory_hostname in groups[\u0027monasca_storm\u0027]"},{"line_number":30,"context_line":"- include: configure_inxludb.yml"},{"line_number":31,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5a8bc5a2_edfe2337","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":18},"updated":"2016-09-23 21:02:16.000000000","message":"being that this var will always be defined in defaults I think it should be cast to `bool`, Something like: \n\nwhen:\n  - enable_XXX | bool \n  ...","commit_id":"f10147bd06dd271e959b57bb8876946a720908f9"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"033b5e4611693399f8ba5b5d43ce8522e1548afd","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    - inventory_hostname in groups[\u0027monasca_storm\u0027]"},{"line_number":30,"context_line":"- include: configure_inxludb.yml"},{"line_number":31,"context_line":"  when:"},{"line_number":32,"context_line":"    - enable_influxdb is defined"},{"line_number":33,"context_line":"    - inventory_hostname in groups[\u0027monasca_influxdb\u0027]"},{"line_number":34,"context_line":"- include: configure_grafana.yml"},{"line_number":35,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5a8bc5a2_0dfeef36","line":32,"range":{"start_line":32,"start_character":6,"end_line":32,"end_character":21},"updated":"2016-09-23 21:02:16.000000000","message":"being that this var will always be defined in defaults I think it should be cast to `bool`, Something like: \n\nwhen:\n  - enable_XXX | bool \n  ...","commit_id":"f10147bd06dd271e959b57bb8876946a720908f9"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"033b5e4611693399f8ba5b5d43ce8522e1548afd","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    - inventory_hostname in groups[\u0027monasca_influxdb\u0027]"},{"line_number":34,"context_line":"- include: configure_grafana.yml"},{"line_number":35,"context_line":"  when:"},{"line_number":36,"context_line":"    - enable_grafana is defined"},{"line_number":37,"context_line":"    - inventory_hostname in groups[\u0027monasca_grafana\u0027]"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5a8bc5a2_2df9eb4d","line":36,"range":{"start_line":36,"start_character":6,"end_line":36,"end_character":20},"updated":"2016-09-23 21:02:16.000000000","message":"being that this var will always be defined in defaults I think it should be cast to `bool`, Something like: \n\nwhen:\n  - enable_XXX | bool \n  ...","commit_id":"f10147bd06dd271e959b57bb8876946a720908f9"}],"tasks/install.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"6f1b3d1a043b013d122e3cad81013d1ce5755df5","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# (c) 2016 Paul Stevens \u003cpaul.stevens@is.co.za\u003e"},{"line_number":18,"context_line":"- include: install_zookeeper.yml"},{"line_number":19,"context_line":"  when:"},{"line_number":20,"context_line":"    - enable_zookeeper is True"},{"line_number":21,"context_line":"    - inventory_hostname in groups[\u0027monasca_zookeeper\u0027]"},{"line_number":22,"context_line":"- include: install_kafka.yml"},{"line_number":23,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a8bc5a2_ec3b8acf","line":20,"range":{"start_line":20,"start_character":22,"end_line":20,"end_character":30},"updated":"2016-09-23 18:39:47.000000000","message":"same in this file, omit the \" is True\"","commit_id":"206200375ae0865bd1aa7f113ee91e941f0333fd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"033b5e4611693399f8ba5b5d43ce8522e1548afd","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# (c) 2016 Paul Stevens \u003cpaul.stevens@is.co.za\u003e"},{"line_number":18,"context_line":"- include: install_zookeeper.yml"},{"line_number":19,"context_line":"  when:"},{"line_number":20,"context_line":"    - enable_zookeeper is True"},{"line_number":21,"context_line":"    - inventory_hostname in groups[\u0027monasca_zookeeper\u0027]"},{"line_number":22,"context_line":"- include: install_kafka.yml"},{"line_number":23,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5a8bc5a2_0d834f99","line":20,"range":{"start_line":20,"start_character":6,"end_line":20,"end_character":30},"updated":"2016-09-23 21:02:16.000000000","message":"set this to cast to `bool` like so -- enable_XXX | bool","commit_id":"f10147bd06dd271e959b57bb8876946a720908f9"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"033b5e4611693399f8ba5b5d43ce8522e1548afd","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    - inventory_hostname in groups[\u0027monasca_zookeeper\u0027]"},{"line_number":22,"context_line":"- include: install_kafka.yml"},{"line_number":23,"context_line":"  when:"},{"line_number":24,"context_line":"    - enable_kafka is True"},{"line_number":25,"context_line":"    - inventory_hostname in groups[\u0027monasca_kafka\u0027]"},{"line_number":26,"context_line":"- include: install_storm.yml"},{"line_number":27,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5a8bc5a2_4d4b9787","line":24,"range":{"start_line":24,"start_character":6,"end_line":24,"end_character":18},"updated":"2016-09-23 21:02:16.000000000","message":"set this to cast to `bool` like so -- enable_XXX | bool","commit_id":"f10147bd06dd271e959b57bb8876946a720908f9"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"033b5e4611693399f8ba5b5d43ce8522e1548afd","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    - inventory_hostname in groups[\u0027monasca_kafka\u0027]"},{"line_number":26,"context_line":"- include: install_storm.yml"},{"line_number":27,"context_line":"  when:"},{"line_number":28,"context_line":"    - enable_storm is True"},{"line_number":29,"context_line":"    - inventory_hostname in groups[\u0027monasca_storm\u0027]"},{"line_number":30,"context_line":"- include: install_inxludb.yml"},{"line_number":31,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5a8bc5a2_6d4e9397","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":18},"updated":"2016-09-23 21:02:16.000000000","message":"set this to cast to `bool` like so -- enable_XXX | bool","commit_id":"f10147bd06dd271e959b57bb8876946a720908f9"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"033b5e4611693399f8ba5b5d43ce8522e1548afd","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    - inventory_hostname in groups[\u0027monasca_storm\u0027]"},{"line_number":30,"context_line":"- include: install_inxludb.yml"},{"line_number":31,"context_line":"  when:"},{"line_number":32,"context_line":"    - enable_influxdb is True"},{"line_number":33,"context_line":"    - inventory_hostname in groups[\u0027monasca_influxdb\u0027]"},{"line_number":34,"context_line":"- include: install_grafana.yml"},{"line_number":35,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5a8bc5a2_8d459f71","line":32,"range":{"start_line":32,"start_character":6,"end_line":32,"end_character":21},"updated":"2016-09-23 21:02:16.000000000","message":"set this to cast to `bool` like so -- enable_XXX | bool","commit_id":"f10147bd06dd271e959b57bb8876946a720908f9"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"033b5e4611693399f8ba5b5d43ce8522e1548afd","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    - inventory_hostname in groups[\u0027monasca_influxdb\u0027]"},{"line_number":34,"context_line":"- include: install_grafana.yml"},{"line_number":35,"context_line":"  when:"},{"line_number":36,"context_line":"    - enable_grafana is True"},{"line_number":37,"context_line":"    - inventory_hostname in groups[\u0027monasca_grafana\u0027]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Create developer mode constraint file"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5a8bc5a2_ed5aa34f","line":36,"range":{"start_line":36,"start_character":6,"end_line":36,"end_character":20},"updated":"2016-09-23 21:02:16.000000000","message":"set this to cast to `bool` like so -- enable_XXX | bool","commit_id":"f10147bd06dd271e959b57bb8876946a720908f9"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"033b5e4611693399f8ba5b5d43ce8522e1548afd","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# (c) 2016 Donovan Francesco \u003cdonovan.francesco@is.co.za\u003e"},{"line_number":17,"context_line":"# (c) 2016 Paul Stevens \u003cpaul.stevens@is.co.za\u003e"},{"line_number":18,"context_line":"- include: install_zookeeper.yml"},{"line_number":19,"context_line":"  when:"},{"line_number":20,"context_line":"    - enable_zookeeper is True"},{"line_number":21,"context_line":"    - inventory_hostname in groups[\u0027monasca_zookeeper\u0027]"},{"line_number":22,"context_line":"- include: install_kafka.yml"},{"line_number":23,"context_line":"  when:"},{"line_number":24,"context_line":"    - enable_kafka is True"},{"line_number":25,"context_line":"    - inventory_hostname in groups[\u0027monasca_kafka\u0027]"},{"line_number":26,"context_line":"- include: install_storm.yml"},{"line_number":27,"context_line":"  when:"},{"line_number":28,"context_line":"    - enable_storm is True"},{"line_number":29,"context_line":"    - inventory_hostname in groups[\u0027monasca_storm\u0027]"},{"line_number":30,"context_line":"- include: install_inxludb.yml"},{"line_number":31,"context_line":"  when:"},{"line_number":32,"context_line":"    - enable_influxdb is True"},{"line_number":33,"context_line":"    - inventory_hostname in groups[\u0027monasca_influxdb\u0027]"},{"line_number":34,"context_line":"- include: install_grafana.yml"},{"line_number":35,"context_line":"  when:"},{"line_number":36,"context_line":"    - enable_grafana is True"},{"line_number":37,"context_line":"    - inventory_hostname in groups[\u0027monasca_grafana\u0027]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Create developer mode constraint file"},{"line_number":40,"context_line":"  copy:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5a8bc5a2_2d556b1c","line":37,"range":{"start_line":18,"start_character":0,"end_line":37,"end_character":53},"updated":"2016-09-23 21:02:16.000000000","message":"It\u0027d be nice to have a space between tasks as it helps make the task file more readable.","commit_id":"f10147bd06dd271e959b57bb8876946a720908f9"}],"tasks/install_influxdb.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"6f1b3d1a043b013d122e3cad81013d1ce5755df5","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Download InfluxDB"},{"line_number":21,"context_line":"  get_url:"},{"line_number":22,"context_line":"    url: https://dl.influxdata.com/influxdb/releases/{{ influxdb_version }}.tar.gz"},{"line_number":23,"context_line":"    dest: /tmp/{{ influxdb_version }}.tar.gz"},{"line_number":24,"context_line":"    mode: 0600"},{"line_number":25,"context_line":"  register: download_influxdb"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a8bc5a2_8c784691","line":22,"range":{"start_line":22,"start_character":9,"end_line":22,"end_character":53},"updated":"2016-09-23 18:39:47.000000000","message":"This should be a var as well, in case folks want to mirror the external deps","commit_id":"206200375ae0865bd1aa7f113ee91e941f0333fd"}],"tasks/install_kafka.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"6f1b3d1a043b013d122e3cad81013d1ce5755df5","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"- name: Download Apache Kafka"},{"line_number":20,"context_line":"  get_url:"},{"line_number":21,"context_line":"    url: \"http://www-us.apache.org/dist/kafka/{{ kafka_base_version }}/{{ kafka_version }}.tgz\""},{"line_number":22,"context_line":"    dest: /tmp/{{ apache_kafka_version }}"},{"line_number":23,"context_line":"    mode: 0600"},{"line_number":24,"context_line":"  register: download_kafka_binary"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a8bc5a2_8c9f66b3","line":21,"range":{"start_line":21,"start_character":10,"end_line":21,"end_character":46},"updated":"2016-09-23 18:39:47.000000000","message":"This should be a var","commit_id":"206200375ae0865bd1aa7f113ee91e941f0333fd"}],"tasks/install_storm.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"6f1b3d1a043b013d122e3cad81013d1ce5755df5","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"- name: Download Apache Storm"},{"line_number":20,"context_line":"  get_url:"},{"line_number":21,"context_line":"    url: \"http://www-us.apache.org/dist/storm/{{ storm_version }}/{{ storm_verson }}.tar.gz\""},{"line_number":22,"context_line":"    dest: \"/tmp/{{ storm_version }}.tar.gz\""},{"line_number":23,"context_line":"    mode: 0600"},{"line_number":24,"context_line":"  register: download_storm"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a8bc5a2_cca96ee1","line":21,"range":{"start_line":21,"start_character":10,"end_line":21,"end_character":46},"updated":"2016-09-23 18:39:47.000000000","message":"Make this a var","commit_id":"206200375ae0865bd1aa7f113ee91e941f0333fd"}],"tasks/install_zookeeper.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"6f1b3d1a043b013d122e3cad81013d1ce5755df5","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"- name: Download Apache Zookeeper"},{"line_number":20,"context_line":"  get_url:"},{"line_number":21,"context_line":"    url: \"http://www-us.apache.org/dist/zookeeper/stable/{{ zookeeper_version }}.tar.gz\""},{"line_number":22,"context_line":"    dest: \"/tmp/{{ zookeeper_version }}.tar.gz\""},{"line_number":23,"context_line":"    mode: 0600"},{"line_number":24,"context_line":"  register: download_zookeeper"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a8bc5a2_cc808e49","line":21,"range":{"start_line":21,"start_character":10,"end_line":21,"end_character":57},"updated":"2016-09-23 18:39:47.000000000","message":"Make this a var","commit_id":"206200375ae0865bd1aa7f113ee91e941f0333fd"}],"tasks/monasca_init_common.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"61e5bd6bf9ba2f1d7d2fa2c46f756d012f16b7e6","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- include: monasca_init_upstart.yml"},{"line_number":17,"context_line":"  static: no"},{"line_number":18,"context_line":"  when: pid1_name \u003d\u003d \"init\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- include: monasca_init_systemd.yml"}],"source_content_type":"text/x-yaml","patch_set":72,"id":"fa6399be_8d04dcc0","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":12},"updated":"2016-10-12 14:28:00.000000000","message":"As you\u0027re using inventory-based conditionals for the handler and included tasks, you will need to remove this.","commit_id":"f07119a5581f6900aff598503b15e10229623026"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"61e5bd6bf9ba2f1d7d2fa2c46f756d012f16b7e6","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  when: pid1_name \u003d\u003d \"init\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- include: monasca_init_systemd.yml"},{"line_number":21,"context_line":"  static: no"},{"line_number":22,"context_line":"  when: pid1_name \u003d\u003d \"systemd\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Load service"}],"source_content_type":"text/x-yaml","patch_set":72,"id":"fa6399be_cd2c144d","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":12},"updated":"2016-10-12 14:28:00.000000000","message":"As you\u0027re using inventory-based conditionals for the handler and included tasks, you will need to remove this.","commit_id":"f07119a5581f6900aff598503b15e10229623026"}],"templates/grafana/grafana-server.j2":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"4d0b9fe9ea885a5a6e802296ff70e7b67461bd75","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#! /usr/bin/env bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# chkconfig: 2345 80 05"},{"line_number":4,"context_line":"# description: Grafana web server \u0026 backend"}],"source_content_type":"text/x-jinja2","patch_set":102,"id":"ba5da102_9e7c3622","line":1,"updated":"2016-10-27 14:47:00.000000000","message":"Should this still be in the role, now that we are relying upon upstream grafana role?","commit_id":"e69406a58bd0553394cb03739361ff1d9baf38e9"}],"templates/influxdb/influxdb.conf.j2":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"4d0b9fe9ea885a5a6e802296ff70e7b67461bd75","unresolved":false,"context_lines":[{"line_number":24,"context_line":"### about the InfluxDB cluster."},{"line_number":25,"context_line":"###"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"[meta]"},{"line_number":28,"context_line":"  dir \u003d \"{{ monasca_influxdb_data_directory }}/meta\""},{"line_number":29,"context_line":"  hostname \u003d \"{{ ansible_default_ipv4.address }}\""},{"line_number":30,"context_line":"  bind-address \u003d \":8089\""}],"source_content_type":"text/x-jinja2","patch_set":102,"id":"ba5da102_fe73724b","line":27,"updated":"2016-10-27 14:47:00.000000000","message":"Shouldn\u0027t we get this from the upstream influx role?","commit_id":"e69406a58bd0553394cb03739361ff1d9baf38e9"}],"templates/kafka/log4j.properties.j2":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"4d0b9fe9ea885a5a6e802296ff70e7b67461bd75","unresolved":false,"context_lines":[{"line_number":21,"context_line":"log4j.appender.kafkaAppender\u003dorg.apache.log4j.RollingFileAppender"},{"line_number":22,"context_line":"log4j.appender.kafkaAppender.MaxFileSize\u003d50MB"},{"line_number":23,"context_line":"log4j.appender.kafkaAppender.MaxBackupIndex\u003d4"},{"line_number":24,"context_line":"log4j.appender.kafkaAppender.File\u003d{{ monasca_kafka_log_directory }}/server.log"},{"line_number":25,"context_line":"log4j.appender.kafkaAppender.layout\u003dorg.apache.log4j.PatternLayout"},{"line_number":26,"context_line":"log4j.appender.kafkaAppender.layout.ConversionPattern\u003d[%d] %p %m (%c)%n"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":102,"id":"ba5da102_5e99be6d","line":24,"updated":"2016-10-27 14:47:00.000000000","message":"Again, I would expect this to come from the upstream kafka role","commit_id":"e69406a58bd0553394cb03739361ff1d9baf38e9"}],"tests/test-install-monasca.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"033b5e4611693399f8ba5b5d43ce8522e1548afd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5a8bc5a2_3048645b","updated":"2016-09-23 21:02:16.000000000","message":"I think it\u0027d be nice to pull in the test repo bits here and use some of the common rabbitmq and mariadb playbooks like so:\n\nhttps://github.com/openstack/openstack-ansible-tests/blob/master/create-grant-db.yml\n\nhttps://github.com/openstack/openstack-ansible-tests/blob/master/ensure-rabbitmq.yml","commit_id":"f10147bd06dd271e959b57bb8876946a720908f9"}]}
