)]}'
{"defaults/main.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"9290a3cbfcc16a3b2d1d839d6bc743dd59c54747","unresolved":false,"context_lines":[{"line_number":213,"context_line":"   config_options: \"--config-file /etc/neutron/neutron.conf --config-file /etc/neutron/{{ neutron_plugins[neutron_plugin_type].plugin_ini }}\""},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"## Neutron DHCP Agent"},{"line_number":216,"context_line":"neutron_dhcp: \"{% if neutron_plugin_type \u003d\u003d \u0027ml2\u0027 %}True{% else %}False{% endif %}\""},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"## Neutron Metadata Agent"},{"line_number":219,"context_line":"neutron_metadata: \"{% if neutron_plugin_type \u003d\u003d \u0027ml2\u0027 %}True{% else %}False{% endif %}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_2e86e9da","line":216,"range":{"start_line":216,"start_character":15,"end_line":216,"end_character":82},"updated":"2016-04-20 09:33:13.000000000","message":"I\u0027d use the ternary form for readability","commit_id":"56cff84860934af714c15388523b25b6cfd5e31c"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"93ec5a716a81ff74a2c6f5547430336e76eda2f7","unresolved":false,"context_lines":[{"line_number":213,"context_line":"   config_options: \"--config-file /etc/neutron/neutron.conf --config-file /etc/neutron/{{ neutron_plugins[neutron_plugin_type].plugin_ini }}\""},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"## Neutron DHCP Agent"},{"line_number":216,"context_line":"neutron_dhcp: \"{% if neutron_plugin_type \u003d\u003d \u0027ml2\u0027 %}True{% else %}False{% endif %}\""},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"## Neutron Metadata Agent"},{"line_number":219,"context_line":"neutron_metadata: \"{% if neutron_plugin_type \u003d\u003d \u0027ml2\u0027 %}True{% else %}False{% endif %}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_82fa7173","line":216,"range":{"start_line":216,"start_character":15,"end_line":216,"end_character":82},"in_reply_to":"1a122d0e_2e86e9da","updated":"2016-04-20 09:36:36.000000000","message":"Yeah, I thought about that but decided to maintain the convention in the vars further below. I think a follow on patch could improve readability by implementing the ternary patch for all these vars. The vars may not even be needed in that case as the ternary filter could be used directly in the dict above.","commit_id":"56cff84860934af714c15388523b25b6cfd5e31c"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"b8b8854b2ff46ff4e145b798c9e7b4becf8b5a4d","unresolved":false,"context_lines":[{"line_number":213,"context_line":"   config_options: \"--config-file /etc/neutron/neutron.conf --config-file /etc/neutron/{{ neutron_plugins[neutron_plugin_type].plugin_ini }}\""},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"## Neutron DHCP Agent"},{"line_number":216,"context_line":"neutron_dhcp: \"{% if neutron_plugin_type \u003d\u003d \u0027ml2\u0027 %}True{% else %}False{% endif %}\""},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"## Neutron Metadata Agent"},{"line_number":219,"context_line":"neutron_metadata: \"{% if neutron_plugin_type \u003d\u003d \u0027ml2\u0027 %}True{% else %}False{% endif %}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_8cbf40a9","line":216,"range":{"start_line":216,"start_character":15,"end_line":216,"end_character":82},"in_reply_to":"1a122d0e_82fa7173","updated":"2016-04-20 11:10:14.000000000","message":"agreed","commit_id":"56cff84860934af714c15388523b25b6cfd5e31c"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"9290a3cbfcc16a3b2d1d839d6bc743dd59c54747","unresolved":false,"context_lines":[{"line_number":216,"context_line":"neutron_dhcp: \"{% if neutron_plugin_type \u003d\u003d \u0027ml2\u0027 %}True{% else %}False{% endif %}\""},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"## Neutron Metadata Agent"},{"line_number":219,"context_line":"neutron_metadata: \"{% if neutron_plugin_type \u003d\u003d \u0027ml2\u0027 %}True{% else %}False{% endif %}\""},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"## Neutron LinuxBridge Agent"},{"line_number":222,"context_line":"neutron_linuxbridge: \"{% if neutron_plugin_type \u003d\u003d \u0027ml2\u0027 and \u0027linuxbridge\u0027 in neutron_ml2_mechanism_drivers %}True{% else %}False{% endif %}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_ae72f90e","line":219,"range":{"start_line":219,"start_character":19,"end_line":219,"end_character":86},"updated":"2016-04-20 09:33:13.000000000","message":"Same comment","commit_id":"56cff84860934af714c15388523b25b6cfd5e31c"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"b8b8854b2ff46ff4e145b798c9e7b4becf8b5a4d","unresolved":false,"context_lines":[{"line_number":216,"context_line":"neutron_dhcp: \"{% if neutron_plugin_type \u003d\u003d \u0027ml2\u0027 %}True{% else %}False{% endif %}\""},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"## Neutron Metadata Agent"},{"line_number":219,"context_line":"neutron_metadata: \"{% if neutron_plugin_type \u003d\u003d \u0027ml2\u0027 %}True{% else %}False{% endif %}\""},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"## Neutron LinuxBridge Agent"},{"line_number":222,"context_line":"neutron_linuxbridge: \"{% if neutron_plugin_type \u003d\u003d \u0027ml2\u0027 and \u0027linuxbridge\u0027 in neutron_ml2_mechanism_drivers %}True{% else %}False{% endif %}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_0cea10ac","line":219,"range":{"start_line":219,"start_character":19,"end_line":219,"end_character":86},"in_reply_to":"1a122d0e_ae72f90e","updated":"2016-04-20 11:10:14.000000000","message":"agreed","commit_id":"56cff84860934af714c15388523b25b6cfd5e31c"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"9290a3cbfcc16a3b2d1d839d6bc743dd59c54747","unresolved":false,"context_lines":[{"line_number":219,"context_line":"neutron_metadata: \"{% if neutron_plugin_type \u003d\u003d \u0027ml2\u0027 %}True{% else %}False{% endif %}\""},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"## Neutron LinuxBridge Agent"},{"line_number":222,"context_line":"neutron_linuxbridge: \"{% if neutron_plugin_type \u003d\u003d \u0027ml2\u0027 and \u0027linuxbridge\u0027 in neutron_ml2_mechanism_drivers %}True{% else %}False{% endif %}\""},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"## Neutron LBaaS"},{"line_number":225,"context_line":"# See documentation section titled \"Configuring the Network Load Balacing"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_ee66b14f","line":222,"range":{"start_line":222,"start_character":22,"end_line":222,"end_character":110},"updated":"2016-04-20 09:33:13.000000000","message":"Same comment","commit_id":"56cff84860934af714c15388523b25b6cfd5e31c"}],"releasenotes/notes/neutron-agent-dynamic-enable-47f0c709ef0dfe55.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"9290a3cbfcc16a3b2d1d839d6bc743dd59c54747","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    ``neutron_plugin_type`` and the ``neutron_ml2_mechanism_drivers``"},{"line_number":6,"context_line":"    that are set. This aims to simplify the configuration of Neutron"},{"line_number":7,"context_line":"    services and eliminate the need for deployers to override the"},{"line_number":8,"context_line":"    entire ``neutron_services`` dict variable to disable these services."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - Whether the Neutron DHCP Agent, Metadata Agent or LinuxBridge Agent"},{"line_number":11,"context_line":"    should be enabled is now dynamically determined based on the"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_6ef7418b","line":8,"updated":"2016-04-20 09:33:13.000000000","message":"\"While the simplification brings the opportunity to deployers to simply flip switches to enable/disable components, it also allows further evolutivity in the default dict (for example with the inclusion of new components) without the needs for deployer to follow the latest `neutron_services` changes in their configuration.\"","commit_id":"56cff84860934af714c15388523b25b6cfd5e31c"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"b8b8854b2ff46ff4e145b798c9e7b4becf8b5a4d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    ``neutron_plugin_type`` and the ``neutron_ml2_mechanism_drivers``"},{"line_number":6,"context_line":"    that are set. This aims to simplify the configuration of Neutron"},{"line_number":7,"context_line":"    services and eliminate the need for deployers to override the"},{"line_number":8,"context_line":"    entire ``neutron_services`` dict variable to disable these services."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - Whether the Neutron DHCP Agent, Metadata Agent or LinuxBridge Agent"},{"line_number":11,"context_line":"    should be enabled is now dynamically determined based on the"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_ac531ce1","line":8,"in_reply_to":"1a122d0e_65dabfe9","updated":"2016-04-20 11:10:14.000000000","message":"True about the proposition to not use vars. Maybe I should have said neutron_plugin_type and neutron_ml2_mechanism drivers. \n\nI just think it\u0027s a good idea to tell deployers/integrators they should not override the dict anymore unless they really know what they are doing (and therefore are prepared to follow up these dict changes)","commit_id":"56cff84860934af714c15388523b25b6cfd5e31c"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f256ed5be8dd33517b8e0db292dba5a76b7c498e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    ``neutron_plugin_type`` and the ``neutron_ml2_mechanism_drivers``"},{"line_number":6,"context_line":"    that are set. This aims to simplify the configuration of Neutron"},{"line_number":7,"context_line":"    services and eliminate the need for deployers to override the"},{"line_number":8,"context_line":"    entire ``neutron_services`` dict variable to disable these services."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - Whether the Neutron DHCP Agent, Metadata Agent or LinuxBridge Agent"},{"line_number":11,"context_line":"    should be enabled is now dynamically determined based on the"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_65dabfe9","line":8,"in_reply_to":"1a122d0e_6ef7418b","updated":"2016-04-20 09:56:10.000000000","message":"I\u0027d prefer not to propose that the new vars are used to enable/disable the services. They\u0027re meant as vars to improve readability, not for deployers to set. Only the neutron_plugin_type and neutron_ml2_mechanism_drivers should be set by deployers.","commit_id":"56cff84860934af714c15388523b25b6cfd5e31c"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"9290a3cbfcc16a3b2d1d839d6bc743dd59c54747","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    ``neutron_plugin_type`` and the ``neutron_ml2_mechanism_drivers``"},{"line_number":13,"context_line":"    that are set. This aims to simplify the configuration of Neutron"},{"line_number":14,"context_line":"    services and eliminate the need for deployers to override the"},{"line_number":15,"context_line":"    entire ``neutron_services`` dict variable to disable these services."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_2eaee997","line":15,"updated":"2016-04-20 09:33:13.000000000","message":"\"Deployers should avoid overriding the complete dict starting from now.\"","commit_id":"56cff84860934af714c15388523b25b6cfd5e31c"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f256ed5be8dd33517b8e0db292dba5a76b7c498e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    ``neutron_plugin_type`` and the ``neutron_ml2_mechanism_drivers``"},{"line_number":13,"context_line":"    that are set. This aims to simplify the configuration of Neutron"},{"line_number":14,"context_line":"    services and eliminate the need for deployers to override the"},{"line_number":15,"context_line":"    entire ``neutron_services`` dict variable to disable these services."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_c5fab342","line":15,"in_reply_to":"1a122d0e_2eaee997","updated":"2016-04-20 09:56:10.000000000","message":"I\u0027m open to adding something like this if there is more demand to do so. Personally I think that this is implied and not entirely necessary.","commit_id":"56cff84860934af714c15388523b25b6cfd5e31c"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"b8b8854b2ff46ff4e145b798c9e7b4becf8b5a4d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    ``neutron_plugin_type`` and the ``neutron_ml2_mechanism_drivers``"},{"line_number":13,"context_line":"    that are set. This aims to simplify the configuration of Neutron"},{"line_number":14,"context_line":"    services and eliminate the need for deployers to override the"},{"line_number":15,"context_line":"    entire ``neutron_services`` dict variable to disable these services."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_ccbc98bd","line":15,"in_reply_to":"1a122d0e_c5fab342","updated":"2016-04-20 11:10:14.000000000","message":"True","commit_id":"56cff84860934af714c15388523b25b6cfd5e31c"}]}